88170 2012-06-02 10:21:37 -0700 Fix a couple flexbox tests to use flex-start and flex-end 2012-06-04 10:05:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony ojan webkit.review.bot oldest_to_newest 640041 0 tony 2012-06-02 10:21:37 -0700 Fix a couple flexbox tests to use flex-start and flex-end 640042 1 145450 tony 2012-06-02 10:23:27 -0700 Created attachment 145450 Patch 640644 2 ojan 2012-06-04 09:53:45 -0700 Nit: if we were to fix this to not break again, we'd add asserts to each div that they have the expected alignment in the computed style. 640649 3 145450 webkit.review.bot 2012-06-04 10:05:38 -0700 Comment on attachment 145450 Patch Clearing flags on attachment: 145450 Committed r119405: <http://trac.webkit.org/changeset/119405> 640650 4 webkit.review.bot 2012-06-04 10:05:42 -0700 All reviewed patches have been landed. Closing bug. 145450 2012-06-02 10:23:27 -0700 2012-06-04 10:05:37 -0700 Patch bug-88170-20120602102343.patch text/plain 6252 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MzIzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzg2YzI1NmY1NzdkMzc2NmJkYTI1 NDg3NWQ5ZWNhNjlkOWY0OTZkOS4uODBhZTg5OTg0ZGFkMWQ1MTA3MTVjYTNmMTMzYzdmNjhkYzNk ZjJiNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTAyICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IGEgY291cGxlIGZsZXhib3ggdGVzdHMgdG8g dXNlIGZsZXgtc3RhcnQgYW5kIGZsZXgtZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04ODE3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgdGVzdCB3YXMgc3RpbGwgdXNpbmcgc3RhcnQvZW5kIGZv ciBhbGlnbi1zZWxmLCB3aGljaCBmYWxsYmFjaworICAgICAgICB0byBzdHJldGNoLiBUaGUgdGVz dCBzdGlsbCBwYXNzZWQgYmVjYXVzZSBpdCBpcyB0ZXN0aW5nIHRoYXQgYWxsCisgICAgICAgIHZh bHVlcyBvZiBhbGlnbi1zZWxmIGJlaGF2ZSB0aGUgc2FtZSBhbmQgc3RyZXRjaCBwcm9kdWNlZCB0 aGUgc2FtZQorICAgICAgICBiZWhhdmlvciBhcyBmbGV4LXN0YXJ0L2ZsZXgtZW5kLgorCisgICAg ICAgICogY3NzMy9mbGV4Ym94L2Nyb3NzLWF4aXMtc2Nyb2xsYmFyLmh0bWw6CisKIDIwMTItMDYt MDIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRd IFJlcGxhY2UgUXRYbWxQYXR0ZXJucyB1c2FnZSB3aXRoIGxpYnhzbHQgZGVwZW5kZW5jeQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2Nyb3NzLWF4aXMtc2Nyb2xsYmFyLmh0 bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvY3Jvc3MtYXhpcy1zY3JvbGxiYXIuaHRtbApp bmRleCA1ZWU1MGIyN2U5ZDhhYTYwNDNmNWVjMzVlYmYxNDEyYjNlZTFmMTc3Li4yOGE2YmUzZGQw NjFlY2EwMTgwYTAxYzZhY2Q2M2U1MWRhYzdkZDVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9j c3MzL2ZsZXhib3gvY3Jvc3MtYXhpcy1zY3JvbGxiYXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9j c3MzL2ZsZXhib3gvY3Jvc3MtYXhpcy1zY3JvbGxiYXIuaHRtbApAQCAtNTUsOSArNTUsOSBAQCBU aGlzIHRlc3QgcGFzc2VzIGlmIG5vIHJlZCBpcyBzaG93aW5nLgogCiA8ZGl2IHN0eWxlPSJwb3Np dGlvbjogYWJzb2x1dGU7IHRvcDogMDsgbGVmdDogMDsiPgogPGRpdiBjbGFzcz0iZmxleGJveCBj b2x1bW4iIHN0eWxlPSJvdmVyZmxvdy14OiBzY3JvbGw7IG92ZXJmbG93LXk6IGhpZGRlbjsgYm9y ZGVyLWJvdHRvbTogMTBweCBzb2xpZCBncmVlbjsiPgotICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQt YWxpZ24tc2VsZjogc3RhcnQiPjwvZGl2PgorICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24t c2VsZjogZmxleC1zdGFydCI+PC9kaXY+CiAgICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1z ZWxmOiBjZW50ZXIiPjwvZGl2PgotICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjog ZW5kIj48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGZsZXgtZW5k Ij48L2Rpdj4KICAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGJhc2VsaW5lIj48 L2Rpdj4KICAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IHN0cmV0Y2giPjwvZGl2 PgogPC9kaXY+CkBAIC02NSw5ICs2NSw5IEBAIFRoaXMgdGVzdCBwYXNzZXMgaWYgbm8gcmVkIGlz IHNob3dpbmcuCiAKIDxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAwOyBsZWZ0 OiAxNTBweDsiPgogPGRpdiBjbGFzcz0iZmxleGJveCBjb2x1bW4iIHN0eWxlPSJvdmVyZmxvdy15 OiBzY3JvbGw7IG92ZXJmbG93LXg6IGhpZGRlbjsgYm9yZGVyLXJpZ2h0OiAxMHB4IHNvbGlkIGdy ZWVuOyI+Ci0gICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBzdGFydCI+PC9kaXY+ CisgICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBmbGV4LXN0YXJ0Ij48L2Rpdj4K ICAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGNlbnRlciI+PC9kaXY+Ci0gICAg PGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBlbmQiPjwvZGl2PgorICAgIDxkaXYgc3R5 bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZmxleC1lbmQiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9 Ii13ZWJraXQtYWxpZ24tc2VsZjogYmFzZWxpbmUiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13 ZWJraXQtYWxpZ24tc2VsZjogc3RyZXRjaCI+PC9kaXY+CiA8L2Rpdj4KQEAgLTc1LDI5ICs3NSwy OSBAQCBUaGlzIHRlc3QgcGFzc2VzIGlmIG5vIHJlZCBpcyBzaG93aW5nLgogCiA8ZGl2IHN0eWxl PSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDowOyBsZWZ0OiAzMDBweCIgY2xhc3M9InZlcnRpY2Fs LWxyIj4KIDxkaXYgY2xhc3M9ImZsZXhib3ggY29sdW1uIiBzdHlsZT0ib3ZlcmZsb3cteTogc2Ny b2xsOyBvdmVyZmxvdy14OiBoaWRkZW47IGJvcmRlci1yaWdodDogMTBweCBzb2xpZCBncmVlbjsi PgotICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogc3RhcnQiPjwvZGl2PgorICAg IDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZmxleC1zdGFydCI+PC9kaXY+CiAgICAg PGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBjZW50ZXIiPjwvZGl2PgotICAgIDxkaXYg c3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZW5kIj48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSIt d2Via2l0LWFsaWduLXNlbGY6IGZsZXgtZW5kIj48L2Rpdj4KICAgICA8ZGl2IHN0eWxlPSItd2Vi a2l0LWFsaWduLXNlbGY6IGJhc2VsaW5lIj48L2Rpdj4KLSAgICA8ZGl2IHN0eWxlPSItd2Via2l0 LWFsaWduLXNlbGY6IHN0YXJ0Ij48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWdu LXNlbGY6IGZsZXgtc3RhcnQiPjwvZGl2PgogPC9kaXY+CiA8L2Rpdj4KIAogPGRpdiBzdHlsZT0i cG9zaXRpb246IGFic29sdXRlOyB0b3A6MDsgbGVmdDogNDUwcHg7IiBjbGFzcz0idmVydGljYWwt bHIiPgogPGRpdiBjbGFzcz0iZmxleGJveCBjb2x1bW4iIHN0eWxlPSJvdmVyZmxvdy14OiBzY3Jv bGw7IG92ZXJmbG93LXk6IGhpZGRlbjsgYm9yZGVyLWJvdHRvbTogMTBweCBzb2xpZCBncmVlbjsi PgotICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogc3RhcnQiPjwvZGl2PgorICAg IDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZmxleC1zdGFydCI+PC9kaXY+CiAgICAg PGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBjZW50ZXIiPjwvZGl2PgotICAgIDxkaXYg c3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZW5kIj48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSIt d2Via2l0LWFsaWduLXNlbGY6IGZsZXgtZW5kIj48L2Rpdj4KICAgICA8ZGl2IHN0eWxlPSItd2Vi a2l0LWFsaWduLXNlbGY6IGJhc2VsaW5lIj48L2Rpdj4KLSAgICA8ZGl2IHN0eWxlPSItd2Via2l0 LWFsaWduLXNlbGY6IHN0YXJ0Ij48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWdu LXNlbGY6IGZsZXgtc3RhcnQiPjwvZGl2PgogPC9kaXY+CiA8L2Rpdj4KIAogPGRpdiBzdHlsZT0i aGVpZ2h0OiAyMHB4OyB3aWR0aDogMTAwcHg7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAxMDBw eDsgbGVmdDogMCI+CiA8ZGl2IGNsYXNzPSJmbGV4Ym94IHJvdyIgc3R5bGU9Im92ZXJmbG93LXg6 IHNjcm9sbDsgb3ZlcmZsb3cteTogaGlkZGVuOyBib3JkZXItYm90dG9tOiAxMHB4IHNvbGlkIGdy ZWVuOyI+Ci0gICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBzdGFydCI+PC9kaXY+ CisgICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBmbGV4LXN0YXJ0Ij48L2Rpdj4K ICAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGNlbnRlciI+PC9kaXY+Ci0gICAg PGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBlbmQiPjwvZGl2PgorICAgIDxkaXYgc3R5 bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZmxleC1lbmQiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9 Ii13ZWJraXQtYWxpZ24tc2VsZjogYmFzZWxpbmUiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13 ZWJraXQtYWxpZ24tc2VsZjogc3RyZXRjaCI+PC9kaXY+CiA8L2Rpdj4KQEAgLTEwNSw5ICsxMDUs OSBAQCBUaGlzIHRlc3QgcGFzc2VzIGlmIG5vIHJlZCBpcyBzaG93aW5nLgogCiA8ZGl2IHN0eWxl PSJoZWlnaHQ6IDIwcHg7IHdpZHRoOiAxMDBweDsgcG9zaXRpb246IGFic29sdXRlOyB0b3A6IDEw MHB4OyBsZWZ0OiAxNTBweCI+CiA8ZGl2IGNsYXNzPSJmbGV4Ym94IHJvdyIgc3R5bGU9Im92ZXJm bG93LXk6IHNjcm9sbDsgb3ZlcmZsb3cteDogaGlkZGVuOyBib3JkZXItcmlnaHQ6IDEwcHggc29s aWQgZ3JlZW47Ij4KLSAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IHN0YXJ0Ij48 L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGZsZXgtc3RhcnQiPjwv ZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogY2VudGVyIj48L2Rpdj4K LSAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGVuZCI+PC9kaXY+CisgICAgPGRp diBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBmbGV4LWVuZCI+PC9kaXY+CiAgICAgPGRpdiBz dHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBiYXNlbGluZSI+PC9kaXY+CiAgICAgPGRpdiBzdHls ZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBzdHJldGNoIj48L2Rpdj4KIDwvZGl2PgpAQCAtMTE1LDkg KzExNSw5IEBAIFRoaXMgdGVzdCBwYXNzZXMgaWYgbm8gcmVkIGlzIHNob3dpbmcuCiAKIDxkaXYg c3R5bGU9ImhlaWdodDogNTBweDsgd2lkdGg6IDUwcHg7IHBvc2l0aW9uOiBhYnNvbHV0ZTsgdG9w OiAxMDBweDsgbGVmdDogMzAwcHgiIGNsYXNzPSJ2ZXJ0aWNhbC1sciI+CiA8ZGl2IGNsYXNzPSJm bGV4Ym94IHJvdyIgc3R5bGU9Im92ZXJmbG93LXg6IHNjcm9sbDsgb3ZlcmZsb3cteTogaGlkZGVu OyBib3JkZXItYm90dG9tOiAxMHB4IHNvbGlkIGdyZWVuOyI+Ci0gICAgPGRpdiBzdHlsZT0iLXdl YmtpdC1hbGlnbi1zZWxmOiBzdGFydCI+PC9kaXY+CisgICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1h bGlnbi1zZWxmOiBmbGV4LXN0YXJ0Ij48L2Rpdj4KICAgICA8ZGl2IHN0eWxlPSItd2Via2l0LWFs aWduLXNlbGY6IGNlbnRlciI+PC9kaXY+Ci0gICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1z ZWxmOiBlbmQiPjwvZGl2PgorICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogZmxl eC1lbmQiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogYmFzZWxp bmUiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtYWxpZ24tc2VsZjogc3RyZXRjaCI+ PC9kaXY+CiA8L2Rpdj4KQEAgLTEyNSw5ICsxMjUsOSBAQCBUaGlzIHRlc3QgcGFzc2VzIGlmIG5v IHJlZCBpcyBzaG93aW5nLgogCiA8ZGl2IHN0eWxlPSJoZWlnaHQ6IDUwcHg7IHdpZHRoOiA1MHB4 OyBwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTAwcHg7IGxlZnQ6IDQ1MHB4IiBjbGFzcz0idmVy dGljYWwtbHIiPgogPGRpdiBjbGFzcz0iZmxleGJveCByb3ciIHN0eWxlPSJvdmVyZmxvdy15OiBz Y3JvbGw7IG92ZXJmbG93LXg6IGhpZGRlbjsgYm9yZGVyLXJpZ2h0OiAxMHB4IHNvbGlkIGdyZWVu OyI+Ci0gICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBzdGFydCI+PC9kaXY+Cisg ICAgPGRpdiBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBmbGV4LXN0YXJ0Ij48L2Rpdj4KICAg ICA8ZGl2IHN0eWxlPSItd2Via2l0LWFsaWduLXNlbGY6IGNlbnRlciI+PC9kaXY+Ci0gICAgPGRp diBzdHlsZT0iLXdlYmtpdC1hbGlnbi1zZWxmOiBlbmQiPjwvZGl2PgorICAgIDxkaXYgc3R5bGU9 Ii13ZWJraXQtYWxpZ24tc2VsZjogZmxleC1lbmQiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13 ZWJraXQtYWxpZ24tc2VsZjogYmFzZWxpbmUiPjwvZGl2PgogICAgIDxkaXYgc3R5bGU9Ii13ZWJr aXQtYWxpZ24tc2VsZjogc3RyZXRjaCI+PC9kaXY+CiA8L2Rpdj4K