88154 2012-06-01 17:07:33 -0700 loadRequest should check for empty URLs. 2012-06-02 14:30:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang yongjun_zhang ap beidson ddkilzer webkit.review.bot yongjun_zhang oldest_to_newest 639878 0 yongjun_zhang 2012-06-01 17:07:33 -0700 In [WebFrame loadRequest], we check if the url is valid or nil, if not we transform it to file: url. However, WebKit client could pass down an empty URL and we need to handle that as well. 639879 1 yongjun_zhang 2012-06-01 17:09:13 -0700 <rdar://problem/11537160> 639890 2 145411 yongjun_zhang 2012-06-01 17:38:50 -0700 Created attachment 145411 Don't transform empty URLs to file: URL. 639891 3 webkit.review.bot 2012-06-01 17:42:37 -0700 Attachment 145411 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 639893 4 145412 yongjun_zhang 2012-06-01 17:47:14 -0700 Created attachment 145412 Don't transform empty URLs to file: URL, update the changeLog with bug id. 639946 5 145412 beidson 2012-06-01 21:40:10 -0700 Comment on attachment 145412 Don't transform empty URLs to file: URL, update the changeLog with bug id. In WebCore string land, "isEmpty()" covers both null and empty, so I think you can just get rid of [request URL] altogether. 640050 6 145451 yongjun_zhang 2012-06-02 10:31:48 -0700 Created attachment 145451 only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case. 640080 7 145451 webkit.review.bot 2012-06-02 14:30:19 -0700 Comment on attachment 145451 only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case. Clearing flags on attachment: 145451 Committed r119339: <http://trac.webkit.org/changeset/119339> 640081 8 webkit.review.bot 2012-06-02 14:30:32 -0700 All reviewed patches have been landed. Closing bug. 145411 2012-06-01 17:38:50 -0700 2012-06-01 17:47:14 -0700 Don't transform empty URLs to file: URL. loadRequest.patch text/plain 2123 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTMwMikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTAx ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTmVl ZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BTISkKKworICAgICAgICBJbiBb V2ViRnJhbWUgbG9hZFJlcXVlc3RdLCBpZiB0aGUgdXJsIGlzIGludmFsaWQgYW5kIG5vdCBuaWws IHdlIHRyYW5zZm9ybSBpdCB0byBmaWxlOiB1cmwuCisgICAgICAgIEhvd2V2ZXIsIFdlYktpdCBj bGllbnQgY291bGQgc2VuZCBkb3duIGFuIGVtcHR5IFVSTCB0aGF0IG1ha2VzIHVzIHRyYW5zZm9y bSBpdCB0byBmaWxlOiB1cmwKKyAgICAgICAgYXMgd2VsbC4gIFdlIHNob3VsZCBza2lwIHRoYXQg YXMgd2UgZGlkIGZvciBuaWwgVVJMcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViRnJhbWUubW06CisgICAgICAgICgtW1dlYkZy YW1lIGxvYWRSZXF1ZXN0Ol0pOgorCiAyMDEyLTA2LTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJv ZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkZyYW1lOjpfc3RyaW5nQnlFdmFsdWF0aW5nSmF2 YVNjcmlwdEZyb21TdHJpbmcgbWV0aG9kcyBkb24ndCBoYW5kbGUgbmlsIHN0cmluZwpJbmRleDog U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCShyZXZpc2lvbiAxMTkzMDIpCisrKyBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0x Mzc1LDkgKzEzNzUsOSBAQCAtICh2b2lkKWxvYWRSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1 CiAgICAgLy8gU29tZSB1c2VycyBvZiBXZWJLaXQgQVBJIGluY29ycmVjdGx5IHVzZSAiZmlsZSBw YXRoIGFzIFVSTCIgc3R5bGUgcmVxdWVzdHMgd2hpY2ggYXJlIGludmFsaWQuCiAgICAgLy8gQnkg cmUtd3JpdGluZyB0aG9zZSBVUkxzIGhlcmUgd2UgdGVjaG5pY2FsbHkgYnJlYWsgdGhlIC1bV2Vi RGF0YVNvdXJjZSBpbml0aWFsUmVxdWVzdF0gQVBJCiAgICAgLy8gYnV0IHRoYXQgaXMgbmVjZXNz YXJ5IHRvIGltcGxlbWVudCB0aGlzIHF1aXJrIG9ubHkgYXQgdGhlIEFQSSBib3VuZGFyeS4KLSAg ICAvLyBOb3RlIHRoYXQgb3RoZXIgdXNlcnMgb2YgV2ViS2l0IEFQSSB1c2UgbmlsIHJlcXVlc3Rz IG9yIHJlcXVlc3RzIHdpdGggbmlsIFVSTHMsIHNvIHdlCi0gICAgLy8gb25seSBpbXBsZW1lbnQg dGhpcyB3b3JrYXJvdW5kIHdoZW4gdGhlIHJlcXVlc3QgaGFkIGEgbm9uLW5pbCBVUkwuCi0gICAg aWYgKCFyZXNvdXJjZVJlcXVlc3QudXJsKCkuaXNWYWxpZCgpICYmIFtyZXF1ZXN0IFVSTF0pCisg ICAgLy8gTm90ZSB0aGF0IG90aGVyIHVzZXJzIG9mIFdlYktpdCBBUEkgdXNlIG5pbCByZXF1ZXN0 cyBvciByZXF1ZXN0cyB3aXRoIG5pbCBVUkxzIG9yIGVtcHR5IFVSTHMsIHNvIHdlCisgICAgLy8g b25seSBpbXBsZW1lbnQgdGhpcyB3b3JrYXJvdW5kIHdoZW4gdGhlIHJlcXVlc3QgaGFkIGEgbm9u LW5pbCBvciBub24tZW1wdHkgVVJMLgorICAgIGlmICghcmVzb3VyY2VSZXF1ZXN0LnVybCgpLmlz VmFsaWQoKSAmJiBbcmVxdWVzdCBVUkxdICYmICFyZXNvdXJjZVJlcXVlc3QudXJsKCkuaXNFbXB0 eSgpKQogICAgICAgICByZXNvdXJjZVJlcXVlc3Quc2V0VVJMKFtOU1VSTCBVUkxXaXRoU3RyaW5n OltAImZpbGU6IiBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzpbW3JlcXVlc3QgVVJMXSBhYnNvbHV0 ZVN0cmluZ11dXSk7CiAKICAgICBjb3JlRnJhbWUtPmxvYWRlcigpLT5sb2FkKHJlc291cmNlUmVx dWVzdCwgZmFsc2UpOwo= 145412 2012-06-01 17:47:14 -0700 2012-06-02 10:31:48 -0700 Don't transform empty URLs to file: URL, update the changeLog with bug id. loadRequest.patch text/plain 2174 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTMwMikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTAx ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgbG9h ZFJlcXVlc3Qgc2hvdWxkIGNoZWNrIGZvciBlbXB0eSBVUkxzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxNTQKKworICAgICAgICBJbiBbV2ViRnJh bWUgbG9hZFJlcXVlc3RdLCBpZiB0aGUgdXJsIGlzIGludmFsaWQgYW5kIG5vdCBuaWwsIHdlIHRy YW5zZm9ybSBpdCB0byBmaWxlOiB1cmwuCisgICAgICAgIEhvd2V2ZXIsIFdlYktpdCBjbGllbnQg Y291bGQgc2VuZCBkb3duIGFuIGVtcHR5IFVSTCB0aGF0IG1ha2VzIHVzIHRyYW5zZm9ybSBpdCB0 byBmaWxlOiB1cmwKKyAgICAgICAgYXMgd2VsbC4gIFdlIHNob3VsZCBza2lwIHRoYXQgYXMgd2Ug ZGlkIGZvciBuaWwgVVJMcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYlZpZXcvV2ViRnJhbWUubW06CisgICAgICAgICgtW1dlYkZyYW1lIGxv YWRSZXF1ZXN0Ol0pOgorCiAyMDEyLTA2LTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYkZyYW1lOjpfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlw dEZyb21TdHJpbmcgbWV0aG9kcyBkb24ndCBoYW5kbGUgbmlsIHN0cmluZwpJbmRleDogU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCShyZXZpc2lvbiAxMTkzMDIpCisrKyBTb3VyY2Uv V2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzc1LDkg KzEzNzUsOSBAQCAtICh2b2lkKWxvYWRSZXF1ZXN0OihOU1VSTFJlcXVlc3QgKilyZXF1CiAgICAg Ly8gU29tZSB1c2VycyBvZiBXZWJLaXQgQVBJIGluY29ycmVjdGx5IHVzZSAiZmlsZSBwYXRoIGFz IFVSTCIgc3R5bGUgcmVxdWVzdHMgd2hpY2ggYXJlIGludmFsaWQuCiAgICAgLy8gQnkgcmUtd3Jp dGluZyB0aG9zZSBVUkxzIGhlcmUgd2UgdGVjaG5pY2FsbHkgYnJlYWsgdGhlIC1bV2ViRGF0YVNv dXJjZSBpbml0aWFsUmVxdWVzdF0gQVBJCiAgICAgLy8gYnV0IHRoYXQgaXMgbmVjZXNzYXJ5IHRv IGltcGxlbWVudCB0aGlzIHF1aXJrIG9ubHkgYXQgdGhlIEFQSSBib3VuZGFyeS4KLSAgICAvLyBO b3RlIHRoYXQgb3RoZXIgdXNlcnMgb2YgV2ViS2l0IEFQSSB1c2UgbmlsIHJlcXVlc3RzIG9yIHJl cXVlc3RzIHdpdGggbmlsIFVSTHMsIHNvIHdlCi0gICAgLy8gb25seSBpbXBsZW1lbnQgdGhpcyB3 b3JrYXJvdW5kIHdoZW4gdGhlIHJlcXVlc3QgaGFkIGEgbm9uLW5pbCBVUkwuCi0gICAgaWYgKCFy ZXNvdXJjZVJlcXVlc3QudXJsKCkuaXNWYWxpZCgpICYmIFtyZXF1ZXN0IFVSTF0pCisgICAgLy8g Tm90ZSB0aGF0IG90aGVyIHVzZXJzIG9mIFdlYktpdCBBUEkgdXNlIG5pbCByZXF1ZXN0cyBvciBy ZXF1ZXN0cyB3aXRoIG5pbCBVUkxzIG9yIGVtcHR5IFVSTHMsIHNvIHdlCisgICAgLy8gb25seSBp bXBsZW1lbnQgdGhpcyB3b3JrYXJvdW5kIHdoZW4gdGhlIHJlcXVlc3QgaGFkIGEgbm9uLW5pbCBv ciBub24tZW1wdHkgVVJMLgorICAgIGlmICghcmVzb3VyY2VSZXF1ZXN0LnVybCgpLmlzVmFsaWQo KSAmJiBbcmVxdWVzdCBVUkxdICYmICFyZXNvdXJjZVJlcXVlc3QudXJsKCkuaXNFbXB0eSgpKQog ICAgICAgICByZXNvdXJjZVJlcXVlc3Quc2V0VVJMKFtOU1VSTCBVUkxXaXRoU3RyaW5nOltAImZp bGU6IiBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzpbW3JlcXVlc3QgVVJMXSBhYnNvbHV0ZVN0cmlu Z11dXSk7CiAKICAgICBjb3JlRnJhbWUtPmxvYWRlcigpLT5sb2FkKHJlc291cmNlUmVxdWVzdCwg ZmFsc2UpOwo= 145451 2012-06-02 10:31:48 -0700 2012-06-02 14:30:18 -0700 only use isEmpty() as Brady pointed out, since String.isEmpty() also covers the nil URL case. loadRequest.patch text/plain 2155 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTMyMikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTAx ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgbG9h ZFJlcXVlc3Qgc2hvdWxkIGNoZWNrIGZvciBlbXB0eSBVUkxzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxNTQKKworICAgICAgICBJbiBbV2ViRnJh bWUgbG9hZFJlcXVlc3RdLCBpZiB0aGUgdXJsIGlzIGludmFsaWQgYW5kIG5vdCBuaWwsIHdlIHRy YW5zZm9ybSBpdCB0byBmaWxlOiB1cmwuCisgICAgICAgIEhvd2V2ZXIsIFdlYktpdCBjbGllbnQg Y291bGQgc2VuZCBkb3duIGFuIGVtcHR5IFVSTCB0aGF0IG1ha2VzIHVzIHRyYW5zZm9ybSBpdCB0 byBmaWxlOiB1cmwKKyAgICAgICAgYXMgd2VsbC4gIFdlIHNob3VsZCBza2lwIHRoYXQgYXMgd2Ug ZGlkIGZvciBuaWwgVVJMcy4KKworICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCisK KyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lLm1tOgorICAgICAgICAoLVtXZWJGcmFtZSBsb2Fk UmVxdWVzdDpdKToKKwogMjAxMi0wNi0wMSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWJGcmFtZTo6X3N0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHRG cm9tU3RyaW5nIG1ldGhvZHMgZG9uJ3QgaGFuZGxlIG5pbCBzdHJpbmcKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQkocmV2aXNpb24gMTE5MzIyKQorKysgU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTM3NSw5ICsx Mzc1LDkgQEAgLSAodm9pZClsb2FkUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdQogICAgIC8v IFNvbWUgdXNlcnMgb2YgV2ViS2l0IEFQSSBpbmNvcnJlY3RseSB1c2UgImZpbGUgcGF0aCBhcyBV UkwiIHN0eWxlIHJlcXVlc3RzIHdoaWNoIGFyZSBpbnZhbGlkLgogICAgIC8vIEJ5IHJlLXdyaXRp bmcgdGhvc2UgVVJMcyBoZXJlIHdlIHRlY2huaWNhbGx5IGJyZWFrIHRoZSAtW1dlYkRhdGFTb3Vy Y2UgaW5pdGlhbFJlcXVlc3RdIEFQSQogICAgIC8vIGJ1dCB0aGF0IGlzIG5lY2Vzc2FyeSB0byBp bXBsZW1lbnQgdGhpcyBxdWlyayBvbmx5IGF0IHRoZSBBUEkgYm91bmRhcnkuCi0gICAgLy8gTm90 ZSB0aGF0IG90aGVyIHVzZXJzIG9mIFdlYktpdCBBUEkgdXNlIG5pbCByZXF1ZXN0cyBvciByZXF1 ZXN0cyB3aXRoIG5pbCBVUkxzLCBzbyB3ZQotICAgIC8vIG9ubHkgaW1wbGVtZW50IHRoaXMgd29y a2Fyb3VuZCB3aGVuIHRoZSByZXF1ZXN0IGhhZCBhIG5vbi1uaWwgVVJMLgotICAgIGlmICghcmVz b3VyY2VSZXF1ZXN0LnVybCgpLmlzVmFsaWQoKSAmJiBbcmVxdWVzdCBVUkxdKQorICAgIC8vIE5v dGUgdGhhdCBvdGhlciB1c2VycyBvZiBXZWJLaXQgQVBJIHVzZSBuaWwgcmVxdWVzdHMgb3IgcmVx dWVzdHMgd2l0aCBuaWwgVVJMcyBvciBlbXB0eSBVUkxzLCBzbyB3ZQorICAgIC8vIG9ubHkgaW1w bGVtZW50IHRoaXMgd29ya2Fyb3VuZCB3aGVuIHRoZSByZXF1ZXN0IGhhZCBhIG5vbi1uaWwgb3Ig bm9uLWVtcHR5IFVSTC4KKyAgICBpZiAoIXJlc291cmNlUmVxdWVzdC51cmwoKS5pc1ZhbGlkKCkg JiYgIXJlc291cmNlUmVxdWVzdC51cmwoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJlc291cmNlUmVx dWVzdC5zZXRVUkwoW05TVVJMIFVSTFdpdGhTdHJpbmc6W0AiZmlsZToiIHN0cmluZ0J5QXBwZW5k aW5nU3RyaW5nOltbcmVxdWVzdCBVUkxdIGFic29sdXRlU3RyaW5nXV1dKTsKIAogICAgIGNvcmVG cmFtZS0+bG9hZGVyKCktPmxvYWQocmVzb3VyY2VSZXF1ZXN0LCBmYWxzZSk7Cg==