88141 2012-06-01 15:24:19 -0700 DFG constant folding search for the last local access skips the immediately previous local access 2012-06-01 15:45:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 639784 0 fpizlo 2012-06-01 15:24:19 -0700 If you use a loop in the style of: for (i = start; i--;) then you need to remember that the first value of 'i' that the loop body will see is 'start - 1'. Hence the following is probably wrong: for (i = start - 1; i--;) 639787 1 145390 fpizlo 2012-06-01 15:26:43 -0700 Created attachment 145390 the patch 639800 2 fpizlo 2012-06-01 15:45:10 -0700 Landed in http://trac.webkit.org/changeset/119292 145390 2012-06-01 15:26:43 -0700 2012-06-01 15:32:14 -0700 the patch fixconstfold_patch_1.diff text/plain 4597 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5Mjg4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEyLTA2LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGNvbnN0YW50IGZvbGRpbmcgc2VhcmNoIGZvciB0aGUgbGFzdCBsb2NhbCBhY2Nlc3Mgc2tp cHMgdGhlIGltbWVkaWF0ZWx5IHByZXZpb3VzIGxvY2FsIGFjY2VzcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxNDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIElmIHlvdSB1c2UgYSBsb29w IGluIHRoZSBzdHlsZSBvZjoKKworICAgICAgICBmb3IgKGkgPSBzdGFydDsgaS0tOykKKworICAg ICAgICB0aGVuIHlvdSBuZWVkIHRvIHJlbWVtYmVyIHRoYXQgdGhlIGZpcnN0IHZhbHVlIG9mICdp JyB0aGF0IHRoZSBsb29wIGJvZHkgd2lsbCBzZWUgaXMgJ3N0YXJ0IC0gMScuCisgICAgICAgIEhl bmNlIHRoZSBmb2xsb3dpbmcgaXMgcHJvYmFibHkgd3Jvbmc6CisgICAgICAgIAorICAgICAgICBm b3IgKGkgPSBzdGFydCAtIDE7IGktLTspCisKKyAgICAgICAgKiBkZmcvREZHQ29uc3RhbnRGb2xk aW5nUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkNvbnN0YW50Rm9sZGluZ1BoYXNlOjpy dW4pOgorCiAyMDEyLTA2LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgREZHIGNvbnN0YW50IGZvbGRpbmcgc2hvdWxkIGJlIE9LIHdpdGggR2V0TG9jYWwgb2Yg Y2FwdHVyZWQgdmFyaWFibGVzIGhhdmluZyBhIGNvbnN0YW50CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcAkocmV2 aXNpb24gMTE5Mjg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEZv bGRpbmdQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg0LDcgKzg0LDcgQEAgcHVibGljOgog ICAgICAgICAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICAgICAgQVNT RVJUKGluZGV4SW5CbG9jayA+IDApOwogICAgICAgICAgICAgICAgICAgICAgICAgLy8gTXVzdCBz ZWFyY2ggZm9yIHRoZSBwcmV2aW91cyBhY2Nlc3MgdG8gdGhpcyBsb2NhbC4KLSAgICAgICAgICAg ICAgICAgICAgICAgIGZvciAoQmxvY2tJbmRleCBzdWJJbmRleEluQmxvY2sgPSBpbmRleEluQmxv Y2sgLSAxOyBzdWJJbmRleEluQmxvY2stLTspIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGZv ciAoQmxvY2tJbmRleCBzdWJJbmRleEluQmxvY2sgPSBpbmRleEluQmxvY2s7IHN1YkluZGV4SW5C bG9jay0tOykgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5vZGVJbmRleCBzdWJOb2Rl SW5kZXggPSBibG9jay0+YXQoc3ViSW5kZXhJbkJsb2NrKTsKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBOb2RlJiBzdWJOb2RlID0gbV9ncmFwaFtzdWJOb2RlSW5kZXhdOwogICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGlmICghc3ViTm9kZS5zaG91bGRHZW5lcmF0ZSgpKQpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gMTE5Mjg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KKworICAgICAgICBERkcgY29uc3RhbnQgZm9sZGluZyBzZWFyY2ggZm9yIHRoZSBs YXN0IGxvY2FsIGFjY2VzcyBza2lwcyB0aGUgaW1tZWRpYXRlbHkgcHJldmlvdXMgbG9jYWwgYWNj ZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODE0 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFz dC9qcy9kZmctb2J2aW91cy1jb25zdGFudC1jZmEtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2pzL2RmZy1vYnZpb3VzLWNvbnN0YW50LWNmYS5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9kZmctb2J2aW91cy1jb25zdGFudC1jZmEuanM6IEFk ZGVkLgorICAgICAgICAoYmFyLmJheik6CisgICAgICAgIChiYXIpOgorCiAyMDEyLTA2LTAxICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBhIHR5cG8gaW4g dGhlIGV4cGVjdGVkIHJlc3VsdCBmb3IgdGhlIHRlc3QgYWRkZWQgaW4gcjExOTI4MS4xMTkyODEK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvZGZnLW9idmlvdXMtY29uc3RhbnQtY2ZhLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL2RmZy1vYnZpb3VzLWNv bnN0YW50LWNmYS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2pzL2RmZy1vYnZpb3VzLWNvbnN0YW50LWNmYS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMTAgQEAKK1RoaXMgdGVzdHMgdGhhdCBpZiB0aGUgQ0ZBIHBlcmZvcm1zIGNvbnN0 YW50IGZvbGRpbmcgb24gYW4gb2J2aW91cyBzZXQgYW5kIHRoZW4gZ2V0IG9mIGEgY2FwdHVyZWQg bG9jYWwsIHRoZW4gd2UgZG9uJ3QgY3Jhc2guCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBh IHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4K KworCitQQVNTIHJlc3VsdCBpcyAyMjgzMDAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2RmZy1vYnZp b3VzLWNvbnN0YW50LWNmYS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMv ZGZnLW9idmlvdXMtY29uc3RhbnQtY2ZhLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2pzL2RmZy1vYnZpb3VzLWNvbnN0YW50LWNmYS5odG1sCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDEwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9F TiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMv ZGZnLW9idmlvdXMtY29uc3RhbnQtY2ZhLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2RmZy1vYnZpb3VzLWNvbnN0YW50LWNm YS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9kZmct b2J2aW91cy1jb25zdGFudC1jZmEuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2pzL3NjcmlwdC10ZXN0cy9kZmctb2J2aW91cy1jb25zdGFudC1jZmEuanMJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMjMgQEAKK2Rlc2NyaXB0aW9uKAorIlRoaXMgdGVzdHMgdGhhdCBpZiB0aGUg Q0ZBIHBlcmZvcm1zIGNvbnN0YW50IGZvbGRpbmcgb24gYW4gb2J2aW91cyBzZXQgYW5kIHRoZW4g Z2V0IG9mIGEgY2FwdHVyZWQgbG9jYWwsIHRoZW4gd2UgZG9uJ3QgY3Jhc2guIgorKTsKKworZnVu Y3Rpb24gYmFyKGEsIGIpIHsKKyAgICB2YXIgeDsKKyAgICB2YXIgeTsKKyAgICBmdW5jdGlvbiBi YXooKSB7CisgICAgICAgIHJldHVybiB4ICsgeTsKKyAgICB9CisgICAgeCA9IDEzOworICAgIHkg PSAxNjsKKyAgICBpZiAoeSA9PSAxNikgeworICAgICAgICByZXR1cm4geCArIGEgKyBiICsgYmF6 KCk7CisgICAgfSBlbHNlCisgICAgICAgIHJldHVybiAyNDsKK30KKwordmFyIHJlc3VsdCA9IDA7 Citmb3IgKHZhciBpID0gMDsgaSA8IDIwMDsgKytpKQorICAgIHJlc3VsdCArPSBiYXIoaSwgMTAw MCk7CisKK3Nob3VsZEJlKCJyZXN1bHQiLCAiMjI4MzAwIik7Cg==