88130 2012-06-01 13:33:06 -0700 [BlackBerry] Fix the return value checking in SelectPopupClient 2012-06-01 15:34:51 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 haizhang webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 639675 0 haizhang 2012-06-01 13:33:06 -0700 In SelectPopupClient, return '1' means selected, '0' means not selected, the ASCII value of '0' is 48, not 32, use '0' to be more readable. 639679 1 145370 haizhang 2012-06-01 13:36:52 -0700 Created attachment 145370 patch 639687 2 145370 rwlbuis 2012-06-01 13:46:46 -0700 Comment on attachment 145370 patch Looks good. 639790 3 145370 webkit.review.bot 2012-06-01 15:34:47 -0700 Comment on attachment 145370 patch Clearing flags on attachment: 145370 Committed r119290: <http://trac.webkit.org/changeset/119290> 639791 4 webkit.review.bot 2012-06-01 15:34:51 -0700 All reviewed patches have been landed. Closing bug. 145370 2012-06-01 13:36:52 -0700 2012-06-01 15:34:47 -0700 patch 0001-2012-06-01-Crystal-Zhang-haizhang-rim.com.patch text/plain 2381 haizhang RnJvbSBmZWExZWE4Mjg4NTMxODk0MTk1YTY3MTM5ZDQ5Nzc4ZTk3ZDExODNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl OiBGcmksIDEgSnVuIDIwMTIgMTY6MzU6NDcgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA2 LTAxICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4KCiAgICAgICAgW0JsYWNrQmVy cnldIEZpeCB0aGUgcmV0dXJuIHZhbHVlIGNoZWNraW5nIGluIFNlbGVjdFBvcHVwQ2xpZW50CiAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MTMwCgogICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBJbiBTZWxlY3RQb3B1cENs aWVudCwgcmV0dXJuICcxJyBtZWFucyBzZWxlY3RlZCwgJzAnIG1lYW5zIG5vdCBzZWxlY3RlZCwK ICAgICAgICB0aGUgQVNDSUkgdmFsdWUgb2YgJzAnIGlzIDQ4LCBub3QgMzIsIHVzZSAnMCcgdG8g YmUgbW9yZSByZWFkYWJsZS4KCiAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1cENs aWVudC5jcHA6CiAgICAgICAgKFdlYkNvcmU6OlNlbGVjdFBvcHVwQ2xpZW50OjpzZXRWYWx1ZUFu ZENsb3NlUG9wdXApOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL2JsYWNrYmVycnkv V2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwICAgICAgIHwgICAgMiArLQogMiBm aWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggNzBlNDJiMC4uMTk1NzQyYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMDEgIENyeXN0YWwgWmhh bmcgIDxoYWl6aGFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGaXggdGhlIHJl dHVybiB2YWx1ZSBjaGVja2luZyBpbiBTZWxlY3RQb3B1cENsaWVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgxMzAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBTZWxlY3RQb3B1cENsaWVudCwgcmV0 dXJuICcxJyBtZWFucyBzZWxlY3RlZCwgJzAnIG1lYW5zIG5vdCBzZWxlY3RlZCwgCisgICAgICAg IHRoZSBBU0NJSSB2YWx1ZSBvZiAnMCcgaXMgNDgsIG5vdCAzMiwgdXNlICcwJyB0byBiZSBtb3Jl IHJlYWRhYmxlLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0UG9wdXBDbGllbnQ6OnNldFZhbHVlQW5kQ2xv c2VQb3B1cCk6CisKIDIwMTItMDYtMDEgIEpvbmF0aGFuIERvbmcgIDxqb25hdGhhbi5kb25nQHRv cmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIGVuZCBlZGl0aW5n IGhhbmRsaW5nIGludG8gQXV0b2ZpbGxNYW5hZ2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1NlbGVjdFBvcHVwQ2xpZW50LmNwcApp bmRleCA5MmY2NTUwLi5kMzg4YjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHAKQEAgLTE0 Miw3ICsxNDIsNyBAQCB2b2lkIFNlbGVjdFBvcHVwQ2xpZW50OjpzZXRWYWx1ZUFuZENsb3NlUG9w dXAoaW50LCBjb25zdCBTdHJpbmcmIHN0cmluZ1ZhbHVlKQogICAgIGlmIChtX3NpemUgPiAwKSB7 CiAgICAgICAgIGJvb2wgc2VsZWN0ZWRzW21fc2l6ZV07CiAgICAgICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBtX3NpemU7IGkrKykKLSAgICAgICAgICAgIHNlbGVjdGVkc1tpXSA9IHN0cmlu Z1ZhbHVlW2ldIC0gMzI7CisgICAgICAgICAgICBzZWxlY3RlZHNbaV0gPSBzdHJpbmdWYWx1ZVtp XSAtICcwJzsKIAogICAgICAgICBjb25zdCBXVEY6OlZlY3RvcjxIVE1MRWxlbWVudCo+JiBpdGVt cyA9IG1fZWxlbWVudC0+bGlzdEl0ZW1zKCk7CiAKLS0gCjEuNy4xMC4xCgo=