88119 2012-06-01 12:07:09 -0700 REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call 2012-06-01 12:32:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 639588 0 beidson 2012-06-01 12:07:09 -0700 REGRESSION (r99448) Zero-sized plugins never get an NPP_SetWindow call The regression from 99448 was specifically about Netscape plug-ins on Mac, but it's a theoretical problem on all WK2 ports. In radar as <rdar://problem/11335622> 639603 1 145354 beidson 2012-06-01 12:15:59 -0700 Created attachment 145354 Patch v1 639611 2 145354 andersca 2012-06-01 12:22:54 -0700 Comment on attachment 145354 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=145354&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:715 > + m_hasCalledSetWindow = true; I think you should set this to true in callSetWindow, since it can be called from platformPaint as well. 639613 3 beidson 2012-06-01 12:24:57 -0700 http://trac.webkit.org/changeset/119260 639619 4 beidson 2012-06-01 12:28:59 -0700 (In reply to comment #2) > (From update of attachment 145354 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145354&action=review > > > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:715 > > + m_hasCalledSetWindow = true; > > I think you should set this to true in callSetWindow, since it can be called from platformPaint as well. I was trying to keep it local to where it was used, having done an (apparently faulty) search for other callers and coming up empty. Makes sense, and will do in a followup. 639624 5 beidson 2012-06-01 12:32:36 -0700 Followed up in http://trac.webkit.org/changeset/119261 145354 2012-06-01 12:15:59 -0700 2012-06-01 12:22:54 -0700 Patch v1 patch.txt text/plain 3324 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNTcwODEyLi5hYmI4Yzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDYtMDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMTMzNTYyMj4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODExOQorICAgICAgICBSRUdSRVNTSU9OIChyOTk0NDgpIFplcm8t c2l6ZWQgcGx1Zy1pbnMgbm8gbG9uZ2VyIGdldCBhbiBOUFBfU2V0V2luZG93IGNhbGwKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBmbGFnIHRv IE5ldHNjYXBlUGx1Z2luIHRvIHRyYWNrIHdoZXRoZXIgb3Igbm90IE5QUF9TZXRXaW5kb3cgaGFz IGV2ZXIgYmVlbiBjYWxsZWQuCisgICAgICAgIENoZWNrIHRoaXMgZmxhZyBpbiBnZW9tZXRyeURp ZENoYW5nZSB0byBtYWtlIHN1cmUgZXZlcnkgcGx1Zy1pbiBnZXRzIHRoZSBjYWxsIGF0IGxlYXN0 IG9uY2UuCisKKyAgICAgICAgIkV2ZXJ5Ym9keSBnZXRzIG9uZS4gIFRlbGwgaGltLCBQZXRlci4i CisgICAgICAgICJBcHBhcmVudGx5IGV2ZXJ5Ym9keSBnZXRzIG9uZS4iCisgICAgICAgICJCaW5n by4iCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVn aW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6TmV0c2NhcGVQbHVnaW4p OgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6Z2VvbWV0cnlEaWRDaGFuZ2UpOgor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oOgor ICAgICAgICAoTmV0c2NhcGVQbHVnaW4pOgorCiAyMDEyLTA1LTMxICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgd2Via2l0X2Rv d25sb2FkX2dldF9yZXF1ZXN0IHRvIFdlYktpdDIgR1RLKyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVn aW4uY3BwCmluZGV4IDJiOTEwMzguLjMxYzdhNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNw cApAQCAtNzEsNiArNzEsNyBAQCBOZXRzY2FwZVBsdWdpbjo6TmV0c2NhcGVQbHVnaW4oUGFzc1Jl ZlB0cjxOZXRzY2FwZVBsdWdpbk1vZHVsZT4gcGx1Z2luTW9kdWxlKQogICAgICwgbV9pc1RyYW5z cGFyZW50KGZhbHNlKQogICAgICwgbV9pbk5QUE5ldyhmYWxzZSkKICAgICAsIG1fc2hvdWxkVXNl TWFudWFsTG9hZGVyKGZhbHNlKQorICAgICwgbV9oYXNDYWxsZWRTZXRXaW5kb3coZmFsc2UpCiAg ICAgLCBtX25leHRUaW1lcklEKDApCiAjaWYgUExBVEZPUk0oTUFDKQogICAgICwgbV9kcmF3aW5n TW9kZWwoc3RhdGljX2Nhc3Q8TlBEcmF3aW5nTW9kZWw+KC0xKSkKQEAgLTY5MiwxMSArNjkzLDEx IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46Omdlb21ldHJ5RGlkQ2hhbmdlKGNvbnN0IEludFNpemUm IHBsdWdpblNpemUsIGNvbnN0IEludFJlY3QmCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAg ICBib29sIHNob3VsZENhbGxXaW5kb3cgPSB0cnVlOworICAgIGJvb2wgc2hvdWxkQ2FsbFNldFdp bmRvdyA9IHRydWU7CiAKICAgICAvLyBJZiB0aGUgcGx1Zy1pbiBkb2Vzbid0IHdhbnQgd2luZG93 IHJlbGF0aXZlIGNvb3JkaW5hdGVzLCB3ZSBkb24ndCBuZWVkIHRvIGNhbGwgc2V0V2luZG93IHVu bGVzcyBpdHMgc2l6ZSBvciBjbGlwIHJlY3QgY2hhbmdlcy4KLSAgICBpZiAod2FudHNQbHVnaW5S ZWxhdGl2ZU5QV2luZG93Q29vcmRpbmF0ZXMoKSAmJiBtX3BsdWdpblNpemUgPT0gcGx1Z2luU2l6 ZSAmJiBtX2NsaXBSZWN0ID09IGNsaXBSZWN0KQotICAgICAgICBzaG91bGRDYWxsV2luZG93ID0g ZmFsc2U7CisgICAgaWYgKG1faGFzQ2FsbGVkU2V0V2luZG93ICYmIHdhbnRzUGx1Z2luUmVsYXRp dmVOUFdpbmRvd0Nvb3JkaW5hdGVzKCkgJiYgbV9wbHVnaW5TaXplID09IHBsdWdpblNpemUgJiYg bV9jbGlwUmVjdCA9PSBjbGlwUmVjdCkKKyAgICAgICAgc2hvdWxkQ2FsbFNldFdpbmRvdyA9IGZh bHNlOwogCiAgICAgbV9wbHVnaW5TaXplID0gcGx1Z2luU2l6ZTsKICAgICBtX2NsaXBSZWN0ID0g Y2xpcFJlY3Q7CkBAIC03MDcsMTAgKzcwOCwxMSBAQCB2b2lkIE5ldHNjYXBlUGx1Z2luOjpnZW9t ZXRyeURpZENoYW5nZShjb25zdCBJbnRTaXplJiBwbHVnaW5TaXplLCBjb25zdCBJbnRSZWN0Jgog CiAgICAgcGxhdGZvcm1HZW9tZXRyeURpZENoYW5nZSgpOwogCi0gICAgaWYgKCFzaG91bGRDYWxs V2luZG93KQorICAgIGlmICghc2hvdWxkQ2FsbFNldFdpbmRvdykKICAgICAgICAgcmV0dXJuOwog CiAgICAgY2FsbFNldFdpbmRvdygpOworICAgIG1faGFzQ2FsbGVkU2V0V2luZG93ID0gdHJ1ZTsK IH0KIAogdm9pZCBOZXRzY2FwZVBsdWdpbjo6dmlzaWJpbGl0eURpZENoYW5nZSgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQ bHVnaW4uaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRz Y2FwZVBsdWdpbi5oCmluZGV4IDkxOTQ5ODQuLjFjNDljNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdp bi5oCkBAIC0yNzIsNiArMjcyLDggQEAgcHJpdmF0ZToKICAgICBib29sIG1faXNUcmFuc3BhcmVu dDsKICAgICBib29sIG1faW5OUFBOZXc7CiAgICAgYm9vbCBtX3Nob3VsZFVzZU1hbnVhbExvYWRl cjsKKyAgICBib29sIG1faGFzQ2FsbGVkU2V0V2luZG93OworCiAgICAgUmVmUHRyPE5ldHNjYXBl UGx1Z2luU3RyZWFtPiBtX21hbnVhbFN0cmVhbTsKICAgICBWZWN0b3I8Ym9vbCwgOD4gbV9wb3B1 cEVuYWJsZWRTdGF0ZXM7CiAK