88118 2012-06-01 12:02:36 -0700 [Win] jscore-tests flakey 2012-06-27 18:14:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Windows 7 RESOLVED FIXED http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29?numbuilds=100 InRadar, MakingBotsRed P2 Normal --- 90119 1 jberlin msaboff fpizlo ggaren msaboff oliver webkit-bug-importer webkit.review.bot oldest_to_newest 639581 0 jberlin 2012-06-01 12:02:36 -0700 The tests that fail and the number of tests that fail vary between runs: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24361/steps/jscore-test/logs/stdio (r119227) ** Danger, Will Robinson! Danger! The following failures have been introduced: js1_3/regress/function-002.js http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24362 (r119229) No failures http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24363/steps/jscore-test/logs/stdio (r119235) ** Danger, Will Robinson! Danger! The following failures have been introduced: ecma/LexicalConventions/7.4.3-1-n.js js1_2/regexp/parentheses.js http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24365/steps/jscore-test/logs/stdio (r119239) ** Danger, Will Robinson! Danger! The following failures have been introduced: ecma/Date/15.9.3.8-4.js ecma_2/Exceptions/expression-019.js ecma_2/Exceptions/lexical-015.js ecma_3/RegExp/regress-78156.js http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/24366/steps/jscore-test/logs/stdio (r119241) ** Danger, Will Robinson! Danger! The following failures have been introduced: ecma_2/Statements/switch-002.js I am not sure what to do about this. As long as they are flakey, the Windows bots will be flakey red. 639584 1 webkit-bug-importer 2012-06-01 12:03:31 -0700 <rdar://problem/11576884> 659037 2 149837 msaboff 2012-06-27 18:02:00 -0700 Created attachment 149837 Patch 659041 3 webkit.review.bot 2012-06-27 18:05:49 -0700 Attachment 149837 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/tests/mozilla/jsDriver.pl:191: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:192: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:193: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:219: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:222: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:223: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:225: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:226: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:227: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:228: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:229: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/tests/mozilla/jsDriver.pl:230: Line contains tab character. [whitespace/tab] [5] Total errors found: 12 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 659048 4 149837 jberlin 2012-06-27 18:09:56 -0700 Comment on attachment 149837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149837&action=review > Source/JavaScriptCore/tests/mozilla/jsDriver.pl:185 > +# with 0 or 3. To work around this, a -x option was added to jsc that will Missing an ")" after 3. > Source/JavaScriptCore/tests/mozilla/jsDriver.pl:231 > + } elsif ($opt_exit_munge == 1) { Looks like this elseif needs to be outdented one level. 659050 5 msaboff 2012-06-27 18:14:33 -0700 Committed r121394: <http://trac.webkit.org/changeset/121394> 149837 2012-06-27 18:02:00 -0700 2012-06-27 18:09:56 -0700 Patch 88118.patch text/plain 5434 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIxMzkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEyLTA2LTI3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIGpzY29yZS10ZXN0cyBmbGFrZXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAganNEcml2ZXIucGwgb24gd2luZG93cyBpbnRlcm1pdHRlbnRs eSBkb2Vzbid0IGdldCB0aGUgcmV0dXJuZWQgdmFsdWUgZnJvbSBqc2MsCisgICAgICAgIGluc3Rl YWQgaXQgZ2V0cyAxMjYuICBBZGRlZCBhIG5ldyBvcHRpb24gdG8ganNjICgteCkgd2hpY2ggcHJp bnRzIHRoZSBleGl0CisgICAgICAgIGNvZGUgYmVmb3JlIGV4aXRpbmcuICBqc0RyaXZlci5wbCB1 c2VzIHRoaXMgb3B0aW9uIG9uIFdpbmRvd3MgYW5kIHBhcnNlcyB0aGUKKyAgICAgICAgZXhpdCBj b2RlIG91dHB1dCBmb3IgdGhlIGV4aXQgY29kZSwgcmVtb3ZpbmcgaXQgYmVmb3JlIGNvbXBhcmlu ZyB0aGUgYWN0dWFsCisgICAgICAgIGFuZCBleHBlY3RlZCBvdXRwdXRzLiAgRmlsZWQgYSBmb2xs b3cgb24gIkZJWE1FIiBkZWZlY3Q6CisgICAgICAgIFtXSU5dIEludGVybWl0dGVudCBmYWlsdXJl IGZvciBqc2MgcmV0dXJuIHZhbHVlIHRvIHByb3BhZ2F0ZSB0aHJvdWdoIGpzRHJpdmVyLnBsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MDExOQorCisg ICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKENvbW1hbmRMaW5lOjpDb21tYW5kTGluZSk6Cisg ICAgICAgIChDb21tYW5kTGluZSk6CisgICAgICAgIChwcmludFVzYWdlU3RhdGVtZW50KToKKyAg ICAgICAgKHBhcnNlQXJndW1lbnRzKToKKyAgICAgICAgKGpzY21haW4pOgorICAgICAgICAqIHRl c3RzL21vemlsbGEvanNEcml2ZXIucGw6CisgICAgICAgIChleGVjdXRlX3Rlc3RzKToKKwogMjAx Mi0wNi0yNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEphdmFz Y3JpcHQgU0hBLTUxMiBnaXZlcyB3cm9uZyBoYXNoIG9uIHNlY29uZCBhbmQgc3Vic2VxdWVudCBy dW5zIHVubGVzcyBXZWIgSW5zcGVjdG9yIEphdmFzY3JpcHQgRGVidWdnaW5nIGlzIG9uCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gMTIxMzg5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNywxMSArMTE3LDEzIEBAIHN0cnVj dCBDb21tYW5kTGluZSB7CiAgICAgQ29tbWFuZExpbmUoKQogICAgICAgICA6IGludGVyYWN0aXZl KGZhbHNlKQogICAgICAgICAsIGR1bXAoZmFsc2UpCisgICAgICAgICwgZXhpdENvZGUoZmFsc2Up CiAgICAgewogICAgIH0KIAogICAgIGJvb2wgaW50ZXJhY3RpdmU7CiAgICAgYm9vbCBkdW1wOwor ICAgIGJvb2wgZXhpdENvZGU7CiAgICAgVmVjdG9yPFNjcmlwdD4gc2NyaXB0czsKICAgICBWZWN0 b3I8VVN0cmluZz4gYXJndW1lbnRzOwogfTsKQEAgLTYxMSw2ICs2MTMsNyBAQCBzdGF0aWMgTk9f UkVUVVJOIHZvaWQgcHJpbnRVc2FnZVN0YXRlbWVuCiAjaWYgSEFWRShTSUdOQUxfSCkKICAgICBm cHJpbnRmKHN0ZGVyciwgIiAgLXMgICAgICAgICBJbnN0YWxscyBzaWduYWwgaGFuZGxlcnMgdGhh dCBleGl0IG9uIGEgY3Jhc2ggKFVuaXggcGxhdGZvcm1zIG9ubHkpXG4iKTsKICNlbmRpZgorICAg IGZwcmludGYoc3RkZXJyLCAiICAteCAgICAgICAgIE91dHB1dCBleGl0IGNvZGUgYmVmb3JlIHRl cm1pbmF0aW5nXG4iKTsKIAogICAgIGV4aXQoaGVscCA/IEVYSVRfU1VDQ0VTUyA6IEVYSVRfRkFJ TFVSRSk7CiB9CkBAIC02NDksNiArNjUyLDEwIEBAIHN0YXRpYyB2b2lkIHBhcnNlQXJndW1lbnRz KGludCBhcmdjLCBjaGEKICNlbmRpZgogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0K KyAgICAgICAgaWYgKCFzdHJjbXAoYXJnLCAiLXgiKSkgeworICAgICAgICAgICAgb3B0aW9ucy5l eGl0Q29kZSA9IHRydWU7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQogICAgICAg ICBpZiAoIXN0cmNtcChhcmcsICItLSIpKSB7CiAgICAgICAgICAgICArK2k7CiAgICAgICAgICAg ICBicmVhazsKQEAgLTY2Nyw5ICs2NzQsOSBAQCBzdGF0aWMgdm9pZCBwYXJzZUFyZ3VtZW50cyhp bnQgYXJnYywgY2hhCiAKIGludCBqc2NtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKIHsKLSAg ICAKICAgICBSZWZQdHI8SlNHbG9iYWxEYXRhPiBnbG9iYWxEYXRhID0gSlNHbG9iYWxEYXRhOjpj cmVhdGUoVGhyZWFkU3RhY2tUeXBlTGFyZ2UsIExhcmdlSGVhcCk7CiAgICAgSlNMb2NrSG9sZGVy IGxvY2soZ2xvYmFsRGF0YS5nZXQoKSk7CisgICAgaW50IHJlc3VsdDsKIAogICAgIENvbW1hbmRM aW5lIG9wdGlvbnM7CiAgICAgcGFyc2VBcmd1bWVudHMoYXJnYywgYXJndiwgb3B0aW9ucyk7CkBA IC02NzksNyArNjg2LDEyIEBAIGludCBqc2NtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKICAg ICBpZiAob3B0aW9ucy5pbnRlcmFjdGl2ZSAmJiBzdWNjZXNzKQogICAgICAgICBydW5JbnRlcmFj dGl2ZShnbG9iYWxPYmplY3QpOwogCi0gICAgcmV0dXJuIHN1Y2Nlc3MgPyAwIDogMzsKKyAgICBy ZXN1bHQgPSBzdWNjZXNzID8gMCA6IDM7CisKKyAgICBpZiAob3B0aW9ucy5leGl0Q29kZSkKKyAg ICAgICAgcHJpbnRmKCJqc2MgZXhpdGluZyAlZFxuIiwgcmVzdWx0KTsKKworICAgIHJldHVybiBy ZXN1bHQ7CiB9CiAKIHN0YXRpYyBib29sIGZpbGxCdWZmZXJXaXRoQ29udGVudHNPZkZpbGUoY29u c3QgVVN0cmluZyYgZmlsZU5hbWUsIFZlY3RvcjxjaGFyPiYgYnVmZmVyKQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL21vemlsbGEvanNEcml2ZXIucGwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL21vemlsbGEvanNEcml2ZXIucGwJKHJldmlzaW9u IDEyMTM4OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9tb3ppbGxhL2pzRHJpdmVy LnBsCSh3b3JraW5nIGNvcHkpCkBAIC0xNjQsNiArMTY0LDcgQEAgc3ViIGV4ZWN1dGVfdGVzdHMg ewogICAgICAgICBteSAkZmFpbHVyZV9saW5lczsKICAgICAgICAgbXkgJGJ1Z19udW1iZXI7CiAg ICAgICAgIG15ICRzdGF0dXNfbGluZXM7CisgICAgICAgIG15IEBqc2NfZXhpdF9jb2RlOwogICAg ICAgICAKICMgdXNlciBzZWxlY3RlZCBbUV11aXQgZnJvbSBeQyBoYW5kbGVyLgogICAgICAgICBp ZiAoJHVzZXJfZXhpdCkgewpAQCAtMTc3LDYgKzE3OCwxOSBAQCBzdWIgZXhlY3V0ZV90ZXN0cyB7 CiAgICAgICAgICAgICAkc2hlbGxfY29tbWFuZCA9ICRvcHRfYXJjaCAuICIgIjsKICAgICAgICAg ICAgIAogICAgICAgICAgICAgJHNoZWxsX2NvbW1hbmQgLj0gJnhwX3BhdGgoJGVuZ2luZV9jb21t YW5kKSAgLiAiIC1zICI7CisKKyMgRklYTUU6IDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTAxMTk+CisjIFNwb3JhZGljYWxseSBvbiBXaW5kb3dzLCB0aGUgZXhpdCBj b2RlIHJldHVybmVkIGFmdGVyIGNsb3NlKCkgaW4KKyMgJD8gaXMgMTI2IChhZnRlciB0aGUgYXBw cm9wcmFpdGUgc2hpZnRpbmcsIGV2ZW4gdGhvdWdoIGpzYyBleGl0cworIyB3aXRoIDAgb3IgMy4g VG8gd29yayBhcm91bmQgdGhpcywgYSAteCBvcHRpb24gd2FzIGFkZGVkIHRvIGpzYyB0aGF0IHdp bGwKKyMgb3V0cHV0IHRoZSBleGl0IHZhbHVlIHJpZ2h0IGJlZm9yZSBleGl0aW5nLiAgV2UgcGFy c2UgdGhhdCB2YWx1ZSBhbmQKKyMgcmVtb3ZlIGl0IGZyb20gdGhlIG91dHB1dCBzdHJlYW0gYmVm b3JlIGNvbXBhcmluZyB0aGUgYWN0dWFsIGFuZCBleHBlY3RlZAorIyBvdXRwdXRzLiBXaGVuIHRo YXQgYnVnIGlzIGZvdW5kIGFuZCBmaXhlZCwgdGhlIGNvZGUgZm9yIHByb2Nlc3Npbmcgb2YKKyMg ImpzYyBleGl0aW5nIFtcZF0iIGFuZCB1c2Ugb2YgQGpzY19leGl0X2NvZGUgY2FuIGJlIHJlbW92 ZWQgYWxvbmcgd2l0aAorIyB0aGUgLXggb3B0aW9uIGluIGpzYy5jcHAKKwkgICAgaWYgKCRvc190 eXBlIGVxICJXSU4iKSB7CisJCSRzaGVsbF9jb21tYW5kIC49ICIgLXggIjsKKwkgICAgfQogICAg ICAgICAgICAgCiAgICAgICAgICAgICAkcGF0aCA9ICZ4cF9wYXRoKCRvcHRfc3VpdGVfcGF0aCAu ICRzdWl0ZSAuICIvc2hlbGwuanMiKTsKICAgICAgICAgICAgIGlmICgtZiAkcGF0aCkgewpAQCAt MjAyLDEwICsyMTYsMTkgQEAgc3ViIGV4ZWN1dGVfdGVzdHMgewogICAgICAgICAgICAgICAkcmVk aXJlY3RfY29tbWFuZCAuICIgfCIpOwogICAgICAgICBAb3V0cHV0ID0gPE9VVFBVVD47CiAgICAg ICAgIGNsb3NlIChPVVRQVVQpOwotICAgICAgICAKLSAgICAgICAgQG91dHB1dCA9IGdyZXAgKCEv anNcPi8sIEBvdXRwdXQpOwotICAgICAgICAKLSAgICAgICAgaWYgKCRvcHRfZXhpdF9tdW5nZSA9 PSAxKSB7CisJCisgICAgICAgIEBqc2NfZXhpdF9jb2RlID0gZ3JlcCAoL2pzYyBleGl0aW5nIFtc ZF0vLCBAb3V0cHV0KTsKKyAgICAgICAgQG91dHB1dCA9IGdyZXAgKCEvanNcPnxqc2MgZXhpdGlu ZyBbXGRdLywgQG91dHB1dCk7CisJCisJaWYgKCgkI2pzY19leGl0X2NvZGUgPT0gMCkgJiYgKCRq c2NfZXhpdF9jb2RlWzBdID1+IC9qc2MgZXhpdGluZyAoW1xkXSlcVyovKSkgeworIyByZXR1cm4g dmFsdWUgZnJvbSBqc2Mgb3V0cHV0IHRvIHdvcmsgYXJvdW5kIHdpbmRvd3MgYnVnCisJICAgICRn b3RfZXhpdCA9ICQxOworCSAgICBpZiAoJG9wdF9leGl0X211bmdlID09IDEpIHsKKwkJJGV4aXRf c2lnbmFsID0gKCQ/ICYgMjU1KTsKKwkgICAgfSBlbHNlIHsKKwkJJGV4aXRfc2lnbmFsID0gMDsK KwkgICAgfQorICAgICAgICB9IGVsc2lmICgkb3B0X2V4aXRfbXVuZ2UgPT0gMSkgewogIyBzaWdu YWwgaW5mb3JtYXRpb24gaW4gdGhlIGxvd2VyIDggYml0cywgZXhpdCBjb2RlIGFib3ZlIHRoYXQK ICAgICAgICAgICAgICRnb3RfZXhpdCA9ICgkPyA+PiA4KTsKICAgICAgICAgICAgICRleGl0X3Np Z25hbCA9ICgkPyAmIDI1NSk7Cg==