88109 2012-06-01 10:47:25 -0700 WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string 2012-06-07 17:07:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff thorton webkit-bug-importer oldest_to_newest 639514 0 msaboff 2012-06-01 10:47:25 -0700 The various flavors of WebFrame::_stringByEvaluatingJavaScriptFromString don't properly handle nil string. Instead such nil strings are passed down to the JavaScript engine where it may be a crash. An if (!string) return @"": should be added as appropriate. 639567 1 145346 msaboff 2012-06-01 11:52:01 -0700 Created attachment 145346 Patch 639620 2 145346 simon.fraser 2012-06-01 12:29:16 -0700 Comment on attachment 145346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145346&action=review > Tools/TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:60 > + EXPECT_EQ(nil, result); Don't you expect an empty string, not a nil string? 639629 3 145346 ggaren 2012-06-01 12:37:24 -0700 Comment on attachment 145346 Patch Expectation should be empty string. Does nil pass? 639676 4 145369 msaboff 2012-06-01 13:34:11 -0700 Created attachment 145369 Patch with fix (In reply to comment #3) > (From update of attachment 145346 [details]) > Expectation should be empty string. Does nil pass? I was thinking about this as I was out at lunch, realizing that the test was wrong. The test was "passing", but shouldn't. I was assuming that run-test-webkit-api built the tests before running. Therefore I wasn't testing the new code. Built and tested this patch. It works as expected. 639707 5 145369 ggaren 2012-06-01 14:14:24 -0700 Comment on attachment 145369 Patch with fix r=me 639717 6 msaboff 2012-06-01 14:26:29 -0700 Committed r119280: <http://trac.webkit.org/changeset/119280> 644095 7 webkit-bug-importer 2012-06-07 17:07:16 -0700 <rdar://problem/11620927> 145346 2012-06-01 11:52:01 -0700 2012-06-01 13:34:11 -0700 Patch 88109.patch text/plain 3485 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTI1NykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTAx ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkZyYW1l Ojpfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmcgbWV0aG9kcyBkb24ndCBo YW5kbGUgbmlsIHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODgxMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBzaG9ydCBjaXJjdWl0IHJldHVybiB3aGVuIHRoZSBOU1N0cmluZyB0byBl dmFsdWF0ZSBpcyBuaWwuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lLm1tOgorICAgICAg ICAoLVtXZWJGcmFtZSBfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmc6Zm9y Y2VVc2VyR2VzdHVyZTpdKToKKyAgICAgICAgKC1bV2ViRnJhbWUgX3N0cmluZ0J5RXZhbHVhdGlu Z0phdmFTY3JpcHRGcm9tU3RyaW5nOndpdGhHbG9iYWxPYmplY3Q6aW5TY3JpcHRXb3JsZDpdKToK KwogMjAxMi0wNS0zMSAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxMTc1NzIpOiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2st YXN5bmMtcmVtb3ZlLWZyYW1lLmh0bWwgY3Jhc2hlcyBvbiBNYWMKSW5kZXg6IFNvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJGcmFtZS5tbQkocmV2aXNpb24gMTE5MjU0KQorKysgU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNTgwLDYgKzU4MCw5 IEBAIC0gKE5TU3RyaW5nICopX3N0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3IKIAogLSAoTlNTdHJp bmcgKilfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmc6KE5TU3RyaW5nICop c3RyaW5nIGZvcmNlVXNlckdlc3R1cmU6KEJPT0wpZm9yY2VVc2VyR2VzdHVyZQogeworICAgIGlm ICghc3RyaW5nKQorICAgICAgICByZXR1cm4gQCIiOworCiAgICAgQVNTRVJUKF9wcml2YXRlLT5j b3JlRnJhbWUtPmRvY3VtZW50KCkpOwogICAgIFJldGFpblB0cjxXZWJGcmFtZT4gcHJvdGVjdChz ZWxmKTsgLy8gRXhlY3V0aW5nIGFyYml0cmFyeSBKYXZhU2NyaXB0IGNhbiBkZXN0cm95IHRoZSBm cmFtZS4KICAgICAKQEAgLTExMDMsNiArMTEwNiw5IEBAIC0gKEJPT0wpX2FsbG93c0ZvbGxvd2lu Z0xpbms6KE5TVVJMICopVVIKIAogLSAoTlNTdHJpbmcgKilfc3RyaW5nQnlFdmFsdWF0aW5nSmF2 YVNjcmlwdEZyb21TdHJpbmc6KE5TU3RyaW5nICopc3RyaW5nIHdpdGhHbG9iYWxPYmplY3Q6KEpT T2JqZWN0UmVmKWdsb2JhbE9iamVjdFJlZiBpblNjcmlwdFdvcmxkOihXZWJTY3JpcHRXb3JsZCAq KXdvcmxkCiB7CisgICAgaWYgKCFzdHJpbmcpCisgICAgICAgIHJldHVybiBAIiI7CisKICAgICAv LyBTdGFydCBvZmYgd2l0aCBzb21lIGd1ZXNzIGF0IGEgZnJhbWUgYW5kIGEgZ2xvYmFsIG9iamVj dCwgd2UnbGwgdHJ5IHRvIGRvIGJldHRlci4uLiEKICAgICBKU0RPTVdpbmRvdyogYW55V29ybGRH bG9iYWxPYmplY3QgPSBfcHJpdmF0ZS0+Y29yZUZyYW1lLT5zY3JpcHQoKS0+Z2xvYmFsT2JqZWN0 KG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKTsKIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5MjU3KQorKysgVG9vbHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMDEgIE1pY2hh ZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViRnJhbWU6Ol9zdHJp bmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0RnJvbVN0cmluZyBtZXRob2RzIGRvbid0IGhhbmRsZSBu aWwgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODEwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGl0aW9uYWwgdGVzdCBjYXNlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9t YWMvU3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmcubW06CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxMi0wNi0wMSAgSmVzc2llIEJlcmxpbiAgPGpiZXJs aW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkLgpJbmRleDogVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21T dHJpbmcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU3Ry aW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmcubW0JKHJldmlzaW9uIDExOTI1NCkK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL1N0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHRGcm9tU3RyaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSwxMCBAQCBURVNU KFdlYktpdDEsIFN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpCiAKICAgICBSZXRhaW5QdHI8V2Vi Vmlldz4gd2ViVmlldyAoQWRvcHROUywgW1tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5T WmVyb1JlY3QgZnJhbWVOYW1lOkAiIiBncm91cE5hbWU6QCIiXSk7CiAKKyAgICAvLyBUZXN0IGEg bmlsIHN0cmluZworICAgIE5TU3RyaW5nICpyZXN1bHQgPSBbd2ViVmlldy5nZXQoKSBzdHJpbmdC eUV2YWx1YXRpbmdKYXZhU2NyaXB0RnJvbVN0cmluZzpuaWxdOworICAgIEVYUEVDVF9FUShuaWws IHJlc3VsdCk7CisKICAgICBmb3IgKGlkIGV4cHJlc3Npb24gaW4gZXhwcmVzc2lvbnMuZ2V0KCkp IHsKICAgICAgICAgTlNTdHJpbmcgKmV4cGVjdGVkUmVzdWx0ID0gW2V4cHJlc3Npb25zLmdldCgp IG9iamVjdEZvcktleTpleHByZXNzaW9uXTsKICAgICAgICAgTlNTdHJpbmcgKnJlc3VsdCA9IFt3 ZWJWaWV3LmdldCgpIHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHRGcm9tU3RyaW5nOmV4cHJl c3Npb25dOwo= 145369 2012-06-01 13:34:11 -0700 2012-06-01 14:14:24 -0700 Patch with fix 88109-1.patch text/plain 3491 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTI1NykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTAx ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkZyYW1l Ojpfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmcgbWV0aG9kcyBkb24ndCBo YW5kbGUgbmlsIHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODgxMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBzaG9ydCBjaXJjdWl0IHJldHVybiB3aGVuIHRoZSBOU1N0cmluZyB0byBl dmFsdWF0ZSBpcyBuaWwuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lLm1tOgorICAgICAg ICAoLVtXZWJGcmFtZSBfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmc6Zm9y Y2VVc2VyR2VzdHVyZTpdKToKKyAgICAgICAgKC1bV2ViRnJhbWUgX3N0cmluZ0J5RXZhbHVhdGlu Z0phdmFTY3JpcHRGcm9tU3RyaW5nOndpdGhHbG9iYWxPYmplY3Q6aW5TY3JpcHRXb3JsZDpdKToK KwogMjAxMi0wNS0zMSAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxMTc1NzIpOiBlZGl0aW5nL3NwZWxsaW5nL3NwZWxsY2hlY2st YXN5bmMtcmVtb3ZlLWZyYW1lLmh0bWwgY3Jhc2hlcyBvbiBNYWMKSW5kZXg6IFNvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJGcmFtZS5tbQkocmV2aXNpb24gMTE5MjU0KQorKysgU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNTgwLDYgKzU4MCw5 IEBAIC0gKE5TU3RyaW5nICopX3N0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3IKIAogLSAoTlNTdHJp bmcgKilfc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmc6KE5TU3RyaW5nICop c3RyaW5nIGZvcmNlVXNlckdlc3R1cmU6KEJPT0wpZm9yY2VVc2VyR2VzdHVyZQogeworICAgIGlm ICghc3RyaW5nKQorICAgICAgICByZXR1cm4gQCIiOworCiAgICAgQVNTRVJUKF9wcml2YXRlLT5j b3JlRnJhbWUtPmRvY3VtZW50KCkpOwogICAgIFJldGFpblB0cjxXZWJGcmFtZT4gcHJvdGVjdChz ZWxmKTsgLy8gRXhlY3V0aW5nIGFyYml0cmFyeSBKYXZhU2NyaXB0IGNhbiBkZXN0cm95IHRoZSBm cmFtZS4KICAgICAKQEAgLTExMDMsNiArMTEwNiw5IEBAIC0gKEJPT0wpX2FsbG93c0ZvbGxvd2lu Z0xpbms6KE5TVVJMICopVVIKIAogLSAoTlNTdHJpbmcgKilfc3RyaW5nQnlFdmFsdWF0aW5nSmF2 YVNjcmlwdEZyb21TdHJpbmc6KE5TU3RyaW5nICopc3RyaW5nIHdpdGhHbG9iYWxPYmplY3Q6KEpT T2JqZWN0UmVmKWdsb2JhbE9iamVjdFJlZiBpblNjcmlwdFdvcmxkOihXZWJTY3JpcHRXb3JsZCAq KXdvcmxkCiB7CisgICAgaWYgKCFzdHJpbmcpCisgICAgICAgIHJldHVybiBAIiI7CisKICAgICAv LyBTdGFydCBvZmYgd2l0aCBzb21lIGd1ZXNzIGF0IGEgZnJhbWUgYW5kIGEgZ2xvYmFsIG9iamVj dCwgd2UnbGwgdHJ5IHRvIGRvIGJldHRlci4uLiEKICAgICBKU0RPTVdpbmRvdyogYW55V29ybGRH bG9iYWxPYmplY3QgPSBfcHJpdmF0ZS0+Y29yZUZyYW1lLT5zY3JpcHQoKS0+Z2xvYmFsT2JqZWN0 KG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKTsKIApJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTE5MjU3KQorKysgVG9vbHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMDEgIE1pY2hh ZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViRnJhbWU6Ol9zdHJp bmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0RnJvbVN0cmluZyBtZXRob2RzIGRvbid0IGhhbmRsZSBu aWwgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODEwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGl0aW9uYWwgdGVzdCBjYXNlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9t YWMvU3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmcubW06CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxMi0wNi0wMSAgSmVzc2llIEJlcmxpbiAgPGpiZXJs aW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkLgpJbmRleDogVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21T dHJpbmcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU3Ry aW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdEZyb21TdHJpbmcubW0JKHJldmlzaW9uIDExOTI1NCkK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL1N0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHRGcm9tU3RyaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSwxMCBAQCBURVNU KFdlYktpdDEsIFN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpCiAKICAgICBSZXRhaW5QdHI8V2Vi Vmlldz4gd2ViVmlldyAoQWRvcHROUywgW1tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5T WmVyb1JlY3QgZnJhbWVOYW1lOkAiIiBncm91cE5hbWU6QCIiXSk7CiAKKyAgICAvLyBUZXN0IGEg bmlsIHN0cmluZworICAgIE5TU3RyaW5nICpyZXN1bHQgPSBbd2ViVmlldy5nZXQoKSBzdHJpbmdC eUV2YWx1YXRpbmdKYXZhU2NyaXB0RnJvbVN0cmluZzpuaWxdOworICAgIEVYUEVDVF9XS19TVFJF UShAIiIsIHJlc3VsdCk7CisKICAgICBmb3IgKGlkIGV4cHJlc3Npb24gaW4gZXhwcmVzc2lvbnMu Z2V0KCkpIHsKICAgICAgICAgTlNTdHJpbmcgKmV4cGVjdGVkUmVzdWx0ID0gW2V4cHJlc3Npb25z LmdldCgpIG9iamVjdEZvcktleTpleHByZXNzaW9uXTsKICAgICAgICAgTlNTdHJpbmcgKnJlc3Vs dCA9IFt3ZWJWaWV3LmdldCgpIHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHRGcm9tU3RyaW5n OmV4cHJlc3Npb25dOwo=