88106 2012-06-01 10:12:50 -0700 Crash in WebCore::FontFallbackList::determinePitch 2012-06-02 14:53:04 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 efidler efidler mitz rwlbuis staikos webkit.review.bot oldest_to_newest 639484 0 efidler 2012-06-01 10:12:50 -0700 If the site doesn't ask for a reasonable font and the system doesn't provide a good fallback, FontFallBackList::primaryFontData can be 0. 639488 1 145335 efidler 2012-06-01 10:15:57 -0700 Created attachment 145335 Patch 639583 2 145335 mitz 2012-06-01 12:03:04 -0700 Comment on attachment 145335 Patch There are many places in the code that require primaryFontData to be non-0. This bug should be fixed in the FontCache implementation so that it always provides some font as a last resort. 639709 3 145375 efidler 2012-06-01 14:16:36 -0700 Created attachment 145375 Patch 640082 4 145375 webkit.review.bot 2012-06-02 14:52:50 -0700 Comment on attachment 145375 Patch Clearing flags on attachment: 145375 Committed r119340: <http://trac.webkit.org/changeset/119340> 640083 5 webkit.review.bot 2012-06-02 14:53:04 -0700 All reviewed patches have been landed. Closing bug. 145335 2012-06-01 10:15:57 -0700 2012-06-01 14:16:31 -0700 Patch bug-88106-20120601131556.patch text/plain 1620 efidler U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBjYzQxNDcwOGM5ODI1 OGQ2OTQxNjQyZWZmMDRhZjMxMWY0NjM1MS4uN2Q5YjIxMjk5ZDBjYTIzNzE4NGYzMzA5MTFjOGE5 OGEzMDYwNDAwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTAxICBFbGkg RmlkbGVyICA8ZWZpZGxlckByaW0uY29tPgorCisgICAgICAgIERvbid0IGNyYXNoIGlmIHdlIGFz ayBmb3IgZm9udHMgdGhhdCBkb24ndCBleGlzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUklNIFBSIDE2MTIxOQorCisgICAgICAgIElmIHRoZSBzaXRl IGRvZXNuJ3QgYXNrIGZvciBhIHJlYXNvbmFibGUgZm9udCBhbmQgdGhlIHN5c3RlbSBkb2Vzbid0 CisgICAgICAgIHByb3ZpZGUgYSBnb29kIGZhbGxiYWNrLCBGb250RmFsbEJhY2tMaXN0Ojpwcmlt YXJ5Rm9udERhdGEgY2FuIGJlIDAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250 RmFsbGJhY2tMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRGYWxsYmFja0xpc3Q6OmRl dGVybWluZVBpdGNoKToKKwogMjAxMi0wNS0yOCAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0aGFuLmRv bmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBodHRwIGF1dGhl bnRpY2F0aW9uIGNyYXNoIHRoZSBicm93c2VyIHdoZW4gdXNlciBjb21taXQgb3IgY2FuY2VsIHRo ZSBodHRwIGF1dGhlbnRpY2F0aW9uIGRpYWxvZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhbGxiYWNrTGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Gb250RmFsbGJhY2tMaXN0LmNwcAppbmRleCA2ZDExYzA5ZTM0Yjcw ZWJjZDM3ZmQ3OTFkZTljZGQ4ZjgxMmI5NWY3Li44Mzk1MmExODNiMjE4YjU1MzNlYWU3M2Y2YWY1 YThhZmI2NGNhYWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9Gb250RmFsbGJhY2tMaXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9Gb250RmFsbGJhY2tMaXN0LmNwcApAQCAtNzYsNiArNzYsOSBAQCB2b2lkIEZvbnRGYWxs YmFja0xpc3Q6OnJlbGVhc2VGb250RGF0YSgpCiB2b2lkIEZvbnRGYWxsYmFja0xpc3Q6OmRldGVy bWluZVBpdGNoKGNvbnN0IEZvbnQqIGZvbnQpIGNvbnN0CiB7CiAgICAgY29uc3QgRm9udERhdGEq IGZvbnREYXRhID0gcHJpbWFyeUZvbnREYXRhKGZvbnQpOworICAgIGlmICghZm9udERhdGEpCisg ICAgICAgIHJldHVybjsKKwogICAgIGlmICghZm9udERhdGEtPmlzU2VnbWVudGVkKCkpCiAgICAg ICAgIG1fcGl0Y2ggPSBzdGF0aWNfY2FzdDxjb25zdCBTaW1wbGVGb250RGF0YSo+KGZvbnREYXRh KS0+cGl0Y2goKTsKICAgICBlbHNlIHsK 145375 2012-06-01 14:16:36 -0700 2012-06-02 14:52:49 -0700 Patch bug-88106-20120601171635.patch text/plain 1838 efidler U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBjYzQxNDcwOGM5ODI1 OGQ2OTQxNjQyZWZmMDRhZjMxMWY0NjM1MS4uOWI1MzZmMjM4MWM2NmE1NTRiMzcyYTRiZTgzNWUx NDc1MGExMjE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTAxICBFbGkg RmlkbGVyICA8ZWZpZGxlckByaW0uY29tPgorCisgICAgICAgIERvbid0IGNyYXNoIGlmIHdlIGFz ayBmb3IgZm9udHMgdGhhdCBkb24ndCBleGlzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUklNIFBSIDE2MTIxOQorCisgICAgICAgIElmIHRoZSBzaXRl IGRvZXNuJ3QgYXNrIGZvciBhIHJlYXNvbmFibGUgZm9udCBhbmQgdGhlIHN5c3RlbSBkb2Vzbid0 CisgICAgICAgIHByb3ZpZGUgYSBnb29kIGZhbGxiYWNrLCBGb250RmFsbEJhY2tMaXN0Ojpwcmlt YXJ5Rm9udERhdGEgY2FuIGJlIDAsCisgICAgICAgIHdoaWNoIGNhbiBjYXVzZSBhIGNyYXNoLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250Q2FjaGVTa2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0TGFzdFJlc29ydEZhbGxiYWNrRm9udCk6CisK IDIwMTItMDUtMjggIEpvbmF0aGFuIERvbmcgIDxqb25hdGhhbi5kb25nQHRvcmNobW9iaWxlLmNv bS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gaHR0cCBhdXRoZW50aWNhdGlvbiBjcmFzaCB0 aGUgYnJvd3NlciB3aGVuIHVzZXIgY29tbWl0IG9yIGNhbmNlbCB0aGUgaHR0cCBhdXRoZW50aWNh dGlvbiBkaWFsb2cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvRm9udENhY2hlU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9za2lhL0ZvbnRDYWNoZVNraWEuY3BwCmluZGV4IDdjNzUyMTc3MzAwYzlmNDdlODU3NWM2YzA4 MmYxMzhhYTg2NWU2NWQuLjQwNWIzMzYyMDA1NmI3ZjY0OTMyMzE4MDg3NTY0OGUyMzY2ZGJmODYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udENh Y2hlU2tpYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9G b250Q2FjaGVTa2lhLmNwcApAQCAtMTE1LDYgKzExNSwxMiBAQCBTaW1wbGVGb250RGF0YSogRm9u dENhY2hlOjpnZXRMYXN0UmVzb3J0RmFsbGJhY2tGb250KGNvbnN0IEZvbnREZXNjcmlwdGlvbiYg ZGVzYwogICAgICAgICBicmVhazsKICAgICB9CiAKKyAgICBpZiAoIWZvbnRQbGF0Zm9ybURhdGEp IHsKKyAgICAgICAgLy8gd2Ugc2hvdWxkIGF0IGxlYXN0IGhhdmUgQXJpYWw7IHRoaXMgaXMgdGhl IFNrRm9udEhvc3RfZm9udGNvbmZpZyBsYXN0IHJlc29ydCBmYWxsYmFjaworICAgICAgICBERUZJ TkVfU1RBVElDX0xPQ0FMKGNvbnN0IEF0b21pY1N0cmluZywgYXJpYWxTdHIsICgiQXJpYWwiKSk7 CisgICAgICAgIGZvbnRQbGF0Zm9ybURhdGEgPSBnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRhKGRl c2NyaXB0aW9uLCBhcmlhbFN0cik7CisgICAgfQorCiAgICAgQVNTRVJUKGZvbnRQbGF0Zm9ybURh dGEpOwogICAgIHJldHVybiBnZXRDYWNoZWRGb250RGF0YShmb250UGxhdGZvcm1EYXRhLCBzaG91 bGRSZXRhaW4pOwogfQo=