88097 2012-06-01 08:14:35 -0700 [chromium] replace isScrollGestureEventType with isGestureEventType 2012-06-03 00:07:16 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rjkroege rjkroege abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 639355 0 rjkroege 2012-06-01 08:14:35 -0700 In Chromium WebInputEvent, isGestureScrollEventType is incorrect. It includes gesture event types that are not scroll gestures so serves neither the purpose of identifying a gesture event or the purpose of identifying a scrolling gesture event. Correct the method's name and function. 639730 1 145378 rjkroege 2012-06-01 14:38:27 -0700 Created attachment 145378 Patch 639732 2 rjkroege 2012-06-01 14:39:29 -0700 abarth@: Could you review please? 639734 3 webkit.review.bot 2012-06-01 14:40:21 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 639737 4 145378 abarth 2012-06-01 14:42:10 -0700 Comment on attachment 145378 Patch This is fine, but you've got an extra space after the == operators. 639748 5 145382 rjkroege 2012-06-01 14:53:47 -0700 Created attachment 145382 Patch 639750 6 rjkroege 2012-06-01 14:55:46 -0700 abarth@: fixed. PTAL. Sorry I forgot the --no-review. 640150 7 145382 webkit.review.bot 2012-06-03 00:07:10 -0700 Comment on attachment 145382 Patch Clearing flags on attachment: 145382 Committed r119355: <http://trac.webkit.org/changeset/119355> 640151 8 webkit.review.bot 2012-06-03 00:07:16 -0700 All reviewed patches have been landed. Closing bug. 145378 2012-06-01 14:38:27 -0700 2012-06-01 14:53:41 -0700 Patch bug-88097-20120601173826.patch text/plain 2381 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDliMzhkNmRiZDI4MGM0ZjQ5YWY1NjljNzhmYzkzZmUxZjRhOTBkMDMuLjc2Y2JkOGFlMWRiY2Vj MjA3Y2NiMDYxNWUwODg5OWIxNjMwZWNiNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMDEgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gcmVwbGFjZSBpc1Njcm9sbEdlc3R1cmVF dmVudFR5cGUgd2l0aCBpc0dlc3R1cmVFdmVudFR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MDk3CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgcmVw bGFjZXMgdGhlIHVudXNlZCBhbmQgaW5jb3JyZWN0IGlzU2Nyb2xsR2VzdHVyZUV2ZW50VHlwZQor ICAgICAgICBtZXRob2Qgd2l0aCBhIGNvcnJlY3QgYW5kIHVzZWZ1bCBpc0dlc3R1cmVFdmVudFR5 cGUgbWV0aG9kLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcHVibGljL1dlYklucHV0RXZlbnQuaDoKKyAgICAgICAgKFdlYklucHV0RXZlbnQpOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEV2ZW50Ojppc0dlc3R1cmVFdmVudFR5cGUpOgorCiAy MDEyLTA1LTI5ICBBbGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBJbmRleGVkREI6IEFsaWduIGNvZGVzIGFuZCBuYW1lcyBmb3IgSURCLXNwZWNpZmljIGFuZCBE T00tc3BlY2lmaWMgZXJyb3JzL2V4Y2VwdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklucHV0RXZlbnQuaAppbmRleCAxZDI2YjViN2E5MjY3OThkYTVkN2Y0MzI5NTA3 NDI1OTAwYTU0NDI4Li5mYmU4ZTM0NTdkYTBiNGMwOGZiMjViZDNiYWU5N2M0OTFkYjcwNjU5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCkBAIC0x OTgsMTYgKzE5OCwyMSBAQCBwdWJsaWM6CiAgICAgICAgICAgICB8fCB0eXBlID09IFRvdWNoRW5k OwogICAgIH0KIAotICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgV2ViSW5wdXRFdmVudCB8dHlw ZXwgc2hvdWxkIGJlIGhhbmRsZWQgYXMgc2Nyb2xsIGdlc3R1cmUuCi0gICAgc3RhdGljIGJvb2wg aXNTY3JvbGxHZXN0dXJlRXZlbnRUeXBlKGludCB0eXBlKQorICAgIC8vIFJldHVybnMgdHJ1ZSBp ZiB0aGUgV2ViSW5wdXRFdmVudCBpcyBhIGdlc3R1cmUgZXZlbnQuCisgICAgc3RhdGljIGJvb2wg aXNHZXN0dXJlRXZlbnRUeXBlKGludCB0eXBlKQogICAgIHsKICAgICAgICAgcmV0dXJuIHR5cGUg PT0gR2VzdHVyZVNjcm9sbEJlZ2luCi0gICAgICAgICAgICB8fCB0eXBlID09IEdlc3R1cmVTY3Jv bGxFbmQKLSAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVyZVNjcm9sbFVwZGF0ZQotICAgICAg ICAgICAgfHwgdHlwZSA9PSBHZXN0dXJlRmxpbmdTdGFydAotICAgICAgICAgICAgfHwgdHlwZSA9 PSBHZXN0dXJlRmxpbmdDYW5jZWwKLSAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVyZVRhcERv d24KLSAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVyZVRhcDsgLy8gRklYTUU6IFdoeSBpcyBH ZXN0dXJlVGFwIG9uIHRoaXMgbGlzdD8KKyAgICAgICAgICAgIHx8IHR5cGUgPT0gIEdlc3R1cmVT Y3JvbGxFbmQKKyAgICAgICAgICAgIHx8IHR5cGUgPT0gIEdlc3R1cmVTY3JvbGxVcGRhdGUKKyAg ICAgICAgICAgIHx8IHR5cGUgPT0gIEdlc3R1cmVGbGluZ1N0YXJ0CisgICAgICAgICAgICB8fCB0 eXBlID09ICBHZXN0dXJlRmxpbmdDYW5jZWwKKyAgICAgICAgICAgIHx8IHR5cGUgPT0gIEdlc3R1 cmVUYXAKKyAgICAgICAgICAgIHx8IHR5cGUgPT0gIEdlc3R1cmVUYXBEb3duCisgICAgICAgICAg ICB8fCB0eXBlID09ICBHZXN0dXJlRG91YmxlVGFwCisgICAgICAgICAgICB8fCB0eXBlID09ICBH ZXN0dXJlTG9uZ1ByZXNzCisgICAgICAgICAgICB8fCB0eXBlID09ICBHZXN0dXJlUGluY2hCZWdp bgorICAgICAgICAgICAgfHwgdHlwZSA9PSAgR2VzdHVyZVBpbmNoRW5kCisgICAgICAgICAgICB8 fCB0eXBlID09ICBHZXN0dXJlUGluY2hVcGRhdGU7CiAgICAgfQogfTsKIAo= 145382 2012-06-01 14:53:47 -0700 2012-06-03 00:07:09 -0700 Patch bug-88097-20120601175346.patch text/plain 2161 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDliMzhkNmRiZDI4MGM0ZjQ5YWY1NjljNzhmYzkzZmUxZjRhOTBkMDMuLjc2Y2JkOGFlMWRiY2Vj MjA3Y2NiMDYxNWUwODg5OWIxNjMwZWNiNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMDEgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gcmVwbGFjZSBpc1Njcm9sbEdlc3R1cmVF dmVudFR5cGUgd2l0aCBpc0dlc3R1cmVFdmVudFR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MDk3CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgcmVw bGFjZXMgdGhlIHVudXNlZCBhbmQgaW5jb3JyZWN0IGlzU2Nyb2xsR2VzdHVyZUV2ZW50VHlwZQor ICAgICAgICBtZXRob2Qgd2l0aCBhIGNvcnJlY3QgYW5kIHVzZWZ1bCBpc0dlc3R1cmVFdmVudFR5 cGUgbWV0aG9kLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcHVibGljL1dlYklucHV0RXZlbnQuaDoKKyAgICAgICAgKFdlYklucHV0RXZlbnQpOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEV2ZW50Ojppc0dlc3R1cmVFdmVudFR5cGUpOgorCiAy MDEyLTA1LTI5ICBBbGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBJbmRleGVkREI6IEFsaWduIGNvZGVzIGFuZCBuYW1lcyBmb3IgSURCLXNwZWNpZmljIGFuZCBE T00tc3BlY2lmaWMgZXJyb3JzL2V4Y2VwdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklucHV0RXZlbnQuaAppbmRleCAxZDI2YjViN2E5MjY3OThkYTVkN2Y0MzI5NTA3 NDI1OTAwYTU0NDI4Li45ODE5ZWFiN2IxNDg4ZTg2Y2ZiOWNiYTQ4ODQ4YjkyNDZmMTY5NjM5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCkBAIC0x OTgsMTYgKzE5OCwyMSBAQCBwdWJsaWM6CiAgICAgICAgICAgICB8fCB0eXBlID09IFRvdWNoRW5k OwogICAgIH0KIAotICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgV2ViSW5wdXRFdmVudCB8dHlw ZXwgc2hvdWxkIGJlIGhhbmRsZWQgYXMgc2Nyb2xsIGdlc3R1cmUuCi0gICAgc3RhdGljIGJvb2wg aXNTY3JvbGxHZXN0dXJlRXZlbnRUeXBlKGludCB0eXBlKQorICAgIC8vIFJldHVybnMgdHJ1ZSBp ZiB0aGUgV2ViSW5wdXRFdmVudCBpcyBhIGdlc3R1cmUgZXZlbnQuCisgICAgc3RhdGljIGJvb2wg aXNHZXN0dXJlRXZlbnRUeXBlKGludCB0eXBlKQogICAgIHsKICAgICAgICAgcmV0dXJuIHR5cGUg PT0gR2VzdHVyZVNjcm9sbEJlZ2luCiAgICAgICAgICAgICB8fCB0eXBlID09IEdlc3R1cmVTY3Jv bGxFbmQKICAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVyZVNjcm9sbFVwZGF0ZQogICAgICAg ICAgICAgfHwgdHlwZSA9PSBHZXN0dXJlRmxpbmdTdGFydAogICAgICAgICAgICAgfHwgdHlwZSA9 PSBHZXN0dXJlRmxpbmdDYW5jZWwKKyAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVyZVRhcAog ICAgICAgICAgICAgfHwgdHlwZSA9PSBHZXN0dXJlVGFwRG93bgotICAgICAgICAgICAgfHwgdHlw ZSA9PSBHZXN0dXJlVGFwOyAvLyBGSVhNRTogV2h5IGlzIEdlc3R1cmVUYXAgb24gdGhpcyBsaXN0 PworICAgICAgICAgICAgfHwgdHlwZSA9PSBHZXN0dXJlRG91YmxlVGFwCisgICAgICAgICAgICB8 fCB0eXBlID09IEdlc3R1cmVMb25nUHJlc3MKKyAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVy ZVBpbmNoQmVnaW4KKyAgICAgICAgICAgIHx8IHR5cGUgPT0gR2VzdHVyZVBpbmNoRW5kCisgICAg ICAgICAgICB8fCB0eXBlID09IEdlc3R1cmVQaW5jaFVwZGF0ZTsKICAgICB9CiB9OwogCg==