88088 2012-06-01 06:47:36 -0700 REGRESSION(r119219): This patch broke two tests on GTK/Qt. The authors are unavailable. (Requested by kkristof on #webkit). 2012-06-02 00:03:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88056 1 webkit.review.bot webkit.review.bot kkristof morrita ossy rniwa oldest_to_newest 639286 0 webkit.review.bot 2012-06-01 06:47:36 -0700 http://trac.webkit.org/changeset/119219 broke the build: This patch broke two tests on GTK/Qt. The authors are unavailable. (Requested by kkristof on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 639291 1 145293 webkit.review.bot 2012-06-01 06:48:33 -0700 Created attachment 145293 ROLLOUT of r119219 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 639292 2 145293 kkristof 2012-06-01 06:51:26 -0700 Comment on attachment 145293 ROLLOUT of r119219 Clearing flags on attachment: 145293 Committed r119225: <http://trac.webkit.org/changeset/119225> 639293 3 kkristof 2012-06-01 06:51:39 -0700 All reviewed patches have been landed. Closing bug. 639541 4 rniwa 2012-06-01 11:26:07 -0700 Thanks for the roll out. I knew it won't be as straight forward :( 639975 5 ap 2012-06-02 00:03:10 -0700 *** Bug 88085 has been marked as a duplicate of this bug. *** 145293 2012-06-01 06:48:33 -0700 2012-06-01 06:51:26 -0700 ROLLOUT of r119219 bug-88088-20120601135259.patch text/plain 4807 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk5MzBlM2EzNjQ3Y2I3 NTI4MGI3OWQ5YzIwYTFkOWIzMTI1ZDU3ZS4uYmU3YzUzM2NmMGE0YmU5ZjM0MmM5NDE5OTBmODVl OGZjYWQ5ODg5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTAxICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTE5MjE5LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTkyMTkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4MDg4CisKKyAgICAgICAgVGhpcyBwYXRjaCBicm9rZSB0d28gdGVzdHMgb24g R1RLL1F0LiBUaGUgYXV0aG9ycyBhcmUKKyAgICAgICAgdW5hdmFpbGFibGUuIChSZXF1ZXN0ZWQg Ynkga2tyaXN0b2Ygb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmNsb3NlQW5kUmVtb3ZlQ2hpbGQp OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmRldGFjaEZyb21QYXJlbnQpOgorICAg ICAgICAqIHBhZ2UvRnJhbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6OndpbGxEZXRh Y2hQYWdlKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmg6CisgICAgICAgIChGcmFtZSk6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZTo6ZGV0YWNoRnJvbVBhZ2UpOgorICAgICAgICAoV2ViQ29yZSk6 CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6On5QYWdl KToKKwogMjAxMi0wNi0wMSAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBGcmFtZTo6d2lsbERldGFjaFBhZ2UoKSBzaG91bGRuJ3QgYmUgY2FsbGVkIG1vcmUg dGhhbiBvbmNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggMmQ3OWFk NmI1ZDAwN2RhY2UwODRmZGY2ODE0ZGM2MzQ1MjhjZGUyNy4uZDM2ZDExMDQ5ZTIwZDYzOWFkNDQ2 ZDdjNjA0YWYzNjRlNWFiYzhjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CkBAIC0yMjY2LDYgKzIyNjYsNyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjbG9zZUFuZFJlbW92ZUNo aWxkKEZyYW1lKiBjaGlsZCkKICAgICBjaGlsZC0+c2V0VmlldygwKTsKICAgICBpZiAoY2hpbGQt Pm93bmVyRWxlbWVudCgpICYmIGNoaWxkLT5wYWdlKCkpCiAgICAgICAgIGNoaWxkLT5wYWdlKCkt PmRlY3JlbWVudEZyYW1lQ291bnQoKTsKKyAgICBjaGlsZC0+d2lsbERldGFjaFBhZ2UoKTsKICAg ICBjaGlsZC0+ZGV0YWNoRnJvbVBhZ2UoKTsKIAogICAgIG1fZnJhbWUtPnRyZWUoKS0+cmVtb3Zl Q2hpbGQoY2hpbGQpOwpAQCAtMjM0NCw2ICsyMzQ1LDcgQEAgdm9pZCBGcmFtZUxvYWRlcjo6ZGV0 YWNoRnJvbVBhcmVudCgpCiAgICAgICAgIHBhcmVudC0+bG9hZGVyKCktPnNjaGVkdWxlQ2hlY2tD b21wbGV0ZWQoKTsKICAgICB9IGVsc2UgewogICAgICAgICBtX2ZyYW1lLT5zZXRWaWV3KDApOwor ICAgICAgICBtX2ZyYW1lLT53aWxsRGV0YWNoUGFnZSgpOwogICAgICAgICBtX2ZyYW1lLT5kZXRh Y2hGcm9tUGFnZSgpOwogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKaW5kZXggZjgyOGFmZTVi NWY1MTIzMGIxNDY4NWMzZWE1NTVmNjIyYjE5NWYyMC4uMTUyYTFkOTVmYTJmMDNiNzI1YzhjZGQz NWY1ZjBkMjY3ZGI5OGE1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAgLTY4OSwyMyArNjg5LDE4 IEBAIERPTVdpbmRvdyogRnJhbWU6OmRvbVdpbmRvdygpIGNvbnN0CiAgICAgcmV0dXJuIG1fZG9t V2luZG93LmdldCgpOwogfQogCi12b2lkIEZyYW1lOjpkZXRhY2hGcm9tUGFnZSgpCit2b2lkIEZy YW1lOjp3aWxsRGV0YWNoUGFnZSgpCiB7CiAgICAgaWYgKEZyYW1lKiBwYXJlbnQgPSB0cmVlKCkt PnBhcmVudCgpKQogICAgICAgICBwYXJlbnQtPmxvYWRlcigpLT5jaGVja0xvYWRDb21wbGV0ZSgp OwotICAgIGlmIChtX3BhZ2UpCi0gICAgICAgIHdpbGxEZXRhY2hQYWdlKCk7Ci0gICAgbV9wYWdl ID0gMDsKLX0KLQogCi12b2lkIEZyYW1lOjp3aWxsRGV0YWNoUGFnZSgpCi17CiAgICAgSGFzaFNl dDxGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIqPjo6aXRlcmF0b3Igc3RvcCA9IG1fZGVzdHJ1Y3Rp b25PYnNlcnZlcnMuZW5kKCk7CiAgICAgZm9yIChIYXNoU2V0PEZyYW1lRGVzdHJ1Y3Rpb25PYnNl cnZlcio+OjppdGVyYXRvciBpdCA9IG1fZGVzdHJ1Y3Rpb25PYnNlcnZlcnMuYmVnaW4oKTsgaXQg IT0gc3RvcDsgKytpdCkKICAgICAgICAgKCppdCktPndpbGxEZXRhY2hQYWdlKCk7CiAKLSAgICBp ZiAocGFnZSgpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZEZyYW1lKCkgPT0gdGhpcykKKyAg ICAvLyBGSVhNRTogSXQncyB1bmNsZWFyIGFzIHRvIHdoeSB0aGlzIGlzIGNhbGxlZCBtb3JlIHRo YW4gb25jZSwgYnV0IGl0IGlzLAorICAgIC8vIHNvIHBhZ2UoKSBjb3VsZCBiZSBOVUxMLgorICAg IGlmIChwYWdlKCkgJiYgcGFnZSgpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZEZyYW1lKCkg PT0gdGhpcykKICAgICAgICAgcGFnZSgpLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZEZy YW1lKDApOwogCiAgICAgc2NyaXB0KCktPmNsZWFyU2NyaXB0T2JqZWN0cygpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZS5oCmluZGV4IDYwN2ZmMDZiYWM2ZWIzNmE0OWQ3OTMzYzgyYWVhZGZiZjFmOTQ0YzAuLjRjZDRm OTY4M2I0YzNiZTA1ZjgxN2NhODc1OWNhN2EzZmEzNmRhZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmgKQEAg LTkxLDYgKzkxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIGFkZERlc3Ry dWN0aW9uT2JzZXJ2ZXIoRnJhbWVEZXN0cnVjdGlvbk9ic2VydmVyKik7CiAgICAgICAgIHZvaWQg cmVtb3ZlRGVzdHJ1Y3Rpb25PYnNlcnZlcihGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIqKTsKIAor ICAgICAgICB2b2lkIHdpbGxEZXRhY2hQYWdlKCk7CiAgICAgICAgIHZvaWQgZGV0YWNoRnJvbVBh Z2UoKTsKICAgICAgICAgdm9pZCBkaXNjb25uZWN0T3duZXJFbGVtZW50KCk7CiAKQEAgLTIwNiw3 ICsyMDcsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEZyYW1lKFBhZ2UqLCBIVE1M RnJhbWVPd25lckVsZW1lbnQqLCBGcmFtZUxvYWRlckNsaWVudCopOwogCiAgICAgICAgIHZvaWQg aW5qZWN0VXNlclNjcmlwdHNGb3JXb3JsZChET01XcmFwcGVyV29ybGQqLCBjb25zdCBVc2VyU2Ny aXB0VmVjdG9yJiwgVXNlclNjcmlwdEluamVjdGlvblRpbWUpOwotICAgICAgICB2b2lkIHdpbGxE ZXRhY2hQYWdlKCk7CiAKICAgICAgICAgSGFzaFNldDxGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIq PiBtX2Rlc3RydWN0aW9uT2JzZXJ2ZXJzOwogCkBAIC0zNTEsNiArMzUxLDExIEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJuIG1fcGFnZTsKICAgICB9CiAKKyAgICBpbmxpbmUg dm9pZCBGcmFtZTo6ZGV0YWNoRnJvbVBhZ2UoKQorICAgIHsKKyAgICAgICAgbV9wYWdlID0gMDsK KyAgICB9CisKICAgICBpbmxpbmUgRXZlbnRIYW5kbGVyKiBGcmFtZTo6ZXZlbnRIYW5kbGVyKCkg Y29uc3QKICAgICB7CiAgICAgICAgIHJldHVybiAmbV9ldmVudEhhbmRsZXI7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmNwcAppbmRleCA1Yzc0NDQ3NTgwYmFhODhjYzE1OWZkM2Y2ODVmNjNhNjU5ZmRmYTMzLi5kMzA5 MDBmNjA1NTE0NzNhYzYxMWE5ZTM4NTEzZGUyNTFlYTVhMDJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAK QEAgLTE4Nyw4ICsxODcsMTAgQEAgUGFnZTo6flBhZ2UoKQogICAgIHNldEdyb3VwTmFtZShTdHJp bmcoKSk7CiAgICAgYWxsUGFnZXMtPnJlbW92ZSh0aGlzKTsKICAgICAKLSAgICBmb3IgKEZyYW1l KiBmcmFtZSA9IG1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2 ZXJzZU5leHQoKSkKKyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFtZSgpOyBmcmFtZTsg ZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkgeworICAgICAgICBmcmFtZS0+ d2lsbERldGFjaFBhZ2UoKTsKICAgICAgICAgZnJhbWUtPmRldGFjaEZyb21QYWdlKCk7CisgICAg fQogCiAgICAgbV9lZGl0b3JDbGllbnQtPnBhZ2VEZXN0cm95ZWQoKTsKICAgICBpZiAobV9hbHRl cm5hdGl2ZVRleHRDbGllbnQpCg==