88082 2012-06-01 05:50:58 -0700 [Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged 2012-06-01 08:43:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 639238 0 allan.jensen 2012-06-01 05:50:58 -0700 This function no longer serves any practical purpose and is also currently a cause of some flickering. 639244 1 145281 allan.jensen 2012-06-01 05:55:25 -0700 Created attachment 145281 Patch 639250 2 145281 webkit.review.bot 2012-06-01 05:59:14 -0700 Comment on attachment 145281 Patch Rejecting attachment 145281 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: onEngine.cpp Hunk #1 FAILED at 144. Hunk #2 succeeded at 734 with fuzz 1 (offset 59 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp.rej patching file Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h Hunk #1 succeeded at 82 with fuzz 1 (offset -20 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12865546 639260 3 145285 allan.jensen 2012-06-01 06:11:41 -0700 Created attachment 145285 Patch 639379 4 145285 webkit.review.bot 2012-06-01 08:43:20 -0700 Comment on attachment 145285 Patch Clearing flags on attachment: 145285 Committed r119234: <http://trac.webkit.org/changeset/119234> 639380 5 webkit.review.bot 2012-06-01 08:43:25 -0700 All reviewed patches have been landed. Closing bug. 145281 2012-06-01 05:55:25 -0700 2012-06-01 06:11:35 -0700 Patch bug-88082-20120601145535.patch text/plain 3446 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjI1OGM3ZjJjMWVjZWQw NGZkNGRlZDNiZDIwNWQxNzJiYzljYWQxZi4uYTE5MTljMDVhMDZmM2UyNGQ5MThkOTM5ZDlkMmVh NWMxZjQ2NTcwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTAxICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gUmVtb3ZlIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6cGFnZUl0ZW1TaXplQ2hhbmdl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MDgy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1 bmN0aW9uIHdhcyBjYXVzaW5nIGZsaWNrZXJpbmcsIGFuZCBhZnRlciB0ZXN0aW5nIGl0IHdhcyB2 ZXJpZmllZAorICAgICAgICB0aGF0IGl0IHdhcyBubyBsb25nZXIgbmVlZGVkIGVpdGhlci4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwOgor ICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OlF0Vmlld3BvcnRJ bnRlcmFjdGlvbkVuZ2luZSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRl cmFjdGlvbkVuZ2luZS5oOgorICAgICAgICAoUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lKToK KwogMjAxMi0wNS0zMSAgS2V1bnNvb24gTGVlICA8a2V1bnNvb24ubGVlQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdW1dLMl0gQWRkIFdLVVJMUmVxdWVzdEVmbCBhbmQgV0tVUkxSZXNwb25z ZUVmbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJ bnRlcmFjdGlvbkVuZ2luZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3 cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAppbmRleCA5YmMxM2UxOTlkYjUwNDQ2N2JlYjAxN2Ew N2MyMmRkMjQ4ZDkyM2FmLi4zMDljNGUyYWZiZDEwNGVhYzQ1ODkzMTg3YzNiMDRkMDQ3ZjUyMmE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVy YWN0aW9uRW5naW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3 cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcApAQCAtMTQ0LDggKzE0NCw2IEBAIFF0Vmlld3BvcnRJ bnRlcmFjdGlvbkVuZ2luZTo6UXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lKFFRdWlja1dlYlZp ZXcqIHZpZXdwb3J0CiB7CiAgICAgcmVzZXQoKTsKIAotICAgIGNvbm5lY3QobV9wYWdlSXRlbSwg U0lHTkFMKHdpZHRoQ2hhbmdlZCgpKSwgU0xPVChwYWdlSXRlbVNpemVDaGFuZ2VkKCkpLCBRdDo6 RGlyZWN0Q29ubmVjdGlvbik7Ci0gICAgY29ubmVjdChtX3BhZ2VJdGVtLCBTSUdOQUwoaGVpZ2h0 Q2hhbmdlZCgpKSwgU0xPVChwYWdlSXRlbVNpemVDaGFuZ2VkKCkpLCBRdDo6RGlyZWN0Q29ubmVj dGlvbik7CiAgICAgY29ubmVjdChtX3ZpZXdwb3J0SXRlbSwgU0lHTkFMKG1vdmVtZW50U3RhcnRl ZCgpKSwgU0xPVChmbGlja01vdmVTdGFydGVkKCkpLCBRdDo6RGlyZWN0Q29ubmVjdGlvbik7CiAg ICAgY29ubmVjdChtX3ZpZXdwb3J0SXRlbSwgU0lHTkFMKG1vdmVtZW50RW5kZWQoKSksIFNMT1Qo ZmxpY2tNb3ZlRW5kZWQoKSksIFF0OjpEaXJlY3RDb25uZWN0aW9uKTsKIApAQCAtNjc1LDIxICs2 NzMsNiBAQCB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6cGluY2hHZXN0dXJlQ2Fu Y2VsbGVkKCkKICAgICBtX3NjYWxlVXBkYXRlRGVmZXJyZXIuY2xlYXIoKTsKIH0KIAotLyoKLSAq IFRoaXMgaXMgY2FsbGVkIGZvciBhbGwgY2hhbmdlcyBvZiBpdGVtIHNjYWxlLCB3aWR0aCBvciBo ZWlnaHQuCi0gKiBUaGlzIGlzIGNhbGxlZCB3aGVuIGludGVyYWN0aW5nLCBpZS4gZHVyaW5nIGZv ciBpbnN0YW5jZSBwaW5jaC16b29taW5nLgotICoKLSAqIEZJWE1FOiBUaGlzIGlzIGN1cnJlbnRs eSBjYWxsZWQgdHdpY2UgaWYgeW91IGNvbmN1cnJlbnRseSBjaGFuZ2Ugd2lkdGggYW5kIGhlaWdo dC4KLSAqLwotdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnBhZ2VJdGVtU2l6ZUNo YW5nZWQoKQotewotICAgIGlmIChtX3N1c3BlbmRDb3VudCkKLSAgICAgICAgcmV0dXJuOwotCi0g ICAgVmlld3BvcnRVcGRhdGVEZWZlcnJlciBndWFyZCh0aGlzKTsKLSAgICBzZXRQYWdlSXRlbVJl Y3RWaXNpYmxlKG5lYXJlc3RWYWxpZEJvdW5kcygpKTsKLX0KLQogdm9pZCBRdFZpZXdwb3J0SW50 ZXJhY3Rpb25FbmdpbmU6OnNjYWxlQ29udGVudChjb25zdCBRUG9pbnRGJiBjZW50ZXJJbkNTU0Nv b3JkaW5hdGVzLCBxcmVhbCBjc3NTY2FsZSkKIHsKICAgICBRUG9pbnRGIG9sZFBpbmNoQ2VudGVy T25WaWV3cG9ydCA9IG1fdmlld3BvcnRJdGVtLT5tYXBGcm9tV2ViQ29udGVudChjZW50ZXJJbkNT U0Nvb3JkaW5hdGVzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9x dC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuaAppbmRleCBiNzU5NWU1Njk3NTIxM2VhOWE0 YTZlNTMyNGQ5OGE1ZTk4M2YxYWU5Li45ZGE5MTI2M2ZjODgwZmU3NmMyNGNhNDNjYjI5MmFiNGY0 NmM0MTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9y dEludGVyYWN0aW9uRW5naW5lLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0 Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5oCkBAIC0xMDIsOCArMTAyLDcgQEAgUV9TSUdOQUxT OgogICAgIHZvaWQgaW5mb3JtVmlzaWJsZUNvbnRlbnRDaGFuZ2UoY29uc3QgUVBvaW50RiYgdHJh amVjdG9yeSA9IFFQb2ludEYoKSk7CiAKIHByaXZhdGUgUV9TTE9UUzoKLSAgICAvLyBSZXNwb25k IHRvIGNoYW5nZXMgb2YgY29udGVudCB0aGF0IGFyZSBub3QgZHJpdmVuIGJ5IHVzLCBsaWtlIHRo ZSBwYWdlIHJlc2l6aW5nIGl0c2VsZi4KLSAgICB2b2lkIHBhZ2VJdGVtU2l6ZUNoYW5nZWQoKTsK KyAgICAvLyBSZXNwb25kIHRvIGNoYW5nZXMgb2YgcG9zaXRpb24gdGhhdCBhcmUgbm90IGRyaXZl biBieSB1cy4KICAgICB2b2lkIHBhZ2VJdGVtUG9zaXRpb25DaGFuZ2VkKCk7CiAKICAgICB2b2lk IHNjYWxlQW5pbWF0aW9uU3RhdGVDaGFuZ2VkKFFBYnN0cmFjdEFuaW1hdGlvbjo6U3RhdGUsIFFB YnN0cmFjdEFuaW1hdGlvbjo6U3RhdGUpOwo= 145285 2012-06-01 06:11:41 -0700 2012-06-01 08:43:20 -0700 Patch bug-88082-20120601151150.patch text/plain 3521 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTY2Njc1Y2EyOTRmMDlh NWY4MTkwY2QwMDEwMzVmNzExZjFiNTNjNS4uYmQwYzA4OTkxNDE5MmJkMmVlMzgxYzg4NDM5NzJj OWE2YWI2MmYyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTAxICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gUmVtb3ZlIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6cGFnZUl0ZW1TaXplQ2hhbmdl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MDgy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAg ICAgICAgVGhlIGZ1bmN0aW9uIHdhcyBjYXVzaW5nIGZsaWNrZXJpbmcsIGFuZCBhZnRlciB0ZXN0 aW5nIGl0IHdhcyB2ZXJpZmllZAorICAgICAgICB0aGF0IGl0IHdhcyBubyBsb25nZXIgbmVlZGVk IGVpdGhlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25F bmdpbmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6 OlF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0 Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5oOgorICAgICAgICAoUXRWaWV3cG9ydEludGVyYWN0 aW9uRW5naW5lKToKKwogMjAxMi0wNi0wMSAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxr ZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBNb3ZlIHN1c3BlbnNpb24gdG8gUXRW aWV3cG9ydEludGVyYWN0aW9uRW5naW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCmluZGV4IDkxNzYy MGNjNTcwMmNmZjRjYjc4NTFiYjExOTljOTJkZTIxZGNmZjEuLjBjYzMzZTA4ZWVkMTVhYTU0Y2M2 M2Q0MzZlZDBiNDgxNTgyN2JlOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCkBAIC0xNjMsOCAr MTYzLDYgQEAgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpRdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmUoV2ViS2l0OjpXZWJQYWdlUHJveHkqIHAKICAgICAsIG1fbGFzdENvbW1pdHRlZFNj YWxlKC0xKQogICAgICwgbV96b29tT3V0U2NhbGUoMC4wKQogewotICAgIGNvbm5lY3QobV9wYWdl SXRlbSwgU0lHTkFMKHdpZHRoQ2hhbmdlZCgpKSwgU0xPVChwYWdlSXRlbVNpemVDaGFuZ2VkKCkp LCBRdDo6RGlyZWN0Q29ubmVjdGlvbik7Ci0gICAgY29ubmVjdChtX3BhZ2VJdGVtLCBTSUdOQUwo aGVpZ2h0Q2hhbmdlZCgpKSwgU0xPVChwYWdlSXRlbVNpemVDaGFuZ2VkKCkpLCBRdDo6RGlyZWN0 Q29ubmVjdGlvbik7CiAgICAgY29ubmVjdChtX3ZpZXdwb3J0SXRlbSwgU0lHTkFMKG1vdmVtZW50 U3RhcnRlZCgpKSwgU0xPVChmbGlja01vdmVTdGFydGVkKCkpLCBRdDo6RGlyZWN0Q29ubmVjdGlv bik7CiAgICAgY29ubmVjdChtX3ZpZXdwb3J0SXRlbSwgU0lHTkFMKG1vdmVtZW50RW5kZWQoKSks IFNMT1QoZmxpY2tNb3ZlRW5kZWQoKSksIFF0OjpEaXJlY3RDb25uZWN0aW9uKTsKIApAQCAtNzM0 LDIxICs3MzIsNiBAQCB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6dmlld3BvcnRJ dGVtU2l6ZUNoYW5nZWQoKQogICAgIGluZm9ybVZpc2libGVDb250ZW50Q2hhbmdlKFFQb2ludEYo KSk7CiB9CiAKLS8qCi0gKiBUaGlzIGlzIGNhbGxlZCBmb3IgYWxsIGNoYW5nZXMgb2YgaXRlbSBz Y2FsZSwgd2lkdGggb3IgaGVpZ2h0LgotICogVGhpcyBpcyBjYWxsZWQgd2hlbiBpbnRlcmFjdGlu ZywgaWUuIGR1cmluZyBmb3IgaW5zdGFuY2UgcGluY2gtem9vbWluZy4KLSAqCi0gKiBGSVhNRTog VGhpcyBpcyBjdXJyZW50bHkgY2FsbGVkIHR3aWNlIGlmIHlvdSBjb25jdXJyZW50bHkgY2hhbmdl IHdpZHRoIGFuZCBoZWlnaHQuCi0gKi8KLXZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5l OjpwYWdlSXRlbVNpemVDaGFuZ2VkKCkKLXsKLSAgICBpZiAobV9zdXNwZW5kQ291bnQpCi0gICAg ICAgIHJldHVybjsKLQotICAgIFZpZXdwb3J0VXBkYXRlRGVmZXJyZXIgZ3VhcmQodGhpcyk7Ci0g ICAgc2V0UGFnZUl0ZW1SZWN0VmlzaWJsZShuZWFyZXN0VmFsaWRCb3VuZHMoKSk7Ci19Ci0KIHZv aWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpzY2FsZUNvbnRlbnQoY29uc3QgUVBvaW50 RiYgY2VudGVySW5DU1NDb29yZGluYXRlcywgcXJlYWwgY3NzU2NhbGUpCiB7CiAgICAgUVBvaW50 RiBvbGRQaW5jaENlbnRlck9uVmlld3BvcnQgPSBtX3ZpZXdwb3J0SXRlbS0+bWFwRnJvbVdlYkNv bnRlbnQoY2VudGVySW5DU1NDb29yZGluYXRlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmggYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmgKaW5kZXggY2Zh NGYzZWE1MTZmZDlhZDg4YWY4M2MzNDExZWVmYWNiMzY3Yjg2Ni4uYWZmNzk3YWE0NzFjNjZkZjVm NzY3YTdhZmYyMzQ2MTViNDViODFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuaApAQCAtODIsOCArODIs NyBAQCBwdWJsaWM6CiAgICAgdm9pZCBwYWdlQ29udGVudHNTaXplQ2hhbmdlZChjb25zdCBRU2l6 ZSYgbmV3U2l6ZSwgY29uc3QgUVNpemUmIHZpZXdwb3J0U2l6ZSk7CiAKIHByaXZhdGUgUV9TTE9U UzoKLSAgICAvLyBSZXNwb25kIHRvIGNoYW5nZXMgb2YgY29udGVudCB0aGF0IGFyZSBub3QgZHJp dmVuIGJ5IHVzLCBsaWtlIHRoZSBwYWdlIHJlc2l6aW5nIGl0c2VsZi4KLSAgICB2b2lkIHBhZ2VJ dGVtU2l6ZUNoYW5nZWQoKTsKKyAgICAvLyBSZXNwb25kIHRvIGNoYW5nZXMgb2YgcG9zaXRpb24g dGhhdCBhcmUgbm90IGRyaXZlbiBieSB1cy4KICAgICB2b2lkIHBhZ2VJdGVtUG9zaXRpb25DaGFu Z2VkKCk7CiAKICAgICB2b2lkIHNjYWxlQW5pbWF0aW9uU3RhdGVDaGFuZ2VkKFFBYnN0cmFjdEFu aW1hdGlvbjo6U3RhdGUsIFFBYnN0cmFjdEFuaW1hdGlvbjo6U3RhdGUpOwo=