88072 2012-06-01 03:30:13 -0700 [EFL] ewk_intent_data_get() is not needed and can be removed 2012-06-01 08:56:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86868 1 cdumez cdumez abarth gbillock gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 639156 0 cdumez 2012-06-01 03:30:13 -0700 There is no need for Ewk_Intent to publicly expose WebCore::Intent::data(). As a consequence, the ewk_intent_data_get() method can be removed. 639164 1 145260 cdumez 2012-06-01 03:41:45 -0700 Created attachment 145260 Patch 639372 2 145260 abarth 2012-06-01 08:36:38 -0700 Comment on attachment 145260 Patch Ok. 639392 3 145260 webkit.review.bot 2012-06-01 08:56:39 -0700 Comment on attachment 145260 Patch Clearing flags on attachment: 145260 Committed r119238: <http://trac.webkit.org/changeset/119238> 639393 4 webkit.review.bot 2012-06-01 08:56:44 -0700 All reviewed patches have been landed. Closing bug. 145260 2012-06-01 03:41:45 -0700 2012-06-01 08:56:39 -0700 Patch 88072_intent_data_removal.patch text/plain 4179 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBlYzRmMzE1Li4yMTU4ZmUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDYtMDEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBld2tfaW50ZW50X2RhdGFfZ2V0KCkg aXMgbm90IG5lZWRlZCBhbmQgY2FuIGJlIHJlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGV3a19pbnRlbnRfZGF0YV9nZXQoKSBtZXRo b2QgZnJvbSBFd2tfSW50ZW50LiBJbnRlbnQgZGF0YSBpcworICAgICAgICBzZXJpYWxpemVkIGFu ZCBkb2VzIG5vdCBuZWVkIHRvIGJlIHB1YmxpY2x5IGV4cG9zZWQuIFRoZSBicm93c2VyIG9ubHkK KyAgICAgICAgbmVlZHMgYWN0aW9uIGFuZCB0eXBlIHRvIG1hdGNoIHdpdGggc2VydmljZXMuCisK KyAgICAgICAgKiBld2svZXdrX2ludGVudC5jcHA6CisgICAgICAgIChfRXdrX0ludGVudCk6Cisg ICAgICAgIChld2tfaW50ZW50X2FjdGlvbl9nZXQpOgorICAgICAgICAoZXdrX2ludGVudF90eXBl X2dldCk6CisgICAgICAgIChld2tfaW50ZW50X3NlcnZpY2VfZ2V0KToKKyAgICAgICAgKGV3a19p bnRlbnRfZnJlZSk6CisgICAgICAgICogZXdrL2V3a19pbnRlbnQuaDoKKwogMjAxMi0wNS0zMSAg QWxleGFuZGVyIFNoYWxhbW92ICA8YWxleGFuZGVyLnNoYWxhbW92QGludGVsLmNvbT4KIAogICAg ICAgICBbRUZMXSA8aW5wdXQgdHlwZT0ibnVtYmVyIj4gaXMgbm90IGEgc3BpbmJ1dHRvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19pbnRlbnQuY3BwIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a19pbnRlbnQuY3BwCmluZGV4IGUxZGEwN2YuLmVmNzkxNDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfaW50ZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX2ludGVudC5jcHAKQEAgLTIyLDcgKzIyLDYgQEAKIAogI2luY2x1 ZGUgIkludGVudC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCi0jaW5jbHVkZSAiU2Vy aWFsaXplZFNjcmlwdFZhbHVlLmgiCiAjaW5jbHVkZSAiZXdrX2ludGVudF9wcml2YXRlLmgiCiAj aW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlIDxLVVJMLmg+CkBAIC00MCw3ICszOSw2 IEBAIHN0cnVjdCBfRXdrX0ludGVudCB7CiAjZW5kaWYKICAgICBjb25zdCBjaGFyKiBhY3Rpb247 CiAgICAgY29uc3QgY2hhciogdHlwZTsKLSAgICBjb25zdCBjaGFyKiBkYXRhOwogICAgIGNvbnN0 IGNoYXIqIHNlcnZpY2U7CiB9OwogCkBAIC02MCw3ICs1OCw3IEBAIGNvbnN0IGNoYXIqIGV3a19p bnRlbnRfYWN0aW9uX2dldChjb25zdCBFd2tfSW50ZW50KiBpbnRlbnQpCiAjaWYgRU5BQkxFKFdF Ql9JTlRFTlRTKQogICAgIEVXS19JTlRFTlRfQ09SRV9HRVRfT1JfUkVUVVJOKGludGVudCwgY29y ZSwgMCk7CiAKLSAgICAvLyBoaWRlIHRoZSBmb2xsb3dpbmcgb3B0aW16YXRpb24gZnJvbSBvdXRz aWRlCisgICAgLy8gaGlkZSB0aGUgZm9sbG93aW5nIG9wdGltaXphdGlvbiBmcm9tIG91dHNpZGUK ICAgICBFd2tfSW50ZW50KiBld2tJbnRlbnQgPSBjb25zdF9jYXN0PEV3a19JbnRlbnQqPihpbnRl bnQpOwogICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFjZSgmZXdrSW50ZW50LT5hY3Rpb24sCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvcmUtPmFjdGlvbigpLnV0ZjgoKS5kYXRhKCkp OwpAQCAtNzUsNyArNzMsNyBAQCBjb25zdCBjaGFyKiBld2tfaW50ZW50X3R5cGVfZ2V0KGNvbnN0 IEV3a19JbnRlbnQqIGludGVudCkKICNpZiBFTkFCTEUoV0VCX0lOVEVOVFMpCiAgICAgRVdLX0lO VEVOVF9DT1JFX0dFVF9PUl9SRVRVUk4oaW50ZW50LCBjb3JlLCAwKTsKIAotICAgIC8vIGhpZGUg dGhlIGZvbGxvd2luZyBvcHRpbXphdGlvbiBmcm9tIG91dHNpZGUKKyAgICAvLyBoaWRlIHRoZSBm b2xsb3dpbmcgb3B0aW1pemF0aW9uIGZyb20gb3V0c2lkZQogICAgIEV3a19JbnRlbnQqIGV3a0lu dGVudCA9IGNvbnN0X2Nhc3Q8RXdrX0ludGVudCo+KGludGVudCk7CiAgICAgZWluYV9zdHJpbmdz aGFyZV9yZXBsYWNlKCZld2tJbnRlbnQtPnR5cGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvcmUtPnR5cGUoKS51dGY4KCkuZGF0YSgpKTsKQEAgLTg1LDIyICs4MywxMiBAQCBjb25z dCBjaGFyKiBld2tfaW50ZW50X3R5cGVfZ2V0KGNvbnN0IEV3a19JbnRlbnQqIGludGVudCkKICNl bmRpZgogfQogCi1jb25zdCBjaGFyKiBld2tfaW50ZW50X2RhdGFfZ2V0KGNvbnN0IEV3a19JbnRl bnQqIGludGVudCkKLXsKLSNpZiBFTkFCTEUoV0VCX0lOVEVOVFMpCi0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgICByZXR1cm4gMDsKLSNlbHNlCi0gICAgcmV0dXJuIDA7Ci0jZW5kaWYKLX0KLQog Y29uc3QgY2hhciogZXdrX2ludGVudF9zZXJ2aWNlX2dldChjb25zdCBFd2tfSW50ZW50KiBpbnRl bnQpCiB7CiAjaWYgRU5BQkxFKFdFQl9JTlRFTlRTKQogICAgIEVXS19JTlRFTlRfQ09SRV9HRVRf T1JfUkVUVVJOKGludGVudCwgY29yZSwgMCk7CiAKLSAgICAvLyBoaWRlIHRoZSBmb2xsb3dpbmcg b3B0aW16YXRpb24gZnJvbSBvdXRzaWRlCisgICAgLy8gaGlkZSB0aGUgZm9sbG93aW5nIG9wdGlt aXphdGlvbiBmcm9tIG91dHNpZGUKICAgICBFd2tfSW50ZW50KiBld2tJbnRlbnQgPSBjb25zdF9j YXN0PEV3a19JbnRlbnQqPihpbnRlbnQpOwogICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFjZSgm ZXdrSW50ZW50LT5zZXJ2aWNlLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb3JlLT5z ZXJ2aWNlKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CkBAIC0xODQsNyArMTcyLDYgQEAgdm9p ZCBld2tfaW50ZW50X2ZyZWUoRXdrX0ludGVudCogaW50ZW50KQogCiAgICAgZWluYV9zdHJpbmdz aGFyZV9kZWwoaW50ZW50LT5hY3Rpb24pOwogICAgIGVpbmFfc3RyaW5nc2hhcmVfZGVsKGludGVu dC0+dHlwZSk7Ci0gICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoaW50ZW50LT5kYXRhKTsKICAgICBl aW5hX3N0cmluZ3NoYXJlX2RlbChpbnRlbnQtPnNlcnZpY2UpOwogICAgIGRlbGV0ZSBpbnRlbnQ7 CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ludGVudC5oIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19pbnRlbnQuaAppbmRleCBmNGRjMGE4Li4xNDNkZWFhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ludGVudC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfaW50ZW50LmgKQEAgLTU2LDE5ICs1Niw2IEBAIEVBUEkgY29u c3QgY2hhciAqZXdrX2ludGVudF9hY3Rpb25fZ2V0KGNvbnN0IEV3a19JbnRlbnQgKmludGVudCk7 CiBFQVBJIGNvbnN0IGNoYXIgKmV3a19pbnRlbnRfdHlwZV9nZXQoY29uc3QgRXdrX0ludGVudCAq aW50ZW50KTsKIAogLyoqCi0gKiBRdWVyeSBkYXRhIGZvciB0aGlzIGludGVudC4KLSAqCi0gKiBA cGFyYW0gaW50ZW50IGludGVudCBpdGVtIHRvIHF1ZXJ5LgotICoKLSAqIEByZXR1cm4gdGhlIGRh dGEgcG9pbnRlciwgdGhhdCBtYXkgYmUgQGMgTlVMTC4gVGhpcyBwb2ludGVyIGlzCi0gKiAgICAg ICAgIGd1YXJhbnRlZWQgdG8gYmUgZWluYV9zdHJpbmdzaGFyZSwgc28gd2hlbmV2ZXIgcG9zc2li bGUKLSAqICAgICAgICAgc2F2ZSB5b3Vyc2VsZiBzb21lIGNwdSBjeWNsZXMgYW5kIHVzZQotICog ICAgICAgICBlaW5hX3N0cmluZ3NoYXJlX3JlZigpIGluc3RlYWQgb2YgZWluYV9zdHJpbmdzaGFy ZV9hZGQoKSBvcgotICogICAgICAgICBzdHJkdXAoKS4KLSAqLwotRUFQSSBjb25zdCBjaGFyICpl d2tfaW50ZW50X2RhdGFfZ2V0KGNvbnN0IEV3a19JbnRlbnQgKmludGVudCk7Ci0KLS8qKgogICog UXVlcnkgc2VydmljZSBmb3IgdGhpcyBpbnRlbnQuCiAgKgogICogQHBhcmFtIGludGVudCBpbnRl bnQgaXRlbSB0byBxdWVyeS4K