88065 2012-06-01 02:30:45 -0700 [BlackBerry] IndexedDB file should be sand-boxed to the application data directory. 2012-06-06 00:01:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei jrogers rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 639122 0 charles.wei 2012-06-01 02:30:45 -0700 1. The IndexedDB now is only enabled for in-memory levelDB, we should make it file system persistent. 2. The directory should be sandboxes at the application data directory, with each security origin has its own sand-boxed directory. 639125 1 145247 charles.wei 2012-06-01 02:36:15 -0700 Created attachment 145247 Patch 639305 2 145247 rwlbuis 2012-06-01 07:08:35 -0700 Comment on attachment 145247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review > Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102 > + m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str())); Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific? 639360 3 145247 charles.wei 2012-06-01 08:22:20 -0700 Comment on attachment 145247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review >> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102 >> + m_backend->open(name, request.get(), context->securityOrigin(), frame, String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str())); > > Is it possible to put get dataDir in a port specific section? So if dataDir is empty we call BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there nothing port specific? Yes, we should make that at a port specific section. I'll try with another patch. Thanks. 642071 4 145909 charles.wei 2012-06-05 18:13:47 -0700 Created attachment 145909 Patch 642234 5 145909 webkit.review.bot 2012-06-06 00:01:34 -0700 Comment on attachment 145909 Patch Clearing flags on attachment: 145909 Committed r119566: <http://trac.webkit.org/changeset/119566> 642235 6 webkit.review.bot 2012-06-06 00:01:42 -0700 All reviewed patches have been landed. Closing bug. 145247 2012-06-01 02:36:15 -0700 2012-06-05 18:13:34 -0700 Patch bug-88065-20120601174522.patch text/plain 1952 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q4NGJlNzkwYjVjYmIx NzNlMzA3MTk5ZTA2MDYwOWI4NzgzMzI1NC4uNzY5NWNjMjgyZTE0NzU0MzlkYTA1NzJkMzQ0NTc5 NGQ5ZTFmNzBlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTAxICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gSW5kZXhlZERCIGZpbGUgc2hvdWxkIGJlIHNhbmQtYm94ZWQgdG8gdGhlIGFwcGxp Y2F0aW9uIGRhdGEgZGlyZWN0b3J5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODgwNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIEp1c3QgbWFrZSBJbmRleGVkREIgd29ya2luZyBm b3IgSlNDIGJpbmRpbmcuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkZhY3Rvcnk6Om9wZW4pOgorCiAyMDEyLTA1LTMx ICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhd IEV4cGFuZG8gcHJvcGVydGllcyBvbiBhdHRyaWJ1dGUgbm9kZXMgZGlzYXBwZWFyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJGYWN0b3J5LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkZhY3RvcnkuY3BwCmluZGV4IDQyYjRm ZWU5YmE4YjI3NjdiZWYyN2U1MTk1YmNmODNkZDdlMjRjMjguLjg5YTIxNGJkN2JjYTRiYjU4NTYz ZmRhNmVlNGRjMmYzYjM0MDNhZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQkZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k ZXhlZGRiL0lEQkZhY3RvcnkuY3BwCkBAIC01MCw2ICs1MCwxMCBAQAogI2luY2x1ZGUgIldvcmtl ckxvYWRlclByb3h5LmgiCiAjaW5jbHVkZSAiV29ya2VyVGhyZWFkLmgiCiAKKyNpZiBQTEFURk9S TShCTEFDS0JFUlJZKQorI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudC5oPgorI2Vu ZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogSURCRmFjdG9yeTo6SURCRmFjdG9yeShJREJG YWN0b3J5QmFja2VuZEludGVyZmFjZSogZmFjdG9yeSkKQEAgLTk0LDcgKzk4LDExIEBAIFBhc3NS ZWZQdHI8SURCUmVxdWVzdD4gSURCRmFjdG9yeTo6b3BlbihTY3JpcHRFeGVjdXRpb25Db250ZXh0 KiBjb250ZXh0LCBjb25zdCBTCiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgRnJhbWUq IGZyYW1lID0gZG9jdW1lbnQtPmZyYW1lKCk7CiAgICAgICAgIFJlZlB0cjxJREJSZXF1ZXN0PiBy ZXF1ZXN0ID0gSURCUmVxdWVzdDo6Y3JlYXRlKGNvbnRleHQsIElEQkFueTo6Y3JlYXRlKHRoaXMp LCAwKTsKKyNpZiBQTEFURk9STShCTEFDS0JFUlJZKQorICAgICAgICBtX2JhY2tlbmQtPm9wZW4o bmFtZSwgcmVxdWVzdC5nZXQoKSwgY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKSwgZnJhbWUsIFN0 cmluZyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+Z2V0QXBwbGljYXRpb25E YXRhRGlyZWN0b3J5KCkuY19zdHIoKSkpOworI2Vsc2UKICAgICAgICAgbV9iYWNrZW5kLT5vcGVu KG5hbWUsIHJlcXVlc3QuZ2V0KCksIGNvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCksIGZyYW1lLCBT dHJpbmcoKSk7CisjZW5kaWYKICAgICAgICAgcmV0dXJuIHJlcXVlc3Q7CiAgICAgfQogI2lmIEVO QUJMRShXT1JLRVJTKQo= 145909 2012-06-05 18:13:47 -0700 2012-06-06 00:01:33 -0700 Patch bug-88065-20120606092312.patch text/plain 3867 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3YmIwNGY4YzE1ZDYzNTA2MDVkM2U2NmVhNWZjYmRhNzBjMWIwZGVjLi4xMWU2ZDQzMjk2 Yjg5NDBmNzBhN2MzOTRjZmZmN2RmYmVlMzliNDY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNi0wNSAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEluZGV4ZWRE QiBmaWxlIHNob3VsZCBiZSBzYW5kLWJveGVkIHRvIHRoZSBhcHBsaWNhdGlvbiBkYXRhIGRpcmVj dG9yeS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4 MDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBB cGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2 YXRlOjpkaWRDaGFuZ2VTZXR0aW5ncyk6CisgICAgICAgICogQXBpL1dlYlNldHRpbmdzLmNwcDoK KyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlNldHRp bmdzOjppbmRleGVkRGF0YUJhc2VQYXRoKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 V2ViU2V0dGluZ3M6OnNldEluZGV4ZWREYXRhQmFzZVBhdGgpOgorICAgICAgICAqIEFwaS9XZWJT ZXR0aW5ncy5oOgorCiAyMDEyLTA2LTA0ICBBbmRyZXcgTG8gIDxhbmxvQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIFNwbGl0IEFuaW1hdGlvbkZyYW1lUmF0ZUNvbnRyb2xsZXIgaW50 byBpdHMgb3duIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmlu ZGV4IDc0OWI1MmM3NDY4ZjllZDJhM2E4NzIyMWRiNmQ4ZmVmZjliMDIwYTkuLjA5YjhiYmQwMmEw MTI0NWIxYzYzNzAzY2JiZDBjODc1YzAwODg2NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcApAQCAtNjIwMyw2ICs2MjAzLDExIEBAIHZvaWQgV2ViUGFnZVByaXZh dGU6OmRpZENoYW5nZVNldHRpbmdzKFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5ncykKICAgICBjb3Jl U2V0dGluZ3MtPnNldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQod2ViU2V0dGluZ3MtPmlzRnJhbWVG bGF0dGVuaW5nRW5hYmxlZCgpKTsKICNlbmRpZgogCisjaWYgRU5BQkxFKElOREVYRURfREFUQUJB U0UpCisgICAgbV9wYWdlLT5ncm91cCgpLmdyb3VwU2V0dGluZ3MoKS0+c2V0SW5kZXhlZERCRGF0 YWJhc2VQYXRoKHdlYlNldHRpbmdzLT5pbmRleGVkRGF0YUJhc2VQYXRoKCkpOworI2VuZGlmCisK KwogI2lmIEVOQUJMRShXRUJfU09DS0VUUykKICAgICBXZWJTb2NrZXQ6OnNldElzQXZhaWxhYmxl KHdlYlNldHRpbmdzLT5hcmVXZWJTb2NrZXRzRW5hYmxlZCgpKTsKICNlbmRpZgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJTZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNldHRpbmdzLmNwcAppbmRleCAzOTZlOWE2NjhkZjdk ZGJkY2Y1MTdlOTA5MmIyOWM2YzAxOWQ0MmJkLi5hMDljMGUyYjk5ODY5YmJkNTQzZTAzZDkwOTI5 MjNiZTdhYjUxZDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNldHRp bmdzLmNwcApAQCAtNjYsNiArNjYsNyBAQCBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgV2Vi S2l0Rmlyc3RTY2hlZHVsZWRMYXlvdXREZWxheSwgKCJXZWJLaXRGaXJzdFNjaGVkdQogREVGSU5F X1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdEZpeGVkRm9udEZhbWlseSwgKCJXZWJLaXRGaXhl ZEZvbnRGYW1pbHkiKSk7CiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgV2ViS2l0RnJhbWVG bGF0dGVuaW5nRW5hYmxlZCwgKCJXZWJLaXRGcmFtZUZsYXR0ZW5pbmdFbmFibGVkIikpOwogREVG SU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdEdlb2xvY2F0aW9uRW5hYmxlZCwgKCJXZWJL aXRHZW9sb2NhdGlvbkVuYWJsZWQiKSk7CitERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgV2Vi S2l0SW5kZXhlZERhdGFCYXNlUGF0aCwgKCJXZWJLaXRJbmRleGVkRGF0YUJhc2VQYXRoIikpOwog REVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdEphdmFTY3JpcHRDYW5PcGVuV2luZG93 c0F1dG9tYXRpY2FsbHlFbmFibGVkLCAoIldlYktpdEphdmFTY3JpcHRDYW5PcGVuV2luZG93c0F1 dG9tYXRpY2FsbHlFbmFibGVkIikpOwogREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktp dEphdmFTY3JpcHRFbmFibGVkLCAoIldlYktpdEphdmFTY3JpcHRFbmFibGVkIikpOwogREVGSU5F X1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdExvYWRzSW1hZ2VzQXV0b21hdGljYWxseSwgKCJX ZWJLaXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkiKSk7CkBAIC02MDEsNiArNjAyLDE2IEBAIHZv aWQgV2ViU2V0dGluZ3M6OnNldExvY2FsU3RvcmFnZVBhdGgoY29uc3QgV2ViU3RyaW5nJiBwYXRo KQogICAgIG1fcHJpdmF0ZS0+c2V0U3RyaW5nKFdlYktpdExvY2FsU3RvcmFnZVBhdGgsIHBhdGgp OwogfQogCitXZWJTdHJpbmcgV2ViU2V0dGluZ3M6OmluZGV4ZWREYXRhQmFzZVBhdGgoKSBjb25z dAoreworICAgIHJldHVybiBtX3ByaXZhdGUtPmdldFN0cmluZyhXZWJLaXRJbmRleGVkRGF0YUJh c2VQYXRoKTsKK30KKwordm9pZCBXZWJTZXR0aW5nczo6c2V0SW5kZXhlZERhdGFCYXNlUGF0aChj b25zdCBXZWJTdHJpbmcmIHBhdGgpCit7CisgICAgbV9wcml2YXRlLT5zZXRTdHJpbmcoV2ViS2l0 SW5kZXhlZERhdGFCYXNlUGF0aCwgcGF0aCk7Cit9CisKIFdlYlN0cmluZyBXZWJTZXR0aW5nczo6 ZGF0YWJhc2VQYXRoKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9wcml2YXRlLT5nZXRTdHJpbmco V2ViS2l0RGF0YWJhc2VQYXRoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViU2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0 dGluZ3MuaAppbmRleCA0YzE4NGI1YzM5MDMwZWU4MTRjZjViNzlkMmJhMmVkY2RlNWU0NTMxLi40 MDFiZDA3ZjI5OWZlNmM1ZTk5ZDg0ZjFhZDg4MDc5ZGIwYmM1OTRlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJTZXR0aW5ncy5oCkBAIC0xNzMsNiArMTczLDkgQEAgcHVibGlj OgogICAgIFdlYlN0cmluZyBsb2NhbFN0b3JhZ2VQYXRoKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRM b2NhbFN0b3JhZ2VQYXRoKGNvbnN0IFdlYlN0cmluZyYpOwogCisgICAgV2ViU3RyaW5nIGluZGV4 ZWREYXRhQmFzZVBhdGgoKSBjb25zdDsKKyAgICB2b2lkIHNldEluZGV4ZWREYXRhQmFzZVBhdGgo Y29uc3QgV2ViU3RyaW5nJik7CisKICAgICBXZWJTdHJpbmcgZGF0YWJhc2VQYXRoKCkgY29uc3Q7 CiAgICAgdm9pZCBzZXREYXRhYmFzZVBhdGgoY29uc3QgV2ViU3RyaW5nJik7CiAK