88060 2012-06-01 01:09:17 -0700 [Gtk] Assertions in gtk_widget_draw when acquiring pixel output 2012-06-07 06:21:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan mrobinson pnormand webkit.review.bot oldest_to_newest 639072 0 zan 2012-06-01 01:09:17 -0700 Assertions are occurring in createBitmapContextFromWebView in PixelDumpSupportGtk.cpp when calling gtk_widget_draw: gtk_widget_draw: assertion `!widget->priv->alloc_needed' failed To avoid this gtk_widget_size_allocate should be called before gtk_widget_draw to allocate appropriate size of the container whose pixel content we're acquiring. 639095 1 145240 zan 2012-06-01 01:30:22 -0700 Created attachment 145240 Patch 639426 2 145240 mrobinson 2012-06-01 09:14:50 -0700 Comment on attachment 145240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145240&action=review > Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:64 > + GtkAllocation allocation; > + allocation.x = allocation.y = 0; > + allocation.width = width; > + allocation.height = height; > + gtk_widget_size_allocate(viewContainer, &allocation); > + If the allocation is wrong, won't the render tree output be wrong as well? 642683 3 zan 2012-06-06 12:18:50 -0700 Sigh ... this doesn't occur anymore, and I have no idea why. Resolving as invalid for now. 643283 4 zan 2012-06-07 00:19:18 -0700 (In reply to comment #3) > Sigh ... this doesn't occur anymore, and I have no idea why. Resolving as invalid for now. Spotted it again, got a proper fix as well. 643288 5 146219 zan 2012-06-07 00:21:17 -0700 Created attachment 146219 Patch 643485 6 146219 webkit.review.bot 2012-06-07 06:21:26 -0700 Comment on attachment 146219 Patch Clearing flags on attachment: 146219 Committed r119715: <http://trac.webkit.org/changeset/119715> 643486 7 webkit.review.bot 2012-06-07 06:21:31 -0700 All reviewed patches have been landed. Closing bug. 145240 2012-06-01 01:30:22 -0700 2012-06-06 12:19:07 -0700 Patch bug-88060-20120601103020.patch text/plain 1594 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWQ5Yjg1ZmM4MzRhNGNmNDg5NDVjZjgxYTY1ODYyNmYw M2M3Y2YyNS4uNWNlY2Y4NmRiN2Q2NzQ1ODhmMWMzMjlkZWViYzNkMTFjNjQzOWUxZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA2LTAxICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0d0a10gQXNzZXJ0aW9ucyBpbiBndGtfd2lkZ2V0X2RyYXcgd2hlbiBhY3F1aXJp bmcgcGl4ZWwgb3V0cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04ODA2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFsbG9jYXRlIHRoZSBzaXplIG9mIHRoZSBjb250YWluZXIgd2lkZ2V0IG9uY2UgbW9y ZSBiZWZvcmUgZHJhd2luZworICAgICAgICBpdCBpbnRvIGEgQ2Fpcm8gY29udGV4dCBhcyB0aGUg ZHJhd2luZyBkZXBlbmRzIG9uIHRoZSBhbGxvY2F0aW9uCisgICAgICAgIGJlaW5nIHByb3Blcmx5 IGVzdGFibGlzaGVkLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL1BpeGVsRHVtcFN1 cHBvcnRHdGsuY3BwOgorICAgICAgICAoY3JlYXRlQml0bWFwQ29udGV4dEZyb21XZWJWaWV3KToK KwogMjAxMi0wNS0zMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV0syXSB3aW5kb3cuaW50ZXJuYWxzIHNldHRpbmdzIGFyZSBub3QgcmVzZXQgYmV0d2Vl biB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1BpeGVsRHVtcFN1 cHBvcnRHdGsuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1BpeGVsRHVtcFN1cHBvcnRH dGsuY3BwCmluZGV4IDNlYWJmZDk2Y2JmNWJiZTMwZTgwMGMzODg5NWM4ZjBkMGJjZmVlNjEuLjAw ODZiY2E4ODY5YjhkZTdhN2IwNmFlZDVmMTVjNzU1NGI2ZWM1NTcgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNwcAorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9ydEd0ay5jcHAKQEAgLTU2LDYgKzU2LDEy IEBAIFBhc3NSZWZQdHI8Qml0bWFwQ29udGV4dD4gY3JlYXRlQml0bWFwQ29udGV4dEZyb21XZWJW aWV3KGJvb2wsIGJvb2wsIGJvb2wsIGJvb2wKICAgICBjYWlyb19wYWludChjb250ZXh0KTsKICAg ICBnX29iamVjdF91bnJlZihwaXhtYXApOwogI2Vsc2UKKyAgICBHdGtBbGxvY2F0aW9uIGFsbG9j YXRpb247CisgICAgYWxsb2NhdGlvbi54ID0gYWxsb2NhdGlvbi55ID0gMDsKKyAgICBhbGxvY2F0 aW9uLndpZHRoID0gd2lkdGg7CisgICAgYWxsb2NhdGlvbi5oZWlnaHQgPSBoZWlnaHQ7CisgICAg Z3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKHZpZXdDb250YWluZXIsICZhbGxvY2F0aW9uKTsKKwog ICAgIGd0a193aWRnZXRfZHJhdyh2aWV3Q29udGFpbmVyLCBjb250ZXh0KTsKICNlbmRpZgogCg== 146219 2012-06-07 00:21:17 -0700 2012-06-07 06:21:26 -0700 Patch bug-88060-20120607092116.patch text/plain 1598 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NjAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWQ5MjQxZDA1ZWY3OGIzMzUwNzE4YWEwNmE1ZDAxMDRj YjI1MGE0Ny4uMjM4MGJlMTA5YTdhMmJiYmU2NDRmMTEyY2M1ZWI0MjU1YTBmODIyYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA2LTA3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0d0a10gQXNzZXJ0aW9ucyBpbiBndGtfd2lkZ2V0X2RyYXcgd2hlbiBhY3F1aXJp bmcgcGl4ZWwgb3V0cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04ODA2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFNwaW4gdGhlIG1haW4gbG9vcCBiZWZvcmUgYWNxdWlyaW5nIHRoZSBwaXhlbCBjb250 ZW50LiBUaGlzIGVuc3VyZXMgdGhpbmdzCisgICAgICAgIGxpa2UgbGF0ZSBzaXplIGFsbG9jYXRp b25zIGFyZSBmaW5pc2hlZCBiZWZvcmUgY2FsbGluZyBndGtfd2lkZ2V0X2RyYXcsCisgICAgICAg IGF2b2lkaW5nIGFzc2VydGlvbnMgYW5kIHN1YnNlcXVlbnQgZW1wdHkgcGl4ZWwgcmVzdWx0cy4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNwcDoK KyAgICAgICAgKGNyZWF0ZUJpdG1hcENvbnRleHRGcm9tV2ViVmlldyk6CisKIDIwMTItMDYtMDYg IFlvbmcgTGkgPHlvbGlAcmltLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUgbXkg ZW1haWwgYWRkcmVzcyBpbiBjb21taXR0ZXJzLnB5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL1BpeGVsRHVtcFN1cHBvcnRHdGsuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvZ3RrL1BpeGVsRHVtcFN1cHBvcnRHdGsuY3BwCmluZGV4IDRkMTkzYmQ0ODdmZjgxNzZiMDlj NjBhOGJmZTkwNTNiOTllNzMxMTYuLjUwMmIxMWQyYTA2NmE5NmY2NGFkMmMyZWZhMzBlN2U3ZWRk OTdjNmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBw b3J0R3RrLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9y dEd0ay5jcHAKQEAgLTQ4LDYgKzQ4LDkgQEAgUGFzc1JlZlB0cjxCaXRtYXBDb250ZXh0PiBjcmVh dGVCaXRtYXBDb250ZXh0RnJvbVdlYlZpZXcoYm9vbCwgYm9vbCwgYm9vbCwgYm9vbAogICAgIGhl aWdodCA9IGd0a193aWRnZXRfZ2V0X2FsbG9jYXRlZF9oZWlnaHQodmlld0NvbnRhaW5lcik7CiAj ZW5kaWYKIAorICAgIHdoaWxlIChndGtfZXZlbnRzX3BlbmRpbmcoKSkKKyAgICAgICAgZ3RrX21h aW5faXRlcmF0aW9uKCk7CisKICAgICBjYWlyb19zdXJmYWNlX3QqIGltYWdlU3VyZmFjZSA9IGNh aXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlKENBSVJPX0ZPUk1BVF9BUkdCMzIsIHdpZHRoLCBoZWln aHQpOwogICAgIGNhaXJvX3QqIGNvbnRleHQgPSBjYWlyb19jcmVhdGUoaW1hZ2VTdXJmYWNlKTsK IAo=