88059 2012-06-01 00:56:50 -0700 REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow. 2012-06-06 20:47:42 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88084 1 yosin yosin cmarcelo macpherson menard ossy schenney tkent webkit.review.bot zarvai oldest_to_newest 639063 0 yosin 2012-06-01 00:56:50 -0700 This bug is imported from http://crbug.com/129334 Slowness is brought by StyleResolver::locateSharedStyle. When style object is shared among optgroup element, StyleResolver::locateSharedStyle checks option elements before it in document order. For example, if we have following HTML: <select> <optgroup label="1"> <option value="1-1>1-1</option> ... x 100 </optgroup> <optgroup label="2"> <option value="2-1>2-1</option> ... x 100 </optgroup> ... <optgroup label="10"> <option value="2-1>2-1</option> ... x 100 </optgroup> </select> locateSharedStyle checks last 10 option elements in optgroup[label="9" to label="1"] for option elements in optgroup[label="10"] by if (currentNode->renderStyle() == parentStyle && currentNode->lastChild()) { // Adjust for unused reserved tries. visitedNodeCount -= cStyleSearchThreshold - subcount; return currentNode->lastChild(); } Before r109729, style object isn't shared for optgroup element by: bool StyleResolver::canShareStyleWithControl(StyledElement* element) const { HTMLInputElement* thisInputElement = element->toInputElement(); HTMLInputElement* otherInputElement = m_element->toInputElement(); if (!thisInputElement || !otherInputElement) return false; Because, "optgroup" element isn't "input" element. BTW, canShareStyleWithControl should be smarter than non-input element to reduce memory usage for RenderStyle object. 639099 1 145241 yosin 2012-06-01 01:42:47 -0700 Created attachment 145241 Patch 1 639100 2 145242 yosin 2012-06-01 01:44:18 -0700 Created attachment 145242 Patch 2 639114 3 145242 yosin 2012-06-01 02:15:36 -0700 Comment on attachment 145242 Patch 2 Could you review this patch? Thanks in advance. 639157 4 145242 tkent 2012-06-01 03:32:03 -0700 Comment on attachment 145242 Patch 2 Looks ok. 639203 5 145242 webkit.review.bot 2012-06-01 04:53:27 -0700 Comment on attachment 145242 Patch 2 Clearing flags on attachment: 145242 Committed r119213: <http://trac.webkit.org/changeset/119213> 639204 6 webkit.review.bot 2012-06-01 04:53:31 -0700 All reviewed patches have been landed. Closing bug. 639226 7 zarvai 2012-06-01 05:33:10 -0700 Layout tests failing on Qt and GTK after r119213 fast/forms/select/menulist-disabled-option.html: Three and Two changed to One and Two on the select box. fast/css/text-transform-select.html: --- /ramdisk/qt-linux-release/build/layout-test-results/fast/css/text-transform-select-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/fast/css/text-transform-select-actual.txt @@ -9,8 +9,8 @@ RenderBlock {DIV} at (0,21) size 768x96 RenderMenuList {SELECT} at (2,68) size 88x26 [bgcolor=#FFFFFF] RenderBlock (anonymous) at (4,2) size 60x21 - RenderText at (0,0) size 53x21 - text run at (0,0) width 53: "HELLO" + RenderText at (0,0) size 45x21 + text run at (0,0) width 45: "heLLo" RenderText {#text} at (92,70) size 4x21 text run at (92,70) width 4: " " RenderListBox {SELECT} at (98,2) size 82x89 [bgcolor=#FFFFFF] [border: (1px inset #808080)] @@ -23,8 +23,8 @@ RenderBlock {DIV} at (0,117) size 768x96 RenderMenuList {SELECT} at (2,68) size 82x26 [bgcolor=#FFFFFF] RenderBlock (anonymous) at (4,2) size 54x21 - RenderText at (0,0) size 48x21 - text run at (0,0) width 48: "HeLLo" + RenderText at (0,0) size 45x21 + text run at (0,0) width 45: "heLLo" RenderText {#text} at (86,70) size 4x21 text run at (86,70) width 4: " " RenderListBox {SELECT} at (92,2) size 76x89 [bgcolor=#FFFFFF] [border: (1px inset #808080)] @@ -37,8 +37,8 @@ RenderBlock {DIV} at (0,213) size 768x96 RenderMenuList {SELECT} at (2,68) size 67x26 [bgcolor=#FFFFFF] RenderBlock (anonymous) at (4,2) size 39x21 - RenderText at (0,0) size 35x21 - text run at (0,0) width 35: "hello" + RenderText at (0,0) size 45x21 + text run at (0,0) width 45: "heLLo" RenderText {#text} at (71,70) size 4x21 text run at (71,70) width 4: " " RenderListBox {SELECT} at (77,2) size 61x89 [bgcolor=#FFFFFF] [border: (1px inset #808080)] @@ -51,8 +51,8 @@ RenderBlock {DIV} at (0,309) size 768x96 RenderMenuList {SELECT} at (2,68) size 50x26 [bgcolor=#FFFFFF] RenderBlock (anonymous) at (4,2) size 22x21 - RenderText at (0,0) size 22x21 - text run at (0,0) width 22: "SS" + RenderText at (0,0) size 10x21 + text run at (0,0) width 10: "\x{DF}" RenderText {#text} at (54,70) size 4x21 text run at (54,70) width 4: " " RenderListBox {SELECT} at (60,2) size 44x89 [bgcolor=#FFFFFF] [border: (1px inset #808080)] 639255 8 ossy 2012-06-01 06:03:55 -0700 and Lion and EFL too ... Could you guys fix it or should we roll it out? 639271 9 webkit.review.bot 2012-06-01 06:25:54 -0700 Re-opened since this is blocked by 88084 639302 10 schenney 2012-06-01 07:04:07 -0700 r119213 also broke Chromium tests: fast/css/text-transform-select.html fast/forms/select/menulist-disabled-option.html It was rolled out. 639324 11 schenney 2012-06-01 07:26:57 -0700 The Chromium failures were on Mac and Win, not Linux. 642335 12 145979 yosin 2012-06-06 03:30:52 -0700 Created attachment 145979 Patch 3 642339 13 yosin 2012-06-06 03:34:24 -0700 (In reply to comment #10) > r119213 also broke Chromium tests: > fast/css/text-transform-select.html > fast/forms/select/menulist-disabled-option.html > > It was rolled out. I file a bug to share RenderStyle object for option and optgroup elements, bug 88405. A root causes are different in these test cases. 643051 14 145979 yosin 2012-06-06 18:25:20 -0700 Comment on attachment 145979 Patch 3 Could you review this patch? Thanks in advance. 643053 15 145979 tkent 2012-06-06 18:26:53 -0700 Comment on attachment 145979 Patch 3 ok 643145 16 145979 webkit.review.bot 2012-06-06 20:47:34 -0700 Comment on attachment 145979 Patch 3 Clearing flags on attachment: 145979 Committed r119672: <http://trac.webkit.org/changeset/119672> 643146 17 webkit.review.bot 2012-06-06 20:47:42 -0700 All reviewed patches have been landed. Closing bug. 145241 2012-06-01 01:42:47 -0700 2012-06-01 01:44:13 -0700 Patch 1 bug-88059-20120601174245.patch text/plain 2217 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q4NGJlNzkwYjVjYmIx NzNlMzA3MTk5ZTA2MDYwOWI4NzgzMzI1NC4uYTAxY2M4YWFiZDY3MTFlMWE5YjY1OTQ2ZjM3YzE3 MzY1MTQwODVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTA5NzI5KSBbRm9ybV0gVGhlIG9wdGdyb3VwIGVsZW1lbnQncyAiZGlzYWJsZWQiIGF0dHJpYnV0 ZSBoYXMgbm8gZWZmZWN0IHRvIHJlbmRlcmluZyBhbmQgc2VsZWN0aW9uIFJlbmRlcmluZyBvZiBz ZWxlY3Qvb3B0Z3JvdXAvb3B0aW9uIGNvbWJpbmF0aW9uIGlzIHRvbyBzbG93LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgwNTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMg dG8gc2hhcmUgUmVuZGVyU3R5bGUgb2JqZWN0IGFtb25nIHRoZSAib3B0aW9uIiAKKyAgICAgICAg ZWxlbWVudHMgdG8gaW1wcm92ZSByZW5kZXJpbmcgcGVyZm9ybWFuY2UgYW5kIHJlZHVjaW5nIG1l bW9yeSB1c2FnZQorICAgICAgICBvZiBSZW5kZXJTdHlsZS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgYmVoYXZpb3IgYnV0IHJlbmRlcmluZyBwZXJm b3JtYW5jZS4KKworICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRoRWxlbWVudCk6IENoZWNrIGF0 dHJpYnV0ZSB2YWx1ZQorICAgICAgICBtaXNtYXRjaGluZyBmb3IgIm9wdGlvbiIgZWxlbWVudC4K KwogMjAxMi0wNS0zMSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgW1Y4XSBFeHBhbmRvIHByb3BlcnRpZXMgb24gYXR0cmlidXRlIG5vZGVzIGRpc2Fw cGVhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDFmMDIzZDJiZDVhMjQ5 ZmMxNTQ3YWQ5ZTFjOWRiODNhMmRmYjlkNmMuLmFmOGEyNTZmN2I5NjA2YjFhNjQzZmIyNDI4YWEw MjljNzM0YzUxNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKQEAgLTEzODks OCArMTM4OSwxNCBAQCBib29sIFN0eWxlUmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRoRWxlbWVu dChTdHlsZWRFbGVtZW50KiBlbGVtZW50KSBjb25zdAogICAgIH0KICNlbmRpZgogCi0gICAgaWYg KGVsZW1lbnQtPmhhc1RhZ05hbWUob3B0aW9uVGFnKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIC8vIENoZWNrIGF0dHJpYnV0ZXMgZm9yIDpkaXNhYmxlZCwgOmVuYWJlbGQsIDpjaGVja2Vk LCA6ZGVmYXVsdCwgQ1NTIHBzZXVkbyBjbGFzcy4KKyAgICBpZiAoZWxlbWVudC0+aGFzVGFnTmFt ZShvcHRpb25UYWcpKSB7CisgICAgICAgIEhUTUxPcHRpb25FbGVtZW50KiB0aGlzT3B0aW9uRWxl bWVudCA9IHRvSFRNTE9wdGlvbkVsZW1lbnQoZWxlbWVudCk7CisgICAgICAgIEhUTUxPcHRpb25F bGVtZW50KiBvdGhlck9wdGlvbkVsZW1lbnQgPSB0b0hUTUxPcHRpb25FbGVtZW50KG1fZWxlbWVu dCk7CisgICAgICAgIGlmICh0aGlzT3B0aW9uRWxlbWVudC0+aXNFbmFibGVkRm9ybUNvbnRyb2wo KSAhPSBvdGhlck9wdGlvbkVsZW1lbnQtPmlzRW5hYmxlZEZvcm1Db250cm9sKCkKKyAgICAgICAg ICAgIHx8IHRoaXNPcHRpb25FbGVtZW50LT5zZWxlY3RlZCgpICE9IG90aGVyT3B0aW9uRWxlbWVu dC0+c2VsZWN0ZWQoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBp ZiAoZWxlbWVudC0+aGFzVGFnTmFtZShvcHRncm91cFRhZykgJiYgbV9lbGVtZW50LT5kaXNhYmxl ZCgpICE9IGVsZW1lbnQtPmRpc2FibGVkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK 145242 2012-06-01 01:44:18 -0700 2012-06-06 03:30:45 -0700 Patch 2 bug-88059-20120601174416.patch text/plain 2132 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q4NGJlNzkwYjVjYmIx NzNlMzA3MTk5ZTA2MDYwOWI4NzgzMzI1NC4uNTg0OTRhOWE5YmJmYWFiNTE5YzE0NmYzZGU5Y2Vk YjU1MTBhN2RjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTAxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTA5NzI5KSBbRm9ybV0gUmVuZGVyaW5nIG9mIHNlbGVjdC9vcHRncm91cC9vcHRpb24gY29tYmlu YXRpb24gaXMgdG9vIHNsb3cuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04ODA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0byBzaGFyZSBSZW5kZXJTdHlsZSBvYmplY3Qg YW1vbmcgdGhlICJvcHRpb24iIAorICAgICAgICBlbGVtZW50cyB0byBpbXByb3ZlIHJlbmRlcmlu ZyBwZXJmb3JtYW5jZSBhbmQgcmVkdWNpbmcgbWVtb3J5IHVzYWdlCisgICAgICAgIG9mIFJlbmRl clN0eWxlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBkb2Vzbid0IGNoYW5n ZSBiZWhhdmlvciBidXQgcmVuZGVyaW5nIHBlcmZvcm1hbmNlLgorCisgICAgICAgICogY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZlcjo6Y2FuU2hh cmVTdHlsZVdpdGhFbGVtZW50KTogQ2hlY2sgYXR0cmlidXRlIHZhbHVlCisgICAgICAgIG1pc21h dGNoaW5nIGZvciAib3B0aW9uIiBlbGVtZW50LgorCiAyMDEyLTA1LTMxICBEb21pbmljIENvb25l eSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIEV4cGFuZG8gcHJvcGVy dGllcyBvbiBhdHRyaWJ1dGUgbm9kZXMgZGlzYXBwZWFyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNv bHZlci5jcHAKaW5kZXggMWYwMjNkMmJkNWEyNDlmYzE1NDdhZDllMWM5ZGI4M2EyZGZiOWQ2Yy4u YWY4YTI1NmY3Yjk2MDZiMWE2NDNmYjI0MjhhYTAyOWM3MzRjNTE3NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9TdHlsZVJlc29sdmVyLmNwcApAQCAtMTM4OSw4ICsxMzg5LDE0IEBAIGJvb2wgU3R5bGVSZXNv bHZlcjo6Y2FuU2hhcmVTdHlsZVdpdGhFbGVtZW50KFN0eWxlZEVsZW1lbnQqIGVsZW1lbnQpIGNv bnN0CiAgICAgfQogI2VuZGlmCiAKLSAgICBpZiAoZWxlbWVudC0+aGFzVGFnTmFtZShvcHRpb25U YWcpKQotICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgLy8gQ2hlY2sgYXR0cmlidXRlcyBmb3Ig OmRpc2FibGVkLCA6ZW5hYmVsZCwgOmNoZWNrZWQsIDpkZWZhdWx0LCBDU1MgcHNldWRvIGNsYXNz LgorICAgIGlmIChlbGVtZW50LT5oYXNUYWdOYW1lKG9wdGlvblRhZykpIHsKKyAgICAgICAgSFRN TE9wdGlvbkVsZW1lbnQqIHRoaXNPcHRpb25FbGVtZW50ID0gdG9IVE1MT3B0aW9uRWxlbWVudChl bGVtZW50KTsKKyAgICAgICAgSFRNTE9wdGlvbkVsZW1lbnQqIG90aGVyT3B0aW9uRWxlbWVudCA9 IHRvSFRNTE9wdGlvbkVsZW1lbnQobV9lbGVtZW50KTsKKyAgICAgICAgaWYgKHRoaXNPcHRpb25F bGVtZW50LT5pc0VuYWJsZWRGb3JtQ29udHJvbCgpICE9IG90aGVyT3B0aW9uRWxlbWVudC0+aXNF bmFibGVkRm9ybUNvbnRyb2woKQorICAgICAgICAgICAgfHwgdGhpc09wdGlvbkVsZW1lbnQtPnNl bGVjdGVkKCkgIT0gb3RoZXJPcHRpb25FbGVtZW50LT5zZWxlY3RlZCgpKQorICAgICAgICAgICAg cmV0dXJuIGZhbHNlOworICAgIH0KIAogICAgIGlmIChlbGVtZW50LT5oYXNUYWdOYW1lKG9wdGdy b3VwVGFnKSAmJiBtX2VsZW1lbnQtPmRpc2FibGVkKCkgIT0gZWxlbWVudC0+ZGlzYWJsZWQoKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwo= 145979 2012-06-06 03:30:52 -0700 2012-06-06 20:47:34 -0700 Patch 3 bug-88059-20120606193051.patch text/plain 2200 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNlOGQ4Y2JmNzVjY2M3 MWNiODk2ZjJiNjcxNDRmMDQ3NzRlNTM3OC4uODVlYmNmNTAzM2I0NGRkODA1MTliNzJiNWJiNjZj Y2Y2OTBiZTk3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTA2ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTA5NzI5KSBbRm9ybV0gUmVuZGVyaW5nIG9mIHNlbGVjdC9vcHRncm91cC9vcHRpb24gY29tYmlu YXRpb24gaXMgdG9vIHNsb3cuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04ODA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyBub3QgdG8gc2hhcmUgUmVuZGVyU3R5bGUgb2Jq ZWN0IGZvciBvcHRpb24gYW5kCisgICAgICAgIG9wdGdyb3VwIGVsZW1lbnQgcmVnYXJkbGVzcyBh dHRyaWJ1dGVzLgorCisgICAgICAgIFdoZW4gd2UgdHJpZWQgdG8gc2hhcmVkIFJlbmRlclN0eWxl IG9iamVjdCwgcmVuZGVyaW5nIHBlcmZvcm1hbmNlIHdhcworICAgICAgICBnb29kIGJ1dCB3ZSBo YWQgaXNzdWUgaW4gc2VsZWN0ZWQgb3B0aW9uIGFuZCB0ZXh0IHRyYW5zZm9ybSwgc2VlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODQwNSBmb3IgZGV0 YWlscy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgcGF0Y2ggZG9lc24ndCBjaGFuZ2Ug YmVoYXZpb3IgYnV0IHJlbmRlcmluZyBwZXJmb3JtYW5jZS4KKworICAgICAgICAqIGNzcy9TdHls ZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmNhblNoYXJl U3R5bGVXaXRoRWxlbWVudCk6IENoYW5nZWQgdG8gYWx3YXlzCisgICAgICAgIHJldHVybiBmYWxz ZSBmb3Igb3B0aW9uIGFuZCBvcHRncm91cC4KKwogMjAxMi0wNi0wNiAgU2hpbnlhIEthd2FuYWth ICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUG9zaXRpb25JdGVyYXRvcjo7c2V0 T2Zmc2V0SW5MZWFmTm9kZSgpIGlzIG5vdCB1c2VkIGFueXdoZXJlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDNlZjBhZGQ4ZDg5OTY3OWUwNjVjNzg4NWFjNzE5NTgxZGRj ZTNhYTAuLjcwYzk5NmY5Mjc5ZTkxNzIxYmQ1NjUwNmIxNWI0NTMwNGY0NzRmNGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKQEAgLTEzOTEsMTAgKzEzOTEsMTAgQEAgYm9vbCBT dHlsZVJlc29sdmVyOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQoU3R5bGVkRWxlbWVudCogZWxl bWVudCkgY29uc3QKICAgICB9CiAjZW5kaWYKIAotICAgIGlmIChlbGVtZW50LT5oYXNUYWdOYW1l KG9wdGlvblRhZykpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIGlmIChlbGVtZW50LT5o YXNUYWdOYW1lKG9wdGdyb3VwVGFnKSAmJiBtX2VsZW1lbnQtPmRpc2FibGVkKCkgIT0gZWxlbWVu dC0+ZGlzYWJsZWQoKSkKKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHNoYXJlIHN0eWxlIGZvciBv cHRpb24gYW5kIG9wdGdyb3VwIHdoZW5ldmVyIHBvc3NpYmxlLgorICAgIC8vIEJlZm9yZSBkb2lu ZyBzbywgd2UgbmVlZCB0byByZXNvbHZlIGlzc3VlcyBpbiBIVE1MU2VsZWN0RWxlbWVudDo6cmVj YWxjTGlzdEl0ZW1zCisgICAgLy8gYW5kIFJlbmRlck1lbnVMaXN0OjpzZXRUZXh0LiBTZWUgYWxz byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg0MDUKKyAgICBpZiAo ZWxlbWVudC0+aGFzVGFnTmFtZShvcHRpb25UYWcpIHx8IGVsZW1lbnQtPmhhc1RhZ05hbWUob3B0 Z3JvdXBUYWcpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBib29sIGlzQ29udHJvbCA9 IGVsZW1lbnQtPmlzRm9ybUNvbnRyb2xFbGVtZW50KCk7Cg==