88056 2012-06-01 00:39:58 -0700 [Refactoring] Frame::willDetachPage() shouldn't be called more than once. 2012-06-03 17:26:46 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 88088 1 morrita morrita abarth darin japhet rniwa webkit.review.bot oldest_to_newest 639051 0 morrita 2012-06-01 00:39:58 -0700 This is just a cleanup. 639087 1 145237 morrita 2012-06-01 01:22:39 -0700 Created attachment 145237 Patch 639090 2 morrita 2012-06-01 01:24:03 -0700 Darin, Ryosuke, could you take a look? This is just a small cleanup. 639101 3 145237 rniwa 2012-06-01 01:44:33 -0700 Comment on attachment 145237 Patch This is a scary change but looks reasonable. Hopefully it won't cause any regressions. 639102 4 145237 rniwa 2012-06-01 01:46:38 -0700 Comment on attachment 145237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145237&action=review > Source/WebCore/page/Frame.cpp:695 > if (Frame* parent = tree()->parent()) > parent->loader()->checkLoadComplete(); Actually, it's not entirely clear to me why we'd have to call checkLoadComplete more than once :\ 639219 5 145237 webkit.review.bot 2012-06-01 05:30:25 -0700 Comment on attachment 145237 Patch Clearing flags on attachment: 145237 Committed r119219: <http://trac.webkit.org/changeset/119219> 639220 6 webkit.review.bot 2012-06-01 05:30:31 -0700 All reviewed patches have been landed. Closing bug. 639288 7 webkit.review.bot 2012-06-01 06:47:56 -0700 Re-opened since this is blocked by 88088 639388 8 145237 abarth 2012-06-01 08:54:14 -0700 Comment on attachment 145237 Patch I seem to remember trying to do this originally, but there was something I found in studying the code that didn't work properly this way... 640244 9 morrita 2012-06-03 17:26:46 -0700 (In reply to comment #8) > (From update of attachment 145237 [details]) > I seem to remember trying to do this originally, but there was something I found in studying the code that didn't work properly this way... Hmm, interesting... I'd have liked to see the failed test. But this looks something which should keep untouched... 145237 2012-06-01 01:22:39 -0700 2012-06-01 08:54:14 -0700 Patch bug-88056-20120601172238.patch text/plain 4942 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q4NGJlNzkwYjVjYmIx NzNlMzA3MTk5ZTA2MDYwOWI4NzgzMzI1NC4uYjIyYTViNWIwYzM5MDM2YTE4MTc5ODA0YzAxMDYz N2E2M2ViMDcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA2LTAxICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIEZyYW1lOjp3aWxsRGV0 YWNoUGFnZSgpIHNob3VsZG4ndCBiZSBjYWxsZWQgbW9yZSB0aGFuIG9uY2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODA1NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIG1vdmVkIHdp bGxEZXRhY2hQYWdlKCkgdG8gcHJpdmF0ZSBhbmQgY2FsbHMgaXQgZnJvbQorICAgICAgICBkZXRh Y2hGcm9tUGFyZW50KCkuICBBbHNvLCBpdCBjaGVja3MgbV9wYWdlIGFuZCBjYWxsCisgICAgICAg IHdpbGxEZXRhY2hQYWdlKCkgb25seSBvbmNlLCBpZiBtX3BhZ2UgaXMgYXZhaWxhYmxlLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyBzdWl0ZXMuCisKKyAgICAg ICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2Fk ZXI6OmNsb3NlQW5kUmVtb3ZlQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6 OmRldGFjaEZyb21QYXJlbnQpOgorICAgICAgICAqIHBhZ2UvRnJhbWUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWU6OmRldGFjaEZyb21QYWdlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWU6OndpbGxEZXRhY2hQYWdlKToKKyAgICAgICAgKiBwYWdlL0Zy YW1lLmg6CisgICAgICAgIChGcmFtZSk6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlBhZ2U6On5QYWdlKToKKwogMjAxMi0wNS0zMSAgRG9taW5pYyBDb29uZXkg IDxkb21pbmljY0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBFeHBhbmRvIHByb3BlcnRp ZXMgb24gYXR0cmlidXRlIG5vZGVzIGRpc2FwcGVhcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAKaW5kZXggZDM2ZDExMDQ5ZTIwZDYzOWFkNDQ2ZDdjNjA0YWYzNjRlNWFiYzhjNy4u MmQ3OWFkNmI1ZDAwN2RhY2UwODRmZGY2ODE0ZGM2MzQ1MjhjZGUyNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0yMjY2LDcgKzIyNjYsNiBAQCB2b2lkIEZyYW1lTG9h ZGVyOjpjbG9zZUFuZFJlbW92ZUNoaWxkKEZyYW1lKiBjaGlsZCkKICAgICBjaGlsZC0+c2V0Vmll dygwKTsKICAgICBpZiAoY2hpbGQtPm93bmVyRWxlbWVudCgpICYmIGNoaWxkLT5wYWdlKCkpCiAg ICAgICAgIGNoaWxkLT5wYWdlKCktPmRlY3JlbWVudEZyYW1lQ291bnQoKTsKLSAgICBjaGlsZC0+ d2lsbERldGFjaFBhZ2UoKTsKICAgICBjaGlsZC0+ZGV0YWNoRnJvbVBhZ2UoKTsKIAogICAgIG1f ZnJhbWUtPnRyZWUoKS0+cmVtb3ZlQ2hpbGQoY2hpbGQpOwpAQCAtMjM0NSw3ICsyMzQ0LDYgQEAg dm9pZCBGcmFtZUxvYWRlcjo6ZGV0YWNoRnJvbVBhcmVudCgpCiAgICAgICAgIHBhcmVudC0+bG9h ZGVyKCktPnNjaGVkdWxlQ2hlY2tDb21wbGV0ZWQoKTsKICAgICB9IGVsc2UgewogICAgICAgICBt X2ZyYW1lLT5zZXRWaWV3KDApOwotICAgICAgICBtX2ZyYW1lLT53aWxsRGV0YWNoUGFnZSgpOwog ICAgICAgICBtX2ZyYW1lLT5kZXRhY2hGcm9tUGFnZSgpOwogICAgIH0KIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZS5jcHAKaW5kZXggMTUyYTFkOTVmYTJmMDNiNzI1YzhjZGQzNWY1ZjBkMjY3ZGI5OGE1MC4uZjgy OGFmZTViNWY1MTIzMGIxNDY4NWMzZWE1NTVmNjIyYjE5NWYyMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5j cHAKQEAgLTY4OSwxOCArNjg5LDIzIEBAIERPTVdpbmRvdyogRnJhbWU6OmRvbVdpbmRvdygpIGNv bnN0CiAgICAgcmV0dXJuIG1fZG9tV2luZG93LmdldCgpOwogfQogCi12b2lkIEZyYW1lOjp3aWxs RGV0YWNoUGFnZSgpCit2b2lkIEZyYW1lOjpkZXRhY2hGcm9tUGFnZSgpCiB7CiAgICAgaWYgKEZy YW1lKiBwYXJlbnQgPSB0cmVlKCktPnBhcmVudCgpKQogICAgICAgICBwYXJlbnQtPmxvYWRlcigp LT5jaGVja0xvYWRDb21wbGV0ZSgpOworICAgIGlmIChtX3BhZ2UpCisgICAgICAgIHdpbGxEZXRh Y2hQYWdlKCk7CisgICAgbV9wYWdlID0gMDsKK30KKwogCit2b2lkIEZyYW1lOjp3aWxsRGV0YWNo UGFnZSgpCit7CiAgICAgSGFzaFNldDxGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIqPjo6aXRlcmF0 b3Igc3RvcCA9IG1fZGVzdHJ1Y3Rpb25PYnNlcnZlcnMuZW5kKCk7CiAgICAgZm9yIChIYXNoU2V0 PEZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlcio+OjppdGVyYXRvciBpdCA9IG1fZGVzdHJ1Y3Rpb25P YnNlcnZlcnMuYmVnaW4oKTsgaXQgIT0gc3RvcDsgKytpdCkKICAgICAgICAgKCppdCktPndpbGxE ZXRhY2hQYWdlKCk7CiAKLSAgICAvLyBGSVhNRTogSXQncyB1bmNsZWFyIGFzIHRvIHdoeSB0aGlz IGlzIGNhbGxlZCBtb3JlIHRoYW4gb25jZSwgYnV0IGl0IGlzLAotICAgIC8vIHNvIHBhZ2UoKSBj b3VsZCBiZSBOVUxMLgotICAgIGlmIChwYWdlKCkgJiYgcGFnZSgpLT5mb2N1c0NvbnRyb2xsZXIo KS0+Zm9jdXNlZEZyYW1lKCkgPT0gdGhpcykKKyAgICBpZiAocGFnZSgpLT5mb2N1c0NvbnRyb2xs ZXIoKS0+Zm9jdXNlZEZyYW1lKCkgPT0gdGhpcykKICAgICAgICAgcGFnZSgpLT5mb2N1c0NvbnRy b2xsZXIoKS0+c2V0Rm9jdXNlZEZyYW1lKDApOwogCiAgICAgc2NyaXB0KCktPmNsZWFyU2NyaXB0 T2JqZWN0cygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCmluZGV4IDRjZDRmOTY4M2I0YzNiZTA1ZjgxN2NhODc1 OWNhN2EzZmEzNmRhZmIuLjYwN2ZmMDZiYWM2ZWIzNmE0OWQ3OTMzYzgyYWVhZGZiZjFmOTQ0YzAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lLmgKQEAgLTkxLDcgKzkxLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICB2b2lkIGFkZERlc3RydWN0aW9uT2JzZXJ2ZXIoRnJhbWVEZXN0cnVjdGlvbk9ic2Vy dmVyKik7CiAgICAgICAgIHZvaWQgcmVtb3ZlRGVzdHJ1Y3Rpb25PYnNlcnZlcihGcmFtZURlc3Ry dWN0aW9uT2JzZXJ2ZXIqKTsKIAotICAgICAgICB2b2lkIHdpbGxEZXRhY2hQYWdlKCk7CiAgICAg ICAgIHZvaWQgZGV0YWNoRnJvbVBhZ2UoKTsKICAgICAgICAgdm9pZCBkaXNjb25uZWN0T3duZXJF bGVtZW50KCk7CiAKQEAgLTIwNyw2ICsyMDYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIEZyYW1lKFBhZ2UqLCBIVE1MRnJhbWVPd25lckVsZW1lbnQqLCBGcmFtZUxvYWRlckNsaWVu dCopOwogCiAgICAgICAgIHZvaWQgaW5qZWN0VXNlclNjcmlwdHNGb3JXb3JsZChET01XcmFwcGVy V29ybGQqLCBjb25zdCBVc2VyU2NyaXB0VmVjdG9yJiwgVXNlclNjcmlwdEluamVjdGlvblRpbWUp OworICAgICAgICB2b2lkIHdpbGxEZXRhY2hQYWdlKCk7CiAKICAgICAgICAgSGFzaFNldDxGcmFt ZURlc3RydWN0aW9uT2JzZXJ2ZXIqPiBtX2Rlc3RydWN0aW9uT2JzZXJ2ZXJzOwogCkBAIC0zNTEs MTEgKzM1MSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgcmV0dXJuIG1fcGFnZTsK ICAgICB9CiAKLSAgICBpbmxpbmUgdm9pZCBGcmFtZTo6ZGV0YWNoRnJvbVBhZ2UoKQotICAgIHsK LSAgICAgICAgbV9wYWdlID0gMDsKLSAgICB9Ci0KICAgICBpbmxpbmUgRXZlbnRIYW5kbGVyKiBG cmFtZTo6ZXZlbnRIYW5kbGVyKCkgY29uc3QKICAgICB7CiAgICAgICAgIHJldHVybiAmbV9ldmVu dEhhbmRsZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCBkMzA5MDBmNjA1NTE0NzNhYzYxMWE5ZTM4 NTEzZGUyNTFlYTVhMDJmLi41Yzc0NDQ3NTgwYmFhODhjYzE1OWZkM2Y2ODVmNjNhNjU5ZmRmYTMz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTE4NywxMCArMTg3LDggQEAgUGFnZTo6flBhZ2UoKQog ICAgIHNldEdyb3VwTmFtZShTdHJpbmcoKSk7CiAgICAgYWxsUGFnZXMtPnJlbW92ZSh0aGlzKTsK ICAgICAKLSAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUg PSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkgewotICAgICAgICBmcmFtZS0+d2lsbERl dGFjaFBhZ2UoKTsKKyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFtZSgpOyBmcmFtZTsg ZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkKICAgICAgICAgZnJhbWUtPmRl dGFjaEZyb21QYWdlKCk7Ci0gICAgfQogCiAgICAgbV9lZGl0b3JDbGllbnQtPnBhZ2VEZXN0cm95 ZWQoKTsKICAgICBpZiAobV9hbHRlcm5hdGl2ZVRleHRDbGllbnQpCg==