<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>88039</bug_id>
          
          <creation_ts>2012-05-31 20:05:11 -0700</creation_ts>
          <short_desc>[WebKit2] Remove nested #if conditions from messages.in files</short_desc>
          <delta_ts>2012-05-31 20:22:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andy Estes">aestes</reporter>
          <assigned_to name="Andy Estes">aestes</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>638931</commentid>
    <comment_count>0</comment_count>
    <who name="Andy Estes">aestes</who>
    <bug_when>2012-05-31 20:05:11 -0700</bug_when>
    <thetext>#if conditions can&apos;t be nested in .messages.in files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638932</commentid>
    <comment_count>1</comment_count>
    <who name="Andy Estes">aestes</who>
    <bug_when>2012-05-31 20:06:19 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=88036 tracks fixing this limitation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638933</commentid>
    <comment_count>2</comment_count>
      <attachid>145201</attachid>
    <who name="Andy Estes">aestes</who>
    <bug_when>2012-05-31 20:10:00 -0700</bug_when>
    <thetext>Created attachment 145201
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>638937</commentid>
    <comment_count>3</comment_count>
    <who name="Andy Estes">aestes</who>
    <bug_when>2012-05-31 20:22:02 -0700</bug_when>
    <thetext>Committed r119189: &lt;http://trac.webkit.org/changeset/119189&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>145201</attachid>
            <date>2012-05-31 20:10:00 -0700</date>
            <delta_ts>2012-05-31 20:20:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88039-20120531200959.patch</filename>
            <type>text/plain</type>
            <size>4564</size>
            <attacher name="Andy Estes">aestes</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmMzMGEwODYwMzIzOGRl
MDdmMGQ4YjlkZTA0NDA0ZTQxYmJmZTY0YS4uMzIzMmVlNDZmYjcxZWU0ZDRiMjQxODRhM2IxYjkw
MmJiYTdjM2Y4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA1LTMxICBBbmR5
IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBbV2ViS2l0Ml0gUmVtb3ZlIG5l
c3RlZCAjaWYgY29uZGl0aW9ucyBmcm9tIG1lc3NhZ2VzLmluIGZpbGVzCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODAzOQorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb2RlIGdlbmVyYXRvciB0aGF0
IHByb2Nlc3NlcyBtZXNzYWdlcy5pbiBmaWxlcyBjYW4ndCBoYW5kbGUgbmVzdGVkCisgICAgICAg
ICNpZiBjb25kaXRpb25zLiBTYWRseSBJIGFkZGVkIHNhaWQgY29uZGl0aW9ucyBpbiByMTE3NzAw
IGJ1dCBmYWlsZWQgdG8KKyAgICAgICAgdmVyaWZ5IHRoZSBnZW5lcmF0ZWQgcmVzdWx0LiBVbi1u
ZXN0IHRoZSBjb25kaXRpb25zIEkgYWRkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFn
ZVByb3h5Lm1lc3NhZ2VzLmluOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl
Lm1lc3NhZ2VzLmluOgorCisyMDEyLTA1LTMxICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv
bT4KKwogICAgICAgICBEaXNlbnRhbmdsZSBjb2RlIHRoYXQgcmVsaWVzIG9uIFVTRShBVVRPTUFU
SUNfVEVYVF9SRVBMQUNFTUVOVCkgZnJvbSB0aGF0IHdoaWNoIG1lcmVseSByZWxpZXMgb24gUExB
VEZPUk0oTUFDKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9ODc5MzMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ
cm94eS5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku
bWVzc2FnZXMuaW4KaW5kZXggODU0MWNmYjdjMjExNDgzNDVhNDk1MzI2YTVmMGNlNjIyNTBjYjhh
Ni4uZGU2MGE3MTY2ZjU0YTgxODkxMzUwZTA3NTQyNWEzYTk4M2UzZTBlMyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgorKysgYi9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCkBAIC0yMzIs
MTcgKzIzMiwxNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlUHJveHkgewogICAgICMgRHJhZyBhbmQg
ZHJvcCBtZXNzYWdlcwogI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAgICAgRGlkUGVyZm9ybURy
YWdDb250cm9sbGVyQWN0aW9uKFdlYkNvcmU6OkRyYWdTZXNzaW9uIGRyYWdTZXNzaW9uKQotI2lm
IFBMQVRGT1JNKE1BQykKKyNlbmRpZgorI2lmIFBMQVRGT1JNKE1BQykgJiYgRU5BQkxFKERSQUdf
U1VQUE9SVCkKICAgICBTZXREcmFnSW1hZ2UoV2ViQ29yZTo6SW50UG9pbnQgY2xpZW50UG9zaXRp
b24sIFdlYktpdDo6U2hhcmVhYmxlQml0bWFwOjpIYW5kbGUgZHJhZ0ltYWdlLCBib29sIGxpbmtE
cmFnKQogICAgIFNldFByb21pc2VkRGF0YShXVEY6OlN0cmluZyBwYXN0ZWJvYXJkTmFtZSwgV2Vi
S2l0OjpTaGFyZWRNZW1vcnk6OkhhbmRsZSBpbWFnZUhhbmRsZSwgdWludDY0X3QgaW1hZ2VTaXpl
LCBXVEY6OlN0cmluZyBmaWxlbmFtZSwgV1RGOjpTdHJpbmcgZXh0ZW5zaW9uLCBXVEY6OlN0cmlu
ZyB0aXRsZSwgV1RGOjpTdHJpbmcgdXJsLCBXVEY6OlN0cmluZyB2aXNpYmxlVVJMLCBXZWJLaXQ6
OlNoYXJlZE1lbW9yeTo6SGFuZGxlIGFyY2hpdmVIYW5kbGUsIHVpbnQ2NF90IGFyY2hpdmVTaXpl
KQogI2VuZGlmCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTikgJiYgRU5BQkxF
KERSQUdfU1VQUE9SVCkKICAgICBTdGFydERyYWdEcm9wKFdlYkNvcmU6OkludFBvaW50IGltYWdl
UG9pbnQsIFdlYkNvcmU6OkludFBvaW50IGRyYWdQb2ludCwgdWludDY0X3Qgb2tFZmZlY3QsIEhh
c2hNYXA8VUlOVCxWZWN0b3I8U3RyaW5nPiA+IGRhdGFNYXAsIHVpbnQ2NF90IGZpbGVTaXplLCBT
dHJpbmcgcGF0aG5hbWUsIFdlYktpdDo6U2hhcmVkTWVtb3J5OjpIYW5kbGUgZmlsZUNvbnRlbnRI
YW5kbGUsIFdlYkNvcmU6OkludFNpemUgZHJhZ0ltYWdlU2l6ZSwgV2ViS2l0OjpTaGFyZWRNZW1v
cnk6OkhhbmRsZSBkcmFnSW1hZ2UsIGJvb2wgbGlua0RyYWcpCiAjZW5kaWYKLSNpZiBQTEFURk9S
TShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2lmIChQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RL
KSkgJiYgRU5BQkxFKERSQUdfU1VQUE9SVCkKICAgICBTdGFydERyYWcoV2ViQ29yZTo6RHJhZ0Rh
dGEgZHJhZ0RhdGEsIFdlYktpdDo6U2hhcmVhYmxlQml0bWFwOjpIYW5kbGUgZHJhZ0ltYWdlKQog
I2VuZGlmCi0jZW5kaWYKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICAjIERpY3Rpb25hcnkgc3Vw
cG9ydC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ
YWdlLm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh
Z2UubWVzc2FnZXMuaW4KaW5kZXggODk5YTJhOTUyMjY3N2FiMmZkNWZmNjU5YjZjOWQ1N2NjM2Qw
MGRmOS4uZjE0ZmNiNmM5MDE1ZGM5NmQyMTU0ZTkzM2RlOGZiZDY0MDE5ODc5ZCAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4K
KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMu
aW4KQEAgLTQwLDYgKzQwLDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZSB7CiAjaWYgRU5BQkxFKFRP
VUNIX0VWRU5UUykKICAgICBUb3VjaEV2ZW50KFdlYktpdDo6V2ViVG91Y2hFdmVudCBldmVudCkK
ICAgICBUb3VjaEV2ZW50U3luY0ZvclRlc3RpbmcoV2ViS2l0OjpXZWJUb3VjaEV2ZW50IGV2ZW50
KSAtPiAoYm9vbCBoYW5kbGVkKQorI2VuZGlmCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykgJiYg
UExBVEZPUk0oUVQpCiAgICAgSGlnaGxpZ2h0UG90ZW50aWFsQWN0aXZhdGlvbihXZWJDb3JlOjpJ
bnRQb2ludCBwb2ludCwgV2ViQ29yZTo6SW50U2l6ZSBhcmVhKQogI2VuZGlmCkBAIC0xNDEsMTcg
KzE0MiwxNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlIHsKICAgICBIaWRlRmluZFVJKCkKICAgICBD
b3VudFN0cmluZ01hdGNoZXMoV1RGOjpTdHJpbmcgc3RyaW5nLCB1aW50MzJfdCBmaW5kT3B0aW9u
cywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCkKIAotI2lmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAg
ICAgIyBEcmFnIGFuZCBkcm9wLgotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShXSU4p
ICYmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAgICAgUGVyZm9ybURyYWdDb250cm9sbGVyQWN0aW9u
KHVpbnQ2NF90IGFjdGlvbiwgV2ViQ29yZTo6SW50UG9pbnQgY2xpZW50UG9zaXRpb24sIFdlYkNv
cmU6OkludFBvaW50IGdsb2JhbFBvc2l0aW9uLCB1aW50NjRfdCBkcmFnZ2luZ1NvdXJjZU9wZXJh
dGlvbk1hc2ssIEhhc2hNYXA8VUlOVCxWZWN0b3I8U3RyaW5nPj4gZGF0YU1hcCwgdWludDMyX3Qg
ZmxhZ3MpCiAjZW5kaWYKLSNpZiBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2lmIChQ
TEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSkgJiYgRU5BQkxFKERSQUdfU1VQUE9SVCkKICAg
ICBQZXJmb3JtRHJhZ0NvbnRyb2xsZXJBY3Rpb24odWludDY0X3QgYWN0aW9uLCBXZWJDb3JlOjpE
cmFnRGF0YSBkcmFnRGF0YSkKICNlbmRpZgotI2lmICFQTEFURk9STShXSU4pICYmICFQTEFURk9S
TShRVCkgJiYgIVBMQVRGT1JNKEdUSykKKyNpZiAhUExBVEZPUk0oV0lOKSAmJiAhUExBVEZPUk0o
UVQpICYmICFQTEFURk9STShHVEspICYmIEVOQUJMRShEUkFHX1NVUFBPUlQpCiAgICAgUGVyZm9y
bURyYWdDb250cm9sbGVyQWN0aW9uKHVpbnQ2NF90IGFjdGlvbiwgV2ViQ29yZTo6SW50UG9pbnQg
Y2xpZW50UG9zaXRpb24sIFdlYkNvcmU6OkludFBvaW50IGdsb2JhbFBvc2l0aW9uLCB1aW50NjRf
dCBkcmFnZ2luZ1NvdXJjZU9wZXJhdGlvbk1hc2ssIFdURjo6U3RyaW5nIGRyYWdTdG9yYWdlTmFt
ZSwgdWludDMyX3QgZmxhZ3MsIFdlYktpdDo6U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlIHNhbmRi
b3hFeHRlbnNpb25IYW5kbGUsIFdlYktpdDo6U2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlQXJyYXkg
c2FuZGJveEV4dGVuc2lvbnNGb3JVcGxvYWQpCiAjZW5kaWYKKyNpZiBFTkFCTEUoRFJBR19TVVBQ
T1JUKQogICAgIERyYWdFbmRlZChXZWJDb3JlOjpJbnRQb2ludCBjbGllbnRQb3NpdGlvbiwgV2Vi
Q29yZTo6SW50UG9pbnQgZ2xvYmFsUG9zaXRpb24sIHVpbnQ2NF90IG9wZXJhdGlvbikKICNlbmRp
ZgogCg==
</data>
<flag name="review"
          id="152257"
          type_id="1"
          status="+"
          setter="fpizlo"
    />
          </attachment>
      

    </bug>

</bugzilla>