88009 2012-05-31 14:10:06 -0700 Remove some duplicate code in RenderLayerCompositor 2012-05-31 14:21:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser eric simon.fraser webkit.review.bot oldest_to_newest 638706 0 simon.fraser 2012-05-31 14:10:06 -0700 Remove some duplicate code in RenderLayerCompositor 638707 1 145154 simon.fraser 2012-05-31 14:11:30 -0700 Created attachment 145154 Patch 638717 2 simon.fraser 2012-05-31 14:21:43 -0700 http://trac.webkit.org/changeset/119151 145154 2012-05-31 14:11:30 -0700 2012-05-31 14:19:51 -0700 Patch bug-88009-20120531141131.patch text/plain 3236 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzY4YTg5Nzg3NTRmYTRl ZjMwMGFjMTdhOGEyM2NiMzMyM2QxZjg3Yi4uNTA3MmI0MDYyNDQ4Njk3NDdlMzE1YWYxNTljOTRk NThiYzE5NDljYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTMxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBzb21l IGR1cGxpY2F0ZSBjb2RlIGluIFJlbmRlckxheWVyQ29tcG9zaXRvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODgwMDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJMYXllckNvbXBvc2l0b3I6Omhh c05vbkFmZmluZVRyYW5zZm9ybSgpIGhhcyB0aGUgc2FtZSBjb2RlCisgICAgICAgIGFzIHRoZSBl eGlzdGluZyBSZW5kZXJMYXllcjo6aGFzM0RUcmFuc2Zvcm0oKSwgc28ganVzdCB1c2UgdGhlCisg ICAgICAgIFJlbmRlckxheWVyIG1ldGhvZCBhbmQgcmVtb3ZlIGhhc05vbkFmZmluZVRyYW5zZm9y bSgpLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZS4KKyAgICAgICAgCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckNvbXBvc2l0b3I6OmNvbXB1dGVDb21wb3NpdGluZ1JlcXVpcmVtZW50cyk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oOgorICAgICAgICAoUmVu ZGVyTGF5ZXJDb21wb3NpdG9yKToKKwogMjAxMi0wNS0zMSAgRGFuYSBKYW5zZW5zICA8ZGFuYWtq QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIE1vdmUgZHJhd2luZyBjb2RlIGZv ciBSZW5kZXJTdXJmYWNlcyBpbnRvIExheWVyUmVuZGVyZXJDaHJvbWl1bQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCA2YjI2 OWZkYzRlYTYxNjc5MGZjYTFkY2E5OTNjMTFhYjI0MzFhZjVjLi45MTA3ZTk2NjlhNWUwMjY0Yzll YTUyNzUwNDMzZTk3YjQ3YzFjYzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtNzU4LDcgKzc1OCw3IEBAIHZvaWQgUmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpjb21wdXRlQ29tcG9zaXRpbmdSZXF1aXJlbWVudHMoUmVuZGVy TGF5ZXIqIGFuY2VzdG9yCiAgICAgICAgIGlmIChvdmVybGFwTWFwKQogICAgICAgICAgICAgb3Zl cmxhcE1hcC0+cHVzaENvbXBvc2l0aW5nQ29udGFpbmVyKCk7CiAKLSAgICAgICAgaWYgKGhhc05v bkFmZmluZVRyYW5zZm9ybShsYXllci0+cmVuZGVyZXIoKSkgfHwgaXNSdW5uaW5nQWNjZWxlcmF0 ZWRUcmFuc2Zvcm1BbmltYXRpb24obGF5ZXItPnJlbmRlcmVyKCkpKSB7CisgICAgICAgIGlmIChs YXllci0+aGFzM0RUcmFuc2Zvcm0oKSB8fCBpc1J1bm5pbmdBY2NlbGVyYXRlZFRyYW5zZm9ybUFu aW1hdGlvbihsYXllci0+cmVuZGVyZXIoKSkpIHsKICAgICAgICAgICAgIC8vIElmIHdlIGhhdmUg YSAzRCB0cmFuc2Zvcm0sIG9yIGFyZSBhbmltYXRpbmcgdHJhbnNmb3JtLCB0aGVuIHR1cm4gb3Zl cmxhcCB0ZXN0aW5nIG9mZi4KICAgICAgICAgICAgIGNoaWxkU3RhdGUubV90ZXN0aW5nT3Zlcmxh cCA9IGZhbHNlOwogICAgICAgICB9CkBAIC0xNzUwLDE3ICsxNzUwLDYgQEAgYm9vbCBSZW5kZXJM YXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdGb3JQb3NpdGlvbihSZW5kZXJPYmpl Y3QqIHJlbmRlcmUKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotYm9vbCBSZW5kZXJMYXllckNvbXBv c2l0b3I6Omhhc05vbkFmZmluZVRyYW5zZm9ybShSZW5kZXJPYmplY3QqIHJlbmRlcmVyKSBjb25z dAotewotICAgIGlmICghcmVuZGVyZXItPmhhc1RyYW5zZm9ybSgpKQotICAgICAgICByZXR1cm4g ZmFsc2U7Ci0gICAgCi0gICAgaWYgKFRyYW5zZm9ybWF0aW9uTWF0cml4KiB0cmFuc2Zvcm0gPSB0 b1JlbmRlckJveE1vZGVsT2JqZWN0KHJlbmRlcmVyKS0+bGF5ZXIoKS0+dHJhbnNmb3JtKCkpCi0g ICAgICAgIHJldHVybiAhdHJhbnNmb3JtLT5pc0FmZmluZSgpOwotICAgIAotICAgIHJldHVybiBm YWxzZTsKLX0KLQogYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmlzUnVubmluZ0FjY2VsZXJh dGVkVHJhbnNmb3JtQW5pbWF0aW9uKFJlbmRlck9iamVjdCogcmVuZGVyZXIpIGNvbnN0CiB7CiAg ICAgaWYgKCEobV9jb21wb3NpdGluZ1RyaWdnZXJzICYgQ2hyb21lQ2xpZW50OjpBbmltYXRpb25U cmlnZ2VyKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckNvbXBvc2l0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuaAppbmRleCA5ZGYzYTY1NGM2OTQyNWE0ZWI3NWMzZTU1OTRkNGNkYmQzMDBjZTE4Li5i ZTJhNTNlYTQ0ZjA3NmQ5YjI5ZDQwNWEyMDY2Nzk0MTU3NWFkMzcxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCkBAIC0yNjAsNyArMjYw LDYgQEAgcHJpdmF0ZToKICAgICB2b2lkIHJlbW92ZUNvbXBvc2l0ZWRDaGlsZHJlbihSZW5kZXJM YXllciopOwogCiAgICAgYm9vbCBsYXllckhhczNEQ29udGVudChjb25zdCBSZW5kZXJMYXllciop IGNvbnN0OwotICAgIGJvb2wgaGFzTm9uQWZmaW5lVHJhbnNmb3JtKFJlbmRlck9iamVjdCopIGNv bnN0OwogICAgIGJvb2wgaXNSdW5uaW5nQWNjZWxlcmF0ZWRUcmFuc2Zvcm1BbmltYXRpb24oUmVu ZGVyT2JqZWN0KikgY29uc3Q7CiAKICAgICBib29sIGhhc0FueUFkZGl0aW9uYWxDb21wb3NpdGVk TGF5ZXJzKGNvbnN0IFJlbmRlckxheWVyKiByb290TGF5ZXIpIGNvbnN0Owo=