88003 2012-05-31 12:21:57 -0700 Chromium Console.time() and timeEnd() Should Support Async Traces 2012-06-04 16:25:06 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All Unspecified RESOLVED FIXED P4 Minor --- 1 kgr kgr danakj jamesr jbates kgr nduca pfeldman rbyers rniwa webkit.review.bot oldest_to_newest 638632 0 kgr 2012-05-31 12:21:57 -0700 When the Console.time/timerEnd() functions are called on the chromium platform, calls to chrome's TRACE_EVENT methods are called. The versions being called only supported nested synchronous traces and should be switched to the versions that also support asynchronous un-nested traces. 640061 1 145456 kgr 2012-06-02 10:46:26 -0700 Created attachment 145456 Patch 640752 2 145456 nduca 2012-06-04 12:33:41 -0700 Comment on attachment 145456 Patch LGTM. +pfeldman for review. 640772 3 145456 webkit.review.bot 2012-06-04 12:52:22 -0700 Comment on attachment 145456 Patch Clearing flags on attachment: 145456 Committed r119418: <http://trac.webkit.org/changeset/119418> 640773 4 webkit.review.bot 2012-06-04 12:52:26 -0700 All reviewed patches have been landed. Closing bug. 640923 5 danakj 2012-06-04 15:48:32 -0700 This seems to have caused a failure in the browser_tests test GpuFeatureTest.RafNoDamage: [12655:-1597528768:0604/134340:2263335561903:ERROR:trace_event_analyzer.cc(827)] Not enough events: 0 ../../chrome/test/gpu/gpu_feature_browsertest.cc:425: Failure Value of: trace_analyzer::GetRateStats(events, &stats, &stats_options) Actual: false Expected: true [12655:-1597528768:0604/134340:2263335777689:INFO:gpu_feature_browsertest.cc(427)] Number of RAFs: 0 Mean: 6.36069e-307 Min: -1.99068 Max: 2.56952e-256 StdDev: 2.57917e-256 ../../chrome/test/gpu/gpu_feature_browsertest.cc:435: Failure Expected: (stats.mean_us) > (15000.0), actual: 6.36069e-307 vs 15000 I bisected locally to find this change being the cause. 640940 6 rniwa 2012-06-04 16:06:46 -0700 Could you look into this issue? I'm going to roll out the patch I don't hear back from you in the next half an hour or so. 640952 7 jamesr 2012-06-04 16:13:59 -0700 Looks like the chromium-side test should be updated to look for async trace events instead of normal matched ones. Please don't revert, this patch is fine. 640956 8 rniwa 2012-06-04 16:15:44 -0700 (In reply to comment #7) > Looks like the chromium-side test should be updated to look for async trace events instead of normal matched ones. > > Please don't revert, this patch is fine. Okay. Could you make that change? I have no idea what this test is testing, and don't know how to do that. 640963 9 jbates 2012-06-04 16:21:58 -0700 Fix on the way: https://code.google.com/p/chromium/issues/detail?id=131097 640965 10 rniwa 2012-06-04 16:25:06 -0700 (In reply to comment #9) > Fix on the way: > https://code.google.com/p/chromium/issues/detail?id=131097 Great! Thank you. 145456 2012-06-02 10:46:26 -0700 2012-06-04 12:52:22 -0700 Patch bug-88003-20120602134625.patch text/plain 1401 kgr SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDExOTMy MykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2 LTAyICBLZXZpbiBHcmVlciAgPGtnckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVt XSBJc3N1ZSBhc3luYyBldmVudHMgZm9yIGNvbnNvbGUudGltZS90aW1lRW5kCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODAwMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogLi4vLi4vU291cmNlL1dlYkNv cmUvcGFnZS9Db25zb2xlLmNwcDoKKwogMjAxMi0wNi0wMSAgU2ltb24gSGF1c21hbm4gIDxzaW1v bi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBVc2UgLVdlcnJvciBvbmx5IGlu IGRldmVsb3BlciBidWlsZHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAkocmV2aXNpb24g MTE5MTQ5KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzEwLDE0ICszMTAsMTQgQEAgdm9pZCBDb25zb2xlOjp0aW1lKGNvbnN0IFN0cmluZyYg dGl0bGUpCiB7CiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpzdGFydENvbnNvbGVUaW1p bmcocGFnZSgpLCB0aXRsZSk7CiAjaWYgUExBVEZPUk0oQ0hST01JVU0pCi0gICAgVFJBQ0VfRVZF TlRfQ09QWV9CRUdJTjAoIndlYmtpdCIsIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOworICAgIFRSQUNF X0VWRU5UX0NPUFlfQVNZTkNfQkVHSU4wKCJ3ZWJraXQiLCB0aXRsZS51dGY4KCkuZGF0YSgpLCB0 aGlzKTsKICNlbmRpZgogfQogCiB2b2lkIENvbnNvbGU6OnRpbWVFbmQoUGFzc1JlZlB0cjxTY3Jp cHRBcmd1bWVudHM+LCBQYXNzUmVmUHRyPFNjcmlwdENhbGxTdGFjaz4gY2FsbFN0YWNrLCBjb25z dCBTdHJpbmcmIHRpdGxlKQogewogI2lmIFBMQVRGT1JNKENIUk9NSVVNKQotICAgIFRSQUNFX0VW RU5UX0NPUFlfRU5EMCgid2Via2l0IiwgdGl0bGUudXRmOCgpLmRhdGEoKSk7CisgICAgVFJBQ0Vf RVZFTlRfQ09QWV9BU1lOQ19FTkQwKCJ3ZWJraXQiLCB0aXRsZS51dGY4KCkuZGF0YSgpLCB0aGlz KTsKICNlbmRpZgogICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6c3RvcENvbnNvbGVUaW1p bmcocGFnZSgpLCB0aXRsZSwgY2FsbFN0YWNrKTsKIH0K