87999 2012-05-31 11:45:33 -0700 [Qt][W2] Qml Error in ViewportInfoItem.qml in MiniBrowser 2012-06-01 05:27:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob webkit-unassigned cmarcelo kenneth menard webkit.review.bot zoltan oldest_to_newest 638605 0 dinu.jacob 2012-05-31 11:45:33 -0700 qrc:///qml/ViewportInfoItem.qml:28: TypeError: Cannot call method 'toFixed' of undefined qrc:///qml/ViewportInfoItem.qml:35: TypeError: Cannot call method 'toFixed' of undefined qrc:///qml/ViewportInfoItem.qml:42: TypeError: Cannot call method 'toFixed' of undefined qrc:///qml/ViewportInfoItem.qml:49: TypeError: Cannot call method 'toFixed' of undefined qrc:///qml/ViewportInfoItem.qml:57: TypeError: Cannot call method 'toFixed' of undefined qrc:///qml/ViewportInfoItem.qml:71: TypeError: Cannot read property 'width' of undefine 638609 1 dinu.jacob 2012-05-31 11:48:04 -0700 QWebKitTest methods return invalid QVariant initially and attempt to call toFixed on those results in the error seen. It would be better to return some default values than invalid. 638611 2 145125 dinu.jacob 2012-05-31 11:49:00 -0700 Created attachment 145125 patch 639187 3 145125 abecsi 2012-06-01 04:26:47 -0700 Comment on attachment 145125 patch View in context: https://bugs.webkit.org/attachment.cgi?id=145125&action=review > Source/WebKit2/UIProcess/API/qt/qwebkittest.cpp:160 > QVariant QWebKitTest::isScalable() const > { > if (QtViewportInteractionEngine* viewport = m_webViewPrivate->viewportInteractionEngine()) > return !!viewport->m_rawAttributes.userScalable; > - return QVariant(); > + return true; Shouldn't the default be false here? 639190 4 145125 kenneth 2012-06-01 04:28:50 -0700 Comment on attachment 145125 patch View in context: https://bugs.webkit.org/attachment.cgi?id=145125&action=review >> Source/WebKit2/UIProcess/API/qt/qwebkittest.cpp:160 >> + return true; > > Shouldn't the default be false here? Good point 639194 5 dinu.jacob 2012-06-01 04:35:19 -0700 (In reply to comment #4) > (From update of attachment 145125 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145125&action=review > > >> Source/WebKit2/UIProcess/API/qt/qwebkittest.cpp:160 > >> + return true; > > > > Shouldn't the default be false here? > > Good point I will change it. Shouldn't user-scalable set to false explicitly though (isn't it treated as user-scalable true if it is not added explicitly? ) 639197 6 dinu.jacob 2012-06-01 04:39:44 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 145125 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=145125&action=review > > > > >> Source/WebKit2/UIProcess/API/qt/qwebkittest.cpp:160 > > >> + return true; > > > > > > Shouldn't the default be false here? > > > > Good point > > I will change it. Shouldn't user-scalable set to false explicitly though (isn't it treated as user-scalable true if it is not added explicitly? ) Sorry, ignore my comment - I thought I had set it to false :( :( 639217 7 145125 webkit.review.bot 2012-06-01 05:27:08 -0700 Comment on attachment 145125 patch Clearing flags on attachment: 145125 Committed r119218: <http://trac.webkit.org/changeset/119218> 639218 8 webkit.review.bot 2012-06-01 05:27:13 -0700 All reviewed patches have been landed. Closing bug. 145125 2012-05-31 11:49:00 -0700 2012-06-01 05:27:08 -0700 patch 87999.patch text/plain 2863 dinu.jacob ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1Njg0YzNiLi4xOGU1YjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDUtMzEgIERpbnUgSmFjb2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAg ICAgICBbUXRdW1cyXSBRbWwgRXJyb3IgaW4gVmlld3BvcnRJbmZvSXRlbS5xbWwgaW4gTWluaUJy b3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3 OTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0 dXJuIGRlZmF1bHQgdmlld3BvcnQgYXR0cmlidXRlcyByYXRoZXIgdGhhbiBpbnZhbGlkIFFWYXJp YW50LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2Via2l0dGVzdC5jcHA6CisgICAg ICAgIChRV2ViS2l0VGVzdDo6Y29udGVudHNTY2FsZSk6CisgICAgICAgIChRV2ViS2l0VGVzdDo6 ZGV2aWNlUGl4ZWxSYXRpbyk6CisgICAgICAgIChRV2ViS2l0VGVzdDo6aW5pdGlhbFNjYWxlKToK KyAgICAgICAgKFFXZWJLaXRUZXN0OjptaW5pbXVtU2NhbGUpOgorICAgICAgICAoUVdlYktpdFRl c3Q6Om1heGltdW1TY2FsZSk6CisgICAgICAgIChRV2ViS2l0VGVzdDo6aXNTY2FsYWJsZSk6Cisg ICAgICAgIChRV2ViS2l0VGVzdDo6bGF5b3V0U2l6ZSk6CisKIDIwMTItMDUtMzAgIEx1aXogQWdv c3RpbmkgIDxsdWl6LmFnb3N0aW5pQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIGhhbmRsZWQg dG91Y2htb3ZlIGV2ZW50cyBzaG91bGQgbm90IGNhbmNlbCB0YXAgZ2VzdHVyZSByZWNvZ25pdGlv bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2Via2l0dGVz dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJraXR0ZXN0LmNwcApp bmRleCBlMGE0NDFjLi5kZWRhNjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F3ZWJraXR0ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3F3ZWJraXR0ZXN0LmNwcApAQCAtMTIyLDQ3ICsxMjIsNDcgQEAgUVZhcmlhbnQgUVdl YktpdFRlc3Q6OmNvbnRlbnRzU2NhbGUoKSBjb25zdAogewogICAgIGlmIChRdFZpZXdwb3J0SW50 ZXJhY3Rpb25FbmdpbmUqIHZpZXdwb3J0ID0gbV93ZWJWaWV3UHJpdmF0ZS0+dmlld3BvcnRJbnRl cmFjdGlvbkVuZ2luZSgpKQogICAgICAgICByZXR1cm4gdmlld3BvcnQtPmN1cnJlbnRDU1NTY2Fs ZSgpOwotICAgIHJldHVybiBRVmFyaWFudCgpOworICAgIHJldHVybiAxLjA7CiB9CiAKIFFWYXJp YW50IFFXZWJLaXRUZXN0OjpkZXZpY2VQaXhlbFJhdGlvKCkgY29uc3QKIHsKICAgICBpZiAoUXRW aWV3cG9ydEludGVyYWN0aW9uRW5naW5lKiB2aWV3cG9ydCA9IG1fd2ViVmlld1ByaXZhdGUtPnZp ZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoKSkKICAgICAgICAgcmV0dXJuIHZpZXdwb3J0LT5tX2Rl dmljZVBpeGVsUmF0aW87Ci0gICAgcmV0dXJuIFFWYXJpYW50KCk7CisgICAgcmV0dXJuIDEuMDsK IH0KIAogUVZhcmlhbnQgUVdlYktpdFRlc3Q6OmluaXRpYWxTY2FsZSgpIGNvbnN0CiB7CiAgICAg aWYgKFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSogdmlld3BvcnQgPSBtX3dlYlZpZXdQcml2 YXRlLT52aWV3cG9ydEludGVyYWN0aW9uRW5naW5lKCkpCiAgICAgICAgIHJldHVybiB2aWV3cG9y dC0+bV9yYXdBdHRyaWJ1dGVzLmluaXRpYWxTY2FsZTsKLSAgICByZXR1cm4gUVZhcmlhbnQoKTsK KyAgICByZXR1cm4gMS4wOwogfQogCiBRVmFyaWFudCBRV2ViS2l0VGVzdDo6bWluaW11bVNjYWxl KCkgY29uc3QKIHsKICAgICBpZiAoUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lKiB2aWV3cG9y dCA9IG1fd2ViVmlld1ByaXZhdGUtPnZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoKSkKICAgICAg ICAgcmV0dXJuIHZpZXdwb3J0LT5tX21pbmltdW1TY2FsZTsKLSAgICByZXR1cm4gUVZhcmlhbnQo KTsKKyAgICByZXR1cm4gMS4wOwogfQogCiBRVmFyaWFudCBRV2ViS2l0VGVzdDo6bWF4aW11bVNj YWxlKCkgY29uc3QKIHsKICAgICBpZiAoUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lKiB2aWV3 cG9ydCA9IG1fd2ViVmlld1ByaXZhdGUtPnZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoKSkKICAg ICAgICAgcmV0dXJuIHZpZXdwb3J0LT5tX21heGltdW1TY2FsZTsKLSAgICByZXR1cm4gUVZhcmlh bnQoKTsKKyAgICByZXR1cm4gMS4wOwogfQogCiBRVmFyaWFudCBRV2ViS2l0VGVzdDo6aXNTY2Fs YWJsZSgpIGNvbnN0CiB7CiAgICAgaWYgKFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSogdmll d3BvcnQgPSBtX3dlYlZpZXdQcml2YXRlLT52aWV3cG9ydEludGVyYWN0aW9uRW5naW5lKCkpCiAg ICAgICAgIHJldHVybiAhIXZpZXdwb3J0LT5tX3Jhd0F0dHJpYnV0ZXMudXNlclNjYWxhYmxlOwot ICAgIHJldHVybiBRVmFyaWFudCgpOworICAgIHJldHVybiB0cnVlOwogfQogCiBRVmFyaWFudCBR V2ViS2l0VGVzdDo6bGF5b3V0U2l6ZSgpIGNvbnN0CiB7CiAgICAgaWYgKFF0Vmlld3BvcnRJbnRl cmFjdGlvbkVuZ2luZSogdmlld3BvcnQgPSBtX3dlYlZpZXdQcml2YXRlLT52aWV3cG9ydEludGVy YWN0aW9uRW5naW5lKCkpCiAgICAgICAgIHJldHVybiBRU2l6ZUYodmlld3BvcnQtPm1fcmF3QXR0 cmlidXRlcy5sYXlvdXRTaXplKTsKLSAgICByZXR1cm4gUVZhcmlhbnQoKTsKKyAgICByZXR1cm4g UVNpemVGKCk7CiB9Cg==