87997 2012-05-31 11:37:46 -0700 Vector should have a move constructor and move assignment operator 2012-05-31 12:12:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 638598 0 andersca 2012-05-31 11:37:46 -0700 Vector should have a move constructor and move assignment operator 638600 1 145122 andersca 2012-05-31 11:39:28 -0700 Created attachment 145122 Patch 638604 2 webkit.review.bot 2012-05-31 11:44:01 -0700 Attachment 145122 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Co..." exit_code: 1 Source/WTF/wtf/Vector.h:522: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/Vector.h:523: Missing spaces around && [whitespace/operators] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 638625 3 145122 kling 2012-05-31 12:11:40 -0700 Comment on attachment 145122 Patch Wild! 638627 4 andersca 2012-05-31 12:12:56 -0700 Committed r119132: <http://trac.webkit.org/changeset/119132> 145122 2012-05-31 11:39:28 -0700 2012-05-31 12:11:39 -0700 Patch bug-87997-20120531113928.patch text/plain 3412 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDg1ZjNiOWIwNGQzZDY0Zjk1OWU3YjAz N2RkYTQ0OGZmYmVjNWIzNWMuLjFjMTAxNDU5ZGYzNzk3NWQ2NzE1MTgwNGU0MDY4ZjViNWIzYTRk NmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMzEgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBWZWN0b3Igc2hvdWxkIGhhdmUgYSBtb3ZlIGNv bnN0cnVjdG9yIGFuZCBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvQ29tcGlsZXIuaDoKKyAgICAgICAg VXNlIF9faGFzX2V4dGVuc2lvbiBzbyB3ZSBjYW4gdXNlIG1vdmUgc2VtYW50aWNzIGFuZCBvdGhl ciBDKysxMSBmZWF0dXJlcyBldmVuIHdoZW4gYnVpbGRpbmcgYXMgQysrOTguCisgICAgICAgIAor ICAgICAgICAqIHd0Zi9WZWN0b3IuaDoKKyAgICAgICAgQWRkIGEgbW92ZSBjb25zdHJ1Y3RvciBh bmQgYSBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3IgdG8gVmVjdG9yLgorCiAyMDEyLTA1LTMxICBU b3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdIFNpbXBsaWZ5IFFUX1ZFUlNJT05fQ0hFQ0tTIGZvciBRdDUgYnkgaW50cm9kdWNpbmcgSEFW RShRVDUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oIGIvU291cmNlL1dU Ri93dGYvQ29tcGlsZXIuaAppbmRleCA5NjM3ZGMwYmM5NjFkMWJkOTljNWIxNmI5OWE4YmQ3NTNh YWI4ZTE0Li5iNmUxYzgxMWJlZmFmMjU1NzBkODAzMjNlMzIwZDQzMGU0ZmMxOGQwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0NvbXBp bGVyLmgKQEAgLTQ4LDkgKzQ4LDkgQEAKICNkZWZpbmUgQ0xBTkdfUFJBR01BKFBSQUdNQSkgX1By YWdtYShQUkFHTUEpCiAKIC8qIFNwZWNpZmljIGNvbXBpbGVyIGZlYXR1cmVzICovCi0jZGVmaW5l IFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfVkFSSUFESUNfVEVNUExBVEVTIF9faGFzX2ZlYXR1 cmUoY3h4X3ZhcmlhZGljX3RlbXBsYXRlcykKLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRT X0NYWF9SVkFMVUVfUkVGRVJFTkNFUyBfX2hhc19mZWF0dXJlKGN4eF9ydmFsdWVfcmVmZXJlbmNl cykKLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NYWF9ERUxFVEVEX0ZVTkNUSU9OUyBf X2hhc19mZWF0dXJlKGN4eF9kZWxldGVkX2Z1bmN0aW9ucykKKyNkZWZpbmUgV1RGX0NPTVBJTEVS X1NVUFBPUlRTX0NYWF9WQVJJQURJQ19URU1QTEFURVMgX19oYXNfZXh0ZW5zaW9uKGN4eF92YXJp YWRpY190ZW1wbGF0ZXMpCisjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfUlZBTFVF X1JFRkVSRU5DRVMgX19oYXNfZXh0ZW5zaW9uKGN4eF9ydmFsdWVfcmVmZXJlbmNlcykKKyNkZWZp bmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NYWF9ERUxFVEVEX0ZVTkNUSU9OUyBfX2hhc19leHRl bnNpb24oY3h4X2RlbGV0ZWRfZnVuY3Rpb25zKQogI2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9S VFNfQ1hYX05VTExQVFIgX19oYXNfZmVhdHVyZShjeHhfbnVsbHB0cikKICNkZWZpbmUgV1RGX0NP TVBJTEVSX1NVUFBPUlRTX0JMT0NLUyBfX2hhc19mZWF0dXJlKGJsb2NrcykKICNkZWZpbmUgV1RG X0NPTVBJTEVSX1NVUFBPUlRTX0NfU1RBVElDX0FTU0VSVCBfX2hhc19leHRlbnNpb24oY19zdGF0 aWNfYXNzZXJ0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVmVjdG9yLmggYi9Tb3VyY2Uv V1RGL3d0Zi9WZWN0b3IuaAppbmRleCA2ZTZiNWEwODI5ZWQ0ZTg4ODgyYmIwMWQ5ODBhMGNiMzk5 ZGIyMjM5Li5hM2I2YTBlNjI5YTNjZjNiMWY2OTRkMzg3OTk1YjY4NzJmOTVkOTRkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3IuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9WZWN0b3Iu aApAQCAtNTE4LDYgKzUxOCwxMSBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgdGVtcGxhdGU8 c2l6ZV90IG90aGVyQ2FwYWNpdHk+IAogICAgICAgICBWZWN0b3ImIG9wZXJhdG9yPShjb25zdCBW ZWN0b3I8VCwgb3RoZXJDYXBhY2l0eT4mKTsKIAorI2lmIENPTVBJTEVSX1NVUFBPUlRTKENYWF9S VkFMVUVfUkVGRVJFTkNFUykKKyAgICAgICAgVmVjdG9yKFZlY3RvciYmKTsKKyAgICAgICAgVmVj dG9yJiBvcGVyYXRvcj0oVmVjdG9yJiYpOworI2VuZGlmCisKICAgICAgICAgc2l6ZV90IHNpemUo KSBjb25zdCB7IHJldHVybiBtX3NpemU7IH0KICAgICAgICAgc2l6ZV90IGNhcGFjaXR5KCkgY29u c3QgeyByZXR1cm4gbV9idWZmZXIuY2FwYWNpdHkoKTsgfQogICAgICAgICBib29sIGlzRW1wdHko KSBjb25zdCB7IHJldHVybiAhc2l6ZSgpOyB9CkBAIC03NTksNiArNzY0LDI0IEBAIG5hbWVzcGFj ZSBXVEYgewogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogCisjaWYgQ09NUElMRVJfU1VQ UE9SVFMoQ1hYX1JWQUxVRV9SRUZFUkVOQ0VTKQorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNp emVfdCBpbmxpbmVDYXBhY2l0eT4KKyAgICBWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHk+OjpWZWN0 b3IoVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5PiYmIG90aGVyKQorICAgICAgICA6IG1fc2l6ZSgw KQorICAgIHsKKyAgICAgICAgLy8gSXQncyBhIGxpdHRsZSB3ZWlyZCB0byBpbXBsZW1lbnQgYSBt b3ZlIGNvbnN0cnVjdG9yIHVzaW5nIHN3YXAgYnV0IHRoaXMgd2F5IHdlCisgICAgICAgIC8vIGRv bid0IGhhdmUgdG8gYWRkIGEgbW92ZSBjb25zdHJ1Y3RvciB0byBWZWN0b3JCdWZmZXIuCisgICAg ICAgIHN3YXAob3RoZXIpOworICAgIH0KKworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVf dCBpbmxpbmVDYXBhY2l0eT4KKyAgICBWZWN0b3I8VCwgaW5saW5lQ2FwYWNpdHk+JiBWZWN0b3I8 VCwgaW5saW5lQ2FwYWNpdHk+OjpvcGVyYXRvcj0oVmVjdG9yPFQsIGlubGluZUNhcGFjaXR5PiYm IG90aGVyKQorICAgIHsKKyAgICAgICAgc3dhcChvdGhlcik7CisgICAgICAgIHJldHVybiAqdGhp czsKKyAgICB9CisjZW5kaWYKKwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxp bmVDYXBhY2l0eT4KICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPgogICAgIGJvb2wgVmVjdG9yPFQs IGlubGluZUNhcGFjaXR5Pjo6Y29udGFpbnMoY29uc3QgVSYgdmFsdWUpIGNvbnN0Cg==