87992 2012-05-31 11:06:57 -0700 [BlackBerry] Crash in InputHandler - uninit variable 2012-05-31 12:30:56 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos tonikitoo webkit.review.bot oldest_to_newest 638577 0 staikos 2012-05-31 11:06:57 -0700 #0 WebCore::SelectPopupClient::update (this=0x2b64696c, multiple=false, size=14, labels=..., enableds=0x1503398, itemType=0x1158680, selecteds=0x1503338, element=0x151d2c0) #1 0x791a1c3e in BlackBerry::WebKit::InputHandler::openSelectPopup ( this=0xf57050, select=0x151d2c0) The select popup client is not initialized. Crashes the tests among others. 638585 1 145119 staikos 2012-05-31 11:18:23 -0700 Created attachment 145119 Patch to fix the crash 638592 2 145119 rwlbuis 2012-05-31 11:21:57 -0700 Comment on attachment 145119 Patch to fix the crash LGTM. 638639 3 145119 webkit.review.bot 2012-05-31 12:30:52 -0700 Comment on attachment 145119 Patch to fix the crash Clearing flags on attachment: 145119 Committed r119134: <http://trac.webkit.org/changeset/119134> 638640 4 webkit.review.bot 2012-05-31 12:30:56 -0700 All reviewed patches have been landed. Closing bug. 145119 2012-05-31 11:18:23 -0700 2012-05-31 12:30:52 -0700 Patch to fix the crash inputhandler.patch text/plain 1483 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTE5MTI3KQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA1LTMxICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQmxhY2tiZXJyeV0gSW5pdGlhbGl6ZSB0aGUgc2VsZWN0IGNsaWVudCBh bmQgZGVsZXRlIHRoZSBwb2ludGVyCisgICAgICAgIGluIHRoZSBkZXN0cnVjdG9yIHNvIGl0IGRv ZXNuJ3QgbGVhay4gIEZpeGVzIHRlc3QgY3Jhc2hlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6SW5wdXRIYW5kbGVy KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjp+SW5wdXRIYW5k bGVyKToKKwogMjAxMi0wNS0zMSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAK ICAgICAgICAgW0JsYWNrQmVycnldIENyYXNoIHdoZW4gZGVzdHJveWluZyBXZWJPdmVybGF5IHdp dGggYWN0aXZlIFdlYk92ZXJsYXlPdmVycmlkZQpJbmRleDogU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCShyZXZpc2lv biAxMTkxMjQpCisrKyBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1 dEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjAsMTEgKzEyMCwxMyBAQCBJbnB1dEhh bmRsZXI6OklucHV0SGFuZGxlcihXZWJQYWdlUHJpdmF0CiAgICAgLCBtX2NvbXBvc2luZ1RleHRF bmQoMCkKICAgICAsIG1fcGVuZGluZ0tleWJvYXJkVmlzaWJpbGl0eUNoYW5nZShOb0NoYW5nZSkK ICAgICAsIG1fZGVsYXlLZXlib2FyZFZpc2liaWxpdHlDaGFuZ2UoZmFsc2UpCisgICAgLCBtX3Nl bGVjdENsaWVudCgwKQogewogfQogCiBJbnB1dEhhbmRsZXI6On5JbnB1dEhhbmRsZXIoKQogewor ICAgIGRlbGV0ZSBtX3NlbGVjdENsaWVudDsKIH0KIAogc3RhdGljIEJsYWNrQmVycnlJbnB1dFR5 cGUgY29udmVydElucHV0VHlwZShjb25zdCBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dEVsZW1lbnQp Cg==