87968 2012-05-31 06:25:11 -0700 [BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride 2012-05-31 11:09:54 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 638326 0 anilsson 2012-05-31 06:25:11 -0700 The override object is using a compositing thread WebOverlayPrivate object with no client because the layer doesn't delegate drawing to the WebOverlayPrivate, it's only used to modify the override properties on the underlying compositing thread layer. 638333 1 145077 anilsson 2012-05-31 06:30:12 -0700 Created attachment 145077 Patch 638355 2 145077 rwlbuis 2012-05-31 06:51:02 -0700 Comment on attachment 145077 Patch Looks good. 638578 3 145077 webkit.review.bot 2012-05-31 11:09:50 -0700 Comment on attachment 145077 Patch Clearing flags on attachment: 145077 Committed r119126: <http://trac.webkit.org/changeset/119126> 638579 4 webkit.review.bot 2012-05-31 11:09:54 -0700 All reviewed patches have been landed. Closing bug. 145077 2012-05-31 06:30:12 -0700 2012-05-31 11:09:49 -0700 Patch bug-87968-20120531153009.patch text/plain 4061 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlYmJjNzcxYzI5YWNiMTU3NTg1MGQ0ZGEzNGIxYjRiNDEyM2U1MTczLi40Zjk2YTVkMWE3 MjgxYzE4ZWViMzA5ZjljOWE1YTI3M2RjNDg0NGJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyOCBAQAogMjAxMi0wNS0zMSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIENyYXNoIHdoZW4gZGVzdHJveWlu ZyBXZWJPdmVybGF5IHdpdGggYWN0aXZlIFdlYk92ZXJsYXlPdmVycmlkZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc5NjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb3ZlcnJpZGUgb2JqZWN0IGlz IHVzaW5nIGEgY29tcG9zaXRpbmcgdGhyZWFkIFdlYk92ZXJsYXlQcml2YXRlCisgICAgICAgIG9i amVjdCB3aXRoIG5vIGNsaWVudCBiZWNhdXNlIHRoZSBsYXllciBkb2Vzbid0IGRlbGVnYXRlIGRy YXdpbmcgdG8gdGhlCisgICAgICAgIFdlYk92ZXJsYXlQcml2YXRlLCBpdCdzIG9ubHkgdXNlZCB0 byBtb2RpZnkgdGhlIG92ZXJyaWRlIHByb3BlcnRpZXMgb24KKyAgICAgICAgdGhlIHVuZGVybHlp bmcgY29tcG9zaXRpbmcgdGhyZWFkIGxheWVyLgorCisgICAgICAgIFNpbmNlIHRoZSBtX2xheWVy Q29tcG9zaXRpbmdUaHJlYWRDbGllbnQgaXMgb3B0aW9uYWwsIHdlIGhhdmUgdG8gYWRkCisgICAg ICAgIG51bGwgY2hlY2tzLgorCisgICAgICAgICogQXBpL1dlYk92ZXJsYXkuY3BwOgorICAgICAg ICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJPdmVybGF5UHJpdmF0ZUNvbXBvc2l0aW5nVGhyZWFk Ojp+V2ViT3ZlcmxheVByaXZhdGVDb21wb3NpdGluZ1RocmVhZCk6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OldlYk92ZXJsYXlQcml2YXRlQ29tcG9zaXRpbmdUaHJlYWQ6OnNldENsaWVu dCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYk92ZXJsYXlQcml2YXRlQ29tcG9z aXRpbmdUaHJlYWQ6OnNldENvbnRlbnRzVG9JbWFnZSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OldlYk92ZXJsYXlQcml2YXRlQ29tcG9zaXRpbmdUaHJlYWQ6OnNldENvbnRlbnRzVG9D b2xvcik6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYk92ZXJsYXlQcml2YXRlQ29t cG9zaXRpbmdUaHJlYWQ6OnNldERyYXdzQ29udGVudCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OldlYk92ZXJsYXlQcml2YXRlQ29tcG9zaXRpbmdUaHJlYWQ6OmludmFsaWRhdGUpOgor CisyMDEyLTA1LTMxICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKwogICAgICAg ICBbQmxhY2tCZXJyeV0gQ3Jhc2ggd2hlbiBjbG9zaW5nIHdlYiBwYWdlIGlmIHNlbGVjdGlvbiBp cyBhY3RpdmUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg3OTYyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViT3Zl cmxheS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYk92ZXJsYXkuY3BwCmlu ZGV4IGYyZjhkYjJiYWIwN2ViNWE1ZTc0YTc2YmEyNWNlMDJlMjQ2OTM2NGUuLmY4YmRiZWFkNDI4 ODljMzE1OWM5NGQ3OTg2M2Q5YTgxNjBlMDM1M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViT3ZlcmxheS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJPdmVybGF5LmNwcApAQCAtNDkzLDEzICs0OTMsMTUgQEAgV2ViT3ZlcmxheVBy aXZhdGVDb21wb3NpdGluZ1RocmVhZDo6V2ViT3ZlcmxheVByaXZhdGVDb21wb3NpdGluZ1RocmVh ZCgpCiAKIFdlYk92ZXJsYXlQcml2YXRlQ29tcG9zaXRpbmdUaHJlYWQ6On5XZWJPdmVybGF5UHJp dmF0ZUNvbXBvc2l0aW5nVGhyZWFkKCkKIHsKLSAgICBtX2xheWVyQ29tcG9zaXRpbmdUaHJlYWRD bGllbnQtPnNldENsaWVudCgwLCAwKTsKKyAgICBpZiAobV9sYXllckNvbXBvc2l0aW5nVGhyZWFk Q2xpZW50KQorICAgICAgICBtX2xheWVyQ29tcG9zaXRpbmdUaHJlYWRDbGllbnQtPnNldENsaWVu dCgwLCAwKTsKIH0KIAogdm9pZCBXZWJPdmVybGF5UHJpdmF0ZUNvbXBvc2l0aW5nVGhyZWFkOjpz ZXRDbGllbnQoV2ViT3ZlcmxheUNsaWVudCogY2xpZW50KQogewogICAgIFdlYk92ZXJsYXlQcml2 YXRlOjpzZXRDbGllbnQoY2xpZW50KTsKLSAgICBtX2xheWVyQ29tcG9zaXRpbmdUaHJlYWRDbGll bnQtPnNldENsaWVudChxLCBjbGllbnQpOworICAgIGlmIChtX2xheWVyQ29tcG9zaXRpbmdUaHJl YWRDbGllbnQpCisgICAgICAgIG1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENsaWVudC0+c2V0Q2xp ZW50KHEsIGNsaWVudCk7CiB9CiAKIFdlYk92ZXJsYXlPdmVycmlkZSogV2ViT3ZlcmxheVByaXZh dGVDb21wb3NpdGluZ1RocmVhZDo6b3ZlcnJpZGUoKQpAQCAtNjE0LDYgKzYxNiw5IEBAIHZvaWQg V2ViT3ZlcmxheVByaXZhdGVDb21wb3NpdGluZ1RocmVhZDo6cmVtb3ZlRnJvbVBhcmVudCgpCiAK IHZvaWQgV2ViT3ZlcmxheVByaXZhdGVDb21wb3NpdGluZ1RocmVhZDo6c2V0Q29udGVudHNUb0lt YWdlKGNvbnN0IHVuc2lnbmVkIGNoYXIqIGRhdGEsIGNvbnN0IEludFNpemUmIGltYWdlU2l6ZSkK IHsKKyAgICBpZiAoIW1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENsaWVudCkKKyAgICAgICAgcmV0 dXJuOworCiAgICAgY29uc3QgU2tCaXRtYXAmIG9sZENvbnRlbnRzID0gbV9sYXllckNvbXBvc2l0 aW5nVGhyZWFkQ2xpZW50LT5jb250ZW50cygpOwogICAgIGlmICghb2xkQ29udGVudHMuaXNOdWxs KCkpIHsKICAgICAgICAgU2tBdXRvTG9ja1BpeGVscyBsb2NrKG9sZENvbnRlbnRzKTsKQEAgLTYz MSwxMiArNjM2LDE4IEBAIHZvaWQgV2ViT3ZlcmxheVByaXZhdGVDb21wb3NpdGluZ1RocmVhZDo6 c2V0Q29udGVudHNUb0ltYWdlKGNvbnN0IHVuc2lnbmVkIGNoYXIqCiAKIHZvaWQgV2ViT3Zlcmxh eVByaXZhdGVDb21wb3NpdGluZ1RocmVhZDo6c2V0Q29udGVudHNUb0NvbG9yKGNvbnN0IENvbG9y JiBjb2xvcikKIHsKKyAgICBpZiAoIW1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENsaWVudCkKKyAg ICAgICAgcmV0dXJuOworCiAgICAgbV9sYXllckNvbXBvc2l0aW5nVGhyZWFkQ2xpZW50LT5zZXRD b250ZW50c1RvQ29sb3IoY29sb3IpOwogICAgIG1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZC0+c2V0 TmVlZHNUZXh0dXJlKHRydWUpOwogfQogCiB2b2lkIFdlYk92ZXJsYXlQcml2YXRlQ29tcG9zaXRp bmdUaHJlYWQ6OnNldERyYXdzQ29udGVudChib29sIGRyYXdzQ29udGVudCkKIHsKKyAgICBpZiAo IW1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENsaWVudCkKKyAgICAgICAgcmV0dXJuOworCiAgICAg bV9sYXllckNvbXBvc2l0aW5nVGhyZWFkQ2xpZW50LT5zZXREcmF3c0NvbnRlbnQoZHJhd3NDb250 ZW50KTsKICAgICBtX2xheWVyQ29tcG9zaXRpbmdUaHJlYWQtPnNldE5lZWRzVGV4dHVyZSh0cnVl KTsKIH0KQEAgLTY0OCw3ICs2NTksNyBAQCB2b2lkIFdlYk92ZXJsYXlQcml2YXRlQ29tcG9zaXRp bmdUaHJlYWQ6OmNsZWFyKCkKIAogdm9pZCBXZWJPdmVybGF5UHJpdmF0ZUNvbXBvc2l0aW5nVGhy ZWFkOjppbnZhbGlkYXRlKCkKIHsKLSAgICBpZiAoIW1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENs aWVudC0+ZHJhd3NDb250ZW50KCkpCisgICAgaWYgKCFtX2xheWVyQ29tcG9zaXRpbmdUaHJlYWRD bGllbnQgfHwgIW1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENsaWVudC0+ZHJhd3NDb250ZW50KCkp CiAgICAgICAgIHJldHVybjsKIAogICAgIG1fbGF5ZXJDb21wb3NpdGluZ1RocmVhZENsaWVudC0+ aW52YWxpZGF0ZSgpOwo=