87957 2012-05-31 05:11:12 -0700 [GTK] Add webkit_download_get_request to WebKit2 GTK+ API 2012-05-31 08:32:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot oldest_to_newest 638256 0 cgarcia 2012-05-31 05:11:12 -0700 Also present in wk1 it's useful to get the request that originated the download. 638259 1 145054 cgarcia 2012-05-31 05:13:20 -0700 Created attachment 145054 Patch 638261 2 webkit.review.bot 2012-05-31 05:16:43 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 638450 3 cgarcia 2012-05-31 08:32:15 -0700 Committed r119108: <http://trac.webkit.org/changeset/119108> 145054 2012-05-31 05:13:20 -0700 2012-05-31 06:17:00 -0700 Patch wk2-download-request.diff text/plain 5896 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1Njg0YzNiLi44YzBmNjk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDUtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCB3ZWJraXRfZG93bmxvYWRfZ2V0X3JlcXVlc3QgdG8gV2Vi S2l0MiBHVEsrIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODc5NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcDoKKyAgICAgICAgKHdl YmtpdF9kb3dubG9hZF9nZXRfcmVxdWVzdCk6IFJldHVybiB0aGUgV2ViS2l0VVJJUmVxdWVzdAor ICAgICAgICByZXByZXNlbnRpbmcgdGhlIHJlcXVlc3QgdGhhdCBvcmlnaW5hdGVkIHRoZSBkb3du bG9hZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5oOgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQ6IEFk ZCBuZXcgc3ltYm9sLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3REb3du bG9hZHMuY3BwOgorICAgICAgICAodGVzdERvd25sb2FkTG9jYWxGaWxlKToKKyAgICAgICAgKHRl c3REb3dubG9hZFJlbW90ZUZpbGUpOgorCiAyMDEyLTA1LTMwICBMdWl6IEFnb3N0aW5pICA8bHVp ei5hZ29zdGluaUBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBoYW5kbGVkIHRvdWNobW92ZSBl dmVudHMgc2hvdWxkIG5vdCBjYW5jZWwgdGFwIGdlc3R1cmUgcmVjb2duaXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcAppbmRl eCAwMThmMDhkLi42MWQzMTZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXREb3dubG9hZC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuY3BwCkBAIC0yMCw4ICsyMCwxMCBAQAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYktpdERvd25sb2FkLmgiCiAKKyNpbmNsdWRlICJEb3du bG9hZFByb3h5LmgiCiAjaW5jbHVkZSAiV2ViS2l0RG93bmxvYWRQcml2YXRlLmgiCiAjaW5jbHVk ZSAiV2ViS2l0TWFyc2hhbC5oIgorI2luY2x1ZGUgIldlYktpdFVSSVJlcXVlc3RQcml2YXRlLmgi CiAjaW5jbHVkZSAiV2ViS2l0VVJJUmVzcG9uc2VQcml2YXRlLmgiCiAjaW5jbHVkZSA8V2ViQ29y ZS9FcnJvcnNHdGsuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVzcG9uc2UuaD4KQEAg LTUzLDYgKzU1LDcgQEAgZW51bSB7CiBzdHJ1Y3QgX1dlYktpdERvd25sb2FkUHJpdmF0ZSB7CiAg ICAgV0tSZXRhaW5QdHI8V0tEb3dubG9hZFJlZj4gd2tEb3dubG9hZDsKIAorICAgIEdSZWZQdHI8 V2ViS2l0VVJJUmVxdWVzdD4gcmVxdWVzdDsKICAgICBHUmVmUHRyPFdlYktpdFVSSVJlc3BvbnNl PiByZXNwb25zZTsKICAgICBDU3RyaW5nIGRlc3RpbmF0aW9uVVJJOwogICAgIGd1aW50NjQgY3Vy cmVudFNpemU7CkBAIC0zNjAsNiArMzYzLDI1IEBAIHZvaWQgd2Via2l0RG93bmxvYWREZXN0aW5h dGlvbkNyZWF0ZWQoV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBjb25zdCBDU3RyaW5nJiBkCiB9 CiAKIC8qKgorICogd2Via2l0X2Rvd25sb2FkX2dldF9yZXF1ZXN0OgorICogQGRvd25sb2FkOiBh ICNXZWJLaXREb3dubG9hZAorICoKKyAqIFJldHJpZXZlcyB0aGUgI1dlYktpdFVSSVJlcXVlc3Qg b2JqZWN0IHRoYXQgYmFja3MgdGhlIGRvd25sb2FkCisgKiBwcm9jZXNzLgorICoKKyAqIFJldHVy bnM6ICh0cmFuc2ZlciBub25lKTogdGhlICNXZWJLaXRVUklSZXF1ZXN0IG9mIEBkb3dubG9hZAor ICovCitXZWJLaXRVUklSZXF1ZXN0KiB3ZWJraXRfZG93bmxvYWRfZ2V0X3JlcXVlc3QoV2ViS2l0 RG93bmxvYWQqIGRvd25sb2FkKQoreworICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9J U19ET1dOTE9BRChkb3dubG9hZCksIDApOworCisgICAgV2ViS2l0RG93bmxvYWRQcml2YXRlKiBw cml2ID0gZG93bmxvYWQtPnByaXY7CisgICAgaWYgKCFwcml2LT5yZXF1ZXN0KQorICAgICAgICBw cml2LT5yZXF1ZXN0ID0gYWRvcHRHUmVmKHdlYmtpdFVSSVJlcXVlc3RDcmVhdGVGb3JSZXNvdXJj ZVJlcXVlc3QodG9JbXBsKHByaXYtPndrRG93bmxvYWQuZ2V0KCkpLT5yZXF1ZXN0KCkpKTsKKyAg ICByZXR1cm4gZG93bmxvYWQtPnByaXYtPnJlcXVlc3QuZ2V0KCk7Cit9CisKKy8qKgogICogd2Vi a2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlvbjoKICAqIEBkb3dubG9hZDogYSAjV2ViS2l0RG93 bmxvYWQKICAqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXREb3dubG9hZC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 RG93bmxvYWQuaAppbmRleCBiNmM1MWZlLi5iNGEyZDNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmgKQEAgLTI2LDYgKzI2LDcgQEAK IAogI2luY2x1ZGUgPGdsaWItb2JqZWN0Lmg+CiAjaW5jbHVkZSA8d2Via2l0Mi9XZWJLaXREZWZp bmVzLmg+CisjaW5jbHVkZSA8d2Via2l0Mi9XZWJLaXRVUklSZXF1ZXN0Lmg+CiAjaW5jbHVkZSA8 d2Via2l0Mi9XZWJLaXRVUklSZXNwb25zZS5oPgogCiBHX0JFR0lOX0RFQ0xTCkBAIC01Nyw2ICs1 OCw5IEBAIHN0cnVjdCBfV2ViS2l0RG93bmxvYWRDbGFzcyB7CiBXRUJLSVRfQVBJIEdUeXBlCiB3 ZWJraXRfZG93bmxvYWRfZ2V0X3R5cGUgICAgICAgICAgICAgICAodm9pZCk7CiAKK1dFQktJVF9B UEkgV2ViS2l0VVJJUmVxdWVzdCAqCit3ZWJraXRfZG93bmxvYWRfZ2V0X3JlcXVlc3QgICAgICAg ICAgICAoV2ViS2l0RG93bmxvYWQgKmRvd25sb2FkKTsKKwogV0VCS0lUX0FQSSBjb25zdCBnY2hh ciAqCiB3ZWJraXRfZG93bmxvYWRfZ2V0X2Rlc3RpbmF0aW9uICAgICAgICAoV2ViS2l0RG93bmxv YWQgKmRvd25sb2FkKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQKaW5kZXggMTAwNWIzZS4u NmRkZTA4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9j cy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CkBAIC0zNDgsNiArMzQ4LDcgQEAg d2Via2l0X3dpbmRvd19wcm9wZXJ0aWVzX2dldF90eXBlCiA8U0VDVElPTj4KIDxGSUxFPldlYktp dERvd25sb2FkPC9GSUxFPgogV2ViS2l0RG93bmxvYWQKK3dlYmtpdF9kb3dubG9hZF9nZXRfcmVx dWVzdAogd2Via2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlvbgogd2Via2l0X2Rvd25sb2FkX3Nl dF9kZXN0aW5hdGlvbgogd2Via2l0X2Rvd25sb2FkX2dldF9yZXNwb25zZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdERvd25sb2Fkcy5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0RG93bmxvYWRzLmNw cAppbmRleCBhMTE5ZTQ0Li5hY2VjOWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0RG93bmxvYWRzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0RG93bmxvYWRzLmNwcApAQCAtODgsNiArODgs NyBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgdm9pZCBkb3dubG9hZFN0YXJ0ZWRDYWxsYmFjayhX ZWJLaXRXZWJDb250ZXh0KiBjb250ZXh0LCBXZWJLaXREb3dubG9hZCogZG93bmxvYWQsIERvd25s b2FkVGVzdCogdGVzdCkKICAgICB7CisgICAgICAgIGdfYXNzZXJ0KHdlYmtpdF9kb3dubG9hZF9n ZXRfcmVxdWVzdChkb3dubG9hZCkpOwogICAgICAgICB0ZXN0LT5zdGFydGVkKGRvd25sb2FkKTsK ICAgICAgICAgZ19zaWduYWxfY29ubmVjdChkb3dubG9hZCwgIm5vdGlmeTo6cmVzcG9uc2UiLCBH X0NBTExCQUNLKHJlY2VpdmVkUmVzcG9uc2VDYWxsYmFjayksIHRlc3QpOwogICAgICAgICBnX3Np Z25hbF9jb25uZWN0KGRvd25sb2FkLCAiY3JlYXRlZC1kZXN0aW5hdGlvbiIsIEdfQ0FMTEJBQ0so Y3JlYXRlZERlc3RpbmF0aW9uQ2FsbGJhY2spLCB0ZXN0KTsKQEAgLTE5MSw2ICsxOTIsMTAgQEAg c3RhdGljIHZvaWQgdGVzdERvd25sb2FkTG9jYWxGaWxlKERvd25sb2FkVGVzdCogdGVzdCwgZ2Nv bnN0cG9pbnRlcikKICAgICBnX2Fzc2VydF9jbXBpbnQoZXZlbnRzWzNdLCA9PSwgRG93bmxvYWRU ZXN0OjpSZWNlaXZlZERhdGEpOwogICAgIGdfYXNzZXJ0X2NtcGludChldmVudHNbNF0sID09LCBE b3dubG9hZFRlc3Q6OkZpbmlzaGVkKTsKIAorICAgIFdlYktpdFVSSVJlcXVlc3QqIHJlcXVlc3Qg PSB3ZWJraXRfZG93bmxvYWRfZ2V0X3JlcXVlc3QoZG93bmxvYWQuZ2V0KCkpOworICAgIGdfYXNz ZXJ0KHJlcXVlc3QpOworICAgIGdfYXNzZXJ0X2NtcHN0cih3ZWJraXRfdXJpX3JlcXVlc3RfZ2V0 X3VyaShyZXF1ZXN0KSwgPT0sIHNvdXJjZVVSSS5nZXQoKSk7CisKICAgICBnX2Fzc2VydF9jbXBp bnQodGVzdC0+bV9kb3dubG9hZFNpemUsID09LCBnX2ZpbGVfaW5mb19nZXRfc2l6ZShzb3VyY2VJ bmZvLmdldCgpKSk7CiAgICAgZ19hc3NlcnQod2Via2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlv bihkb3dubG9hZC5nZXQoKSkpOwogICAgIGdfYXNzZXJ0X2NtcGZsb2F0KHdlYmtpdF9kb3dubG9h ZF9nZXRfZXN0aW1hdGVkX3Byb2dyZXNzKGRvd25sb2FkLmdldCgpKSwgPT0sIDEpOwpAQCAtMzI4 LDYgKzMzMywxMSBAQCBzdGF0aWMgdm9pZCB0ZXN0RG93bmxvYWRSZW1vdGVGaWxlKERvd25sb2Fk VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBnX2Fzc2VydF9jbXBpbnQoZXZlbnRzWzRd LCA9PSwgRG93bmxvYWRUZXN0OjpGaW5pc2hlZCk7CiAgICAgZXZlbnRzLmNsZWFyKCk7CiAKKyAg ICBXZWJLaXRVUklSZXF1ZXN0KiByZXF1ZXN0ID0gd2Via2l0X2Rvd25sb2FkX2dldF9yZXF1ZXN0 KGRvd25sb2FkLmdldCgpKTsKKyAgICBnX2Fzc2VydChyZXF1ZXN0KTsKKyAgICBDU3RyaW5nIHJl cXVlc3RVUkkgPSBrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIvdGVzdC5wZGYiKTsKKyAgICBnX2Fz c2VydF9jbXBzdHIod2Via2l0X3VyaV9yZXF1ZXN0X2dldF91cmkocmVxdWVzdCksID09LCByZXF1 ZXN0VVJJLmRhdGEoKSk7CisKICAgICBnX2Fzc2VydCh3ZWJraXRfZG93bmxvYWRfZ2V0X2Rlc3Rp bmF0aW9uKGRvd25sb2FkLmdldCgpKSk7CiAgICAgZ19hc3NlcnRfY21wZmxvYXQod2Via2l0X2Rv d25sb2FkX2dldF9lc3RpbWF0ZWRfcHJvZ3Jlc3MoZG93bmxvYWQuZ2V0KCkpLCA9PSwgMSk7CiAg ICAgdGVzdC0+Y2hlY2tEZXN0aW5hdGlvbkFuZERlbGV0ZUZpbGUoZG93bmxvYWQuZ2V0KCksIGtT ZXJ2ZXJTdWdnZXN0ZWRGaWxlbmFtZSk7Cg==