87943 2012-05-31 02:16:13 -0700 [GTK] Memory leak in webkit_web_view_init 2012-05-31 10:29:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 638136 0 naginenis 2012-05-31 02:16:13 -0700 Valgrind reports the following memory leak in webkit_web_view_init. ==9443== 8 bytes in 1 blocks are definitely lost in loss record 1,319 of 31,982 ==9443== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9443== by 0x61FB418: webkit_web_view_init(_WebKitWebView*) (webkitwebview.cpp:3558) ==9443== by 0xB19F956: g_type_create_instance (gtype.c:1892) ==9443== by 0xB1840B8: g_object_constructor (gobject.c:1849) ==9443== by 0xB1856E3: g_object_newv (gobject.c:1713) ==9443== by 0xB1861EB: g_object_new (gobject.c:1542) ==9443== by 0x61FB87D: webkit_web_view_new (webkitwebview.cpp:3612) ==9443== by 0x4049B1: createWindow (main.c:306) ==9443== by 0x4053A8: main (main.c:519) Looks like UserMediaClientGtk is not deleted when UserMediaController is destroyed. 638203 1 naginenis 2012-05-31 03:44:42 -0700 This leak can be fixed by deleting UserMediaClientGtk in pageDestroyed() or making the client to be owned by the WebView so that it will be deleted when the view goes away. IMO, the second option is nice because it avoids the pageDestroyed notification function. 638295 2 145067 naginenis 2012-05-31 05:58:13 -0700 Created attachment 145067 Patch Fix for UserMediaClientGtk leak. 638546 3 145067 webkit.review.bot 2012-05-31 10:29:21 -0700 Comment on attachment 145067 Patch Clearing flags on attachment: 145067 Committed r119118: <http://trac.webkit.org/changeset/119118> 638547 4 webkit.review.bot 2012-05-31 10:29:25 -0700 All reviewed patches have been landed. Closing bug. 145067 2012-05-31 05:58:13 -0700 2012-05-31 10:29:21 -0700 Patch 87943.patch text/plain 2422 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBkNTVmYTlmLi4yNjg1OTVkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDUtMzEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2Fu YS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVtb3J5IGxlYWsg aW4gd2Via2l0X3dlYl92aWV3X2luaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg3OTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4ZWQgYSBtZW1vcnkgbGVhayBpbiB3ZWJraXRfd2ViX3ZpZXdfaW5p dCBieSBtYWtpbmcgdGhlCisgICAgICAgIFVzZXJNZWRpYUNsaWVudEd0ayB0byBiZSBvd25lZCBi eSB0aGUgV2ViVmlldy4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAg ICAgICAgKHdlYmtpdF93ZWJfdmlld19pbml0KToKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vi dmlld3ByaXZhdGUuaDoKKwogMjAxMi0wNS0zMCAgU3VkYXJzYW5hIE5hZ2luZW5pICA8c3VkYXJz YW5hLm5hZ2luZW5pQGxpbnV4LmludGVsLmNvbT4KIAogICAgICAgICBbR1RLXSBbV0syXSBNZW1v cnkgbGVhayBpbiB3ZWJraXRXZWJWaWV3QmFzZVN0YXJ0RHJhZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDFhNTRlYTguLjRiNTI0NDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTExOSwxMCArMTE5LDYg QEAKICNpbmNsdWRlICJEZXZpY2VPcmllbnRhdGlvbkNsaWVudEd0ay5oIgogI2VuZGlmCiAKLSNp ZiBFTkFCTEUoTUVESUFfU1RSRUFNKQotI2luY2x1ZGUgIlVzZXJNZWRpYUNsaWVudEd0ay5oIgot I2VuZGlmCi0KIC8qKgogICogU0VDVElPTjp3ZWJraXR3ZWJ2aWV3CiAgKiBAc2hvcnRfZGVzY3Jp cHRpb246IFRoZSBjZW50cmFsIGNsYXNzIG9mIHRoZSBXZWJLaXRHVEsrIEFQSQpAQCAtMzU1NSw3 ICszNTUxLDggQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2luaXQoV2ViS2l0V2ViVmll dyogd2ViVmlldykKICNlbmRpZgogCiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKLSAgICBXZWJD b3JlOjpwcm92aWRlVXNlck1lZGlhVG8ocHJpdi0+Y29yZVBhZ2UsIG5ldyBVc2VyTWVkaWFDbGll bnRHdGspOworICAgIHByaXYtPnVzZXJNZWRpYUNsaWVudCA9IGFkb3B0UHRyKG5ldyBVc2VyTWVk aWFDbGllbnRHdGspOworICAgIFdlYkNvcmU6OnByb3ZpZGVVc2VyTWVkaWFUbyhwcml2LT5jb3Jl UGFnZSwgcHJpdi0+dXNlck1lZGlhQ2xpZW50LmdldCgpKTsKICNlbmRpZgogCiAgICAgaWYgKER1 bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6ZHVtcFJlbmRlclRyZWVNb2RlRW5hYmxlZCgpKSB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlld3ByaXZhdGUu aCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3cHJpdmF0ZS5oCmluZGV4 IDBiYzVhNTYuLjRjNjVkMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ2aWV3cHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXR3ZWJ2aWV3cHJpdmF0ZS5oCkBAIC0zNCw2ICszNCwxMCBAQAogI2luY2x1ZGUgPHdlYmtpdC93 ZWJraXR3ZWJ2aWV3Lmg+CiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR093blB0ci5oPgogCisjaWYg RU5BQkxFKE1FRElBX1NUUkVBTSkKKyNpbmNsdWRlICJVc2VyTWVkaWFDbGllbnRHdGsuaCIKKyNl bmRpZgorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIFdlYkNvcmU6OlBhZ2UqIGNvcmUoV2ViS2l0V2Vi VmlldyopOwogV2ViS2l0V2ViVmlldyoga2l0KFdlYkNvcmU6OlBhZ2UqKTsKQEAgLTEwNCw2ICsx MDgsMTAgQEAgc3RydWN0IF9XZWJLaXRXZWJWaWV3UHJpdmF0ZSB7CiAjaWYgRU5BQkxFKElDT05E QVRBQkFTRSkKICAgICBndWxvbmcgaWNvbkxvYWRlZEhhbmRsZXI7CiAjZW5kaWYKKworI2lmIEVO QUJMRShNRURJQV9TVFJFQU0pCisgICAgT3duUHRyPFdlYktpdDo6VXNlck1lZGlhQ2xpZW50R3Rr PiB1c2VyTWVkaWFDbGllbnQ7CisjZW5kaWYKIH07CiAKIHZvaWQgd2Via2l0X3dlYl92aWV3X25v dGlmeV9yZWFkeShXZWJLaXRXZWJWaWV3Kik7Cg==