87939 2012-05-31 01:16:18 -0700 Syntax error in fast/filesystem/resources/file-writer-gc-blob.js 2012-06-05 06:18:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leo.yang leo.yang ap haraken kinuko sam webkit.review.bot oldest_to_newest 638096 0 leo.yang 2012-05-31 01:16:18 -0700 var blob = tenXBlob(new Blob["lorem ipsum"]); <-- parentheses are missed around []. 638104 1 145016 leo.yang 2012-05-31 01:20:34 -0700 Created attachment 145016 Patch 638530 2 ap 2012-05-31 10:17:47 -0700 What effect does this have on test results? 638894 3 leo.yang 2012-05-31 18:44:26 -0700 (In reply to comment #2) > What effect does this have on test results? JSC generates something like: Type Error: "undefined" is not a constructor. Apparently Blob["lorem ipsum"] is undefined. You might ask why this case passes. I would say all portings except for chromium that uses v8 don't support filesystem API so they don't run this case. The BlackBerry porting is implementing filesystem API with JSC. This case will fail using JSC. 638981 4 ap 2012-05-31 22:41:59 -0700 Makes sense. What about chromium - why doesn't the test fail there? It looks like a v8 bindings bug if Blob["lorem ipsum"] === Blob. 638983 5 leo.yang 2012-05-31 23:00:59 -0700 (In reply to comment #4) > Makes sense. What about chromium - why doesn't the test fail there? It looks like a v8 bindings bug if Blob["lorem ipsum"] === Blob. I have no idea why there is no error for v8. The fix is harmless for v8 since the cr-linux ews bot is green. IIRC, cr-linux ews bot will run layout tests. 641158 6 haraken 2012-06-04 20:55:16 -0700 (In reply to comment #5) > (In reply to comment #4) > I have no idea why there is no error for v8. The fix is harmless for v8 since the cr-linux ews bot is green. IIRC, cr-linux ews bot will run layout tests. That's because file-writer-gc-blob.html is skipped in LayoutTests/platform/chromium/TestExpectations due to bug 85174. 641166 7 145016 ap 2012-06-04 21:14:32 -0700 Comment on attachment 145016 Patch Cool. 641172 8 145016 webkit.review.bot 2012-06-04 21:29:49 -0700 Comment on attachment 145016 Patch Clearing flags on attachment: 145016 Committed r119454: <http://trac.webkit.org/changeset/119454> 641173 9 webkit.review.bot 2012-06-04 21:29:54 -0700 All reviewed patches have been landed. Closing bug. 641484 10 kinuko 2012-06-05 06:18:00 -0700 Ah I just noticed this fix. Thanks for fixing! 145016 2012-05-31 01:20:34 -0700 2012-06-04 21:29:49 -0700 Patch 0001-Syntax-error-in-fast-filesystem-resources-file-write.patch text/plain 1852 leo.yang RnJvbSBjNmY1NThhODEwZWU4YjMxZGJmZWQ2NmNhMDY1OTBhNjc2YjQxZGQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDMxIE1heSAyMDEyIDE2OjE5OjQ4ICswODAwClN1YmplY3Q6IFtQQVRDSF0g U3ludGF4IGVycm9yIGluCiBmYXN0L2ZpbGVzeXN0ZW0vcmVzb3VyY2VzL2ZpbGUtd3JpdGVyLWdj LWJsb2IuanMKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzkzOQoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIGZhc3QvZmlsZXN5c3RlbS9yZXNvdXJjZXMv ZmlsZS13cml0ZXItZ2MtYmxvYi5qczogQWRkIHBhcmVudGhlc2VzIGFyb3VuZCB0aGUgYmxvYiBk YXRhLgooc3RhcnRXcml0ZSk6Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIC4uLi9maWxlc3lzdGVtL3Jlc291 cmNlcy9maWxlLXdyaXRlci1nYy1ibG9iLmpzICAgIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2Vk LCAxMSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDcxY2FlNzEuLjdlNjc0 NDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0zMSAgTGVvIFlhbmcgIDxsZW8ueWFu Z0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgU3ludGF4IGVycm9yIGluIGZhc3QvZmls ZXN5c3RlbS9yZXNvdXJjZXMvZmlsZS13cml0ZXItZ2MtYmxvYi5qcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc5MzkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZmlsZXN5c3RlbS9yZXNvdXJj ZXMvZmlsZS13cml0ZXItZ2MtYmxvYi5qczogQWRkIHBhcmVudGhlc2VzIGFyb3VuZCB0aGUgYmxv YiBkYXRhLgorICAgICAgICAoc3RhcnRXcml0ZSk6CisKIDIwMTItMDUtMzEgIEFsZXhlaSBGaWxp cHBvdiAgPGFsZXhlaWZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJl dGFpbmVycyBhcmUgbWlzc2luZyBmb3IgYWxsIG9iamVjdHMKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZmlsZXN5c3RlbS9yZXNvdXJjZXMvZmlsZS13cml0ZXItZ2MtYmxvYi5qcyBiL0xh eW91dFRlc3RzL2Zhc3QvZmlsZXN5c3RlbS9yZXNvdXJjZXMvZmlsZS13cml0ZXItZ2MtYmxvYi5q cwppbmRleCBlYTFmNmYyLi40OGZiNzVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zp bGVzeXN0ZW0vcmVzb3VyY2VzL2ZpbGUtd3JpdGVyLWdjLWJsb2IuanMKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9maWxlc3lzdGVtL3Jlc291cmNlcy9maWxlLXdyaXRlci1nYy1ibG9iLmpzCkBAIC0y Myw3ICsyMyw3IEBAIGZ1bmN0aW9uIHRlblhCbG9iKGJsb2IpIHsKIAogZnVuY3Rpb24gc3RhcnRX cml0ZSh3cml0ZXIpIHsKICAgICAvLyBMZXQncyBtYWtlIGl0IGFib3V0IGEgbWVnYWJ5dGUuCi0g ICAgdmFyIGJsb2IgPSB0ZW5YQmxvYihuZXcgQmxvYlsibG9yZW0gaXBzdW0iXSk7CisgICAgdmFy IGJsb2IgPSB0ZW5YQmxvYihuZXcgQmxvYihbImxvcmVtIGlwc3VtIl0pKTsKICAgICBibG9iID0g dGVuWEJsb2IoYmxvYik7CiAgICAgYmxvYiA9IHRlblhCbG9iKGJsb2IpOwogICAgIGJsb2IgPSB0 ZW5YQmxvYihibG9iKTsKLS0gCjEuNy45LjUKCg==