87936 2012-05-31 00:50:59 -0700 [Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls. 2012-05-31 18:37:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan cmarcelo dinu.jacob kenneth menard webkit.review.bot zoltan oldest_to_newest 638072 0 zalan 2012-05-31 00:50:59 -0700 SSIA 638088 1 145011 zalan 2012-05-31 01:05:28 -0700 Created attachment 145011 Patch 638119 2 145011 kenneth 2012-05-31 01:50:02 -0700 Comment on attachment 145011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345 > void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value) > { > + ViewportUpdateDeferrer guard(this); > setPageItemRectVisible(value.toRectF()); > } This one is not needed... it should be guarded already 638234 3 zalan 2012-05-31 04:45:37 -0700 (In reply to comment #2) > (From update of attachment 145011 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145011&action=review > > > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:345 > > void QtViewportInteractionEngine::scaleAnimationValueChanged(QVariant value) > > { > > + ViewportUpdateDeferrer guard(this); > > setPageItemRectVisible(value.toRectF()); > > } > > This one is not needed... it should be guarded already Good catch, but unfortunately it is not guarded. Created a new bug report on that bug#87954 638250 4 145052 zalan 2012-05-31 05:02:20 -0700 Created attachment 145052 Patch 638305 5 145052 webkit.review.bot 2012-05-31 06:07:51 -0700 Comment on attachment 145052 Patch Clearing flags on attachment: 145052 Committed r119095: <http://trac.webkit.org/changeset/119095> 638306 6 webkit.review.bot 2012-05-31 06:07:57 -0700 All reviewed patches have been landed. Closing bug. 638886 7 dinu.jacob 2012-05-31 18:37:30 -0700 *** Bug 88004 has been marked as a duplicate of this bug. *** 145011 2012-05-31 01:05:28 -0700 2012-05-31 05:02:07 -0700 Patch bug-87936-20120531100526.patch text/plain 1999 zalan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTA2OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTMxICBaYWxhbiBC dWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gQWRkIG1pc3Np bmcgVmlld3BvcnRVcGRhdGVEZWZlcnJlciBndWFyZGluZyB0byBzZXRQYWdlSXRlbVJlY3RWaXNp YmxlKCkgY2FsbHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6dmlld3BvcnRBdHRyaWJ1 dGVzQ2hhbmdlZCk6CisgICAgICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2lu ZTo6cGFnZUNvbnRlbnRzU2l6ZUNoYW5nZWQpOgorICAgICAgICAoV2ViS2l0OjpRdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmU6OnNjYWxlQW5pbWF0aW9uVmFsdWVDaGFuZ2VkKToKKwogMjAxMi0w NS0zMSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSB0aGUg c3BlY2lmaWNhdGlvbiBvZiBmcmFtZXdvcmsgYW5kIGxpYnJhcnkgbGlua2luZyBvdXQgb2YgV2Vi S2l0Mi54Y29kZXByb2ogYW5kIGludG8gV2ViS2l0Mi54Y2NvbmZpZwpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlv bkVuZ2luZS5jcHAJKHJldmlzaW9uIDExOTA1NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MDAsNiArMjAwLDcgQEAgdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnZpZXdwbwog CiAgICAgLy8gSWYgdGhlIHdlYiBhcHAgc3VjY2Vzc2l2ZWx5IGNoYW5nZXMgdGhlIHZpZXdwb3J0 IG9uIHB1cnBvc2UKICAgICAvLyBpdCB3YW50cyB0byBiZSBpbiBjb250cm9sIGFuZCB3ZSBzaG91 bGQgZGlzYWJsZSBhbmltYXRpb25zLgorICAgIFZpZXdwb3J0VXBkYXRlRGVmZXJyZXIgZ3VhcmQo dGhpcyk7CiAgICAgc2V0UGFnZUl0ZW1SZWN0VmlzaWJsZShuZWFyZXN0VmFsaWRCb3VuZHMoKSk7 CiB9CiAKQEAgLTIyMSw2ICsyMjIsNyBAQCB2b2lkIFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2lu ZTo6cGFnZUNvCiAgICAgLy8gd2UgZGlkbid0IGRvIHNjYWxlIGFkanVzdG1lbnQuCiAgICAgZW1p dCBtX3ZpZXdwb3J0SXRlbS0+ZXhwZXJpbWVudGFsKCktPnRlc3QoKS0+Y29udGVudHNTY2FsZUNv bW1pdHRlZCgpOwogCisgICAgVmlld3BvcnRVcGRhdGVEZWZlcnJlciBndWFyZCh0aGlzKTsKICAg ICBzZXRQYWdlSXRlbVJlY3RWaXNpYmxlKG5lYXJlc3RWYWxpZEJvdW5kcygpKTsKIH0KIApAQCAt MzM4LDYgKzM0MCw3IEBAIHZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjpzY2FsZUEK IAogdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnNjYWxlQW5pbWF0aW9uVmFsdWVD aGFuZ2VkKFFWYXJpYW50IHZhbHVlKQogeworICAgIFZpZXdwb3J0VXBkYXRlRGVmZXJyZXIgZ3Vh cmQodGhpcyk7CiAgICAgc2V0UGFnZUl0ZW1SZWN0VmlzaWJsZSh2YWx1ZS50b1JlY3RGKCkpOwog fQogCg== 145052 2012-05-31 05:02:20 -0700 2012-05-31 06:07:51 -0700 Patch bug-87936-20120531140218.patch text/plain 1644 zalan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTA4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTMxICBaYWxhbiBC dWp0YXMgIDx6YnVqdGFzQGdtYWlsLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gQWRkIG1pc3Np bmcgVmlld3BvcnRVcGRhdGVEZWZlcnJlciBndWFyZGluZyB0byBzZXRQYWdlSXRlbVJlY3RWaXNp YmxlKCkgY2FsbHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL3F0L1F0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZTo6dmlld3BvcnRBdHRyaWJ1 dGVzQ2hhbmdlZCk6CisgICAgICAgIChXZWJLaXQ6OlF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2lu ZTo6cGFnZUNvbnRlbnRzU2l6ZUNoYW5nZWQpOgorCiAyMDEyLTA1LTMxICBHeXV5b3VuZyBLaW0g IDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBSZW5hbWUg ZXdrX3ByaXZhdGUuaCB0byBld2tfdmlld19wcml2YXRlLmgKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25Fbmdp bmUuY3BwCShyZXZpc2lvbiAxMTkwNTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQv UXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAwLDYg KzIwMCw3IEBAIHZvaWQgUXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lOjp2aWV3cG8KIAogICAg IC8vIElmIHRoZSB3ZWIgYXBwIHN1Y2Nlc3NpdmVseSBjaGFuZ2VzIHRoZSB2aWV3cG9ydCBvbiBw dXJwb3NlCiAgICAgLy8gaXQgd2FudHMgdG8gYmUgaW4gY29udHJvbCBhbmQgd2Ugc2hvdWxkIGRp c2FibGUgYW5pbWF0aW9ucy4KKyAgICBWaWV3cG9ydFVwZGF0ZURlZmVycmVyIGd1YXJkKHRoaXMp OwogICAgIHNldFBhZ2VJdGVtUmVjdFZpc2libGUobmVhcmVzdFZhbGlkQm91bmRzKCkpOwogfQog CkBAIC0yMjEsNiArMjIyLDcgQEAgdm9pZCBRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmU6OnBh Z2VDbwogICAgIC8vIHdlIGRpZG4ndCBkbyBzY2FsZSBhZGp1c3RtZW50LgogICAgIGVtaXQgbV92 aWV3cG9ydEl0ZW0tPmV4cGVyaW1lbnRhbCgpLT50ZXN0KCktPmNvbnRlbnRzU2NhbGVDb21taXR0 ZWQoKTsKIAorICAgIFZpZXdwb3J0VXBkYXRlRGVmZXJyZXIgZ3VhcmQodGhpcyk7CiAgICAgc2V0 UGFnZUl0ZW1SZWN0VmlzaWJsZShuZWFyZXN0VmFsaWRCb3VuZHMoKSk7CiB9CiAK