87927 2012-05-30 22:43:33 -0700 [CMAKE][EFL] Remove unneeded include path 2012-05-31 03:02:42 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 638009 0 gyuyoung.kim 2012-05-30 22:43:33 -0700 Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including previous path. In addition, Files on EFL port is using <wtf/gobject/XXX> directly in #include line. So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore. 638012 1 144991 gyuyoung.kim 2012-05-30 22:46:33 -0700 Created attachment 144991 Patch 638140 2 144991 kenneth 2012-05-31 02:26:20 -0700 Comment on attachment 144991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144991&action=review > Source/WebCore/ChangeLog:8 > + Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including previous the previous > Source/WebCore/ChangeLog:9 > + path. In addition, Files on EFL port is using "<wtf/gobject/XXX>" directly in #include line. Files *are* ... on the #include line. 638145 3 145024 gyuyoung.kim 2012-05-31 02:30:38 -0700 Created attachment 145024 Patch 638170 4 145024 webkit.review.bot 2012-05-31 03:02:31 -0700 Comment on attachment 145024 Patch Clearing flags on attachment: 145024 Committed r119080: <http://trac.webkit.org/changeset/119080> 638171 5 webkit.review.bot 2012-05-31 03:02:42 -0700 All reviewed patches have been landed. Closing bug. 144991 2012-05-30 22:46:33 -0700 2012-05-31 02:30:23 -0700 Patch bug-87927-20120531144632.patch text/plain 3034 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYxMjBlY2M2NDA2ZDc3 NmYzMzkwOGRiNDY3ZjI0Mjk4OTcyZTdkNi4uMjYyY2E1NmUwYTQ4NDc4OWRmODFhY2U0NWI0OTNi NGRjODk1ZmU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTMwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NNQUtFXVtF RkxdIFJlbW92ZSB1bm5lZWRlZCBpbmNsdWRlIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhvdWdoICp3dGYqIGRpcmVjdG9yeSB3YXMgbW92ZWQg dG8gU291cmNlL1dURiwgUGxhdGZvcm1FZmwuY21ha2UgaXMgc3RpbGwgaW5jbHVkaW5nIHByZXZp b3VzCisgICAgICAgIHBhdGguIEluIGFkZGl0aW9uLCBGaWxlcyBvbiBFRkwgcG9ydCBpcyB1c2lu ZyAiPHd0Zi9nb2JqZWN0L1hYWD4iIGRpcmVjdGx5IGluICNpbmNsdWRlIGxpbmUuCisgICAgICAg IFNvLCBFRkwgcG9ydCBkb2Vzbid0IG5lZWQgdG8gaW5jbHVkZSAke0pBVkFTQ1JJUFRDT1JFX0RJ Un0vd3RmL2dvYmplY3QgcGF0aCBhbnltb3JlLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21h a2U6IFJlbW92ZSAnJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3d0Zi9nb2JqZWN0JyBwYXRoIGZyb20g aW5jbHVkZSBwYXRoIGxpc3QuCisKIDIwMTItMDUtMzAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEZvcm0gY29udHJvbHMgaW4gPGZpZWxkc2V0IGRpc2FibGVk PiBzaG91bGQgbm90IGJlIGZvY3VzYWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggOTUxNTFmMGJiN2Y2YTZlMGQ1 OWQ5ZGQ1ODg5N2MzNWRjMDA1ZGY5NC4uNzY3NmVmYmUyNWQ4YjA5MWVhMDdjMmM1Yjc5ZGE5Mjc2 ZmY0YWJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0zMCAgR3l1eW91bmcg S2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDTUFLRV1bRUZMXSBS ZW1vdmUgdW5uZWVkZWQgaW5jbHVkZSBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NzkyNyAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaG91Z2ggKnd0ZiogZGlyZWN0b3J5IHdhcyBtb3ZlZCB0byBT b3VyY2UvV1RGLCBQbGF0Zm9ybUVmbC5jbWFrZSBpcyBzdGlsbCBpbmNsdWRpbmcgcHJldmlvdXMK KyAgICAgICAgcGF0aC4gSW4gYWRkaXRpb24sIEZpbGVzIG9uIEVGTCBwb3J0IGlzIHVzaW5nIDx3 dGYvZ29iamVjdC9YWFg+IGRpcmVjdGx5IGluICNpbmNsdWRlIGxpbmUuCisgICAgICAgIFNvLCBF RkwgcG9ydCBkb2Vzbid0IG5lZWQgdG8gaW5jbHVkZSAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vd3Rm L2dvYmplY3QgcGF0aCBhbnltb3JlLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6IFJl bW92ZSAnJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3d0Zi9nb2JqZWN0JyBwYXRoIGZyb20gaW5jbHVk ZSBwYXRoIGxpc3QuCisKIDIwMTItMDUtMjkgIEFydmlkIE5pbHNzb24gIDxhbmlsc3NvbkByaW0u Y29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBXZWJLaXQtc2lkZSBpbXBsZW1lbnRhdGlvbiBv ZiBTZWxlY3Rpb25PdmVybGF5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVm bC5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDVlYzA4N2U2 MjY2N2QxNjM0YzQ0NGM3ODJiYjEyYWRhMTg4NzNmMTMuLmU5MGQ3ODE5MDNiZGY3NzU4ZjExNzJh ZjBkZDk0NzQ1N2YxYTFiZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC00LDcgKzQs NiBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX0xJTktfRkxBR1MKICkKIAogTElTVChBUFBFTkQgV2Vi Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCi0gICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0vd3RmL2dv YmplY3QiCiAgICIke1dFQkNPUkVfRElSfS9hY2Nlc3NpYmlsaXR5L2VmbCIKICAgIiR7V0VCQ09S RV9ESVJ9L3BhZ2UvZWZsIgogICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZWZsIgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxh dGZvcm1FZmwuY21ha2UKaW5kZXggYTYzMGJhY2M1OTMzYzljOGU3ZTIxN2JlNDg1M2I4NGRlZDIx NDgyMS4uNTQ2NjNjZDQ3MmNjNGQzZjA3M2Y3ZjU1Y2Y2NDczMzY2MWIxMTBkNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtRWZsLmNtYWtlCkBAIC0xMCw3ICsxMCw2IEBAIExJU1QoQVBQRU5EIFdlYktpdF9JTkNM VURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V0VCS0lUX0RJUn0vZWZsL2V3ayIKICAgICAiJHtXRUJL SVRfRElSfS9lZmwvV2ViQ29yZVN1cHBvcnQiCiAgICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9G b3J3YXJkaW5nSGVhZGVycyIKLSAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3d0Zi9nb2JqZWN0 IgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9lZmwiCiAgICAgIiR7V0VCQ09SRV9ESVJ9 L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvIgogICAgICIke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS9n cmFwaGljcy9lZmwiCg== 145024 2012-05-31 02:30:38 -0700 2012-05-31 03:02:31 -0700 Patch bug-87927-20120531183036.patch text/plain 3098 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGVjMTI3ZDE3NjI0OGUz YjNiMGU3OGVkMTVjMGVjMjc3MTYxYzQwYS4uZGI0MWIyMzUxN2I5NTk1NTkzODBmYmJhZjg2Y2I2 Y2QzY2VkODAwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTMxICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NNQUtFXVtF RkxdIFJlbW92ZSB1bm5lZWRlZCBpbmNsdWRlIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2Vu bmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgVGhvdWdoICp3dGYqIGRpcmVjdG9y eSB3YXMgbW92ZWQgdG8gU291cmNlL1dURiwgUGxhdGZvcm1FZmwuY21ha2UgaXMgc3RpbGwgaW5j bHVkaW5nIHRoZSBwcmV2aW91cworICAgICAgICBwYXRoLiBJbiBhZGRpdGlvbiwgZmlsZXMgb24g RUZMIHBvcnQgYXJlIHVzaW5nICI8d3RmL2dvYmplY3QvWFhYPiIgZGlyZWN0bHkgaW4gI2luY2x1 ZGUgbGluZS4KKyAgICAgICAgU28sIEVGTCBwb3J0IGRvZXNuJ3QgbmVlZCB0byBpbmNsdWRlICR7 SkFWQVNDUklQVENPUkVfRElSfS93dGYvZ29iamVjdCBwYXRoIGFueW1vcmUuCisKKyAgICAgICAg KiBQbGF0Zm9ybUVmbC5jbWFrZTogUmVtb3ZlICcke0pBVkFTQ1JJUFRDT1JFX0RJUn0vd3RmL2dv YmplY3QnIHBhdGggZnJvbSBpbmNsdWRlIHBhdGggbGlzdC4KKwogMjAxMi0wNS0zMSAgWW9zaGlm dW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQbGF0Zm9ybV0gSW50 cm9kdWNlIERlY2ltYWwgY2xhc3MgZm9yIE51bWJlci9SYW5nZSBpbnB1dCB0eXBlLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpp bmRleCAyMDI0OTg0ZWUxZDA1MzU1YmQ0YzA5ZmUzYzYxOTAxZTEyOTMwOTBhLi5hZTY3ZTMzZWY0 YTA2Y2YzNDViMmY4Nzk1YTc0NTU1MjZhOGZiN2UzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA1LTMxICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0NNQUtFXVtFRkxdIFJlbW92ZSB1bm5lZWRlZCBpbmNsdWRlIHBhdGgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3OTI3IAorCisgICAg ICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIFRo b3VnaCAqd3RmKiBkaXJlY3Rvcnkgd2FzIG1vdmVkIHRvIFNvdXJjZS9XVEYsIFBsYXRmb3JtRWZs LmNtYWtlIGlzIHN0aWxsIGluY2x1ZGluZyB0aGUgcHJldmlvdXMKKyAgICAgICAgcGF0aC4gSW4g YWRkaXRpb24sIGZpbGVzIG9uIEVGTCBwb3J0IGFyZSB1c2luZyA8d3RmL2dvYmplY3QvWFhYPiBk aXJlY3RseSBpbiAjaW5jbHVkZSBsaW5lLgorICAgICAgICBTbywgRUZMIHBvcnQgZG9lc24ndCBu ZWVkIHRvIGluY2x1ZGUgJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3d0Zi9nb2JqZWN0IHBhdGggYW55 bW9yZS4KKworICAgICAgICAqIFBsYXRmb3JtRWZsLmNtYWtlOiBSZW1vdmUgJyR7SkFWQVNDUklQ VENPUkVfRElSfS93dGYvZ29iamVjdCcgcGF0aCBmcm9tIGluY2x1ZGUgcGF0aCBsaXN0LgorCiAy MDEyLTA1LTMwICBLb25yYWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIEFkZCBhbiBBY2NlbGVyYXRlZCBDb21wb3NpdGluZyBsYXllciBmb3IgV2Vi IEluc3BlY3RvciBET00gaGlnaGxpZ2h0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxh dGZvcm1FZmwuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCA1 ZWMwODdlNjI2NjdkMTYzNGM0NDRjNzgyYmIxMmFkYTE4ODczZjEzLi5lOTBkNzgxOTAzYmRmNzc1 OGYxMTcyYWYwZGQ5NDc0NTdmMWExYmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0 Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAt NCw3ICs0LDYgQEAgTElTVChBUFBFTkQgV2ViQ29yZV9MSU5LX0ZMQUdTCiApCiAKIExJU1QoQVBQ RU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwotICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9 L3d0Zi9nb2JqZWN0IgogICAiJHtXRUJDT1JFX0RJUn0vYWNjZXNzaWJpbGl0eS9lZmwiCiAgICIk e1dFQkNPUkVfRElSfS9wYWdlL2VmbCIKICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2VmbCIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1FZmwuY21ha2UgYi9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGE2MzBiYWNjNTkzM2M5YzhlN2UyMTdiZTQ4NTNi ODRkZWQyMTQ4MjEuLjU0NjYzY2Q0NzJjYzRkM2YwNzNmN2Y1NWNmNjQ3MzM2NjFiMTEwZDcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1FZmwuY21ha2UKKysrIGIvU291cmNlL1dl YktpdC9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMTAsNyArMTAsNiBAQCBMSVNUKEFQUEVORCBXZWJL aXRfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dFQktJVF9ESVJ9L2VmbC9ld2siCiAgICAg IiR7V0VCS0lUX0RJUn0vZWZsL1dlYkNvcmVTdXBwb3J0IgogICAgICIke0pBVkFTQ1JJUFRDT1JF X0RJUn0vRm9yd2FyZGluZ0hlYWRlcnMiCi0gICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS93dGYv Z29iamVjdCIKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZWZsIgogICAgICIke1dFQkNP UkVfRElSfS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlybyIKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxh dGZvcm0vZ3JhcGhpY3MvZWZsIgo=