87925 2012-05-30 22:01:19 -0700 [V8] Expando properties on attribute nodes disappear 2012-09-11 23:11:17 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88045 88062 1 dominicc dominicc abarth dominicc haraken japhet jbadics webkit.review.bot oldest_to_newest 637995 0 144983 dominicc 2012-05-30 22:01:19 -0700 Created attachment 144983 Repro. Must run Chrome with --js-flags=--expose_gc. Object grouping for attribute nodes is incorrect. See the attached repro. It should print "magic", "magic" but because the attribute node wrapper is collected prematurely, it prints "magic", "undefined". 638960 1 145208 dominicc 2012-05-31 21:46:29 -0700 Created attachment 145208 Patch 638963 2 145208 dominicc 2012-05-31 21:47:19 -0700 Comment on attachment 145208 Patch Filed bug 88045 for JSC. It seems the same bug exists in JSC bindings. 638972 3 145208 abarth 2012-05-31 22:13:31 -0700 Comment on attachment 145208 Patch LGTM. You might want to run this patch by haraken before landing. 638977 4 145208 haraken 2012-05-31 22:26:59 -0700 Comment on attachment 145208 Patch LGTM from me too 638997 5 145208 webkit.review.bot 2012-05-31 23:37:22 -0700 Comment on attachment 145208 Patch Clearing flags on attachment: 145208 Committed r119196: <http://trac.webkit.org/changeset/119196> 638998 6 webkit.review.bot 2012-05-31 23:37:30 -0700 All reviewed patches have been landed. Closing bug. 639092 7 jbadics 2012-06-01 01:25:32 -0700 A newly added test (fast/dom/gc-attribute-node.html) fails on Qt, GTK and EFL 64 bit since r119196. I will skip this test until the problem is solved. https://bugs.webkit.org/show_bug.cgi?id=88062 144983 2012-05-30 22:01:19 -0700 2012-05-30 22:01:19 -0700 Repro. Must run Chrome with --js-flags=--expose_gc. index.html text/html 533 dominicc PCFET0NUWVBFIGh0bWw+Cjxib2R5Pgo8c2NyaXB0Pgp2YXIgZ2MgPSB3aW5kb3cuZ2MgfHwgZnVu Y3Rpb24gKCkgewogIGNvbnNvbGUubG9nKCdubyBnYywgcnVuIHdpdGggLS1qcy1mbGFncz0tLWV4 cG9zZV9nYycpOwp9OwoKdmFyIGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKZG9j dW1lbnQuYm9keS5hcHBlbmRDaGlsZChlKTsKZS5zZXRBdHRyaWJ1dGUoJ2ZvbycsICdiYXInKTsK dmFyIGEgPSBlLmdldEF0dHJpYnV0ZU5vZGUoJ2ZvbycpOwphLnVsdHJhID0gJ21hZ2ljJzsKY29u c29sZS5sb2coYS51bHRyYSk7ICAvLyBwcmludHMgIm1hZ2ljIgoKLy8gUmVsaW5xdWlzaCBkaXJl Y3QgcmVmZXJlbmNlcyB0byBzb21lIHN0dWZmCmEgPSBudWxsOwplID0gbnVsbDsKZ2MoKTsgZ2Mo KTsgZ2MoKTsKCi8vIE5vdyBnZXQgaXQgYmFjawplID0gZG9jdW1lbnQuYm9keS5xdWVyeVNlbGVj dG9yKCdkaXYnKTsKYSA9IGUuZ2V0QXR0cmlidXRlTm9kZSgnZm9vJyk7CmNvbnNvbGUubG9nKGEu dWx0cmEpOwoKPC9zY3JpcHQ+Cgo= 145208 2012-05-31 21:46:29 -0700 2012-05-31 23:37:21 -0700 Patch bug-87925-20120601134628.patch text/plain 5273 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGVjMTI3ZDE3NjI0OGUz YjNiMGU3OGVkMTVjMGVjMjc3MTYxYzQwYS4uZTA5MWFkMGJhMjlmM2RhMWE5Mjc5YjFiM2I2MzQy MjFmZWI1NjdmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTMxICBEb21p bmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEV4cGFu ZG8gcHJvcGVydGllcyBvbiBhdHRyaWJ1dGUgbm9kZXMgZGlzYXBwZWFyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzkyNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2djLWF0dHJp YnV0ZS1ub2RlLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmNhbGN1bGF0ZUdyb3VwSWQpOiBHcm91cCBhdHRyaWJ1dGVz IGxpa2Ugb3RoZXIgbm9kZXMuCisKIDIwMTItMDUtMzEgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2lu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbUGxhdGZvcm1dIEludHJvZHVjZSBEZWNpbWFsIGNs YXNzIGZvciBOdW1iZXIvUmFuZ2UgaW5wdXQgdHlwZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAppbmRleCAxOGZlY2MyNjFhYTA3NTM5NzYyMTkyMWUy NmE5MzUwNmU5YjA2MDEwLi4wOTNjNjQ0YTU3MDU2YTVjZWM1Mzk5MDJmZTc2OGI2OTc2YTc1MGVk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCkBA IC0zMDYsMTAgKzMwNiw5IEBAIHN0YXRpYyBHcm91cElkIGNhbGN1bGF0ZUdyb3VwSWQoTm9kZSog bm9kZSkKICAgICAgICAgLy8gYmVjYXVzZSBpdCdsbCBhbHdheXMgYmUgYSBncm91cCBvZiAxLgog ICAgICAgICBpZiAoIXJvb3QpCiAgICAgICAgICAgICByZXR1cm4gR3JvdXBJZCgpOwotICAgIH0g ZWxzZSB7Ci0gICAgICAgIHdoaWxlIChOb2RlKiBwYXJlbnQgPSByb290LT5wYXJlbnRPckhvc3RO b2RlKCkpCi0gICAgICAgICAgICByb290ID0gcGFyZW50OwogICAgIH0KKyAgICB3aGlsZSAoTm9k ZSogcGFyZW50ID0gcm9vdC0+cGFyZW50T3JIb3N0Tm9kZSgpKQorICAgICAgICByb290ID0gcGFy ZW50OwogCiAgICAgcmV0dXJuIEdyb3VwSWQocm9vdCk7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzgwNmUzNjIyZmQz M2ZiMjVkODE4ZTI0YjE4NWRmZjViM2YzYzAwNy4uMDMxNTJiNDU4OWRiYmM5NGM4OTcwNDVkOTdh MjI4MjRhYjgwMTIxZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTMxICBEb21pbmlj IENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEV4cGFuZG8g cHJvcGVydGllcyBvbiBhdHRyaWJ1dGUgbm9kZXMgZGlzYXBwZWFyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzkyNQorCisgICAgICAgIENoZWNrcyBp biBhIGZhaWxpbmcgcmVzdWx0IGZvciBKU0M7IHNlZQorICAgICAgICA8aHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4MDQ1Pi4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2RlLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vZ2MtYXR0cmlidXRlLW5vZGUu aHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vZ2MtYXR0 cmlidXRlLW5vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv ZmFzdC9kb20vZ2MtYXR0cmlidXRlLW5vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxMi0w NS0zMSAgWm9sdGFuIEFydmFpICA8emFydmFpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBb UXRdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBSZWJhc2UgeHNzIHRlc3QsIHNraXAgZmFpbGluZyB0 ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2Rl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2RlLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYjc4Mzg5YjExNzZmMGQ1ZmM0ZGNiMzI2ZjEyZmVkZjUy Y2E3MDI1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vZ2MtYXR0cmli dXRlLW5vZGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3RzIHRoYXQgYXR0cmli dXRlIG5vZGUgd3JhcHBlcnMgYXJlIG5vdCBwcmVtYXR1cmVseSBnYXJiYWdlIGNvbGxlY3RlZAor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBhLnByb3AgaXMgInNldCIKK1BB U1MgYS5wcm9wIGlzICJzZXQiCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RF U1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vZ2MtYXR0cmli dXRlLW5vZGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2RlLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uYWRkNDgyZTAzYjk4YzkwMTg3MWEyMjYwYjFlZDk2ZDVhNTE2OWYwNQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2Rl Lmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8bGluayByZWw9InN0eWxl c2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxib2R5Pgor PHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUZXN0cyB0aGF0IGF0dHJpYnV0ZSBub2RlIHdyYXBwZXJz IGFyZSBub3QgcHJlbWF0dXJlbHkgZ2FyYmFnZSBjb2xsZWN0ZWQnKTsKKwordmFyIGUgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZSk7 CitlLnNldEF0dHJpYnV0ZSgnaWQnLCAnZCcpOworZS5zZXRBdHRyaWJ1dGUoJ2ZvbycsICdiYXIn KTsKK2EgPSBlLmdldEF0dHJpYnV0ZU5vZGUoJ2ZvbycpOworYS5wcm9wID0gJ3NldCc7CitzaG91 bGRCZSgnYS5wcm9wJywgJyJzZXQiJyk7CisKK2EgPSBudWxsOworZSA9IG51bGw7CitnYygpOwor CitlID0gZG9jdW1lbnQuYm9keS5xdWVyeVNlbGVjdG9yKCdkaXYjZCcpOworYSA9IGUuZ2V0QXR0 cmlidXRlTm9kZSgnZm9vJyk7CitzaG91bGRCZSgnYS5wcm9wJywgJyJzZXQiJyk7CisKK3N1Y2Nl c3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2RlLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1u b2RlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lYjc4Mzg5YjExNzZmMGQ1ZmM0ZGNiMzI2ZjEy ZmVkZjUyY2E3MDI1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vZmFzdC9kb20vZ2MtYXR0cmlidXRlLW5vZGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs MTEgQEAKK1Rlc3RzIHRoYXQgYXR0cmlidXRlIG5vZGUgd3JhcHBlcnMgYXJlIG5vdCBwcmVtYXR1 cmVseSBnYXJiYWdlIGNvbGxlY3RlZAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBhLnByb3AgaXMgInNldCIKK1BBU1MgYS5wcm9wIGlzICJzZXQiCitQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZG9tL2djLWF0dHJpYnV0ZS1ub2RlLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2RvbS9nYy1hdHRyaWJ1dGUtbm9kZS1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTdiN2EyZjY4MTBhZDUwN2RjMTkzNDRjYzcxZWYxYjg3 MDU4Yjk1ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0 L2RvbS9nYy1hdHRyaWJ1dGUtbm9kZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGVz dHMgdGhhdCBhdHRyaWJ1dGUgbm9kZSB3cmFwcGVycyBhcmUgbm90IHByZW1hdHVyZWx5IGdhcmJh Z2UgY29sbGVjdGVkCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGEucHJv cCBpcyAic2V0IgorRkFJTCBhLnByb3Agc2hvdWxkIGJlIHNldCAob2YgdHlwZSBzdHJpbmcpLiBX YXMgdW5kZWZpbmVkIChvZiB0eXBlIHVuZGVmaW5lZCkuCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwo=