<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>87901</bug_id>
          
          <creation_ts>2012-05-30 14:48:05 -0700</creation_ts>
          <short_desc>Avoid second layout for flex-direction:row, flex-basis:auto flex items</short_desc>
          <delta_ts>2022-02-27 23:51:56 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>62048</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Ojan Vafai">ojan</assigned_to>
          <cc>eric</cc>
    
    <cc>hyatt</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>637715</commentid>
    <comment_count>0</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-05-30 14:48:05 -0700</bug_when>
    <thetext>Avoid second layout for flex-direction:row, flex-basis:auto flex items</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>637717</commentid>
    <comment_count>1</comment_count>
      <attachid>144928</attachid>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-05-30 14:49:06 -0700</bug_when>
    <thetext>Created attachment 144928
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>637771</commentid>
    <comment_count>2</comment_count>
      <attachid>144928</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-05-30 15:50:28 -0700</bug_when>
    <thetext>Comment on attachment 144928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144928&amp;action=review

&gt; Source/WebCore/rendering/RenderFlexibleBox.cpp:997
&gt; +        // FIXME: If we&apos;re overriding logicalHeight (i.e. hasOrthogonalFlow(child) == true), we only need to layout here if the
&gt; +        // contents of the child depends on it&apos;s height (e.g. % height elements, background-color, etc) because we already
&gt; +        // layed out once in computeMainAxisPreferredSizes at the unflexed height.

Nit: Might be easier to file a bug about this and dump some of this in the bug instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>637909</commentid>
    <comment_count>3</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2012-05-30 18:37:14 -0700</bug_when>
    <thetext>Committed r119015: &lt;http://trac.webkit.org/changeset/119015&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>144928</attachid>
            <date>2012-05-30 14:49:06 -0700</date>
            <delta_ts>2022-02-27 23:51:56 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-87901-20120530144905.patch</filename>
            <type>text/plain</type>
            <size>3153</size>
            <attacher name="Ojan Vafai">ojan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4OTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMyZGI5NmI1NGVmYTlk
YTM5NWI4ODVhODBiM2Q1NTQ5YmU2YmZmZi4uOThmMzVlNTA0YzlkMWMyNWYzYTA5Yzg3NDJiY2Rm
NzhhYTgwOTM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTMwICBPamFu
IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQXZvaWQgc2Vjb25kIGxheW91
dCBmb3IgZmxleC1kaXJlY3Rpb246cm93LCBmbGV4LWJhc2lzOmF1dG8gZmxleCBpdGVtcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc5MDEKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu
IFRoaXMgaXMgc3RyaWN0bHkgYSBwZXJmb3JtYW5jZSBvcHRpbWl6YXRpb24gYW5kIGhhcyBubyBv
dGhlcgorICAgICAgICB3ZWIgdmlzaWJsZSBjaGFuZ2VzLgorCisgICAgICAgIEFsc28sIGFkZCBG
SVhNRXMgZm9yIG90aGVyIGNhc2VzIHdoZXJlIHdlIGNvdWxkIGF2b2lkIGRvaW5nIGxheW91dHMu
IAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlTWFpbkF4aXNQcmVmZXJyZWRTaXpl
cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6bGF5b3V0QW5kUGxhY2VD
aGlsZHJlbik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6YXBwbHlTdHJl
dGNoQWxpZ25tZW50VG9DaGlsZCk6CisKIDIwMTItMDUtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5
X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRmFjdG9yIERlZmVycmFibGVPbmVTaG90VGlt
ZXIgb3V0IG9mIEdyYXBoaWNzQ29udGV4dENHL0dlbmVyYXRvckdlbmVyYXRlZEltYWdlCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwIGIv
U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAppbmRleCA0ZWQ2
MjdhZTU0ODFmNzZkNjNjMjY4NTMyYmEyZDBlZDkzMjMxMjc3Li4yNWJhNDI1OTNhZTViODA4ZmVm
ODc4YmVhYWZhZTI5OWVlNTZhMWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp
bmcvUmVuZGVyRmxleGlibGVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S
ZW5kZXJGbGV4aWJsZUJveC5jcHAKQEAgLTc1Nyw3ICs3NTcsOCBAQCB2b2lkIFJlbmRlckZsZXhp
YmxlQm94Ojpjb21wdXRlTWFpbkF4aXNQcmVmZXJyZWRTaXplcyhib29sIHJlbGF5b3V0Q2hpbGRy
ZW4sIEZsZQogICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgY2hpbGQtPmNsZWFyT3Zl
cnJpZGVTaXplKCk7Ci0gICAgICAgIGlmIChwcmVmZXJyZWRMZW5ndGhGb3JDaGlsZChjaGlsZCku
aXNBdXRvKCkpIHsKKyAgICAgICAgLy8gT25seSBuZWVkIHRvIGxheW91dCBoZXJlIGlmIHdlIHdp
bGwgbmVlZCB0byBnZXQgdGhlIGxvZ2ljYWxIZWlnaHQgb2YgdGhlIGNoaWxkIGluIGNvbXB1dGVO
ZXh0RmxleExpbmUuCisgICAgICAgIGlmIChoYXNPcnRob2dvbmFsRmxvdyhjaGlsZCkgJiYgcHJl
ZmVycmVkTGVuZ3RoRm9yQ2hpbGQoY2hpbGQpLmlzQXV0bygpKSB7CiAgICAgICAgICAgICBpZiAo
IXJlbGF5b3V0Q2hpbGRyZW4pCiAgICAgICAgICAgICAgICAgY2hpbGQtPnNldENoaWxkTmVlZHNM
YXlvdXQodHJ1ZSk7CiAgICAgICAgICAgICBjaGlsZC0+bGF5b3V0SWZOZWVkZWQoKTsKQEAgLTk5
MSw2ICs5OTIsOSBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94OjpsYXlvdXRBbmRQbGFjZUNoaWxk
cmVuKExheW91dFVuaXQmIGNyb3NzQXhpc09mZnNldCwgY29ucwogICAgICAgICB9CiAgICAgICAg
IExheW91dFVuaXQgY2hpbGRQcmVmZXJyZWRTaXplID0gY2hpbGRTaXplc1tpXSArIG1haW5BeGlz
Qm9yZGVyQW5kUGFkZGluZ0V4dGVudEZvckNoaWxkKGNoaWxkKTsKICAgICAgICAgc2V0TG9naWNh
bE92ZXJyaWRlU2l6ZShjaGlsZCwgY2hpbGRQcmVmZXJyZWRTaXplKTsKKyAgICAgICAgLy8gRklY
TUU6IElmIHdlJ3JlIG92ZXJyaWRpbmcgbG9naWNhbEhlaWdodCAoaS5lLiBoYXNPcnRob2dvbmFs
RmxvdyhjaGlsZCkgPT0gdHJ1ZSksIHdlIG9ubHkgbmVlZCB0byBsYXlvdXQgaGVyZSBpZiB0aGUK
KyAgICAgICAgLy8gY29udGVudHMgb2YgdGhlIGNoaWxkIGRlcGVuZHMgb24gaXQncyBoZWlnaHQg
KGUuZy4gJSBoZWlnaHQgZWxlbWVudHMsIGJhY2tncm91bmQtY29sb3IsIGV0YykgYmVjYXVzZSB3
ZSBhbHJlYWR5CisgICAgICAgIC8vIGxheWVkIG91dCBvbmNlIGluIGNvbXB1dGVNYWluQXhpc1By
ZWZlcnJlZFNpemVzIGF0IHRoZSB1bmZsZXhlZCBoZWlnaHQuCiAgICAgICAgIGNoaWxkLT5zZXRD
aGlsZE5lZWRzTGF5b3V0KHRydWUpOwogICAgICAgICBjaGlsZC0+bGF5b3V0SWZOZWVkZWQoKTsK
IApAQCAtMTIxMyw2ICsxMjE3LDggQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6YXBwbHlTdHJl
dGNoQWxpZ25tZW50VG9DaGlsZChSZW5kZXJCb3gqIGNoaWxkLCBMYXlvdXRVbmkKICAgICAgICAg
Y2hpbGQtPnNldExvZ2ljYWxIZWlnaHQoc3RyZXRjaGVkTG9naWNhbEhlaWdodCk7CiAgICAgICAg
IGNoaWxkLT5jb21wdXRlTG9naWNhbEhlaWdodCgpOwogCisgICAgICAgIC8vIEZJWE1FOiBXZSBv
bmx5IG5lZWQgdG8gbGF5b3V0IGhlcmUgaWYgdGhlIGNvbnRlbnRzIG9mIHRoZSBjaGlsZCBkZXBl
bmRzIG9uIGl0J3MgaGVpZ2h0CisgICAgICAgIC8vIChlLmcuICUgaGVpZ2h0IGVsZW1lbnRzLCBi
YWNrZ3JvdW5kLWNvbG9yLCBldGMpLgogICAgICAgICBpZiAoY2hpbGQtPmxvZ2ljYWxIZWlnaHQo
KSAhPSBsb2dpY2FsSGVpZ2h0QmVmb3JlKSB7CiAgICAgICAgICAgICBjaGlsZC0+c2V0T3ZlcnJp
ZGVIZWlnaHQoY2hpbGQtPmxvZ2ljYWxIZWlnaHQoKSk7CiAgICAgICAgICAgICBjaGlsZC0+c2V0
TG9naWNhbEhlaWdodCgwKTsK
</data>
<flag name="review"
          id="151929"
          type_id="1"
          status="+"
          setter="tony"
    />
          </attachment>
      

    </bug>

</bugzilla>