87889 2012-05-30 13:09:52 -0700 REGRESSION(118913): webarchive/test-xml-stylesheet.xml is failing 2012-05-31 08:36:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 87891 1 thorton webkit-unassigned ap kling koivisto webkit-bug-importer oldest_to_newest 637587 0 thorton 2012-05-30 13:09:52 -0700 http://trac.webkit.org/changeset/118913 seems to have caused webarchive/test-xml-stylesheet.xml to fail: - <key>WebSubresources</key> - <array> - <dict> - <key>WebResourceData</key> - <string>#test { - background: green; - } - </string> - <key>WebResourceMIMEType</key> - <string>text/css</string> - <key>WebResourceResponse</key> - <dict> - <key>MIMEType</key> - <string>text/css</string> - <key>URL</key> - <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string> - <key>expectedContentLength</key> - <integer>31</integer> - </dict> - <key>WebResourceURL</key> - <string>file:///LayoutTests/webarchive/resources/test-xml-stylesheet.css</string> - </dict> - </array> I will check in failing results. 637588 1 webkit-bug-importer 2012-05-30 13:10:53 -0700 <rdar://problem/11559199> 637600 2 ap 2012-05-30 13:22:16 -0700 - addSubresourceAttributeURLs(urls); + if (!isElementNode()) + return; + static_cast<const Element*>(this)->collectSubresourceURLsFromAttributes(urls); This means that we're not collecting from ProcessingInstructions anyway. An OVERRIDE annotation would have caught that. I think that the patch should be rolled out. Given that these functions are collecting URLs from more than just element attributes, new names seem misleading (and that's how the regression got introduced anyway). Some kind of renaming (with OVERRIDE) seems appropriate, but it seems easier to do in a new patch. 637602 3 ap 2012-05-30 13:23:06 -0700 s/anyway/any more/ 637639 4 thorton 2012-05-30 13:36:57 -0700 Rolling out in https://bugs.webkit.org/show_bug.cgi?id=87891 638431 5 koivisto 2012-05-31 08:15:00 -0700 Please don't roll out large patches for such minor reasons. This would have been a trivial fix. 638453 6 ap 2012-05-31 08:36:45 -0700 Antti, you may have not read comment 2. The idea of this patch was wrong.