87882 2012-05-30 11:58:17 -0700 [New Multicolumn] Rename layoutColumns to be more general and make it virtual so that it can be implemented by RenderMultiColumnBlock 2012-05-30 12:11:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt eric webkit.review.bot oldest_to_newest 637508 0 hyatt 2012-05-30 11:58:17 -0700 Rename layoutColumns to be more general and make it virtual so that it can be implemented by RenderMultiColumnBlock. 637510 1 144888 hyatt 2012-05-30 11:59:53 -0700 Created attachment 144888 Patch 637517 2 hyatt 2012-05-30 12:11:26 -0700 Landed in r118950. 144888 2012-05-30 11:59:53 -0700 2012-05-30 12:00:34 -0700 Patch patch.txt text/plain 4833 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODk0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTMwICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODc4ODIKKyAgICAgICAgCisgICAgICAgIFtOZXcgTXVsdGljb2x1 bW5dIFJlbmFtZSBsYXlvdXRDb2x1bW5zIHRvIHJlbGF5b3V0Rm9yUGFnaW5hdGlvbiBhbmQgbWFr ZSBpdAorICAgICAgICB2aXJ0dWFsIHNvIHRoYXQgaXQgY2FuIGJlIGltcGxlbWVudGVkIGJ5IFJl bmRlck11bHRpQ29sdW1uQmxvY2suCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyQmxvY2s6OmxheW91dEJsb2NrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJsb2NrOjpyZWxheW91dEZvclBhZ2luYXRpb24pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCbG9jay5oOgorICAgICAgICAoUmVuZGVyQmxvY2spOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJNdWx0aUNvbHVtbkJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck11bHRp Q29sdW1uQmxvY2s6OnJlbGF5b3V0Rm9yUGFnaW5hdGlvbik6CisgICAgICAgIChXZWJDb3JlKToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5CbG9jay5oOgorICAgICAgICAo UmVuZGVyTXVsdGlDb2x1bW5CbG9jayk6CisKIDIwMTItMDUtMzAgIEFsbGFuIFNhbmRmZWxkIEpl bnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBTdXBwb3J0IElN QUdFX0RFQ09ERVJfRE9XTl9TQU1QTElORyBmbGFnLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAxMTg5NDUpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDc4LDcgKzE0 NzgsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjpsYXlvdXRCbG9jayhib29sIHJlbGF5CiAgICAgaWYg KGxvd2VzdEZsb2F0TG9naWNhbEJvdHRvbSgpID4gKGxvZ2ljYWxIZWlnaHQoKSAtIHRvQWRkKSAm JiBleHBhbmRzVG9FbmNsb3NlT3ZlcmhhbmdpbmdGbG9hdHMoKSkKICAgICAgICAgc2V0TG9naWNh bEhlaWdodChsb3dlc3RGbG9hdExvZ2ljYWxCb3R0b20oKSArIHRvQWRkKTsKICAgICAKLSAgICBp ZiAobGF5b3V0Q29sdW1ucyhoYXNTcGVjaWZpZWRQYWdlTG9naWNhbEhlaWdodCwgcGFnZUxvZ2lj YWxIZWlnaHQsIHN0YXRlUHVzaGVyKSkKKyAgICBpZiAocmVsYXlvdXRGb3JQYWdpbmF0aW9uKGhh c1NwZWNpZmllZFBhZ2VMb2dpY2FsSGVpZ2h0LCBwYWdlTG9naWNhbEhlaWdodCwgc3RhdGVQdXNo ZXIpKQogICAgICAgICByZXR1cm47CiAgCiAgICAgLy8gQ2FsY3VsYXRlIG91ciBuZXcgaGVpZ2h0 LgpAQCAtNTAxNyw3ICs1MDE3LDcgQEAgTGF5b3V0UmVjdCBSZW5kZXJCbG9jazo6Y29sdW1uUmVj dEF0KENvbAogICAgIHJldHVybiBMYXlvdXRSZWN0KGNvbExvZ2ljYWxUb3AsIGNvbExvZ2ljYWxM ZWZ0LCBjb2xMb2dpY2FsSGVpZ2h0LCBjb2xMb2dpY2FsV2lkdGgpOwogfQogCi1ib29sIFJlbmRl ckJsb2NrOjpsYXlvdXRDb2x1bW5zKGJvb2wgaGFzU3BlY2lmaWVkUGFnZUxvZ2ljYWxIZWlnaHQs IExheW91dFVuaXQgcGFnZUxvZ2ljYWxIZWlnaHQsIExheW91dFN0YXRlTWFpbnRhaW5lciYgc3Rh dGVQdXNoZXIpCitib29sIFJlbmRlckJsb2NrOjpyZWxheW91dEZvclBhZ2luYXRpb24oYm9vbCBo YXNTcGVjaWZpZWRQYWdlTG9naWNhbEhlaWdodCwgTGF5b3V0VW5pdCBwYWdlTG9naWNhbEhlaWdo dCwgTGF5b3V0U3RhdGVNYWludGFpbmVyJiBzdGF0ZVB1c2hlcikKIHsKICAgICBpZiAoIWhhc0Nv bHVtbnMoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmgJKHJldmlzaW9uIDExODk0NSkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC04MTcsNyArODE3LDYgQEAg cHJpdmF0ZToKICAgICB2b2lkIG9mZnNldEZvckNvbnRlbnRzKExheW91dFBvaW50JikgY29uc3Q7 CiAKICAgICB2aXJ0dWFsIHZvaWQgY2FsY0NvbHVtbldpZHRoKCk7Ci0gICAgYm9vbCBsYXlvdXRD b2x1bW5zKGJvb2wgaGFzU3BlY2lmaWVkUGFnZUxvZ2ljYWxIZWlnaHQsIExheW91dFVuaXQgcGFn ZUxvZ2ljYWxIZWlnaHQsIExheW91dFN0YXRlTWFpbnRhaW5lciYpOwogICAgIHZvaWQgbWFrZUNo aWxkcmVuQW5vbnltb3VzQ29sdW1uQmxvY2tzKFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQsIFJl bmRlckJsb2NrKiBuZXdCbG9ja0JveCwgUmVuZGVyT2JqZWN0KiBuZXdDaGlsZCk7CiAKICAgICBi b29sIGV4cGFuZHNUb0VuY2xvc2VPdmVyaGFuZ2luZ0Zsb2F0cygpIGNvbnN0OwpAQCAtOTMzLDYg KzkzMiw3IEBAIHByaXZhdGU6CiAKIHByb3RlY3RlZDoKICAgICAvLyBQYWdpbmF0aW9uIHJvdXRp bmVzLgorICAgIHZpcnR1YWwgYm9vbCByZWxheW91dEZvclBhZ2luYXRpb24oYm9vbCBoYXNTcGVj aWZpZWRQYWdlTG9naWNhbEhlaWdodCwgTGF5b3V0VW5pdCBwYWdlTG9naWNhbEhlaWdodCwgTGF5 b3V0U3RhdGVNYWludGFpbmVyJik7CiAgICAgCiAgICAgLy8gUmV0dXJucyB0aGUgbG9naWNhbE9m ZnNldCBhdCB0aGUgdG9wIG9mIHRoZSBuZXh0IHBhZ2UuIElmIHRoZSBvZmZzZXQgcGFzc2VkIGlu IGlzIGFscmVhZHkgYXQgdGhlIHRvcCBvZiB0aGUgY3VycmVudCBwYWdlLAogICAgIC8vIHRoZW4g bmV4dFBhZ2VMb2dpY2FsVG9wIHdpdGggRXhjbHVkZVBhZ2VCb3VuZGFyeSB3aWxsIHN0aWxsIG1v dmUgdG8gdGhlIHRvcCBvZiB0aGUgbmV4dCBwYWdlLiBuZXh0UGFnZUxvZ2ljYWxUb3Agd2l0aApJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uQmxvY2suY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVt bkJsb2NrLmNwcAkocmV2aXNpb24gMTE4OTQ1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck11bHRpQ29sdW1uQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCwx MiBAQCB2b2lkIFJlbmRlck11bHRpQ29sdW1uQmxvY2s6OmNoZWNrRm9yUGFnCiAgICAgZW5zdXJl Q29sdW1uU2V0cygpOwogfQogCitib29sIFJlbmRlck11bHRpQ29sdW1uQmxvY2s6OnJlbGF5b3V0 Rm9yUGFnaW5hdGlvbihib29sLCBMYXlvdXRVbml0LCBMYXlvdXRTdGF0ZU1haW50YWluZXImKQor eworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lk IFJlbmRlck11bHRpQ29sdW1uQmxvY2s6OmFkZENoaWxkKFJlbmRlck9iamVjdCogbmV3Q2hpbGQs IFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQpCiB7CiAgICAgaWYgKCFtX2Zsb3dUaHJlYWQpIHsK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkJsb2NrLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1u QmxvY2suaAkocmV2aXNpb24gMTE4OTQ1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlck11bHRpQ29sdW1uQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtNDgsOCArNDgsOSBAQCBw cml2YXRlOgogICAgIAogICAgIHZpcnR1YWwgY29uc3QgY2hhciogcmVuZGVyTmFtZSgpIGNvbnN0 OwogCi0gICAgdmlydHVhbCBib29sIHJlY29tcHV0ZUxvZ2ljYWxXaWR0aCgpOworICAgIHZpcnR1 YWwgYm9vbCByZWNvbXB1dGVMb2dpY2FsV2lkdGgoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZv aWQgY2hlY2tGb3JQYWdpbmF0aW9uTG9naWNhbEhlaWdodENoYW5nZShMYXlvdXRVbml0JiBwYWdl TG9naWNhbEhlaWdodCwgYm9vbCYgcGFnZUxvZ2ljYWxIZWlnaHRDaGFuZ2VkLCBib29sJiBoYXNT cGVjaWZpZWRQYWdlTG9naWNhbEhlaWdodCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIHJl bGF5b3V0Rm9yUGFnaW5hdGlvbihib29sIGhhc1NwZWNpZmllZFBhZ2VMb2dpY2FsSGVpZ2h0LCBM YXlvdXRVbml0IHBhZ2VMb2dpY2FsSGVpZ2h0LCBMYXlvdXRTdGF0ZU1haW50YWluZXImKSBPVkVS UklERTsKIAogICAgIHZpcnR1YWwgdm9pZCBhZGRDaGlsZChSZW5kZXJPYmplY3QqIG5ld0NoaWxk LCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkID0gMCkgT1ZFUlJJREU7CiAK