87866 2012-05-30 09:58:56 -0700 [GTK][WK2] Errors in documentation about webkit_web_view_run_javascript() 2012-05-30 15:38:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 637335 0 mario 2012-05-30 09:58:56 -0700 The snippet of code provided as documentation for webkit_web_view_run_javascript() and webkit_web_view_run_javascript_finish () in WebKit2GTK API contains some errors that should be fixed. 637341 1 144847 mario 2012-05-30 10:02:19 -0700 Created attachment 144847 Patch proposal 637350 2 webkit.review.bot 2012-05-30 10:05:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 637357 3 144847 mario 2012-05-30 10:08:29 -0700 Comment on attachment 144847 Patch proposal Let's get the CQ do the work... 637764 4 144847 webkit.review.bot 2012-05-30 15:38:04 -0700 Comment on attachment 144847 Patch proposal Clearing flags on attachment: 144847 Committed r118985: <http://trac.webkit.org/changeset/118985> 637765 5 webkit.review.bot 2012-05-30 15:38:08 -0700 All reviewed patches have been landed. Closing bug. 144847 2012-05-30 10:02:19 -0700 2012-05-30 15:38:04 -0700 Patch proposal 0001-2012-05-30-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3120 mario RnJvbSAzYWQ1ZTUyNjE3OTJhOTI1NDI4Y2RiMjg4YzQ4ZjU5MmNjOTAxMGQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDMwIE1heSAyMDEyIDE5OjAxOjIxICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wNS0zMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdW1dLMl0gRXJyb3JzIGluIGRvY3VtZW50YXRpb24gYWJvdXQgIHdlYmtp dF93ZWJfdmlld19ydW5famF2YXNjcmlwdCgpCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg3ODY2CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOiBGaXgg ZXJyb3JzLgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAgOSArKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYlZpZXcuY3BwIHwgICAxMiArKysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTNkMTBiYi4u MjczZTE4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEyLTA1LTMwICBNYXJpbyBT YW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXVtXSzJd IEVycm9ycyBpbiBkb2N1bWVudGF0aW9uIGFib3V0ICB3ZWJraXRfd2ViX3ZpZXdfcnVuX2phdmFz Y3JpcHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODc4NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOiBGaXggZXJyb3JzLgorCisyMDEy LTA1LTMwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKwogICAg ICAgICBbR1RLXVtXSzJdIEltcGxlbWVudCBBUEkgZm9yIEdlb2xvY2F0aW9uIHBlcm1pc3Npb24g cmVxdWVzdHMgaW4gdGhlIEdUSyBwb3J0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mzg3OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCmluZGV4IDI1MDg2NWIuLjQ0N2Y2NTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3Bw CkBAIC0xOTM5LDEzICsxOTM5LDEzIEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X3J1bl9qYXZhc2Ny aXB0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IGdjaGFyKiBzY3JpcHQsCiAgKiAgICAg Y29udGV4dCA9IHdlYmtpdF9qYXZhc2NyaXB0X3Jlc3VsdF9nZXRfZ2xvYmFsX2NvbnRleHQgKGpz X3Jlc3VsdCk7CiAgKiAgICAgdmFsdWUgPSB3ZWJraXRfamF2YXNjcmlwdF9yZXN1bHRfZ2V0X3Zh bHVlIChqc19yZXN1bHQpOwogICogICAgIGlmIChKU1ZhbHVlSXNTdHJpbmcgKGNvbnRleHQsIHZh bHVlKSkgewotICogICAgICAgICBKU1N0cmluZ1JlZiAqanNfc3RyX3ZhbHVlOwotICogICAgICAg ICBnY2hhciAgICAgICAqc3RyX3ZhbHVlOwotICogICAgICAgICBnc2l6ZSAgICAgICAgc3RyX2xl bmd0aDsKKyAqICAgICAgICAgSlNTdHJpbmdSZWYganNfc3RyX3ZhbHVlOworICogICAgICAgICBn Y2hhciAgICAgICpzdHJfdmFsdWU7CisgKiAgICAgICAgIGdzaXplICAgICAgIHN0cl9sZW5ndGg7 CiAgKgotICogICAgICAgICBqc19zdHJfdmFsdWUgPSBKU1ZhbHVlVG9TdHJpbmdDb3B5IChjb250 ZXh0LCB2YWx1ZSwgTlVMTCkpOworICogICAgICAgICBqc19zdHJfdmFsdWUgPSBKU1ZhbHVlVG9T dHJpbmdDb3B5IChjb250ZXh0LCB2YWx1ZSwgTlVMTCk7CiAgKiAgICAgICAgIHN0cl9sZW5ndGgg PSBKU1N0cmluZ0dldE1heGltdW1VVEY4Q1N0cmluZ1NpemUgKGpzX3N0cl92YWx1ZSk7Ci0gKiAg ICAgICAgIHN0cl92YWx1ZSA9IChnY2hhciAqKWdfbWFsbG9jIChzdHJfbGVuZ3RoKSk7CisgKiAg ICAgICAgIHN0cl92YWx1ZSA9IChnY2hhciAqKWdfbWFsbG9jIChzdHJfbGVuZ3RoKTsKICAqICAg ICAgICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyAoanNfc3RyX3ZhbHVlLCBzdHJfdmFsdWUsIHN0 cl9sZW5ndGgpOwogICogICAgICAgICBKU1N0cmluZ1JlbGVhc2UgKGpzX3N0cl92YWx1ZSk7CiAg KiAgICAgICAgIGdfcHJpbnQgKCJTY3JpcHQgcmVzdWx0OiAlc1xuIiwgc3RyX3ZhbHVlKTsKQEAg LTE5NjMsNyArMTk2Myw3IEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X3J1bl9qYXZhc2NyaXB0KFdl YktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IGdjaGFyKiBzY3JpcHQsCiAgKiAgICAgZ2NoYXIg KnNjcmlwdDsKICAqCiAgKiAgICAgc2NyaXB0ID0gZ19zdHJkdXBfcHJpbnRmICgid2luZG93LmRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCclcycpLmhyZWY7IiwgbGlua19pZCk7Ci0gKiAgICAgd2Vi a2l0X3dlYl92aWV3X3J1bl9qYXZhc2NyaXB0ICh3ZWJfdmlldywgc2NyaXB0LCB3ZWJfdmlld19q YXZhc2NyaXB0X2ZpbmlzaGVkLCBOVUxMKTsKKyAqICAgICB3ZWJraXRfd2ViX3ZpZXdfcnVuX2ph dmFzY3JpcHQgKHdlYl92aWV3LCBzY3JpcHQsIE5VTEwsIHdlYl92aWV3X2phdmFzY3JpcHRfZmlu aXNoZWQsIE5VTEwpOwogICogICAgIGdfZnJlZSAoc2NyaXB0KTsKICAqIH0KICAqIDwvcHJvZ3Jh bWxpc3Rpbmc+PC9pbmZvcm1hbGV4YW1wbGU+Ci0tIAoxLjcuMTAuMgoK