87861 2012-05-30 09:17:44 -0700 [BlackBerry] Minor string conversion bug 2012-05-30 16:07:40 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Other RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles webkit.review.bot oldest_to_newest 637299 0 joenotcharles 2012-05-30 09:17:44 -0700 In NetworkJob: username is a WTF::String. ResourceHandleInternal::m_user is a string. Yet they're assigned with "username = m_user.utf8().data()". Pointless: "username = m_user" will do. 637312 1 144841 joenotcharles 2012-05-30 09:39:36 -0700 Created attachment 144841 fix 637405 2 144864 joenotcharles 2012-05-30 10:38:53 -0700 Created attachment 144864 fix with changelogs 637788 3 144864 webkit.review.bot 2012-05-30 16:07:36 -0700 Comment on attachment 144864 fix with changelogs Clearing flags on attachment: 144864 Committed r118991: <http://trac.webkit.org/changeset/118991> 637789 4 webkit.review.bot 2012-05-30 16:07:40 -0700 All reviewed patches have been landed. Closing bug. 144841 2012-05-30 09:39:36 -0700 2012-05-30 10:38:53 -0700 fix 0001-2012-05-30-Joe-Mason-jmason-rim.com.patch text/plain 2239 joenotcharles RnJvbSA2MWYyODkyNzBiNzZlYzlhNmEyNmFjYzUyNjY1OTI0NDE5OWVhMzhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBXZWQs IDMwIE1heSAyMDEyIDEwOjMzOjUyIC0wNDAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIDIwMTItMDUt MzAgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgoKICAgICAgICBbQmxhY2tCZXJyeV0gUmVt b3ZlIHVzZWxlc3Mgc3RyaW5nLT5jaGFyKi0+c3RyaW5nIGNvbnZlcnNpb24gaW4gTmV0d29ya0pv Yi4KICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc4NjEK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFJJTSBQUiAjMTUy MzgzOiB1c2VybmFtZSBpcyBhIFdURjo6U3RyaW5nLiAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbDo6 bV91c2VyIGlzIGEgc3RyaW5nLiAgWWV0IHRoZXkncmUKICAgICAgICBhc3NpZ25lZCB3aXRoICJ1 c2VybmFtZSA9IG1fdXNlci51dGY4KCkuZGF0YSgpIi4gIFBvaW50bGVzczogInVzZXJuYW1lID0g bV91c2VyIiB3aWxsIGRvLgoKICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcDoKICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6c2VuZFJlcXVlc3RX aXRoQ3JlZGVudGlhbHMpOgotLS0KIC4uLi9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0 d29ya0pvYi5jcHAgICAgIHwgICAgNiArKystLS0KIDEgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCBlMTVjYjk4Li5k NTQzNjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHly aWdodCAoQykgMjAwOSwgMjAxMCwgMjAxMSBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZC4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOSwgMjAxMCwgMjAxMSwgMjAx MiBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAg KiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQg YW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdl bmVyYWwgUHVibGljCkBAIC03NDksOCArNzQ5LDggQEAgYm9vbCBOZXR3b3JrSm9iOjpzZW5kUmVx dWVzdFdpdGhDcmVkZW50aWFscyhQcm90ZWN0aW9uU3BhY2VTZXJ2ZXJUeXBlIHR5cGUsIFByb3QK ICAgICAgICAgaWYgKHVzZXJuYW1lLmlzRW1wdHkoKSB8fCBwYXNzd29yZC5pc0VtcHR5KCkpIHsK ICAgICAgICAgICAgIC8vIEJlZm9yZSBhc2tpbmcgdGhlIHVzZXIgZm9yIGNyZWRlbnRpYWxzLCB3 ZSBjaGVjayBpZiB0aGUgVVJMIGNvbnRhaW5zIHRoYXQuCiAgICAgICAgICAgICBpZiAoIW1faGFu ZGxlLT5nZXRJbnRlcm5hbCgpLT5tX3VzZXIuaXNFbXB0eSgpICYmICFtX2hhbmRsZS0+Z2V0SW50 ZXJuYWwoKS0+bV9wYXNzLmlzRW1wdHkoKSkgewotICAgICAgICAgICAgICAgIHVzZXJuYW1lID0g bV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fdXNlci51dGY4KCkuZGF0YSgpOwotICAgICAgICAg ICAgICAgIHBhc3N3b3JkID0gbV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fcGFzcy51dGY4KCku ZGF0YSgpOworICAgICAgICAgICAgICAgIHVzZXJuYW1lID0gbV9oYW5kbGUtPmdldEludGVybmFs KCktPm1fdXNlcjsKKyAgICAgICAgICAgICAgICBwYXNzd29yZCA9IG1faGFuZGxlLT5nZXRJbnRl cm5hbCgpLT5tX3Bhc3M7CiAKICAgICAgICAgICAgICAgICAvLyBQcmV2ZW50IHRoZW0gZnJvbSBi ZWVuIHVzZWQgYWdhaW4gaWYgdGhleSBhcmUgd3JvbmcuCiAgICAgICAgICAgICAgICAgLy8gSWYg dGhleSBhcmUgY29ycmVjdCwgdGhleSB3aWxsIHRoZSBwdXQgaW50byBDcmVkZW50aWFsU3RvcmFn ZS4KLS0gCjEuNy41LjQKCg== 144864 2012-05-30 10:38:53 -0700 2012-05-30 16:07:36 -0700 fix with changelogs 0001-2012-05-30-Joe-Mason-jmason-rim.com.patch text/plain 3249 joenotcharles RnJvbSA0OTQ2NzA3ZDFjMGYxYTIzODcyZjljZDBiNTI1YmYwNDI2NzM0YzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBXZWQs IDMwIE1heSAyMDEyIDEwOjMzOjUyIC0wNDAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIDIwMTItMDUt MzAgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgoKICAgICAgICBbQmxhY2tCZXJyeV0gUmVt b3ZlIHVzZWxlc3Mgc3RyaW5nLT5jaGFyKi0+c3RyaW5nIGNvbnZlcnNpb24gaW4gTmV0d29ya0pv Yi4KICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc4NjEK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFJJTSBQUiAjMTUy MzgzOiB1c2VybmFtZSBpcyBhIFdURjo6U3RyaW5nLiAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbDo6 bV91c2VyIGlzIGEgc3RyaW5nLiAgWWV0IHRoZXkncmUKICAgICAgICBhc3NpZ25lZCB3aXRoICJ1 c2VybmFtZSA9IG1fdXNlci51dGY4KCkuZGF0YSgpIi4gIFBvaW50bGVzczogInVzZXJuYW1lID0g bV91c2VyIiB3aWxsIGRvLgoKICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcDoKICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6c2VuZFJlcXVlc3RX aXRoQ3JlZGVudGlhbHMpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgICAgIHwgICAgNiArKystLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTIxZDllMS4uMDAyMjA3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTMw ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUmVt b3ZlIHVzZWxlc3Mgc3RyaW5nLT5jaGFyKi0+c3RyaW5nIGNvbnZlcnNpb24gaW4gTmV0d29ya0pv Yi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3ODYx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUklNIFBS ICMxNTIzODM6IHVzZXJuYW1lIGlzIGEgV1RGOjpTdHJpbmcuICBSZXNvdXJjZUhhbmRsZUludGVy bmFsOjptX3VzZXIgaXMgYSBzdHJpbmcuICBZZXQgdGhleSdyZQorICAgICAgICBhc3NpZ25lZCB3 aXRoICJ1c2VybmFtZSA9IG1fdXNlci51dGY4KCkuZGF0YSgpIi4gIFBvaW50bGVzczogInVzZXJu YW1lID0gbV91c2VyIiB3aWxsIGRvLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGVy ZSBpcyBubyBiZWhhdmlvdXIgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6 c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMpOgorCiAyMDEyLTA1LTI5ICBKb25hdGhhbiBEb25n ICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVy cnldIGh0dHAgYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIGlzc3VlIHdoZW4gbG9hZGluZyBzdWJy ZXNvdXJjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFj a2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9i bGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4IGUxNWNiOTguLmQ1NDM2MTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9i LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0 d29ya0pvYi5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA5LCAy MDEwLCAyMDExIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICogQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEwLCAyMDExLCAyMDEyIFJlc2VhcmNoIEluIE1v dGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRoaXMgbGlicmFyeSBp cyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlm eSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKQEAg LTc0OSw4ICs3NDksOCBAQCBib29sIE5ldHdvcmtKb2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRp YWxzKFByb3RlY3Rpb25TcGFjZVNlcnZlclR5cGUgdHlwZSwgUHJvdAogICAgICAgICBpZiAodXNl cm5hbWUuaXNFbXB0eSgpIHx8IHBhc3N3b3JkLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgLy8g QmVmb3JlIGFza2luZyB0aGUgdXNlciBmb3IgY3JlZGVudGlhbHMsIHdlIGNoZWNrIGlmIHRoZSBV UkwgY29udGFpbnMgdGhhdC4KICAgICAgICAgICAgIGlmICghbV9oYW5kbGUtPmdldEludGVybmFs KCktPm1fdXNlci5pc0VtcHR5KCkgJiYgIW1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX3Bhc3Mu aXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICAgICAgdXNlcm5hbWUgPSBtX2hhbmRsZS0+Z2V0SW50 ZXJuYWwoKS0+bV91c2VyLnV0ZjgoKS5kYXRhKCk7Ci0gICAgICAgICAgICAgICAgcGFzc3dvcmQg PSBtX2hhbmRsZS0+Z2V0SW50ZXJuYWwoKS0+bV9wYXNzLnV0ZjgoKS5kYXRhKCk7CisgICAgICAg ICAgICAgICAgdXNlcm5hbWUgPSBtX2hhbmRsZS0+Z2V0SW50ZXJuYWwoKS0+bV91c2VyOworICAg ICAgICAgICAgICAgIHBhc3N3b3JkID0gbV9oYW5kbGUtPmdldEludGVybmFsKCktPm1fcGFzczsK IAogICAgICAgICAgICAgICAgIC8vIFByZXZlbnQgdGhlbSBmcm9tIGJlZW4gdXNlZCBhZ2FpbiBp ZiB0aGV5IGFyZSB3cm9uZy4KICAgICAgICAgICAgICAgICAvLyBJZiB0aGV5IGFyZSBjb3JyZWN0 LCB0aGV5IHdpbGwgdGhlIHB1dCBpbnRvIENyZWRlbnRpYWxTdG9yYWdlLgotLSAKMS43LjUuNAoK