87833 2012-05-30 01:39:56 -0700 [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message 2012-05-30 09:32:43 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 637021 0 mikhail.pozdnyakov 2012-05-30 01:39:56 -0700 EFL's DRT needs "postProgressFinishedNotification" message in order to unskip http/tests/loading/progress-finished-callback.html 637026 1 144753 mikhail.pozdnyakov 2012-05-30 01:49:12 -0700 Created attachment 144753 patch 637031 2 144753 gyuyoung.kim 2012-05-30 01:55:38 -0700 Comment on attachment 144753 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144753&action=review LGTM. > LayoutTests/ChangeLog:3 > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message There is two spaces between *needs* and *"post. > Tools/ChangeLog:3 > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message ditto. 637040 3 144757 mikhail.pozdnyakov 2012-05-30 02:08:07 -0700 Created attachment 144757 patch v2 (corrected changelog) 637042 4 mikhail.pozdnyakov 2012-05-30 02:08:39 -0700 (In reply to comment #2) > (From update of attachment 144753 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144753&action=review > > LGTM. > > > LayoutTests/ChangeLog:3 > > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message > > There is two spaces between *needs* and *"post. > > > Tools/ChangeLog:3 > > + [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message > > ditto. Thanks. Fixed. 637079 5 144757 gyuyoung.kim 2012-05-30 03:02:07 -0700 Comment on attachment 144757 patch v2 (corrected changelog) LGTM. 637165 6 144757 webkit.review.bot 2012-05-30 06:55:29 -0700 Comment on attachment 144757 patch v2 (corrected changelog) Clearing flags on attachment: 144757 Committed r118918: <http://trac.webkit.org/changeset/118918> 637166 7 webkit.review.bot 2012-05-30 06:55:34 -0700 All reviewed patches have been landed. Closing bug. 637237 8 tmpsantos 2012-05-30 08:05:33 -0700 We have this new failure on the bot after this patch landed: http/tests/local/fileapi/file-last-modified-after-delete.html Mikhail, do you mind having a look? 637307 9 mikhail.pozdnyakov 2012-05-30 09:32:43 -0700 (In reply to comment #8) > We have this new failure on the bot after this patch landed: > > http/tests/local/fileapi/file-last-modified-after-delete.html > > Mikhail, do you mind having a look? Seems to be unrelated 144753 2012-05-30 01:49:12 -0700 2012-05-30 02:08:07 -0700 patch bug87833 text/plain 2990 mikhail.pozdnyakov Y29tbWl0IGZhOTFiMzBiNmRlYWU1M2M3M2UyODYzN2Y5NzMzY2JhMmYyMzQ4OTcKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg V2VkIE1heSAzMCAxMTo0Njo1OSAyMDEyICswMzAwCgogICAgYnVnODc4MzMKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzRm NGY3Mi4uMWUwNzhlNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTMwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdW0RSVF0gRUZMJ3MgRFJUIG5lZWRzICAicG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRp b24iIG1lc3NhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg3ODMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9lZmwvU2tpcHBlZDogVW5za2lwcGVkIGh0dHAvdGVzdHMvbG9hZGluZy9w cm9ncmVzcy1maW5pc2hlZC1jYWxsYmFjay5odG1sLgorCiAyMDEyLTA1LTMwICBNaWtlIExhd3Ro ZXIgIDxtaWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ1NTMyBjYWxjOiBJbXBs ZW1lbnQgQ1NTT00gc3VwcG9ydApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAppbmRleCA1OWNiNmY4 Li4wYTBkYWViIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApAQCAtMTExMiw3ICsxMTEyLDYg QEAgaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1mYWlsb3Zlci10by1uZXR3b3JrLmh0bWwK IGh0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtbXVsdGlwbGUtaW5zdGFuY2VzLmh0bWwKIGh0 dHAvdGVzdHMvbG9hZGluZy9hdXRoZW50aWNhdGlvbi1hZnRlci1yZWRpcmVjdC1zdG9yZXMtd3Jv bmctY3JlZGVudGlhbHMvYXV0aGVudGljYXRpb24tYWZ0ZXItcmVkaXJlY3Qtc3RvcmVzLXdyb25n LWNyZWRlbnRpYWxzLmh0bWwKIGh0dHAvdGVzdHMvbG9hZGluZy9uZXN0ZWRfYmFkX29iamVjdHMu cGhwCi1odHRwL3Rlc3RzL2xvYWRpbmcvcHJvZ3Jlc3MtZmluaXNoZWQtY2FsbGJhY2suaHRtbAog aHR0cC90ZXN0cy9taXNjLzQwMS1hbHRlcm5hdGl2ZS1jb250ZW50LnBocAogaHR0cC90ZXN0cy9t aXNjL2NvcHktcmVzb2x2ZXMtdXJscy5odG1sCiBodHRwL3Rlc3RzL21pc2MvU1ZHRm9udC1kZWxh eWVkLWxvYWQuaHRtbApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdl TG9nCmluZGV4IDI4NmM5M2MuLjJkNjM4ZjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0zMCAgTWlraGFp bCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKworICAgICAgICBb RUZMXVtEUlRdIEVGTCdzIERSVCBuZWVkcyAgInBvc3RQcm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0 aW9uIiBtZXNzYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NzgzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByaW50ICJwb3N0UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNhdGlvbiIgbWVzc2FnZSBpZiBm cmFtZSBsb2FkIGZpbmlzaGVkIAorICAgICAgICB0byB1bnNraXAgaHR0cC90ZXN0cy9sb2FkaW5n L3Byb2dyZXNzLWZpbmlzaGVkLWNhbGxiYWNrLmh0bWwuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRy ZWVDaHJvbWU6Om9uRnJhbWVMb2FkRmluaXNoZWQpOgorCiAyMDEyLTA1LTI5ICBKw6Fub3MgQmFk aWNzICA8amJhZGljc0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgW1F0XSBNb2RpZmllZCBP UldUIGFuZCBOUldUIHRvIGNoZWNrIGZvciB0ZXN0IGV4cGVjdGF0aW9ucyBpbiBwbGF0Zm9ybS9x dC01LjAtd2sxIHRvbwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBS ZW5kZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZUNocm9tZS5jcHAKaW5kZXggN2FjMmVjZS4uZDQwOWQ3ZCAxMDA2NDQKLS0tIGEvVG9vbHMv RHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC01ODEsNiArNTgx LDkgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6b25GcmFtZUxvYWRGaW5pc2hlZCh2b2lk KiwgRXZhc19PYmplY3QqIGZyYW1lLCB2b2lkKgogICAgIGlmIChlcnJvcikKICAgICAgICAgcmV0 dXJuOwogCisgICAgaWYgKCFkb25lICYmIGdMYXlvdXRUZXN0Q29udHJvbGxlci0+ZHVtcFByb2dy ZXNzRmluaXNoZWRDYWxsYmFjaygpKQorICAgICAgICBwcmludGYoInBvc3RQcm9ncmVzc0Zpbmlz aGVkTm90aWZpY2F0aW9uXG4iKTsKKwogICAgIGlmICghZG9uZSAmJiBnTGF5b3V0VGVzdENvbnRy b2xsZXItPmR1bXBGcmFtZUxvYWRDYWxsYmFja3MoKSkgewogICAgICAgICBjb25zdCBTdHJpbmcg ZnJhbWVOYW1lKER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c3VpdGFibGVEUlRGcmFtZU5hbWUo ZnJhbWUpKTsKICAgICAgICAgcHJpbnRmKCIlcyAtIGRpZEZpbmlzaExvYWRGb3JGcmFtZVxuIiwg ZnJhbWVOYW1lLnV0ZjgoKS5kYXRhKCkpOwo= 144757 2012-05-30 02:08:07 -0700 2012-05-30 06:55:29 -0700 patch v2 (corrected changelog) bug87833_v2 text/plain 2988 mikhail.pozdnyakov Y29tbWl0IGQ5NjFjMTYxNjIwYzJkOTAwMTA5NGRmNWExMDcyODY0NGEyNDVjNTUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg V2VkIE1heSAzMCAxMTo0Njo1OSAyMDEyICswMzAwCgogICAgYnVnODc4MzMKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzRm NGY3Mi4uZTg0NDdjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTMwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdW0RSVF0gRUZMJ3MgRFJUIG5lZWRzICJwb3N0UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNhdGlv biIgbWVzc2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODc4MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOiBVbnNraXBwZWQgaHR0cC90ZXN0cy9sb2FkaW5nL3By b2dyZXNzLWZpbmlzaGVkLWNhbGxiYWNrLmh0bWwuCisKIDIwMTItMDUtMzAgIE1pa2UgTGF3dGhl ciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1MzIGNhbGM6IEltcGxl bWVudCBDU1NPTSBzdXBwb3J0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwv U2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IDU5Y2I2Zjgu LjBhMGRhZWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC0xMTEyLDcgKzExMTIsNiBA QCBodHRwL3Rlc3RzL2NhY2hlL3N1YnJlc291cmNlLWZhaWxvdmVyLXRvLW5ldHdvcmsuaHRtbAog aHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1tdWx0aXBsZS1pbnN0YW5jZXMuaHRtbAogaHR0 cC90ZXN0cy9sb2FkaW5nL2F1dGhlbnRpY2F0aW9uLWFmdGVyLXJlZGlyZWN0LXN0b3Jlcy13cm9u Zy1jcmVkZW50aWFscy9hdXRoZW50aWNhdGlvbi1hZnRlci1yZWRpcmVjdC1zdG9yZXMtd3Jvbmct Y3JlZGVudGlhbHMuaHRtbAogaHR0cC90ZXN0cy9sb2FkaW5nL25lc3RlZF9iYWRfb2JqZWN0cy5w aHAKLWh0dHAvdGVzdHMvbG9hZGluZy9wcm9ncmVzcy1maW5pc2hlZC1jYWxsYmFjay5odG1sCiBo dHRwL3Rlc3RzL21pc2MvNDAxLWFsdGVybmF0aXZlLWNvbnRlbnQucGhwCiBodHRwL3Rlc3RzL21p c2MvY29weS1yZXNvbHZlcy11cmxzLmh0bWwKIGh0dHAvdGVzdHMvbWlzYy9TVkdGb250LWRlbGF5 ZWQtbG9hZC5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggMjg2YzkzYy4uMmQ0NDg3NSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTMwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdW0RSVF0gRUZMJ3MgRFJUIG5lZWRzICJwb3N0UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNhdGlv biIgbWVzc2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODc4MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQcmludCAicG9zdFByb2dyZXNzRmluaXNoZWROb3RpZmljYXRpb24iIG1lc3NhZ2UgaWYgZnJh bWUgbG9hZCBmaW5pc2hlZCAKKyAgICAgICAgdG8gdW5za2lwIGh0dHAvdGVzdHMvbG9hZGluZy9w cm9ncmVzcy1maW5pc2hlZC1jYWxsYmFjay5odG1sLgorCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVl Q2hyb21lOjpvbkZyYW1lTG9hZEZpbmlzaGVkKToKKwogMjAxMi0wNS0yOSAgSsOhbm9zIEJhZGlj cyAgPGpiYWRpY3NAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gTW9kaWZpZWQgT1JX VCBhbmQgTlJXVCB0byBjaGVjayBmb3IgdGVzdCBleHBlY3RhdGlvbnMgaW4gcGxhdGZvcm0vcXQt NS4wLXdrMSB0b28KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu ZGVyVHJlZUNocm9tZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWVDaHJvbWUuY3BwCmluZGV4IDdhYzJlY2UuLmQ0MDlkN2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcApAQCAtNTgxLDYgKzU4MSw5 IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6Om9uRnJhbWVMb2FkRmluaXNoZWQodm9pZCos IEV2YXNfT2JqZWN0KiBmcmFtZSwgdm9pZCoKICAgICBpZiAoZXJyb3IpCiAgICAgICAgIHJldHVy bjsKIAorICAgIGlmICghZG9uZSAmJiBnTGF5b3V0VGVzdENvbnRyb2xsZXItPmR1bXBQcm9ncmVz c0ZpbmlzaGVkQ2FsbGJhY2soKSkKKyAgICAgICAgcHJpbnRmKCJwb3N0UHJvZ3Jlc3NGaW5pc2hl ZE5vdGlmaWNhdGlvblxuIik7CisKICAgICBpZiAoIWRvbmUgJiYgZ0xheW91dFRlc3RDb250cm9s bGVyLT5kdW1wRnJhbWVMb2FkQ2FsbGJhY2tzKCkpIHsKICAgICAgICAgY29uc3QgU3RyaW5nIGZy YW1lTmFtZShEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnN1aXRhYmxlRFJURnJhbWVOYW1lKGZy YW1lKSk7CiAgICAgICAgIHByaW50ZigiJXMgLSBkaWRGaW5pc2hMb2FkRm9yRnJhbWVcbiIsIGZy YW1lTmFtZS51dGY4KCkuZGF0YSgpKTsK