87817 2012-05-29 21:18:17 -0700 [BlackBerry] The Page's deviceScaleFactor() is not being properly maintained 2012-11-02 12:43:12 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED FIXED P2 Normal --- 87551 1 mfeil mfeil jkjiang kpiascik tonikitoo webkit.review.bot oldest_to_newest 636809 0 mfeil 2012-05-29 21:18:17 -0700 When navigating between web pages with different CSS pixel sizes, the deviceScaleFactor is not maintained properly. Specifically, when navigating from a page with a deviceScaleFactor greater than one to a page with the default deviceScaleFactor of 1.0. My patch fixes two spots in the code. One where viewport changes from non-default to default are being erroneously thrown out, and another where viewport changes back to default are recognized but deviceScaleFactor is not being updated. 636818 1 144695 mfeil 2012-05-29 21:34:05 -0700 Created attachment 144695 Patch 636893 2 144695 webkit.review.bot 2012-05-29 23:18:04 -0700 Comment on attachment 144695 Patch Clearing flags on attachment: 144695 Committed r118895: <http://trac.webkit.org/changeset/118895> 636894 3 webkit.review.bot 2012-05-29 23:18:19 -0700 All reviewed patches have been landed. Closing bug. 757480 4 mfeil 2012-11-02 12:43:12 -0700 Closing bug for patch that landed a long time ago. 144695 2012-05-29 21:34:05 -0700 2012-05-29 23:18:03 -0700 Patch bug-87817-20120530003404.patch text/plain 2566 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4MDFkOWRiMWU1NWNlZDA5YjQ2ZDliOTQ0YmIwNTU3ZjQ0YTA0YWQ0Li45ZmQ1NTQwZGNj M2E5NWU0NjU0MDUxYTg0Mjk2MDY4ZDhhMDYzYzRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wNS0yNSAgTWF4IEZlaWwgIDxtZmVpbEByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUaGUgUGFnZSdzIGRldmljZVNjYWxlRmFjdG9y KCkgaXMgbm90IGJlaW5nIHByb3Blcmx5IG1haW50YWluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3ODE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBidWcgZml4IGluIFdlYktpdC9ibGFja2Jl cnJ5IGlzIG5lZWRlZCBieSB0aGUgY2hhbmdlcyBmb3IKKyAgICAgICAgZnVsbHNjcmVlbiBtZWRp YSBjb250cm9sIHNpemluZyBpbiBXZWJDb3JlIChidWcgODc1NTEpLiBUaGUgc2l6aW5nCisgICAg ICAgIG9mIGNvbnRyb2xzIGRlcGVuZHMgb24gdGhlIHBhZ2UncyBkZXZpY2VTY2FsZUZhY3Rvcigp LCB3aGljaCB3YXMKKyAgICAgICAgbm90IGJlaW5nIG1haW50YWluZWQgcHJvcGVybHkgZHVlIHRv IGVycm9ycyBpbiBsb2dpYy4gVmlld3BvcnQKKyAgICAgICAgY2hhbmdlcyBmcm9tIG5vbi1kZWZh dWx0IHRvIGRlZmF1bHQgd2VyZSBiZWluZyBlcnJvbmVvdXNseQorICAgICAgICB0aHJvd24gb3V0 LiBBbHNvLCB3aGVuIHRoZSB2aWV3cG9ydCBkaWQgY2hhbmdlIGJhY2sgdG8gZGVmYXVsdAorICAg ICAgICB0aGUgZGV2aWNlU2NhbGVGYWN0b3Igd2FzIG5vdCBiZWluZyB1cGRhdGVkLgorCisgICAg ICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQ YWdlUHJpdmF0ZTo6cmVjb21wdXRlVmlydHVhbFZpZXdwb3J0RnJvbVZpZXdwb3J0QXJndW1lbnRz KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmRpc3BhdGNo Vmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKToKKwogMjAxMi0wNS0yOSAgQXJ2aWQgTmlsc3Nv biAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFdlYk92ZXJsYXkg YnVpbGQgZml4ZXMgYW5kIGJ1ZyBmaXhlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKaW5kZXggYjkxZTlkYzcxNjM2MDM4N2ZlZjBiNGJlMTUzYjNiYjY3ZGNhYmU2Yy4u NmRhZDhkZGExZTdlYWU0ZTA2OWRjYjg2ZTA1YjVjYWQ3OWJkNjUwMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0zMzU4LDggKzMzNTgsMTAgQEAgdm9pZCBX ZWJQYWdlOjpyZXNldFZpcnR1YWxWaWV3cG9ydE9uQ29tbWl0dGVkKGJvb2wgcmVzZXQpCiBJbnRT aXplIFdlYlBhZ2VQcml2YXRlOjpyZWNvbXB1dGVWaXJ0dWFsVmlld3BvcnRGcm9tVmlld3BvcnRB cmd1bWVudHMoKQogewogICAgIHN0YXRpYyBjb25zdCBWaWV3cG9ydEFyZ3VtZW50cyBkZWZhdWx0 Vmlld3BvcnRBcmd1bWVudHM7Ci0gICAgaWYgKG1fdmlld3BvcnRBcmd1bWVudHMgPT0gZGVmYXVs dFZpZXdwb3J0QXJndW1lbnRzKQorICAgIGlmIChtX3ZpZXdwb3J0QXJndW1lbnRzID09IGRlZmF1 bHRWaWV3cG9ydEFyZ3VtZW50cykgeworICAgICAgICBtX3BhZ2UtPnNldERldmljZVNjYWxlRmFj dG9yKDEuMCk7CiAgICAgICAgIHJldHVybiBJbnRTaXplKCk7CisgICAgfQogCiAgICAgaW50IGRl c2t0b3BXaWR0aCA9IGRlZmF1bHRNYXhMYXlvdXRTaXplKCkud2lkdGgoKTsKICAgICBpbnQgZGV2 aWNlV2lkdGggPSBQbGF0Zm9ybTo6R3JhcGhpY3M6OlNjcmVlbjo6cHJpbWFyeVNjcmVlbigpLT53 aWR0aCgpOwpAQCAtMzM5Nyw4ICszMzk5LDcgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6ZGlkUmVj ZWl2ZVRvdWNoRXZlbnRNb2RlKFRvdWNoRXZlbnRNb2RlIG1vZGUpCiAKIHZvaWQgV2ViUGFnZVBy aXZhdGU6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKGNvbnN0IFZpZXdwb3J0 QXJndW1lbnRzJiBhcmd1bWVudHMpCiB7Ci0gICAgc3RhdGljIFZpZXdwb3J0QXJndW1lbnRzIGRl ZmF1bHRWaWV3cG9ydEFyZ3VtZW50czsKLSAgICBpZiAoYXJndW1lbnRzID09IGRlZmF1bHRWaWV3 cG9ydEFyZ3VtZW50cykKKyAgICBpZiAoYXJndW1lbnRzID09IG1fdmlld3BvcnRBcmd1bWVudHMp CiAgICAgICAgIHJldHVybjsKIAogICAgIG1fdmlld3BvcnRBcmd1bWVudHMgPSBhcmd1bWVudHM7 Cg==