87811 2012-05-29 19:16:56 -0700 correct the sequence of diagnostic crash check 2012-05-29 22:18:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 guanqun.lu guanqun.lu cc-bugs enne jamesr webkit.review.bot oldest_to_newest 636739 0 guanqun.lu 2012-05-29 19:16:56 -0700 correct the sequence of diagnostic crash check 636740 1 144678 guanqun.lu 2012-05-29 19:18:10 -0700 Created attachment 144678 Patch 636750 2 guanqun.lu 2012-05-29 19:26:29 -0700 We should do the null check before we de-reference the pointer. Otherwise, we don't get the benefits of crash check. 636789 3 144678 jamesr 2012-05-29 21:00:04 -0700 Comment on attachment 144678 Patch I think you slightly misunderstand the meaning of the tileAt() check - we're trying to verify that _after_ adding the tile it exists. Moving the CHECK() for addedTile seems reasonable. 636841 4 guanqun.lu 2012-05-29 21:58:40 -0700 (In reply to comment #3) > (From update of attachment 144678 [details]) > I think you slightly misunderstand the meaning of the tileAt() check - we're trying to verify that _after_ adding the tile it exists. Moving the CHECK() for addedTile seems reasonable. It does check the tile _after_ it's been added, since it's after the line "m_tiler->addTile(tile.release(), i, j);". The line "addedTile->dirtyRect = m_tiler->tileRect(addedTile);" doesn't add the tile, does it? Do I miss something here? 636848 5 144678 jamesr 2012-05-29 22:11:40 -0700 Comment on attachment 144678 Patch Ah sorry, you're right. Still not sure it's worth churning the line numbers, we're going to remove these lines in a few days anyway. 636854 6 guanqun.lu 2012-05-29 22:18:54 -0700 (In reply to comment #5) > (From update of attachment 144678 [details]) > Ah sorry, you're right. Still not sure it's worth churning the line numbers, we're going to remove these lines in a few days anyway. OK. It's good to know that these lines would be removed. So I will mark this bug as won't fix. Thanks for the review anyway. 144678 2012-05-29 19:18:10 -0700 2012-05-29 22:11:40 -0700 Patch bug-87811-20120530101836.patch text/plain 1497 guanqun.lu U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRiNTAyNjEwMWFkNzc2 NzlmNjgwOGM0NzgyODc4ODZjYjIzNWMwMi4uNzM5YmY3MmNmMWIzMmY2MTY4ZGNkMmU4ZGNkOTky MjhhODE3MGU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTI5ICBMdSBH dWFucXVuICA8Z3VhbnF1bi5sdUBpbnRlbC5jb20+CisKKyAgICAgICAgY29ycmVjdCB0aGUgc2Vx dWVuY2Ugb2YgZGlhZ25vc3RpYyBjcmFzaCBjaGVjaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc4MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RpbGVk TGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUaWxlZExheWVyQ2hyb21pdW06 OmNyZWF0ZVRpbGUpOgorCiAyMDEyLTA1LTI1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTEyMTU1LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRMYXllckNo cm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Rp bGVkTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggMTdjMzUxZjZkN2RmYmRiYWMxYzlkODVlYmE3NGU4 Njk3MWNjOWNjNi4uZWI0ODdkYTAzZjI0YjU0YjIzNjJiNzE3ZTBiYmVmNWQ5YTI1YzYxNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVGlsZWRM YXllckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9UaWxlZExheWVyQ2hyb21pdW0uY3BwCkBAIC0yNjAsMTQgKzI2MCwxNCBAQCBVcGRh dGFibGVUaWxlKiBUaWxlZExheWVyQ2hyb21pdW06OmNyZWF0ZVRpbGUoaW50IGksIGludCBqKQog ICAgIFVwZGF0YWJsZVRpbGUqIGFkZGVkVGlsZSA9IHRpbGUuZ2V0KCk7CiAgICAgbV90aWxlci0+ YWRkVGlsZSh0aWxlLnJlbGVhc2UoKSwgaSwgaik7CiAKLSAgICBhZGRlZFRpbGUtPmRpcnR5UmVj dCA9IG1fdGlsZXItPnRpbGVSZWN0KGFkZGVkVGlsZSk7Ci0KICAgICAvLyBUZW1wb3JhcnkgZGlh Z25vc3RpYyBjcmFzaC4KICAgICBpZiAoIWFkZGVkVGlsZSkKICAgICAgICAgQ1JBU0goKTsKICAg ICBpZiAoIXRpbGVBdChpLCBqKSkKICAgICAgICAgQ1JBU0goKTsKIAorICAgIGFkZGVkVGlsZS0+ ZGlydHlSZWN0ID0gbV90aWxlci0+dGlsZVJlY3QoYWRkZWRUaWxlKTsKKwogICAgIHJldHVybiBh ZGRlZFRpbGU7CiB9CiAK