87808 2012-05-29 18:54:26 -0700 [Qt] handled touchmove events should not cancel tap gesture recognition 2012-05-31 02:39:55 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 luiz luiz abecsi cmarcelo kenneth menard noam tonikitoo webkit.review.bot zoltan oldest_to_newest 636716 0 luiz 2012-05-29 18:54:26 -0700 All the gesture recognition is canceled when a touch event is handled by webprocess. If the touchmove event is handled by javascript then any touchmove, does not matter the length of the movement, will cancel the tap gesture recognition. 636731 1 tonikitoo 2012-05-29 19:09:34 -0700 (In reply to comment #0) > All the gesture recognition is canceled when a touch event is handled by webprocess. > > If the touchmove event is handled by javascript then any touchmove, does not matter the length of the movement, will cancel the tap gesture recognition. If I understood it correctly, we do the same for the blackberry port. 637430 2 144870 luiz 2012-05-30 11:02:42 -0700 Created attachment 144870 patch 637671 3 144870 kenneth 2012-05-30 14:00:18 -0700 Comment on attachment 144870 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review LGTM, but please cc Andras > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 > - resetGestureRecognizers(); Maybe that method is useless now? Did you check? 637688 4 luiz 2012-05-30 14:20:25 -0700 (In reply to comment #3) > (From update of attachment 144870 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review > > LGTM, but please cc Andras > > > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 > > - resetGestureRecognizers(); > > Maybe that method is useless now? Did you check? It is used by QQuickWebViewPrivate::processDidCrash. 637698 5 144870 kenneth 2012-05-30 14:36:59 -0700 Comment on attachment 144870 patch View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review >>> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 >>> - resetGestureRecognizers(); >> >> Maybe that method is useless now? Did you check? > > It is used by QQuickWebViewPrivate::processDidCrash. OK, but I guess I will just do the cancels explicitly there instead... 637828 6 144870 webkit.review.bot 2012-05-30 16:56:44 -0700 Comment on attachment 144870 patch Clearing flags on attachment: 144870 Committed r118997: <http://trac.webkit.org/changeset/118997> 637829 7 webkit.review.bot 2012-05-30 16:56:49 -0700 All reviewed patches have been landed. Closing bug. 638153 8 abecsi 2012-05-31 02:39:55 -0700 (In reply to comment #5) > (From update of attachment 144870 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144870&action=review > > >>> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:-439 > >>> - resetGestureRecognizers(); > >> > >> Maybe that method is useless now? Did you check? > > > > It is used by QQuickWebViewPrivate::processDidCrash. > > OK, but I guess I will just do the cancels explicitly there instead... I'm working on a patch which removes that function and also the base class of the recognizers as discussed earlier, but first I want to simplify the tap gesture recognizer a bit. 144870 2012-05-30 11:02:42 -0700 2012-05-30 16:56:44 -0700 patch 0001-Qt-handled-touchmove-events-should-not-cancel-tap-ge.patch text/plain 2213 luiz RnJvbSA4NTU5YTI2MzM5NDE4Y2Q2ZGQ4ODA1MjIwMWM3MzFmY2Q3YzY1YzQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG5va2lhLmNv bT4KRGF0ZTogVHVlLCAyOSBNYXkgMjAxMiAxOTowNTo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd IFtRdF0gaGFuZGxlZCB0b3VjaG1vdmUgZXZlbnRzIHNob3VsZCBub3QgY2FuY2VsIHRhcCBnZXN0 dXJlCiByZWNvZ25pdGlvbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODc4MDgKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVGFwIGdlc3R1cmUgcmVjb2duaXRp b24gc2hvdWxkIG5vdCBiZSBjYW5jZWxlZCBpZiBhIHRvdWNobW92ZSBldmVudCBpcyBoYW5kbGVk CmJ5IHRoZSB3ZWIgcHJvY2Vzcy4KCiogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxl ci5jcHA6CihXZWJLaXQ6OlF0V2ViUGFnZUV2ZW50SGFuZGxlcjo6ZG9uZVdpdGhUb3VjaEV2ZW50 KToKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFn ZUV2ZW50SGFuZGxlci5jcHAgfCAgICA1ICsrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjYyYjQ5MC4uZTExY2ExMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTI5ICBMdWl6IEFnb3N0aW5pICA8 bHVpei5hZ29zdGluaUBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBoYW5kbGVkIHRvdWNobW92 ZSBldmVudHMgc2hvdWxkIG5vdCBjYW5jZWwgdGFwIGdlc3R1cmUgcmVjb2duaXRpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3ODA4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGFwIGdlc3R1cmUgcmVj b2duaXRpb24gc2hvdWxkIG5vdCBiZSBjYW5jZWxlZCBpZiBhIHRvdWNobW92ZSBldmVudCBpcyBo YW5kbGVkCisgICAgICAgIGJ5IHRoZSB3ZWIgcHJvY2Vzcy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdFdlYlBh Z2VFdmVudEhhbmRsZXI6OmRvbmVXaXRoVG91Y2hFdmVudCk6CisKIDIwMTItMDUtMjkgIFN1ZGFy c2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CiAKICAg ICAgICAgW0dUS10gW1dLMl0gUmVwcm9kdWNpYmxlIGNyYXNoIGluIHBlcmZvcm1EcmFnQ29udHJv bGxlckFjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2Vi UGFnZUV2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQ YWdlRXZlbnRIYW5kbGVyLmNwcAppbmRleCBjMWViYWFjLi5iYmRjM2E2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcApA QCAtNDM2LDcgKzQzNiwxMCBAQCB2b2lkIFF0V2ViUGFnZUV2ZW50SGFuZGxlcjo6ZG9uZVdpdGhU b3VjaEV2ZW50KGNvbnN0IE5hdGl2ZVdlYlRvdWNoRXZlbnQmIGV2ZW50LAogICAgICAgICByZXR1 cm47CiAKICAgICBpZiAod2FzRXZlbnRIYW5kbGVkIHx8IGV2ZW50LnR5cGUoKSA9PSBXZWJFdmVu dDo6VG91Y2hDYW5jZWwpIHsKLSAgICAgICAgcmVzZXRHZXN0dXJlUmVjb2duaXplcnMoKTsKKyAg ICAgICAgbV9wYW5HZXN0dXJlUmVjb2duaXplci5jYW5jZWwoKTsKKyAgICAgICAgbV9waW5jaEdl c3R1cmVSZWNvZ25pemVyLmNhbmNlbCgpOworICAgICAgICBpZiAoZXZlbnQudHlwZSgpICE9IFdl YkV2ZW50OjpUb3VjaE1vdmUpCisgICAgICAgICAgICBtX3RhcEdlc3R1cmVSZWNvZ25pemVyLmNh bmNlbCgpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0tIAoxLjcuOS41Cgo=