87804 2012-05-29 18:23:07 -0700 Fix inefficient usage of traverseNextNode() 2012-05-29 21:03:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent darin morrita rniwa webkit.review.bot oldest_to_newest 636679 0 tkent 2012-05-29 18:23:07 -0700 See https://bugs.webkit.org/show_bug.cgi?id=86534#c49 636686 1 144668 tkent 2012-05-29 18:29:38 -0700 Created attachment 144668 Patch 636702 2 144669 tkent 2012-05-29 18:38:18 -0700 Created attachment 144669 Patch for landing fix typos 636790 3 144669 webkit.review.bot 2012-05-29 21:03:25 -0700 Comment on attachment 144669 Patch for landing Clearing flags on attachment: 144669 Committed r118888: <http://trac.webkit.org/changeset/118888> 636791 4 webkit.review.bot 2012-05-29 21:03:29 -0700 All reviewed patches have been landed. Closing bug. 144668 2012-05-29 18:29:38 -0700 2012-05-29 18:38:12 -0700 Patch bug-87804-20120530102936.patch text/plain 2917 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NkYmU4NjJkMmNiNWVm NzlmYzExM2YwNjMyMDE1MjdjNDM3N2IxNy4uNzM0MmFkNTQ0YmE3ZjkzZDMwYWE1NmViNWVlZDJj YzlkNGFmOGYyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTI5ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggaW5lZmZpY2llbnQg dXNhZ2Ugb2YgdHJhdmVyc2VOZXh0Tm9kZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NzgwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGZvby0+dHJhdmVyc2VOZXh0Tm9kZShmb28pIGlzIGVxdWl2YWxl bnQgdG8gZm9vLT5maXJzdENoaWxkKCksIGFuZAorICAgICAgICBmaXJzdENoaWxkKCkgaXMgbW9y ZSBlZmZpY2llbnQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugb2Ygbm8gYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogaHRtbC9IVE1MRmllbGRTZXRFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxGaWVsZFNldEVsZW1lbnQ6OmludmFsaWRhdGVEaXNhYmxlZFN0 YXRlVW5kZXIpOgorICAgICAgICBSZXBsYXNlIHRyYXZlcnNlTmV4dE5vZGUoKSB3aXRoIGZpcnN0 Q2hpbGQoKSwgYW5kIHNob3J0ZW4gYSB2YXJpYWJsZSBuYW1lLgorICAgICAgICAqIHN2Zy9TVkdT VkdFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NWR0VsZW1lbnQ6OmdldEVsZW1l bnRCeUlkKToKKyAgICAgICAgUmVwbGFzZSB0cmF2ZXJzZU5leHROb2RlKCkgd2l0aCBmaXJzdENo aWxkKCkuCisKIDIwMTItMDUtMjkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6 QGludGVsLmNvbT4KIAogICAgICAgICBTb21lIENvbnRlbnQgU2VjdXJpdHkgUG9saWN5IGNvbnNv bGUgbWVzc2FnZXMgYXJlIG1pc3NpbmcgbGluZSBudW1iZXJzIGluIEpTQwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRmllbGRTZXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEZpZWxkU2V0RWxlbWVudC5jcHAKaW5kZXggYTc0ZTczMjg2ODgzYzMzMjA1 NGEyYzZjODJmYjkwMzIzMzRjOTNkNS4uYzBiMDdlODY3MDk5NjY1YTJlMTNjYWE4NTE1MWE4ZTg2 NDIxNzdkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRmllbGRTZXRFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGaWVsZFNldEVsZW1lbnQuY3Bw CkBAIC00OSw5ICs0OSw5IEBAIFBhc3NSZWZQdHI8SFRNTEZpZWxkU2V0RWxlbWVudD4gSFRNTEZp ZWxkU2V0RWxlbWVudDo6Y3JlYXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmCiAKIHZvaWQgSFRNTEZp ZWxkU2V0RWxlbWVudDo6aW52YWxpZGF0ZURpc2FibGVkU3RhdGVVbmRlcihFbGVtZW50KiBiYXNl KQogewotICAgIGZvciAoTm9kZSogY3VycmVudE5vZGUgPSBiYXNlLT50cmF2ZXJzZU5leHROb2Rl KGJhc2UpOyBjdXJyZW50Tm9kZTsgY3VycmVudE5vZGUgPSBjdXJyZW50Tm9kZS0+dHJhdmVyc2VO ZXh0Tm9kZShiYXNlKSkgewotICAgICAgICBpZiAoY3VycmVudE5vZGUgJiYgY3VycmVudE5vZGUt PmlzRWxlbWVudE5vZGUoKSAmJiB0b0VsZW1lbnQoY3VycmVudE5vZGUpLT5pc0Zvcm1Db250cm9s RWxlbWVudCgpKQotICAgICAgICAgICAgc3RhdGljX2Nhc3Q8SFRNTEZvcm1Db250cm9sRWxlbWVu dCo+KGN1cnJlbnROb2RlKS0+YW5jZXN0b3JEaXNhYmxlZFN0YXRlV2FzQ2hhbmdlZCgpOworICAg IGZvciAoTm9kZSogbm9kZSA9IGJhc2UtPmZpcnN0Q2hpbGQoKTsgbm9kZTsgbm9kZSA9IG5vZGUt PnRyYXZlcnNlTmV4dE5vZGUoYmFzZSkpIHsKKyAgICAgICAgaWYgKG5vZGUtPmlzRWxlbWVudE5v ZGUoKSAmJiB0b0VsZW1lbnQobm9kZSktPmlzRm9ybUNvbnRyb2xFbGVtZW50KCkpCisgICAgICAg ICAgICBzdGF0aWNfY2FzdDxIVE1MRm9ybUNvbnRyb2xFbGVtZW50Kj4obm9kZSktPmFuY2VzdG9y RGlzYWJsZWRTdGF0ZVdhc0NoYW5nZWQoKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdT VkdFbGVtZW50LmNwcAppbmRleCA0YjQzOGY1MDljNjE1MjZmODY0MGYxNjE3NmU0ZTgwOGEzOWUz NDVhLi44Y2RlN2Q1MTZjNmEyMTBiNDM3YzcyNTJiY2U0MGJjMGIxOTc2ODc1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHU1ZHRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvc3ZnL1NWR1NWR0VsZW1lbnQuY3BwCkBAIC03NTQsNyArNzU0LDcgQEAgRWxlbWVudCogU1ZH U1ZHRWxlbWVudDo6Z2V0RWxlbWVudEJ5SWQoY29uc3QgQXRvbWljU3RyaW5nJiBpZCkgY29uc3QK IAogICAgIC8vIEZhbGwgYmFjayB0byB0cmF2ZXJzaW5nIG91ciBzdWJ0cmVlLiBEdXBsaWNhdGUg aWRzIGFyZSBhbGxvd2VkLCB0aGUgZmlyc3QgZm91bmQgd2lsbAogICAgIC8vIGJlIHJldHVybmVk LgotICAgIGZvciAoTm9kZSogbm9kZSA9IHRyYXZlcnNlTmV4dE5vZGUodGhpcyk7IG5vZGU7IG5v ZGUgPSBub2RlLT50cmF2ZXJzZU5leHROb2RlKHRoaXMpKSB7CisgICAgZm9yIChOb2RlKiBub2Rl ID0gZmlyc3RDaGlsZCgpOyBub2RlOyBub2RlID0gbm9kZS0+dHJhdmVyc2VOZXh0Tm9kZSh0aGlz KSkgewogICAgICAgICBpZiAoIW5vZGUtPmlzRWxlbWVudE5vZGUoKSkKICAgICAgICAgICAgIGNv bnRpbnVlOwogCg== 144669 2012-05-29 18:38:18 -0700 2012-05-29 21:03:24 -0700 Patch for landing bug-87804-20120530103817.patch text/plain 2915 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NkYmU4NjJkMmNiNWVm NzlmYzExM2YwNjMyMDE1MjdjNDM3N2IxNy4uMjQ5YmE5ZThkMzdlMDkzNTUwMzQ0MWNmZWZiNzVi NGU1ZDRhMjRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTI5ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggaW5lZmZpY2llbnQg dXNhZ2Ugb2YgdHJhdmVyc2VOZXh0Tm9kZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NzgwNAorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2Ug Tml3YS4KKworICAgICAgICBmb28tPnRyYXZlcnNlTmV4dE5vZGUoZm9vKSBpcyBlcXVpdmFsZW50 IHRvIGZvby0+Zmlyc3RDaGlsZCgpLCBhbmQKKyAgICAgICAgZmlyc3RDaGlsZCgpIGlzIG1vcmUg ZWZmaWNpZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIG9mIG5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIGh0bWwvSFRNTEZpZWxkU2V0RWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRmllbGRTZXRFbGVtZW50OjppbnZhbGlkYXRlRGlzYWJsZWRTdGF0 ZVVuZGVyKToKKyAgICAgICAgUmVwbGFjZSB0cmF2ZXJzZU5leHROb2RlKCkgd2l0aCBmaXJzdENo aWxkKCksIGFuZCBzaG9ydGVuIGEgdmFyaWFibGUgbmFtZS4KKyAgICAgICAgKiBzdmcvU1ZHU1ZH RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdTVkdFbGVtZW50OjpnZXRFbGVtZW50 QnlJZCk6CisgICAgICAgIFJlcGxhY2UgdHJhdmVyc2VOZXh0Tm9kZSgpIHdpdGggZmlyc3RDaGls ZCgpLgorCiAyMDEyLTA1LTI5ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBp bnRlbC5jb20+CiAKICAgICAgICAgU29tZSBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBjb25zb2xl IG1lc3NhZ2VzIGFyZSBtaXNzaW5nIGxpbmUgbnVtYmVycyBpbiBKU0MKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZpZWxkU2V0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGaWVsZFNldEVsZW1lbnQuY3BwCmluZGV4IGE3NGU3MzI4Njg4M2MzMzIwNTRh MmM2YzgyZmI5MDMyMzM0YzkzZDUuLmMwYjA3ZTg2NzA5OTY2NWEyZTEzY2FhODUxNTFhOGU4NjQy MTc3ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZpZWxkU2V0RWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRmllbGRTZXRFbGVtZW50LmNwcApA QCAtNDksOSArNDksOSBAQCBQYXNzUmVmUHRyPEhUTUxGaWVsZFNldEVsZW1lbnQ+IEhUTUxGaWVs ZFNldEVsZW1lbnQ6OmNyZWF0ZShjb25zdCBRdWFsaWZpZWROYW1lJgogCiB2b2lkIEhUTUxGaWVs ZFNldEVsZW1lbnQ6OmludmFsaWRhdGVEaXNhYmxlZFN0YXRlVW5kZXIoRWxlbWVudCogYmFzZSkK IHsKLSAgICBmb3IgKE5vZGUqIGN1cnJlbnROb2RlID0gYmFzZS0+dHJhdmVyc2VOZXh0Tm9kZShi YXNlKTsgY3VycmVudE5vZGU7IGN1cnJlbnROb2RlID0gY3VycmVudE5vZGUtPnRyYXZlcnNlTmV4 dE5vZGUoYmFzZSkpIHsKLSAgICAgICAgaWYgKGN1cnJlbnROb2RlICYmIGN1cnJlbnROb2RlLT5p c0VsZW1lbnROb2RlKCkgJiYgdG9FbGVtZW50KGN1cnJlbnROb2RlKS0+aXNGb3JtQ29udHJvbEVs ZW1lbnQoKSkKLSAgICAgICAgICAgIHN0YXRpY19jYXN0PEhUTUxGb3JtQ29udHJvbEVsZW1lbnQq PihjdXJyZW50Tm9kZSktPmFuY2VzdG9yRGlzYWJsZWRTdGF0ZVdhc0NoYW5nZWQoKTsKKyAgICBm b3IgKE5vZGUqIG5vZGUgPSBiYXNlLT5maXJzdENoaWxkKCk7IG5vZGU7IG5vZGUgPSBub2RlLT50 cmF2ZXJzZU5leHROb2RlKGJhc2UpKSB7CisgICAgICAgIGlmIChub2RlLT5pc0VsZW1lbnROb2Rl KCkgJiYgdG9FbGVtZW50KG5vZGUpLT5pc0Zvcm1Db250cm9sRWxlbWVudCgpKQorICAgICAgICAg ICAgc3RhdGljX2Nhc3Q8SFRNTEZvcm1Db250cm9sRWxlbWVudCo+KG5vZGUpLT5hbmNlc3RvckRp c2FibGVkU3RhdGVXYXNDaGFuZ2VkKCk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHU1ZHRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHU1ZH RWxlbWVudC5jcHAKaW5kZXggNGI0MzhmNTA5YzYxNTI2Zjg2NDBmMTYxNzZlNGU4MDhhMzllMzQ1 YS4uOGNkZTdkNTE2YzZhMjEwYjQzN2M3MjUyYmNlNDBiYzBiMTk3Njg3NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvc3ZnL1NWR1NWR0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9TVkdTVkdFbGVtZW50LmNwcApAQCAtNzU0LDcgKzc1NCw3IEBAIEVsZW1lbnQqIFNWR1NW R0VsZW1lbnQ6OmdldEVsZW1lbnRCeUlkKGNvbnN0IEF0b21pY1N0cmluZyYgaWQpIGNvbnN0CiAK ICAgICAvLyBGYWxsIGJhY2sgdG8gdHJhdmVyc2luZyBvdXIgc3VidHJlZS4gRHVwbGljYXRlIGlk cyBhcmUgYWxsb3dlZCwgdGhlIGZpcnN0IGZvdW5kIHdpbGwKICAgICAvLyBiZSByZXR1cm5lZC4K LSAgICBmb3IgKE5vZGUqIG5vZGUgPSB0cmF2ZXJzZU5leHROb2RlKHRoaXMpOyBub2RlOyBub2Rl ID0gbm9kZS0+dHJhdmVyc2VOZXh0Tm9kZSh0aGlzKSkgeworICAgIGZvciAoTm9kZSogbm9kZSA9 IGZpcnN0Q2hpbGQoKTsgbm9kZTsgbm9kZSA9IG5vZGUtPnRyYXZlcnNlTmV4dE5vZGUodGhpcykp IHsKICAgICAgICAgaWYgKCFub2RlLT5pc0VsZW1lbnROb2RlKCkpCiAgICAgICAgICAgICBjb250 aW51ZTsKIAo=