87795 2012-05-29 17:07:03 -0700 nrwt: seems to leak temp dirs 2012-05-30 14:59:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 636583 0 dpranke 2012-05-29 17:07:03 -0700 nrwt: seems to leak temp dirs 636594 1 144649 dpranke 2012-05-29 17:12:04 -0700 Created attachment 144649 Patch 636772 2 144649 ojan 2012-05-29 20:12:24 -0700 Comment on attachment 144649 Patch __del__ aside, I like this code better. It's more clear when things happen. 636793 3 144649 eric 2012-05-29 21:03:58 -0700 Comment on attachment 144649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144649&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463 > - def __del__(self): > - self._port._filesystem.rmtree(str(self._driver_tempdir)) Maybe we should ASSERT that stop_driver was called? i.e. that _driver_tempdir was set back to None? 637721 4 dpranke 2012-05-30 14:53:53 -0700 (In reply to comment #3) > (From update of attachment 144649 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144649&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:-463 > > - def __del__(self): > > - self._port._filesystem.rmtree(str(self._driver_tempdir)) > > Maybe we should ASSERT that stop_driver was called? i.e. that _driver_tempdir was set back to None? Sure, I can add that. 637729 5 dpranke 2012-05-30 14:59:11 -0700 Committed r118979: <http://trac.webkit.org/changeset/118979> 144649 2012-05-29 17:12:04 -0700 2012-05-29 21:03:58 -0700 Patch bug-87795-20120529171203.patch text/plain 6373 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTQwYmE2NDgzZmNlMDVlMDMyNGFjZGRiMjA2ZmVmY2Q5 NzQ4YjkxYy4uNjdhZTY1OWQyN2YzYjZhNDYwNjY4MTU5OGVkODkxN2I1MjZkZTZkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM3 IEBACiAyMDEyLTA1LTI5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IHNlZW1zIHRvIGxlYWsgdGVtcCBkaXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Nzc5NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFwcGVhcnMgdG8gYmUgYSBidWcgd2hl cmUgdGhlIGNocm9taXVtIGJvdHMgYXJlIGNyZWF0aW5nCisgICAgICAgIHRlbXBvcmFyeSBkaXJl Y3RvcmllcyBhbmQgbm90IGNsZWFuaW5nIHRoZW0gdXAgdGhhdCBzdGFydGVkCisgICAgICAgIGFm dGVyIHRoZSBzd2l0Y2ggdG8gV2ViS2l0RHJpdmVyLiBJdCdzIHBvc3NpYmxlIHRoYXQgX19kZWxf XworICAgICAgICB3YXNuJ3QgZ2V0dGluZyBjYWxsZWQgaW4gYSB0aW1lbHkgbWFubmVyIChvciBh dCBhbGwpLCBhbmQgaXQncworICAgICAgICBnZW5lcmFsbHkgYmFkIHN0eWxlIHRvIHJlbHkgb24g X19kZWxfXyBiZWluZyBjYWxsZWQsIHNvIHRoaXMKKyAgICAgICAgY29kZSBjaGFuZ2VzIHRoaW5n cyBzbyB0aGF0IHdlIGNyZWF0ZSBhIHRlbXAgZGlyIGluCisgICAgICAgIGRyaXZlci5zdGFydCgp IGFuZCByZW1vdmUgaXQgaW4gZHJpdmVyLnN0b3AoKS4gV2UgY291bGQgYmUKKyAgICAgICAgcGFy YW5vaWQgYW5kIGxlYXZlIHRoZSBfX2RlbF9fIGNvZGUgaW4sIGJ1dCB0aGVyZSBkb2Vzbid0IHNl ZW0KKyAgICAgICAgdG8gYmUgbXVjaCBhZHZhbnRhZ2UgdG8gaXQuIElmIHRoZXJlIGFyZSBidWdz IHRoYXQgcmVzdWx0IGluCisgICAgICAgIGRyaXZlcnMgYmVpbmcgc3RhcnRlZCBidXQgbm90IHN0 b3BwZWQsIHdlIGhhdmUgb3RoZXIgcHJvYmxlbXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9tb2NrLnB5OgorICAgICAgICAoTW9ja0ZpbGVT eXN0ZW0uX19pbml0X18pOgorICAgICAgICAoTW9ja0ZpbGVTeXN0ZW0uX21rdGVtcCk6CisgICAg ICAgIChNb2NrRmlsZVN5c3RlbS5ta2R0ZW1wKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weToKKyAgICAgICAgKFdlYktpdERyaXZlci5fX2lu aXRfXyk6CisgICAgICAgIChXZWJLaXREcml2ZXIuX3N0YXJ0KToKKyAgICAgICAgKFdlYktpdERy aXZlci5zdG9wKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3dlYmtpdF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdERyaXZlclRlc3QudGVzdF9jaGVj a19mb3JfZHJpdmVyX2NyYXNoKToKKyAgICAgICAgKFdlYktpdERyaXZlclRlc3QpOgorICAgICAg ICAoV2ViS2l0RHJpdmVyVGVzdC50ZXN0X2NyZWF0aW5nX2FfcG9ydF9kb2VzX25vdF93cml0ZV90 b190aGVfZmlsZXN5c3RlbSk6CisgICAgICAgIChXZWJLaXREcml2ZXJUZXN0LnRlc3Rfc3RvcF9j bGVhbnNfdXBfcHJvcGVybHkpOgorCisyMDEyLTA1LTI5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VA Y2hyb21pdW0ub3JnPgorCiAgICAgICAgIHdlYmtpdHB5OiByZW5hbWUgJ3JtJyB0byAnZGVsZXRl JyBpbiByZWJhc2VsaW5lIHNjbSBvdXRwdXQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg3Nzc5CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lzdGVtX21vY2sucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9tb2NrLnB5CmluZGV4IGQ0YTk1NTA4MGY4 NmE2NjBhYTE2MjQ2YjE4NjU5YzA5NzcyNWZmYjcuLmE0ZWI2OTViZmZlYTE4NDhhZWFhY2UyNDZl ODIzMjE5NzYxNTUyNjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS9maWxlc3lzdGVtX21vY2sucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL2ZpbGVzeXN0ZW1fbW9jay5weQpAQCAtNDcsNiArNDcsNyBAQCBjbGFzcyBN b2NrRmlsZVN5c3RlbShvYmplY3QpOgogICAgICAgICAiIiIKICAgICAgICAgc2VsZi5maWxlcyA9 IGZpbGVzIG9yIHt9CiAgICAgICAgIHNlbGYud3JpdHRlbl9maWxlcyA9IHt9CisgICAgICAgIHNl bGYubGFzdF90bXBkaXIgPSBOb25lCiAgICAgICAgIHNlbGYuX3NlcCA9ICcvJwogICAgICAgICBz ZWxmLmN1cnJlbnRfdG1wbm8gPSAwCiAgICAgICAgIHNlbGYuY3dkID0gY3dkCkBAIC0yMzMsNyAr MjM0LDggQEAgY2xhc3MgTW9ja0ZpbGVTeXN0ZW0ob2JqZWN0KToKICAgICAgICAgICAgIGRpciA9 IHNlbGYuc2VwICsgJ19faW1fdG1wJwogICAgICAgICBjdXJubyA9IHNlbGYuY3VycmVudF90bXBu bwogICAgICAgICBzZWxmLmN1cnJlbnRfdG1wbm8gKz0gMQotICAgICAgICByZXR1cm4gc2VsZi5q b2luKGRpciwgIiVzXyV1XyVzIiAlIChwcmVmaXgsIGN1cm5vLCBzdWZmaXgpKQorICAgICAgICBz ZWxmLmxhc3RfdG1wZGlyID0gc2VsZi5qb2luKGRpciwgJyVzXyV1XyVzJyAlIChwcmVmaXgsIGN1 cm5vLCBzdWZmaXgpKQorICAgICAgICByZXR1cm4gc2VsZi5sYXN0X3RtcGRpcgogCiAgICAgZGVm IG1rZHRlbXAoc2VsZiwgKiprd2FyZ3MpOgogICAgICAgICBjbGFzcyBUZW1wb3JhcnlEaXJlY3Rv cnkob2JqZWN0KToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvd2Via2l0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC93ZWJraXQucHkKaW5kZXggZDc5ODAzOWFjODhiYmU0MjQ1NjE4YWUzZTY5Njc2ZjU2Njk4 YmI3My4uNWZlZjYxOWNkMmNhMzczY2Q0YTE2YmNmZmIwOTRiYWQ0ZDU3OTc0ZCAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKQEAg LTQ0MSw3ICs0NDEsNyBAQCBjbGFzcyBXZWJLaXREcml2ZXIoRHJpdmVyKToKIAogICAgIGRlZiBf X2luaXRfXyhzZWxmLCBwb3J0LCB3b3JrZXJfbnVtYmVyLCBwaXhlbF90ZXN0cywgbm9fdGltZW91 dD1GYWxzZSk6CiAgICAgICAgIERyaXZlci5fX2luaXRfXyhzZWxmLCBwb3J0LCB3b3JrZXJfbnVt YmVyLCBwaXhlbF90ZXN0cywgbm9fdGltZW91dCkKLSAgICAgICAgc2VsZi5fZHJpdmVyX3RlbXBk aXIgPSBwb3J0Ll9maWxlc3lzdGVtLm1rZHRlbXAocHJlZml4PSclcy0nICUgc2VsZi5fcG9ydC5k cml2ZXJfbmFtZSgpKQorICAgICAgICBzZWxmLl9kcml2ZXJfdGVtcGRpciA9IE5vbmUKICAgICAg ICAgIyBXZWJLaXRUZXN0UnVubmVyIGNhbiByZXBvcnQgYmFjayBzdWJwcm9jZXNzIGNyYXNoZXMg YnkgcHJpbnRpbmcKICAgICAgICAgIyAiI0NSQVNIRUQgLSBQUk9DRVNTTkFNRSIuICBTaW5jZSB0 aG9zZSBjYW4gaGFwcGVuIGF0IGFueSB0aW1lCiAgICAgICAgICMgYW5kIFNlcnZlclByb2Nlc3Mg d29uJ3QgYmUgYXdhcmUgb2YgdGhlbSAoc2luY2UgdGhlIGFjdHVhbCB0b29sCkBAIC00NTcsMTEg KzQ1Nyw2IEBAIGNsYXNzIFdlYktpdERyaXZlcihEcml2ZXIpOgogICAgICAgICBzZWxmLmVycl9z ZWVuX2VvZiA9IEZhbHNlCiAgICAgICAgIHNlbGYuX3NlcnZlcl9wcm9jZXNzID0gTm9uZQogCi0g ICAgIyBGSVhNRTogVGhpcyBtYXkgYmUgdW5zYWZlLCBhcyBweXRob24gZG9lcyBub3QgZ3VhcmVu dGVlIGFueSBvcmRlcmluZyBvZiBfX2RlbF9fIGNhbGxzCi0gICAgIyBJIGJlbGlldmUgaXQncyBw b3NzaWJsZSB0aGF0IHNlbGYuX3BvcnQgb3Igc2VsZi5fcG9ydC5fZmlsZXN5c3RlbSBtYXkgYWxy ZWFkeSBiZSBkZXN0cm95ZWQuCi0gICAgZGVmIF9fZGVsX18oc2VsZik6Ci0gICAgICAgIHNlbGYu X3BvcnQuX2ZpbGVzeXN0ZW0ucm10cmVlKHN0cihzZWxmLl9kcml2ZXJfdGVtcGRpcikpCi0KICAg ICBkZWYgY21kX2xpbmUoc2VsZiwgcGl4ZWxfdGVzdHMsIHBlcl90ZXN0X2FyZ3MpOgogICAgICAg ICBjbWQgPSBzZWxmLl9jb21tYW5kX3dyYXBwZXIoc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCd3cmFw cGVyJykpCiAgICAgICAgIGNtZC5hcHBlbmQoc2VsZi5fcG9ydC5fcGF0aF90b19kcml2ZXIoKSkK QEAgLTQ4NSw2ICs0ODAsNyBAQCBjbGFzcyBXZWJLaXREcml2ZXIoRHJpdmVyKToKICAgICAgICAg cmV0dXJuIGNtZAogCiAgICAgZGVmIF9zdGFydChzZWxmLCBwaXhlbF90ZXN0cywgcGVyX3Rlc3Rf YXJncyk6CisgICAgICAgIHNlbGYuX2RyaXZlcl90ZW1wZGlyID0gc2VsZi5fcG9ydC5fZmlsZXN5 c3RlbS5ta2R0ZW1wKHByZWZpeD0nJXMtJyAlIHNlbGYuX3BvcnQuZHJpdmVyX25hbWUoKSkKICAg ICAgICAgc2VydmVyX25hbWUgPSBzZWxmLl9wb3J0LmRyaXZlcl9uYW1lKCkKICAgICAgICAgZW52 aXJvbm1lbnQgPSBzZWxmLl9wb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZXJ2ZXJfbmFt ZSkKICAgICAgICAgZW52aXJvbm1lbnRbJ0RZTERfTElCUkFSWV9QQVRIJ10gPSBzZWxmLl9wb3J0 Ll9idWlsZF9wYXRoKCkKQEAgLTY2OCw2ICs2NjQsMTAgQEAgY2xhc3MgV2ViS2l0RHJpdmVyKERy aXZlcik6CiAgICAgICAgICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5zdG9wKCkKICAgICAgICAg ICAgIHNlbGYuX3NlcnZlcl9wcm9jZXNzID0gTm9uZQogCisgICAgICAgIGlmIHNlbGYuX2RyaXZl cl90ZW1wZGlyOgorICAgICAgICAgICAgc2VsZi5fcG9ydC5fZmlsZXN5c3RlbS5ybXRyZWUoc3Ry KHNlbGYuX2RyaXZlcl90ZW1wZGlyKSkKKyAgICAgICAgICAgIHNlbGYuX2RyaXZlcl90ZW1wZGly ID0gTm9uZQorCiAKIGNsYXNzIENvbnRlbnRCbG9jayhvYmplY3QpOgogICAgIGRlZiBfX2luaXRf XyhzZWxmKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkKaW5kZXggMDk5MTZiYTRlNDVhYTkwYzkzYTNl MWFlZTRkYjVkZmQ4ZjkzODQwYy4uNDViNmNkYjkyOTdhODg4MDk2YTIxYWFmODU1NTg1ODg3NGJm ZGQxYyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkKQEAgLTM0NCwzICszNDQsMTggQEAgY2xhc3Mg V2ViS2l0RHJpdmVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGRyaXZlci5fY3Jh c2hlZF9waWQgPSBOb25lCiAgICAgICAgIGRyaXZlci5fc2VydmVyX3Byb2Nlc3MgPSBGYWtlU2Vy dmVyUHJvY2VzcyhUcnVlKQogICAgICAgICBhc3NlcnRfY3Jhc2goZHJpdmVyLCAnJywgVHJ1ZSwg J0Zha2VTZXJ2ZXJQcm9jZXNzJywgMTIzNCkKKworICAgIGRlZiB0ZXN0X2NyZWF0aW5nX2FfcG9y dF9kb2VzX25vdF93cml0ZV90b190aGVfZmlsZXN5c3RlbShzZWxmKToKKyAgICAgICAgcG9ydCA9 IFRlc3RXZWJLaXRQb3J0KCkKKyAgICAgICAgZHJpdmVyID0gV2ViS2l0RHJpdmVyKHBvcnQsIDAs IHBpeGVsX3Rlc3RzPVRydWUpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQuX2ZpbGVz eXN0ZW0ud3JpdHRlbl9maWxlcywge30pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBvcnQu X2ZpbGVzeXN0ZW0ubGFzdF90bXBkaXIsIE5vbmUpCisKKyAgICBkZWYgdGVzdF9zdG9wX2NsZWFu c191cF9wcm9wZXJseShzZWxmKToKKyAgICAgICAgcG9ydCA9IFRlc3RXZWJLaXRQb3J0KCkKKyAg ICAgICAgZHJpdmVyID0gV2ViS2l0RHJpdmVyKHBvcnQsIDAsIHBpeGVsX3Rlc3RzPVRydWUpCisg ICAgICAgIGRyaXZlci5zdGFydChUcnVlLCBbXSkKKyAgICAgICAgbGFzdF90bXBkaXIgPSBwb3J0 Ll9maWxlc3lzdGVtLmxhc3RfdG1wZGlyCisgICAgICAgIHNlbGYuYXNzZXJ0Tm90RXF1YWxzKGxh c3RfdG1wZGlyLCBOb25lKQorICAgICAgICBkcml2ZXIuc3RvcCgpCisgICAgICAgIHNlbGYuYXNz ZXJ0RmFsc2UocG9ydC5fZmlsZXN5c3RlbS5pc2RpcihsYXN0X3RtcGRpcikpCg==