87791 2012-05-29 16:17:56 -0700 Show an error in the pretty diff when an image lacks a checksum 2012-05-30 09:14:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dpranke eric tony webkit.review.bot oldest_to_newest 636527 0 ojan 2012-05-29 16:17:56 -0700 Show an error in the pretty diff when an image lacks a checksum 636528 1 144639 ojan 2012-05-29 16:18:24 -0700 Created attachment 144639 Patch 636575 2 144639 tony 2012-05-29 17:03:31 -0700 Comment on attachment 144639 Patch Is this only for expected.png files? What if someone is checking in a png, e.g., for the web inspector? 636579 3 dpranke 2012-05-29 17:06:29 -0700 (In reply to comment #2) > (From update of attachment 144639 [details]) > Is this only for expected.png files? What if someone is checking in a png, e.g., for the web inspector? bah, good point. 636742 4 144639 webkit.review.bot 2012-05-29 19:18:25 -0700 Comment on attachment 144639 Patch Clearing flags on attachment: 144639 Committed r118882: <http://trac.webkit.org/changeset/118882> 636743 5 webkit.review.bot 2012-05-29 19:18:30 -0700 All reviewed patches have been landed. Closing bug. 636865 6 tkent 2012-05-29 22:42:04 -0700 It seems PrettyPatch warns whenever a patch adds (not updates) new images. 637295 7 ojan 2012-05-30 09:14:21 -0700 (In reply to comment #6) > It seems PrettyPatch warns whenever a patch adds (not updates) new images. Not sure I understand. Can you point me at a patch/bug where it's doing the wrong thing? 144639 2012-05-29 16:18:24 -0700 2012-05-29 19:18:25 -0700 Patch bug-87791-20120529161823.patch text/plain 3736 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODE4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBlOTk1YjgzZjQ4MWRmMjNmN2FiMmIyNWJmYTIzY2E4NTY5MmE4ZTY0Li5mZDIyMDJlMjE4 NDcwOWJkMDdmYmU3Mjg3NGQ5NjAyMDVjZGQ5YWI2IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0yOSAgT2phbiBWYWZhaSAgPG9qYW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFNob3cgYW4gZXJyb3IgaW4gdGhlIHByZXR0eSBkaWZmIHdo ZW4gYW4gaW1hZ2UgbGFja3MgYSBjaGVja3N1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc3OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiOgorICAgICAg ICAqIFByZXR0eVBhdGNoL1ByZXR0eVBhdGNoX3Rlc3QucmI6CisKIDIwMTItMDQtMDEgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBDb2RlIHJldmlldyB0b29sIG5v IGxvbmdlciBuZWVkcyB0byB3b3JrIGFyb3VuZCBwb3NpdGlvbjpmaXhlZCBoYW5kbGluZyBvbiBp UGFkCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmIgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5 UGF0Y2gucmIKaW5kZXggZjY3MjE2M2RhMTNkMjcxMTVhZDBlMDlmNTlhNzc1ODk1ZjUwNDc1ZC4u NGQzOGJkMmQ0Njc2YzYyNGViMDdlMjM1NzIzOGIyZDRkOTk1MjRhYyAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCisrKyBiL1dl YnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgpAQCAtOTgs NiArOTgsOCBAQCBwcml2YXRlCiAgICAgICAgIFdlYnNpdGVzCiAgICAgXQogCisgICAgSU1BR0Vf Q0hFQ0tTVU1fRVJST1IgPSAiPHA+SU5WQUxJRDogSW1hZ2UgbGFja3MgYSBjaGVja3N1bS4gVGhp cyB3aWxsIGZhaWwgd2l0aCBhIE1JU1NJTkcgZXJyb3IgaW4gcnVuLXdlYmtpdC10ZXN0cy4gQWx3 YXlzIGdlbmVyYXRlIG5ldyBwbmcgZmlsZXMgdXNpbmcgcnVuLXdlYmtpdC10ZXN0cy48L3A+Igor CiAgICAgZGVmIHNlbGYubm9ybWFsaXplX2xpbmVfZW5kaW5nKHMpCiAgICAgICAgIHMuZ3N1YiAv XHJcbj8vLCAiXG4iCiAgICAgZW5kCkBAIC01NzgsNyArNTgwLDcgQEAgRU9GCiAgICAgICAgICAg ICBlbmQKICAgICAgICAgICAgIGltYWdlX3NuaXBwZXQgPSAiPGltZyBjbGFzcz0naW1hZ2UnIHNy Yz0nIiArIEBpbWFnZV91cmwgKyAiJyAvPiIKICAgICAgICAgICAgIGlmIG5vdCBAaW1hZ2VfY2hl Y2tzdW0gdGhlbgotICAgICAgICAgICAgICAgIHJldHVybiBpbWFnZV9zbmlwcGV0CisgICAgICAg ICAgICAgICAgcmV0dXJuIElNQUdFX0NIRUNLU1VNX0VSUk9SICsgaW1hZ2Vfc25pcHBldAogICAg ICAgICAgICAgZW5kCiAgICAgICAgICAgICByZXR1cm4gIjxwPiIgKyBAaW1hZ2VfY2hlY2tzdW0g KyAiPC9wPiIgKyBpbWFnZV9zbmlwcGV0CiAgICAgICAgIGVuZApAQCAtNjAxLDYgKzYwMyw4IEBA IEVPRgogCiAgICAgICAgICAgICAgICAgICAgICAgICBpZiBpbWFnZV9jaGVja3N1bQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHN0ciArPSBpbWFnZV9jaGVja3N1bSArICI8YnI+IgorICAg ICAgICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 ciArPSBJTUFHRV9DSEVDS1NVTV9FUlJPUiArICI8YnI+IgogICAgICAgICAgICAgICAgICAgICAg ICAgZW5kCiAgICAgICAgICAgICAgICAgICAgICAgICBpZiBpbWFnZV91cmwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzdHIgKz0gIjxpbWcgY2xhc3M9J2ltYWdlJyBzcmM9JyIgKyBpbWFn ZV91cmwgKyAiJyAvPiIKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0 dHlQYXRjaC9QcmV0dHlQYXRjaF90ZXN0LnJiIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1By ZXR0eVBhdGNoL1ByZXR0eVBhdGNoX3Rlc3QucmIKaW5kZXggZWQ0MTY5M2I3MmYyMGRlYmJkZDJk YmM1NmFjZGExNWNhYzAxN2FlOC4uZmVmOGNhMGQzZjc5MTg5NjRiYzc4NmU2ZDMyNDlhOTViOTZm YmNhYiAxMDA3NTUKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1By ZXR0eVBhdGNoX3Rlc3QucmIKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBh dGNoL1ByZXR0eVBhdGNoX3Rlc3QucmIKQEAgLTYwLDkgKzYwLDIxIEBAIGNsYXNzIFByZXR0eVBh dGNoX3Rlc3QgPCBUZXN0OjpVbml0OjpUZXN0Q2FzZQogICAgICAgICBhc3NlcnRfZXF1YWwoaW5m b1tJbmZvOjpTSEFSRURdLCAkbGFzdF9wcmV0dGlmeV9wYXJ0X2NvdW50WyJzaGFyZWQiXSwgIldy b25nIG51bWJlciBvZiAnc2hhcmVkJyBwYXJ0cyBpbiAiICsgZGVzY3JpcHRpb24pCiAgICAgICAg IGFzc2VydF9lcXVhbCgwLCAkbGFzdF9wcmV0dGlmeV9wYXJ0X2NvdW50WyJiaW5hcnkiXSwgIldy b25nIG51bWJlciBvZiAnYmluYXJ5JyBwYXJ0cyBpbiAiICsgZGVzY3JpcHRpb24pCiAgICAgICAg IGFzc2VydF9lcXVhbCgwLCAkbGFzdF9wcmV0dGlmeV9wYXJ0X2NvdW50WyJleHRyYWN0LWVycm9y Il0sICJXcm9uZyBudW1iZXIgb2YgJ2V4dHJhY3QtZXJyb3InIHBhcnRzIGluICIgKyBkZXNjcmlw dGlvbikKKyAgICAgICAgcmV0dXJuIHByZXR0eQogICAgIGVuZAogCiAgICAgZGVmIHRlc3RfcGF0 Y2hlcwogICAgICAgICBQQVRDSEVTLmVhY2ggeyB8aWQsIGluZm98IGNoZWNrX29uZV9wYXRjaChp ZCwgaW5mbykgfQogICAgIGVuZAorCisgICAgZGVmIHRlc3RfaW1hZ2VzX3dpdGhvdXRfY2hlY2tz dW0KKyAgICAgICAgcHJldHR5ID0gY2hlY2tfb25lX3BhdGNoKDE0NDA2NCwgWyJJbWFnZXMgd2l0 aG91dCBjaGVja3N1bXMiLCAxMCwgNSwgNCwgOF0pCisgICAgICAgIHB1dHMgcHJldHR5CisgICAg ICAgIG1hdGNoZXMgPSBwcmV0dHkubWF0Y2goIklOVkFMSUQ6IEltYWdlIGxhY2tzIGEgY2hlY2tz dW0uIikKKyAgICAgICAgYXNzZXJ0KG1hdGNoZXMsICJTaG91bGQgaGF2ZSBpbnZhbGlkIGNoZWNr c3VtcyIpCisgICAgICAgICMgRklYTUU6IFRoaXMgc2hvdWxkIG9ubHkgaGF2ZSA0IGludmFsaWQg aW1hZ2VzLCBidXQgZ2l0IGFwcGx5IG5lZWRzIGFuIGFjdHVhbCBjb3B5IG9mIHRoZSBiZWZvcmUg YmluYXJ5CisgICAgICAgICMgaW4gb3JkZXIgdG8gYXBwbHkgZGlmZnMgY29ycmVjdGx5LiBUaGUg ZW5kIHJlc3VsdCBpcyB0aGF0IGFsbCBpbWFnZXMgaW4gdGhlIHBhdGNoIGFyZSBlbXB0eSBhbmQg dGh1cworICAgICAgICAjIHRob3VnaHQgdG8gaGF2ZSBubyBjaGVja3N1bSwgaW5zdGVhZCBvZiB0 aGUgNCBpbWFnZXMgdGhhdCBhY3R1YWxseSBkb24ndCBoYXZlIGEgY2hlY2tzdW0uCisgICAgICAg IGFzc2VydF9lcXVhbCgxMCwgcHJldHR5LnNjYW4oL0lOVkFMSURcOiBJbWFnZSBsYWNrcyBhIGNo ZWNrc3VtXC4vKS5zaXplKQorICAgIGVuZAogZW5kCg==