87785 2012-05-29 14:58:03 -0700 [V8] Clean up V8LazyEventListener to use one less function call 2012-05-30 11:33:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv abarth haraken japhet rafaelw schenney webkit.review.bot oldest_to_newest 636477 0 arv 2012-05-29 14:58:03 -0700 [V8] Clean up V8LazyEventListener to use one less function call 636486 1 144631 arv 2012-05-29 15:12:08 -0700 Created attachment 144631 Patch 636563 2 144631 haraken 2012-05-29 16:50:10 -0700 Comment on attachment 144631 Patch Looks OK. 636596 3 arv 2012-05-29 17:13:43 -0700 I don't have a win build so it is very likely that my manual rebaseline of the expected file is wrong. 637381 4 arv 2012-05-30 10:20:49 -0700 Rafael, Stephen: This may need a rebaseline for chromium-win since I manually updated the expectation since I don't have a windows build: inspector/debugger/debugger-scripts.html 637478 5 144631 webkit.review.bot 2012-05-30 11:33:20 -0700 Comment on attachment 144631 Patch Clearing flags on attachment: 144631 Committed r118944: <http://trac.webkit.org/changeset/118944> 637480 6 webkit.review.bot 2012-05-30 11:33:24 -0700 All reviewed patches have been landed. Closing bug. 144631 2012-05-29 15:12:08 -0700 2012-05-30 11:33:20 -0700 Patch bug-87785-20120529151207.patch text/plain 5029 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEwMTI0NzJiNGE3NDA1 NTE4NzBkNGFjZWNjYTQ5MmM1Y2I2MDZiOC4uOThhMzM0MDQ2MGU0Njc1YmQ3MDRlYTQwOWRhNGM0 MzZkYTBiOWM1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTI5ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBDbGVhbiB1cCBW OExhenlFdmVudExpc3RlbmVyIHRvIHVzZSBvbmUgbGVzcyBmdW5jdGlvbiBjYWxsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Nzc4NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc3RlYWQgb2YgcmVseWlu ZyBvbiAnYXJndW1lbnRzJyB3ZSByZWx5IG9uICd0aGlzJy4gJ3RoaXMnIGNhbm5vdCBiZSBpbnRl cmNlcHRlZCBieSBhCisgICAgICAgIHdpdGgtc3RhdGVtZW50IHNvIGl0IGlzIHNhZmUgdG8gdXNl IHRoYXQgdG8gYmluZCB0aGUgY29udGV4dCBvYmplY3RzLiBUaGlzIGFsbG93cyB1cyB0bworICAg ICAgICByZW1vdmUgb25lIGxheWVyIG9mIGZ1bmN0aW9uIGluZGlyZWN0aW9uIGluIHRoZSBnZW5l cmF0ZWQgY29kZS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAg ICAgICogYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWOExhenlFdmVudExpc3RlbmVyOjpwcmVwYXJlTGlzdGVuZXJPYmplY3QpOgorCiAyMDEy LTA1LTI5ICBKb2huIFN1bGxpdmFuICA8c3VsbGl2YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFVw ZGF0ZSBsYWJlbCBmb3IgYmxhY2tsaXN0ZWQgcGx1Zy1pbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmNwcAppbmRleCBlZjQ1OTJlMWEwMDU1 MTdiMjRkNWZmMDVhM2YzNzJkMDBmNzE0ZGUwLi44M2IxYTE0MDM0YzE4YzIwMjVkZDZjNWYwMjlj NTYwMWVlNTU1ZDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExh enlFdmVudExpc3RlbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExh enlFdmVudExpc3RlbmVyLmNwcApAQCAtMTQxLDcgKzE0MSw2IEBAIHZvaWQgVjhMYXp5RXZlbnRM aXN0ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNv bnRleHQpCiAgICAgLy8gQnkgY2FsbGluZyB0aGUgZnVuY3Rpb24gd2l0aCA0IGFyZ3VtZW50cywg d2UgY3JlYXRlIGEgc2V0dGVyIG9uIGFyZ3VtZW50cyBvYmplY3QKICAgICAvLyB3aGljaCB3b3Vs ZCBzaGFkb3cgcHJvcGVydHkgIjMiIG9uIHRoZSBwcm90b3R5cGUuCiAgICAgU3RyaW5nIGNvZGUg PSAiKGZ1bmN0aW9uKCkgeyIgXAotICAgICAgICAiYXJndW1lbnRzWzNdID0gZnVuY3Rpb24oKSB7 IiBcCiAgICAgICAgICJ3aXRoICh0aGlzWzJdKSB7IiBcCiAgICAgICAgICJ3aXRoICh0aGlzWzFd KSB7IiBcCiAgICAgICAgICJ3aXRoICh0aGlzWzBdKSB7IjsKQEAgLTE1MCw4ICsxNDksNyBAQCB2 b2lkIFY4TGF6eUV2ZW50TGlzdGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdChTY3JpcHRFeGVj dXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgIGNvZGUuYXBwZW5kKCIpIHsiKTsKICAgICBjb2Rl LmFwcGVuZChtX2NvZGUpOwogICAgIC8vIEluc2VydCAnXG4nIG90aGVyd2lzZSAvLy1zdHlsZSBj b21tZW50cyBjb3VsZCBicmVhayB0aGUgaGFuZGxlci4KLSAgICBjb2RlLmFwcGVuZCgiXG59O319 fX07Iik7Ci0gICAgY29kZS5hcHBlbmQoInJldHVybiBhcmd1bWVudHNbM10oKTt9KSIpOworICAg IGNvZGUuYXBwZW5kKCJcbn07fX19fSkiKTsKICAgICB2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IGNv ZGVFeHRlcm5hbFN0cmluZyA9IHY4RXh0ZXJuYWxTdHJpbmcoY29kZSk7CiAKICAgICB2ODo6SGFu ZGxlPHY4OjpTY3JpcHQ+IHNjcmlwdCA9IFY4UHJveHk6OmNvbXBpbGVTY3JpcHQoY29kZUV4dGVy bmFsU3RyaW5nLCBtX3NvdXJjZVVSTCwgbV9wb3NpdGlvbik7CkBAIC0xNzksMTMgKzE3NywyMSBA QCB2b2lkIFY4TGF6eUV2ZW50TGlzdGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdChTY3JpcHRF eGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZm9y bVdyYXBwZXIgPSB0b09iamVjdFdyYXBwZXI8SFRNTEZvcm1FbGVtZW50Pihmb3JtRWxlbWVudCk7 CiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBkb2N1bWVudFdyYXBwZXIgPSB0b09iamVjdFdy YXBwZXI8RG9jdW1lbnQ+KG1fbm9kZSA/IG1fbm9kZS0+b3duZXJEb2N1bWVudCgpIDogMCk7CiAK LSAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gcGFyYW1ldGVyc1s0XSA9IHsgbm9kZVdyYXBwZXIs IGZvcm1XcmFwcGVyLCBkb2N1bWVudFdyYXBwZXIsIHY4OjpIYW5kbGU8djg6OlZhbHVlPih2ODo6 TnVsbCgpKSB9OworICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiB0aGlzT2JqZWN0ID0gdjg6Ok9i amVjdDo6TmV3KCk7CisgICAgaWYgKHRoaXNPYmplY3QuSXNFbXB0eSgpKQorICAgICAgICByZXR1 cm47CisgICAgaWYgKCF0aGlzT2JqZWN0LT5Gb3JjZVNldCh2ODo6SW50ZWdlcjo6TmV3RnJvbVVu c2lnbmVkKDApLCBub2RlV3JhcHBlcikpCisgICAgICAgIHJldHVybjsKKyAgICBpZiAoIXRoaXNP YmplY3QtPkZvcmNlU2V0KHY4OjpJbnRlZ2VyOjpOZXdGcm9tVW5zaWduZWQoMSksIGZvcm1XcmFw cGVyKSkKKyAgICAgICAgcmV0dXJuOworICAgIGlmICghdGhpc09iamVjdC0+Rm9yY2VTZXQodjg6 OkludGVnZXI6Ok5ld0Zyb21VbnNpZ25lZCgyKSwgZG9jdW1lbnRXcmFwcGVyKSkKKyAgICAgICAg cmV0dXJuOwogCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIGNvZGUgd2hlbiB3ZSBzdG9wIGRv aW5nIHRoZSAnd2l0aCcgaGFjayBhYm92ZS4KICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiBpbm5l clZhbHVlOwogICAgIHsKICAgICAgICAgVjhSZWN1cnNpb25TY29wZTo6TWljcm90YXNrU3VwcHJl c3Npb24gc2NvcGU7Ci0gICAgICAgIGlubmVyVmFsdWUgPSBpbnRlcm1lZGlhdGVGdW5jdGlvbi0+ Q2FsbCh2OENvbnRleHQtPkdsb2JhbCgpLCAzLCBwYXJhbWV0ZXJzKTsKKyAgICAgICAgaW5uZXJW YWx1ZSA9IGludGVybWVkaWF0ZUZ1bmN0aW9uLT5DYWxsKHRoaXNPYmplY3QsIDAsIDApOwogICAg IH0KICAgICBpZiAoaW5uZXJWYWx1ZS5Jc0VtcHR5KCkgfHwgIWlubmVyVmFsdWUtPklzRnVuY3Rp b24oKSkKICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFhYTEzMWM2NzcwYmNlYWViOGE3ZGQ3N2Y3 MWJmZWJmMWFhZDBjY2QuLmIzNWI5MmIzNDIxMTAwYWY1YzBkZDlhY2UzZjg3NzYyNTkzYWIwMTYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0yOSAgRXJpayBBcnZpZHNzb24gIDxhcnZA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFtWOF0gQ2xlYW4gdXAgVjhMYXp5RXZlbnRMaXN0ZW5l ciB0byB1c2Ugb25lIGxlc3MgZnVuY3Rpb24gY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc3ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHJlbHlpbmcgb24gJ2FyZ3VtZW50cycg d2UgcmVseSBvbiAndGhpcycuICd0aGlzJyBjYW5ub3QgYmUgaW50ZXJjZXB0ZWQgYnkgYQorICAg ICAgICB3aXRoLXN0YXRlbWVudCBzbyBpdCBpcyBzYWZlIHRvIHVzZSB0aGF0IHRvIGJpbmQgdGhl IGNvbnRleHQgb2JqZWN0cy4gVGhpcyBhbGxvd3MgdXMgdG8KKyAgICAgICAgcmVtb3ZlIG9uZSBs YXllciBvZiBmdW5jdGlvbiBpbmRpcmVjdGlvbiBpbiB0aGUgZ2VuZXJhdGVkIGNvZGUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS13aW4vaW5zcGVjdG9yL2RlYnVnZ2VyL2RlYnVnZ2Vy LXNjcmlwdHMtZXhwZWN0ZWQudHh0OgorCiAyMDEyLTA1LTI5ICBKdWxpZW4gQ2hhZmZyYWl4ICA8 amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjExMTc0Mik6IGJv eC1zaXppbmc6IGJvcmRlci1ib3ggZG9lc24ndCB3b3JrIG9uIGZpeGVkIHRhYmxlIGxheW91dApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luL2luc3BlY3Rvci9k ZWJ1Z2dlci9kZWJ1Z2dlci1zY3JpcHRzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtLXdpbi9pbnNwZWN0b3IvZGVidWdnZXIvZGVidWdnZXItc2NyaXB0cy1leHBl Y3RlZC50eHQKaW5kZXggODQwODgxNmQzNmUwNjQ2OGZlNjQyMmQ1MzI3ZWEyNzA4MDYxNjA2OC4u OWFhYjg1YjljNjZmMjVlYjBlZTc2ZmRiZmI2NTQ4ZmRmZmUzYjAzZCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luL2luc3BlY3Rvci9kZWJ1Z2dlci9kZWJ1Z2dl ci1zY3JpcHRzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS13aW4vaW5zcGVjdG9yL2RlYnVnZ2VyL2RlYnVnZ2VyLXNjcmlwdHMtZXhwZWN0ZWQudHh0CkBA IC0xOCw2ICsxOCw2IEBAIHNjcmlwdCA1OgogICAgIGVuZDogNDg6MAogc2NyaXB0IDY6CiAgICAg c3RhcnQ6IDUxOjU2Ci0gICAgZW5kOiA1MjozMQorICAgIGVuZDogNTI6NwogRGVidWdnZXIgd2Fz IGRpc2FibGVkLgogCg==