87783 2012-05-29 14:50:23 -0700 [WK2] window.internals settings are not reset between tests 2012-06-01 12:34:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 88064 87540 1 ap mihaip abarth cshu dglazkov dominicc eric jberlin mihaip mrowe ossy thorton oldest_to_newest 636468 0 ap 2012-05-29 14:50:23 -0700 This setting leaks between tests, causing lots of pseudo-flaky tests. E.g.: --- /Volumes/Data/slave/lion-intel-release-tests-wk2/build/layout-test-results/fast/xpath/4XPath/Borrowed/od_20000608-expected.txt +++ /Volumes/Data/slave/lion-intel-release-tests-wk2/build/layout-test-results/fast/xpath/4XPath/Borrowed/od_20000608-actual.txt @@ -1,6 +1,6 @@ -PASS nodeset.snapshotLength is 0 -PASS nodeset.snapshotLength is 12 -PASS successfullyParsed is true +CONSOLE MESSAGE: Synchronous XMLHttpRequests cannot be made in the current window context. +CONSOLE MESSAGE: line 67: INVALID_ACCESS_ERR: DOM Exception 15: A parameter or an operation was not supported by the underlying object. +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE 636473 1 mihaip 2012-05-29 14:52:26 -0700 Oops, will investigate. 636506 2 mihaip 2012-05-29 15:48:19 -0700 I'm not able to reproduce this when building/running with Chromium's DRT. Does this affect any other bots besides the WebKit2 one? I did add the resetting logic to InternalSettings::restoreTo (http://trac.webkit.org/changeset/118599/trunk/Source/WebCore/testing/InternalSettings.cpp), just like all the other settings. 636537 3 ap 2012-05-29 16:25:54 -0700 Yes, this seems specific to WebKitTestRunner as far as I can tell. 636604 4 mihaip 2012-05-29 17:19:24 -0700 I'm not familiar with how WebKitTestRunner is set up, but it seems to be missing a call to WebCoreTestSupport::resetInternalsObject. Where is its equivalent to resetWebViewToConsistentStateBeforeTesting? 636617 5 ap 2012-05-29 17:29:24 -0700 TestController::resetStateToConsistentValues is the function. Yes, it doesn't appear to call resetInternalsObject (whoa!) 636641 6 mihaip 2012-05-29 17:48:16 -0700 (In reply to comment #5) > TestController::resetStateToConsistentValues is the function. Yes, it doesn't appear to call resetInternalsObject (whoa!) As far as I can tell, the call wouldn't be right there, since this needs to happen in the web process. However, that does send a "reset" message to the process, which eventually ends up in InjectBundlePage::reset. Doing the reset there seems to make sense, but it crashes with: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 libWebCoreTestSupport.dylib 0x0000000106704b07 WebCore::toInternals(JSC::JSValue) + 23 (JSCell.h:195) 1 libWebCoreTestSupport.dylib 0x0000000106712a89 WebCoreTestSupport::resetInternalsObject(OpaqueJSContext const*) + 265 (WebCoreTestSupport.cpp:55) 2 WebKitTestRunnerInjectedBundle 0x000000010655f103 WTR::InjectedBundlePage::reset() + 185 3 WebKitTestRunnerInjectedBundle 0x000000010655d637 WTR::InjectedBundle::beginTesting(OpaqueWKDictionary const*) + 491 (InjectedBundle.cpp:235) 4 WebKitTestRunnerInjectedBundle 0x000000010655d719 WTR::InjectedBundle::didReceiveMessage(OpaqueWKString const*, void const*) + 193 (WKRetainPtr.h:85) 5 com.apple.WebKit2 0x000000010022082c WebKit::InjectedBundleClient::didReceiveMessage(WebKit::InjectedBundle*, WTF::String const&, WebKit::APIObject*) + 78 (PassRefPtr.h:51) 636642 7 mihaip 2012-05-29 17:48:34 -0700 The actual resetting code that I'm adding is: WKBundleFrameRef frame = WKBundlePageGetMainFrame(m_page); JSGlobalContextRef context = WKBundleFrameGetJavaScriptContext(frame); WebCoreTestSupport::resetInternalsObject(context); 637423 8 144867 mihaip 2012-05-30 10:57:31 -0700 Created attachment 144867 Patch 637425 9 mihaip 2012-05-30 10:58:47 -0700 The patch doesn't fix the underlying issue (WebKitTestRunner not resetting internals correctly), since I'm not where to begin. However, it does fix the flakiness caused by the test that I added. 637442 10 ap 2012-05-30 11:11:54 -0700 Can someone comment on what it would take to make WebKitTestRunner reset internals state? It's very surprising that it hasn't been implemented ages ago. 637488 11 ap 2012-05-30 11:37:33 -0700 Also CC'ing Dominic, who implemented window.internals for WebKit2 in <http://trac.webkit.org/changeset/89530>, and Mark who reviewed the patch. 637823 12 ap 2012-05-30 16:51:51 -0700 window.internals is an extremely poor mechanism for changing settings: 1. Changing a setting in one window.internals.settings object affects all frames in a page, but does not work across secondary windows. This is inconsistent. 2. If a test navigates to a different URL (with waitUntilDone/notifyDone), settings are restored from last document's InternalSettings instead of first one's, so changes made in first one just leak to future tests. 3. As seen in this bug, it's just completely broken in WebKit2. 637894 13 144965 ap 2012-05-30 18:17:29 -0700 Created attachment 144965 reset internals in WTR Just fixes the WTR issue, not the cluster of Internals bugs. The reason why Mihai's code was crashing is that on first iteration, reset() is called before there is an internals object injected. We just need to do that after running a test, not before. 637980 14 144965 mihaip 2012-05-30 21:01:55 -0700 Comment on attachment 144965 reset internals in WTR View in context: https://bugs.webkit.org/attachment.cgi?id=144965&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:354 > + WebCoreTestSupport::resetInternalsObject(context); FWIW, the Qt port would appear to need a DumpRenderTreeSupportQ::resetInternalsObject call, based on the injectInternalsObject callsite. 638581 15 ap 2012-05-31 11:13:42 -0700 Committed <http://trac.webkit.org/changeset/119127>. I'll file a new bug for the more general Internals issues. Mihai, there are good changes in your patch, would you be willing to file a new bug for those, minus test change? 639106 16 ossy 2012-06-01 01:54:55 -0700 It made 2 tests crash on Qt WK2. Could you check it, please? The new bug report is https://bugs.webkit.org/show_bug.cgi?id=88064 639627 17 mihaip 2012-06-01 12:34:25 -0700 (In reply to comment #15) > Mihai, there are good changes in your patch, would you be willing to file a new bug for those, minus test change? Filed bug 88032 and added the patch. 144867 2012-05-30 10:57:31 -0700 2012-05-31 11:13:51 -0700 Patch bug-87783-20120530105730.patch text/plain 5589 mihaip U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFkOTc1MDEyYmU5ODhh OWVjYjk4ZWM1MGYxNmU5ZTNjNzliN2IyYy4uNGY0ZDFjMTc3NzE1MmE0YWM3YmQ4M2NiNzBlNjU1 ZDJhNGU4YjMyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTMwICBNaWhh aSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNldHRpbmcgdG8g YWxsb3cgc3luY2hyb25vdXMgWEhScyB0byBiZSBkaXNhYmxlZCBpbiBkb2N1bWVudHMgaXMgbm90 IHJlc2V0IGJldHdlZW4gdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg3NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW50ZXJuYWxTZXR0aW5nczo6c2V0U3luY1hIUkluRG9jdW1lbnRzRW5hYmxlZCk6IEZp eCBhCisgICAgICAgIGNvcHktYW5kLXBhc3RlIGVycm9yIAorICAgICAgICAqIHhtbC9YTUxIdHRw UmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6b3Blbik6IElt cHJvdmVzIHRoZSBkaXNhYmxlZCBtZXNzYWdlLCBhcworICAgICAgICBzdWdnZXN0ZWQgaW4gYSBj b21tZW50IGFmdGVyIHIxMTg1OTkgd2FzIHB1dCBpbiB0aGUgY29tbWl0IHF1ZXVlLgorCiAyMDEy LTA1LTI5ICBWaWN0b3IgQ2FyYnVuZSAgPHZpY3RvckByb3NlZHUub3JnPgogCiAgICAgICAgIERp c3BsYXkgY3VlcyBpbiB0aGUgY29udHJvbHMgYXJlYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3Rpbmcv SW50ZXJuYWxTZXR0aW5ncy5jcHAKaW5kZXggZDY0ODY2ODIxYjdhOWYyMDhjZDM4YzA5N2M3MTIy MzAyMWQxZTc0My4uYWIwZWNlMDBhNTczNDM2ZjE2ZDJhYWZkNDBhOTY0OWY3M2JmMDQ4OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3BwCkBAIC0zNjEsMTAg KzM2MSwxMCBAQCB2b2lkIEludGVybmFsU2V0dGluZ3M6OnNldEZpeGVkUG9zaXRpb25DcmVhdGVz U3RhY2tpbmdDb250ZXh0KGJvb2wgY3JlYXRlcywgRXhjZQogICAgIHNldHRpbmdzKCktPnNldEZp eGVkUG9zaXRpb25DcmVhdGVzU3RhY2tpbmdDb250ZXh0KGNyZWF0ZXMpOwogfQogCi12b2lkIElu dGVybmFsU2V0dGluZ3M6OnNldFN5bmNYSFJJbkRvY3VtZW50c0VuYWJsZWQoYm9vbCBjcmVhdGVz LCBFeGNlcHRpb25Db2RlJiBlYykKK3ZvaWQgSW50ZXJuYWxTZXR0aW5nczo6c2V0U3luY1hIUklu RG9jdW1lbnRzRW5hYmxlZChib29sIGVuYWJsZWQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewotICAg IEludGVybmFsU2V0dGluZ3NHdWFyZEZvckZyYW1lVmlldygpOwotICAgIHNldHRpbmdzKCktPnNl dFN5bmNYSFJJbkRvY3VtZW50c0VuYWJsZWQoY3JlYXRlcyk7CisgICAgSW50ZXJuYWxTZXR0aW5n c0d1YXJkRm9yU2V0dGluZ3MoKTsKKyAgICBzZXR0aW5ncygpLT5zZXRTeW5jWEhSSW5Eb2N1bWVu dHNFbmFibGVkKGVuYWJsZWQpOwogfQogCiB2b2lkIEludGVybmFsU2V0dGluZ3M6OnNldEphdmFT Y3JpcHRQcm9maWxpbmdFbmFibGVkKGJvb2wgZW5hYmxlZCwgRXhjZXB0aW9uQ29kZSYgZWMpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvU291cmNl L1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCBiZTZiNGM2OThjNjFlMDU0MzA1 ZGJjMTUyNWU1ZGNiZmEyMTMxNjc1Li43YzVlNWI1ZjA4N2IwNTg4ODU1NDY1NDE1NzI4YjlkY2Y2 MjA2NTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTQ4Niw3ICs0 ODYsNyBAQCB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBj b25zdCBLVVJMJiB1cmwsIGJvb2wgYXN5bmMsIEV4YwogCiAgICAgaWYgKCFhc3luYyAmJiBzY3Jp cHRFeGVjdXRpb25Db250ZXh0KCktPmlzRG9jdW1lbnQoKSkgewogICAgICAgICBpZiAoIWRvY3Vt ZW50KCktPnNldHRpbmdzKCktPnN5bmNYSFJJbkRvY3VtZW50c0VuYWJsZWQoKSkgewotICAgICAg ICAgICAgbG9nQ29uc29sZUVycm9yKHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSwgIlN5bmNocm9u b3VzIFhNTEh0dHBSZXF1ZXN0cyBjYW5ub3QgYmUgbWFkZSBpbiB0aGUgY3VycmVudCB3aW5kb3cg Y29udGV4dC4iKTsKKyAgICAgICAgICAgIGxvZ0NvbnNvbGVFcnJvcihzY3JpcHRFeGVjdXRpb25D b250ZXh0KCksICJTeW5jaHJvbm91cyBYTUxIdHRwUmVxdWVzdHMgYXJlIGRpc2FibGVkIGZvciB0 aGlzIHBhZ2UuIik7CiAgICAgICAgICAgICBlYyA9IElOVkFMSURfQUNDRVNTX0VSUjsKICAgICAg ICAgICAgIHJldHVybjsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGEyMTU4YjUzOWMzNTBlMmJlNzg2YmZj NDc3OTRhZTAwMDQyYTk4ZGQuLjNkMDE0ZjgyNTM3NjQ2YTE4NWVlYTdkOTk1YmRhNDNjZWZjMjMy NTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0zMCAgTWloYWkgUGFycGFyaXRhICA8 bWloYWlwQGNocm9taXVtLm9yZz4KKworICAgICAgICBTZXR0aW5nIHRvIGFsbG93IHN5bmNocm9u b3VzIFhIUnMgdG8gYmUgZGlzYWJsZWQgaW4gZG9jdW1lbnRzIGlzIG5vdCByZXNldCBiZXR3ZWVu IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 Nzc4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgV29yayBhcm91bmQgV2ViS2l0VGVzdFJ1bm5lciBub3QgcmVzZXR0aW5nIHRoZSBpbnRl cm5hbHMgb2JqZWN0IGJ5CisgICAgICAgIGhhdmluZyBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0 dHByZXF1ZXN0LXN5bmMtZGlzYWJsZWQuaHRtbCByZXN0b3JlCisgICAgICAgIHRoZSBTeW5jWEhS SW5Eb2N1bWVudHNFbmFibGVkIHNldHRpbmcgbWFudWFsbHkuICAgICAgICAKKworICAgICAgICAq IGZhc3QveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtc3luYy1kaXNhYmxlZC1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1zeW5j LWRpc2FibGVkLmh0bWw6CisKIDIwMTItMDUtMjkgIFJhZmFlbCBXZWluc3RlaW4gIDxyYWZhZWx3 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGluZyB0ZXN0IGV4cGVjdGF0aW9ucyAoZmFz dC9mb3Jtcy9mb3JtLWFzc29jaWF0ZWQtZWxlbWVudC1yZW1vdmFsIE1JU1NJTkcpLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1zeW5j LWRpc2FibGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QveG1saHR0cHJlcXVlc3Qv eG1saHR0cHJlcXVlc3Qtc3luYy1kaXNhYmxlZC1leHBlY3RlZC50eHQKaW5kZXggY2ZlZjQ1ZjVj OGRmZmIxM2I3MmU1ZDE1YWNjMTZlMjViZmRmZWZhZC4uYTA5NzU5MDIxODkxYjFjMmI3Yzg0NWJj ZmUzYWMyNGY5MWZhYTQyNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC94bWxodHRwcmVx dWVzdC94bWxodHRwcmVxdWVzdC1zeW5jLWRpc2FibGVkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXN5bmMtZGlzYWJsZWQt ZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsNCBAQAotQ09OU09MRSBNRVNTQUdFOiBTeW5jaHJvbm91 cyBYTUxIdHRwUmVxdWVzdHMgY2Fubm90IGJlIG1hZGUgaW4gdGhlIGN1cnJlbnQgd2luZG93IGNv bnRleHQuCitDT05TT0xFIE1FU1NBR0U6IFN5bmNocm9ub3VzIFhNTEh0dHBSZXF1ZXN0cyBhcmUg ZGlzYWJsZWQgZm9yIHRoaXMgcGFnZS4KIFRoaXMgdGVzdHMgdGhhdCBzeW5jaHJvbm91cyBYTUxI dHRwUmVxdWVzdHMgZmFpbCB3aGVuIHRoZXkgYXJlIGRpc2FibGVkIGZvciBkb2N1bWVudHMuCiAK IE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv eG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtc3luYy1kaXNhYmxlZC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1zeW5jLWRpc2FibGVkLmh0 bWwKaW5kZXggMGFhMmY1ZTVkYmI3NjllZmE5OWM2ZGRiMGVlMWM0NGZmYWZkMDM3Ny4uNjZkYzJh OWFhYzE0YTNmNTVkNmJlNzQ5ODczODc0ZTRkNDJhNWM3ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1zeW5jLWRpc2FibGVkLmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1zeW5j LWRpc2FibGVkLmh0bWwKQEAgLTEyLDYgKzEyLDE1IEBACiAgICAgICAgIGRlc2NyaXB0aW9uKCdU aGlzIHRlc3RzIHRoYXQgc3luY2hyb25vdXMgWE1MSHR0cFJlcXVlc3RzIGZhaWwgd2hlbiB0aGV5 IGFyZSBkaXNhYmxlZCBmb3IgZG9jdW1lbnRzLicpOwogICAgICAgICB2YXIgeGhyID0gbmV3IFhN TEh0dHBSZXF1ZXN0KCk7CiAgICAgICAgIHNob3VsZFRocm93KCd4aHIub3BlbigiR0VUIiwgImh0 dHA6Ly9teWRvbWFpbi8iLCBmYWxzZSknKTsKKyAgICAgICAgCisgICAgICAgIC8vIFRoaXMgc2hv dWxkIG5vdCBiZSByZXF1aXJlZCAodGhlIGludGVybmFscyBvYmplY3Qgc2hvdWxkIHJlc3RvcmUg CisgICAgICAgIC8vIHNldHRpbmdzKSwgYnV0IGlzIG5lZWRlZCB3aGVuIHJ1bm5pbmcgdGVzdHMg dW5kZXIgV2ViS2l0VGVzdFJ1bm5lci8KKyAgICAgICAgLy8gV2ViS2l0Miwgc2luY2UgdGhhdCBk b2Vzbid0IHJlc2V0IGludGVybmFscyBjb3JyZWN0bHkgKHNlZQorICAgICAgICAvLyBodHRwOi8v d2Via2l0Lm9yZy9iLzg3NzgzKQorICAgICAgICBpZiAoJ2ludGVybmFscycgaW4gd2luZG93KSB7 CisgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldFN5bmNYSFJJbkRvY3Vt ZW50c0VuYWJsZWQodHJ1ZSk7CisgICAgICAgIH0KKwogICAgIDwvc2NyaXB0PgogICAgIDxzY3Jp cHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwvaGVh ZD4K 144965 2012-05-30 18:17:29 -0700 2012-05-30 21:01:55 -0700 reset internals in WTR ResetInternals.txt text/plain 3406 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExOTAxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDEyLTA1LTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFNldHRpbmcgdG8gYWxsb3cgc3luY2hyb25vdXMgWEhScyB0byBiZSBkaXNh YmxlZCBpbiBkb2N1bWVudHMgaXMgbm90IHJlc2V0IGJldHdlZW4gdGVzdHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NzgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcDoKKyAgICAgICAgKFdUUjo6SW5qZWN0ZWRC dW5kbGU6OmRvbmUpOiBDYWxsIHJlc2V0QWZ0ZXJUZXN0KCkuCisKKyAgICAgICAgKiBXZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHA6CisgICAgICAg IChXVFI6OkluamVjdGVkQnVuZGxlUGFnZTo6cHJlcGFyZSk6IFJlbmFtZWQgZnJvbSAicmVzZXQi IGZvciBjbGFyaXR5LgorICAgICAgICAoV1RSOjpJbmplY3RlZEJ1bmRsZVBhZ2U6OnJlc2V0QWZ0 ZXJUZXN0KTogQWRkZWQgYSBmdW5jdGlvbiB0aGF0IHJlc2V0cyBpbnRlcm5hbHMuCisgICAgICAg IFRoaXMgbmVlZHMgdG8gYmUgZG9uZSBhZnRlciBhIHRldHMsIGJlY2F1c2UgdGhlIGNvZGUgYXNz dW1lcyB0aGF0IHRoZXJlIGlzIGFuIG9iamVjdAorICAgICAgICBlaXRoIHRoaXMgbmFtZSBpbiBn bG9iYWwgc2NvcGUuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0luamVjdGVkQnVuZGxlUGFnZS5oOgorCiAyMDEyLTA1LTMwICBLZXZpbiBPbGxpdmllciAgPGtl dmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gRml4IDIuOSBpc3N1ZXMgd2l0 aCBjX3N0cigpIHR5cGUgYnkgdXNpbmcgdGhlIHd4IGZwcmludGYgd3JhcHBlci4KSW5kZXg6IFRv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGUuY3BwCShyZXZpc2lvbiAxMTg4MDApCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMw LDcgKzIzMCw3IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGU6OmJlZ2luVGVzdGluZyhXS0RpY3QKIAog ICAgIG1fbGF5b3V0VGVzdENvbnRyb2xsZXItPnNldFNob3VsZER1bXBGcmFtZUxvYWRDYWxsYmFj a3MoYm9vbGVhbkZvcktleShzZXR0aW5ncywgIkR1bXBGcmFtZUxvYWREZWxlZ2F0ZXMiKSk7CiAK LSAgICBwYWdlKCktPnJlc2V0KCk7CisgICAgcGFnZSgpLT5wcmVwYXJlKCk7CiAKICAgICBXS0J1 bmRsZUNsZWFyQWxsRGF0YWJhc2VzKG1fYnVuZGxlKTsKICAgICBXS0J1bmRsZUNsZWFyQXBwbGlj YXRpb25DYWNoZShtX2J1bmRsZSk7CkBAIC0yNjAsNyArMjYwLDkgQEAgdm9pZCBJbmplY3RlZEJ1 bmRsZTo6ZG9uZSgpCiAgICAgV0tCdW5kbGVQb3N0TWVzc2FnZShtX2J1bmRsZSwgZG9uZU1lc3Nh Z2VOYW1lLmdldCgpLCBkb25lTWVzc2FnZUJvZHkuZ2V0KCkpOwogCiAgICAgY2xvc2VPdGhlclBh Z2VzKCk7Ci0gICAgCisKKyAgICBwYWdlKCktPnJlc2V0QWZ0ZXJUZXN0KCk7CisKICAgICBtX3N0 YXRlID0gSWRsZTsKIH0KIApJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRl c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcAkocmV2aXNpb24g MTE4ODAwKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3Rl ZEJ1bmRsZVBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzAsNyArMzMwLDcgQEAgdm9pZCBJ bmplY3RlZEJ1bmRsZVBhZ2U6OnN0b3BMb2FkaW5nKCkKICAgICBXS0J1bmRsZVBhZ2VTdG9wTG9h ZGluZyhtX3BhZ2UpOwogfQogCi12b2lkIEluamVjdGVkQnVuZGxlUGFnZTo6cmVzZXQoKQordm9p ZCBJbmplY3RlZEJ1bmRsZVBhZ2U6OnByZXBhcmUoKQogewogICAgIFdLQnVuZGxlUGFnZUNsZWFy TWFpbkZyYW1lTmFtZShtX3BhZ2UpOwogCkBAIC0zNDcsNiArMzQ3LDEzIEBAIHZvaWQgSW5qZWN0 ZWRCdW5kbGVQYWdlOjpyZXNldCgpCiAgICAgV0tCdW5kbGVQYWdlU2V0VHJhY2tzUmVwYWludHMo bV9wYWdlLCBmYWxzZSk7CiB9CiAKK3ZvaWQgSW5qZWN0ZWRCdW5kbGVQYWdlOjpyZXNldEFmdGVy VGVzdCgpCit7CisgICAgV0tCdW5kbGVGcmFtZVJlZiBmcmFtZSA9IFdLQnVuZGxlUGFnZUdldE1h aW5GcmFtZShtX3BhZ2UpOworICAgIEpTR2xvYmFsQ29udGV4dFJlZiBjb250ZXh0ID0gV0tCdW5k bGVGcmFtZUdldEphdmFTY3JpcHRDb250ZXh0KGZyYW1lKTsKKyAgICBXZWJDb3JlVGVzdFN1cHBv cnQ6OnJlc2V0SW50ZXJuYWxzT2JqZWN0KGNvbnRleHQpOworfQorCiAvLyBMb2FkZXIgQ2xpZW50 IENhbGxiYWNrcwogCiAvLyBTdHJpbmcgb3V0cHV0IG11c3QgYmUgaWRlbnRpY2FsIHRvIC1bV2Vi RnJhbWUgX2RydF9kZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdF0uCkluZGV4OiBUb29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGVQYWdlLmgJKHJldmlzaW9uIDExODgwMCkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAg LTQyLDcgKzQyLDggQEAgcHVibGljOgogCiAgICAgdm9pZCBzdG9wTG9hZGluZygpOwogCi0gICAg dm9pZCByZXNldCgpOworICAgIHZvaWQgcHJlcGFyZSgpOworICAgIHZvaWQgcmVzZXRBZnRlclRl c3QoKTsKIAogICAgIHZvaWQgZHVtcEJhY2tGb3J3YXJkTGlzdCgpOwogCg==