87764 2012-05-29 12:06:34 -0700 [New Multicolumn] Add implementation of checkForPaginationLogicalHeightChange to RenderMultiColumnBlock 2012-05-29 12:13:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt eric webkit.review.bot oldest_to_newest 636297 0 hyatt 2012-05-29 12:06:34 -0700 Add implementation of checkForPaginationLogicalHeightChange to RenderMultiColumnBlock. Also stub out ensureColumnSets() and write a comment describing how it's going to work. 636300 1 144595 hyatt 2012-05-29 12:08:21 -0700 Created attachment 144595 Patch 636308 2 hyatt 2012-05-29 12:13:07 -0700 Landed in r118815. 144595 2012-05-29 12:08:21 -0700 2012-05-29 12:11:30 -0700 Patch patch.txt text/plain 5789 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODgxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTI5ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODc3NjQKKyAgICAgICAgCisgICAgICAgIEFkZCBpbXBsZW1lbnRh dGlvbiBvZiBjaGVja0ZvclBhZ2luYXRpb25Mb2dpY2FsSGVpZ2h0Q2hhbmdlIHRvIFJlbmRlck11 bHRpQ29sdW1uQmxvY2suCisgICAgICAgIAorICAgICAgICBBbHNvIHN0dWIgb3V0IGVuc3VyZUNv bHVtblNldHMoKSBhbmQgd3JpdGUgYSBjb21tZW50IGRlc2NyaWJpbmcgaG93IGl0J3MgZ29pbmcg dG8gd29yay4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck11bHRpQ29sdW1uQmxvY2s6OlJlbmRlck11bHRpQ29sdW1uQmxvY2spOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5CbG9jazo6Y2hlY2tGb3JQYWdpbmF0aW9u TG9naWNhbEhlaWdodENoYW5nZSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlck11bHRpQ29sdW1uQmxvY2s6OmVuc3VyZUNvbHVtblNldHMpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkJsb2NrLmg6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJNdWx0aUNvbHVtbkJsb2NrOjpjb2x1bW5IZWlnaHQpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyTXVsdGlDb2x1bW5CbG9jazo6c2V0Q29sdW1uSGVpZ2h0KToKKyAgICAgICAgKFJlbmRl ck11bHRpQ29sdW1uQmxvY2spOgorCiAyMDEyLTA1LTI5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTE4NjIwLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1u QmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJN dWx0aUNvbHVtbkJsb2NrLmNwcAkocmV2aXNpb24gMTE4ODA2KQorKysgU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z Niw2ICszNiw3IEBAIFJlbmRlck11bHRpQ29sdW1uQmxvY2s6OlJlbmRlck11bHRpQ29sdW0KICAg ICAsIG1fZmxvd1RocmVhZCgwKQogICAgICwgbV9jb2x1bW5Db3VudCgxKQogICAgICwgbV9jb2x1 bW5XaWR0aCgwKQorICAgICwgbV9jb2x1bW5IZWlnaHQoWkVST19MQVlPVVRfVU5JVCkKIHsKIH0K IApAQCAtNzUsNiArNzYsMjcgQEAgYm9vbCBSZW5kZXJNdWx0aUNvbHVtbkJsb2NrOjpyZWNvbXB1 dGVMbwogICAgIHJldHVybiByZWxheW91dENoaWxkcmVuOwogfQogCit2b2lkIFJlbmRlck11bHRp Q29sdW1uQmxvY2s6OmNoZWNrRm9yUGFnaW5hdGlvbkxvZ2ljYWxIZWlnaHRDaGFuZ2UoTGF5b3V0 VW5pdCYgcGFnZUxvZ2ljYWxIZWlnaHQsIGJvb2wmIHBhZ2VMb2dpY2FsSGVpZ2h0Q2hhbmdlZCwg Ym9vbCYgaGFzU3BlY2lmaWVkUGFnZUxvZ2ljYWxIZWlnaHQpCit7CisgICAgLy8gV2UgbmVlZCB0 byBnbyBhaGVhZCBhbmQgc2V0IG91ciBleHBsaWNpdCBwYWdlIGhlaWdodCBpZiBvbmUgZXhpc3Rz LCBzbyB0aGF0IHdlIGNhbgorICAgIC8vIGF2b2lkIGRvaW5nIG11bHRpcGxlIGxheW91dCBwYXNz ZXMuCisgICAgY29tcHV0ZUxvZ2ljYWxIZWlnaHQoKTsKKyAgICBMYXlvdXRVbml0IG5ld0NvbnRl bnRMb2dpY2FsSGVpZ2h0ID0gY29udGVudExvZ2ljYWxIZWlnaHQoKTsKKyAgICBpZiAobmV3Q29u dGVudExvZ2ljYWxIZWlnaHQgPiBaRVJPX0xBWU9VVF9VTklUKSB7CisgICAgICAgIHBhZ2VMb2dp Y2FsSGVpZ2h0ID0gbmV3Q29udGVudExvZ2ljYWxIZWlnaHQ7CisgICAgICAgIGhhc1NwZWNpZmll ZFBhZ2VMb2dpY2FsSGVpZ2h0ID0gdHJ1ZTsKKyAgICB9CisgICAgc2V0TG9naWNhbEhlaWdodCha RVJPX0xBWU9VVF9VTklUKTsKKworICAgIGlmIChjb2x1bW5IZWlnaHQoKSAhPSBwYWdlTG9naWNh bEhlaWdodCAmJiBldmVySGFkTGF5b3V0KCkpIHsKKyAgICAgICAgc2V0Q29sdW1uSGVpZ2h0KHBh Z2VMb2dpY2FsSGVpZ2h0KTsKKyAgICAgICAgcGFnZUxvZ2ljYWxIZWlnaHRDaGFuZ2VkID0gdHJ1 ZTsKKyAgICB9CisgICAgCisgICAgLy8gU2V0IHVwIG91ciBjb2x1bW4gc2V0cy4KKyAgICBlbnN1 cmVDb2x1bW5TZXRzKCk7Cit9CisKIHZvaWQgUmVuZGVyTXVsdGlDb2x1bW5CbG9jazo6YWRkQ2hp bGQoUmVuZGVyT2JqZWN0KiBuZXdDaGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCkKIHsK ICAgICBpZiAoIW1fZmxvd1RocmVhZCkgewpAQCAtOTEsNiArMTEzLDI1IEBAIHZvaWQgUmVuZGVy TXVsdGlDb2x1bW5CbG9jazo6YWRkQ2hpbGQoUmUKICAgICAgICAgbV9mbG93VGhyZWFkLT5hZGRD aGlsZChuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOwogfQogCit2b2lkIFJlbmRlck11bHRpQ29sdW1u QmxvY2s6OmVuc3VyZUNvbHVtblNldHMoKQoreworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisg ICAgLy8gVGhpcyBmdW5jdGlvbiBlbnN1cmVzIHdlIGhhdmUgdGhlIGNvcnJlY3QgY29sdW1uIHNl dCBpbmZvcm1hdGlvbiBiZWZvcmUgd2UgZ2V0IGludG8gbGF5b3V0LgorICAgIC8vIEZvciBhIHNp bXBsZSBtdWx0aS1jb2x1bW4gbGF5b3V0IGluIGNvbnRpbnVvdXMgbWVkaWEsIG9ubHkgb25lIGNv bHVtbiBzZXQgY2hpbGQgaXMgcmVxdWlyZWQuCisgICAgLy8gT25jZSBhIGNvbHVtbiBpcyBuZXN0 ZWQgaW5zaWRlIGFuIGVuY2xvc2luZyBwYWdpbmF0aW9uIGNvbnRleHQsIHRoZSBudW1iZXIgb2Yg Y29sdW1uIHNldHMKKyAgICAvLyByZXF1aXJlZCBiZWNvbWVzIDJuLTEsIHdoZXJlIG4gaXMgdGhl IHRvdGFsIG51bWJlciBvZiBuZXN0ZWQgcGFnaW5hdGlvbiBjb250ZXh0cy4gRm9yIGV4YW1wbGU6 CisgICAgLy8KKyAgICAvLyBDb2x1bW4gbGF5b3V0IHdpdGggbm8gZW5jbG9zaW5nIHBhZ2luYXRp b24gbW9kZWwgPSAyICogMSAtIDEgPSAxIGNvbHVtbiBzZXQuCisgICAgLy8gQ29sdW1ucyBpbnNp ZGUgcGFnZXMgPSAyICogMiAtIDEgPSAzIGNvbHVtbiBzZXRzIChib3R0b20gb2YgZmlyc3QgcGFn ZSwgYWxsIHRoZSBzdWJzZXF1ZW50IHBhZ2VzLCB0aGVuIHRoZSBsYXN0IHBhZ2UpLgorICAgIC8v IENvbHVtbnMgaW5zaWRlIGNvbHVtbnMgaW5zaWRlIHBhZ2VzID0gMiAqIDMgLSAxID0gNSBjb2x1 bW4gc2V0cy4KKyAgICAvLworICAgIC8vIEluIGFkZGl0aW9uLCBjb2x1bW4gc3BhbnMgd2lsbCBm b3JjZSBhIGNvbHVtbiBzZXQgdG8gInNwbGl0IiBpbnRvIGJlZm9yZS9hZnRlciBzZXRzIGFyb3Vu ZCB0aGUgc3Bhbm5pbmcgcmVnaW9uLgorICAgIC8vCisgICAgLy8gRmluYWxseSwgd2Ugd2lsbCBu ZWVkIHRvIGRlYWwgd2l0aCBjb2x1bW5zIGluc2lkZSByZWdpb25zLiBJZiByZWdpb25zIGhhdmUg dmFyaWFibGUgd2lkdGhzLCB0aGVuIHRoZXJlIHdpbGwgbmVlZAorICAgIC8vIHRvIGJlIHVuaXF1 ZSBjb2x1bW4gc2V0cyBjcmVhdGVkIGluc2lkZSBhbnkgcmVnaW9uIHdob3NlIHdpZHRoIGlzIGRp ZmZlcmVudCBmcm9tIGl0cyBzdXJyb3VuZGluZyByZWdpb25zLiBUaGlzIGlzCisgICAgLy8gYWN0 dWFsbHkgcHJldHR5IHNpbWlsYXIgdG8gdGhlIHNwYW5uaW5nIGNhc2UsIGluIHRoYXQgd2UgYnJl YWsgdXAgdGhlIGNvbHVtbiBzZXRzIHdoZW5ldmVyIHRoZSB3aWR0aCB2YXJpZXMuCit9CisKIGNv bnN0IGNoYXIqIFJlbmRlck11bHRpQ29sdW1uQmxvY2s6OnJlbmRlck5hbWUoKSBjb25zdAogeyAg ICAKICAgICBpZiAoaXNGbG9hdGluZygpKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck11bHRpQ29sdW1uQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5CbG9jay5oCShyZXZpc2lvbiAxMTg4MDYpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTXVsdGlDb2x1bW5CbG9jay5oCSh3b3JraW5n IGNvcHkpCkBAIC0zNywyMiArMzcsMjggQEAgY2xhc3MgUmVuZGVyTXVsdGlDb2x1bW5CbG9jayA6 IHB1YmxpYyBSZQogcHVibGljOgogICAgIFJlbmRlck11bHRpQ29sdW1uQmxvY2soTm9kZSopOwog ICAgIAorICAgIExheW91dFVuaXQgY29sdW1uSGVpZ2h0KCkgY29uc3QgeyByZXR1cm4gbV9jb2x1 bW5IZWlnaHQ7IH0KKyAgICB2b2lkIHNldENvbHVtbkhlaWdodChMYXlvdXRVbml0IGNvbHVtbkhl aWdodCkgeyBtX2NvbHVtbkhlaWdodCA9IGNvbHVtbkhlaWdodDsgfQorCiBwcml2YXRlOgogICAg IHZpcnR1YWwgY29uc3QgY2hhciogcmVuZGVyTmFtZSgpIGNvbnN0OwogCiAgICAgdmlydHVhbCBi b29sIHJlY29tcHV0ZUxvZ2ljYWxXaWR0aCgpOwotICAgIHZvaWQgY29tcHV0ZUNvbHVtbkNvdW50 QW5kV2lkdGgoKTsKKyAgICB2aXJ0dWFsIHZvaWQgY2hlY2tGb3JQYWdpbmF0aW9uTG9naWNhbEhl aWdodENoYW5nZShMYXlvdXRVbml0JiBwYWdlTG9naWNhbEhlaWdodCwgYm9vbCYgcGFnZUxvZ2lj YWxIZWlnaHRDaGFuZ2VkLCBib29sJiBoYXNTcGVjaWZpZWRQYWdlTG9naWNhbEhlaWdodCkgT1ZF UlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgYWRkQ2hpbGQoUmVuZGVyT2JqZWN0KiBuZXdDaGls ZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCA9IDApIE9WRVJSSURFOwogCisgICAgdm9pZCBj b21wdXRlQ29sdW1uQ291bnRBbmRXaWR0aCgpOworCisgICAgdm9pZCBlbnN1cmVDb2x1bW5TZXRz KCk7CisKICAgICBSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQqIGZsb3dUaHJlYWQoKSBjb25z dCB7IHJldHVybiBtX2Zsb3dUaHJlYWQ7IH0KIAotcHJpdmF0ZToKICAgICBSZW5kZXJNdWx0aUNv bHVtbkZsb3dUaHJlYWQqIG1fZmxvd1RocmVhZDsKLQogICAgIHVuc2lnbmVkIG1fY29sdW1uQ291 bnQ7ICAgLy8gVGhlIGRlZmF1bHQgY29sdW1uIGNvdW50L3dpZHRoIHRoYXQgYXJlIGJhc2VkIG9m ZiBvdXIgY29udGFpbmluZyBibG9jayB3aWR0aC4gVGhlc2UgdmFsdWVzIHJlcHJlc2VudCBvbmx5 IHRoZSBkZWZhdWx0LAogICAgIExheW91dFVuaXQgbV9jb2x1bW5XaWR0aDsgLy8gc2luY2UgYSBt dWx0aS1jb2x1bW4gYmxvY2sgdGhhdCBpcyBzcGxpdCBhY3Jvc3MgdmFyaWFibGUgd2lkdGggcGFn ZXMgb3IgcmVnaW9ucyB3aWxsIGhhdmUgZGlmZmVyZW50IGNvbHVtbiBjb3VudHMgYW5kIHdpZHRo cyBpbiBlYWNoLgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gVGhlc2UgdmFsdWVz IHdpbGwgYmUgY2FjaGVkIChldmVudHVhbGx5KSBmb3IgbXVsdGktY29sdW1uIGJsb2Nrcy4KKyAg ICBMYXlvdXRVbml0IG1fY29sdW1uSGVpZ2h0OyAvLyBUaGUgY3VycmVudCBjb2x1bW4gaGVpZ2h0 LgogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=