87762 2012-05-29 11:44:52 -0700 TextFieldDecorationElement should respect style attribute 2012-05-30 19:02:11 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gcasto webkit-unassigned dglazkov gcasto tkent webkit.review.bot oldest_to_newest 636280 0 gcasto 2012-05-29 11:44:52 -0700 Currently changing the style of a TextFieldDecorationElement does not result in the element rendering any differently. This is because customStyleForRenderer() does not take into account the current styling of the element. 636651 1 gcasto 2012-05-29 17:54:49 -0700 Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for. 636658 2 tkent 2012-05-29 18:03:49 -0700 (In reply to comment #1) > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for. Would you take this please? I think the customStyleForRenderr() should be: - RefPtr<RenderStyle> style = RenderStyle::create(); + RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this); 636659 3 gcasto 2012-05-29 18:05:31 -0700 (In reply to comment #2) > (In reply to comment #1) > > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for. > > Would you take this please? > > I think the customStyleForRenderr() should be: > > - RefPtr<RenderStyle> style = RenderStyle::create(); > + RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this); Got it. I'll see if this works. 636666 4 tkent 2012-05-29 18:15:41 -0700 (In reply to comment #2) > (In reply to comment #1) > > Kent-san, is this something that you can take or should I? If I should take this, can I get some guidance on how to proceed? I've glanced through the other implementations of customStyleForRenderer in the codebase, but none of them obviously have the functionality that I'm looking for. > > Would you take this please? > > I think the customStyleForRenderr() should be: > > - RefPtr<RenderStyle> style = RenderStyle::create(); > + RefPtr<RenderStyle> style = document()->styleResolver()->styleForElement(this); Ah, we need to clone it because we modify it. RefPtr<RenderStyle> originalStyle = document()->styleResolver()->styleForElement(this); RefPtr<RenderStyle> style = RenderStyle::clone(originalStyle.get()); 637597 5 144902 gcasto 2012-05-30 13:20:18 -0700 Created attachment 144902 Patch 637916 6 144902 tkent 2012-05-30 18:49:06 -0700 Comment on attachment 144902 Patch Looks good 637924 7 144902 webkit.review.bot 2012-05-30 19:02:06 -0700 Comment on attachment 144902 Patch Clearing flags on attachment: 144902 Committed r119020: <http://trac.webkit.org/changeset/119020> 637925 8 webkit.review.bot 2012-05-30 19:02:11 -0700 All reviewed patches have been landed. Closing bug. 144902 2012-05-30 13:20:18 -0700 2012-05-30 19:02:06 -0700 Patch bug-87762-20120530132017.patch text/plain 1800 gcasto U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4ODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFkOTc1MDEyYmU5ODhh OWVjYjk4ZWM1MGYxNmU5ZTNjNzliN2IyYy4uNjQwYjM1ZTY1NzY0NzE1YTZkNWQyZGY1ZGUwZGRl YjgwYzQ0MDdmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTMwICBHYXJy ZXR0IENhc3RvICA8Z2Nhc3RvQGNocm9taXVtLm9yZz4KKworICAgICAgICBUZXh0RmllbGREZWNv cmF0aW9uRWxlbWVudCBzaG91bGQgcmVzcGVjdCBzdHlsZSBhdHRyaWJ1dGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NzYyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9UZXh0Rmll bGREZWNvcmF0aW9uRWxlbWVudC5jcHA6IFVzZSBzdHlsZSBzZXQgb24gdGhlCisgICAgICAgIEVs ZW1lbnQgd2hlbiBjcmVhdGluZyByZW5kZXJpbmcgc3R5bGUuCisgICAgICAgIChXZWJDb3JlOjpU ZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudDo6Y3VzdG9tU3R5bGVGb3JSZW5kZXJlcik6CisKIDIw MTItMDUtMjkgIFZpY3RvciBDYXJidW5lICA8dmljdG9yQHJvc2VkdS5vcmc+CiAKICAgICAgICAg RGlzcGxheSBjdWVzIGluIHRoZSBjb250cm9scyBhcmVhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudC5jcHAKaW5kZXgg Nzc2M2UyM2RhZGRjZTAzZmFmN2FhZTEyYWYyZjYxZjBhOTQ5OWU3Ni4uYTY3YTRiYWZiYTgyNzNk NjdjNDczM2I5ZDQzN2RjZDUxZDMzZWY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvVGV4dEZpZWxkRGVjb3JhdGlvbkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L1RleHRGaWVsZERlY29yYXRpb25FbGVtZW50LmNwcApAQCAtNDAsNiAr NDAsNyBAQAogI2luY2x1ZGUgIk5vZGVSZW5kZXJTdHlsZS5oIgogI2luY2x1ZGUgIlJlbmRlcklt YWdlLmgiCiAjaW5jbHVkZSAiU2hhZG93Um9vdC5oIgorI2luY2x1ZGUgIlN0eWxlUmVzb2x2ZXIu aCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0xNDMsNyArMTQ0LDggQEAgdm9pZCBUZXh0 RmllbGREZWNvcmF0aW9uRWxlbWVudDo6dXBkYXRlSW1hZ2UoKQogCiBQYXNzUmVmUHRyPFJlbmRl clN0eWxlPiBUZXh0RmllbGREZWNvcmF0aW9uRWxlbWVudDo6Y3VzdG9tU3R5bGVGb3JSZW5kZXJl cigpCiB7Ci0gICAgUmVmUHRyPFJlbmRlclN0eWxlPiBzdHlsZSA9IFJlbmRlclN0eWxlOjpjcmVh dGUoKTsKKyAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IG9yaWdpbmFsU3R5bGUgPSBkb2N1bWVudCgp LT5zdHlsZVJlc29sdmVyKCktPnN0eWxlRm9yRWxlbWVudCh0aGlzKTsKKyAgICBSZWZQdHI8UmVu ZGVyU3R5bGU+IHN0eWxlID0gUmVuZGVyU3R5bGU6OmNsb25lKG9yaWdpbmFsU3R5bGUuZ2V0KCkp OwogICAgIFJlbmRlclN0eWxlKiBpbnB1dFN0eWxlID0gaG9zdElucHV0KCktPnJlbmRlclN0eWxl KCk7CiAgICAgQVNTRVJUKGlucHV0U3R5bGUpOwogICAgIHN0eWxlLT5zZXRXaWR0aChMZW5ndGgo aW5wdXRTdHlsZS0+Zm9udFNpemUoKSwgRml4ZWQpKTsK