87745 2012-05-29 07:20:26 -0700 [GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient 2012-05-29 09:47:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 spena webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 635995 0 spena 2012-05-29 07:20:26 -0700 Building WK2 currently outputs the following warnings: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:194:5: warning: missing initializer for member ‘WKPageUIClient::unavailablePluginButtonClicked’ [-Wmissing-field-initializers] ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:151:5: warning: missing initializer for member ‘WKPageLoaderClient::pluginDidFail’ [-Wmissing-field-initializers] The attached patch initializes these members. 636007 1 144556 spena 2012-05-29 07:41:55 -0700 Created attachment 144556 Patch 636009 2 webkit.review.bot 2012-05-29 07:44:28 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 636015 3 144556 cgarcia 2012-05-29 07:53:03 -0700 Comment on attachment 144556 Patch Thanks! 636134 4 144556 webkit.review.bot 2012-05-29 09:47:19 -0700 Comment on attachment 144556 Patch Clearing flags on attachment: 144556 Committed r118795: <http://trac.webkit.org/changeset/118795> 636135 5 webkit.review.bot 2012-05-29 09:47:24 -0700 All reviewed patches have been landed. Closing bug. 144556 2012-05-29 07:41:55 -0700 2012-05-29 09:47:19 -0700 Patch bug-87745-20120529164154.patch text/plain 2703 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWVjOTUxY2FlYTc0NWFi OTdhYjM2MGMyMjhlMjNhMTg4MjIwYTUzNi4uMGM0ZjBmZTVmMDUzNzlmYjRiMWQ0ZDdhOGMwNTI3 OTIwNDQwMGVjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTI5ICBTaW1v biBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNaXNzaW5nIGZpZWxk IGluaXRpYWxpemVycyBmb3IgV0tQYWdlTG9hZGVyQ2xpZW50IGFuZCBXS1BhZ2VVSUNsaWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc3NDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2lu ZyBpbml0aWFsaXplcnMgZm9yIFdLUGFnZUxvYWRlckNsaWVudCBhbmQKKyAgICAgICAgV0tQYWdl VUlDbGllbnQsIGZvciBjYWxsYmFja3MgV0tQYWdlUGx1Z2luRGlkRmFpbENhbGxiYWNrIGFuZAor ICAgICAgICBXS1BhZ2VVbmF2YWlsYWJsZVBsdWdpbkJ1dHRvbkNsaWNrZWRDYWxsYmFjaywgaW50 cm9kdWNlZCBpbgorICAgICAgICByZXZpc2lvbiByMTE2NzE2LgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKGF0dGFjaExvYWRl ckNsaWVudFRvVmlldyk6IEluaXRpYWxpemUgV0tQYWdlUGx1Z2luRGlkRmFpbENhbGxiYWNrCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VUlDbGllbnQuY3BwOgorICAgICAgICAo YXR0YWNoVUlDbGllbnRUb1ZpZXcpOiBJbml0aWFsaXplIGNhbGxiYWNrCisgICAgICAgIFdLUGFn ZVVuYXZhaWxhYmxlUGx1Z2luQnV0dG9uQ2xpY2tlZENhbGxiYWNrCisKIDIwMTItMDUtMjkgIEtl bm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IFtRdF1bV0syXSBGaXggZmFpbGluZyBxbWx0ZXN0czo6Rml0VG9WaWV3Ojp0ZXN0X2Jhc2ljKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRl ckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2Fk ZXJDbGllbnQuY3BwCmluZGV4IDk0NzYyNTVjODg0NDI1M2Q3NzBmYjE1YWI3YmEyZGUxOWQ0ZDM5 YmQuLjE1OGM3ZmM0MjcwMDgxZGNhZjQ3NzAzNTUwN2U2NDY3MWNkZjFjNGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50 LmNwcApAQCAtMTQ3LDcgKzE0Nyw4IEBAIHZvaWQgYXR0YWNoTG9hZGVyQ2xpZW50VG9WaWV3KFdl YktpdFdlYlZpZXcqIHdlYlZpZXcpCiAgICAgICAgIDAsIC8vIGRpZERldGVjdFhTU0ZvckZyYW1l CiAgICAgICAgIDAsIC8vIGRpZEZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvckZyYW1lCiAg ICAgICAgIDAsIC8vIHdpbGxHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQotICAgICAgICAwIC8vIGlu dGVyYWN0aW9uT2NjdXJyZWRXaGlsZVByb2Nlc3NVbnJlc3BvbnNpdmUKKyAgICAgICAgMCwgLy8g aW50ZXJhY3Rpb25PY2N1cnJlZFdoaWxlUHJvY2Vzc1VucmVzcG9uc2l2ZQorICAgICAgICAwLCAv LyBwbHVnaW5EaWRGYWlsCiAgICAgfTsKICAgICBXS1BhZ2VSZWYgd2tQYWdlID0gdG9BUEkod2Vi a2l0V2ViVmlld0Jhc2VHZXRQYWdlKFdFQktJVF9XRUJfVklFV19CQVNFKHdlYlZpZXcpKSk7CiAg ICAgV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudCh3a1BhZ2UsICZ3a0xvYWRlckNsaWVudCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVSUNsaWVu dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVSUNsaWVudC5j cHAKaW5kZXggOWY3OGM5Y2JmYzM0ZmE2MzE3NGY3ZDNhZjVjMmRkNWU3Yzc1MDRiNS4uMjU0OGQ3 YjcyM2ExOTRkM2NiZWQwZDJkNzM5Nzc0MTc1MDBiN2FlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VUlDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVJQ2xpZW50LmNwcApAQCAtMTkxLDYgKzE5 MSw3IEBAIHZvaWQgYXR0YWNoVUlDbGllbnRUb1ZpZXcoV2ViS2l0V2ViVmlldyogd2ViVmlldykK ICAgICAgICAgY3JlYXRlTmV3UGFnZSwKICAgICAgICAgbW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQs CiAgICAgICAgIDAsIC8vIGRlY2lkZVBvbGljeUZvck5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1 ZXN0CisgICAgICAgIDAsIC8vIHVuYXZhaWxhYmxlUGx1Z2luQnV0dG9uQ2xpY2tlZAogICAgIH07 CiAgICAgV0tQYWdlUmVmIHdrUGFnZSA9IHRvQVBJKHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFnZShX RUJLSVRfV0VCX1ZJRVdfQkFTRSh3ZWJWaWV3KSkpOwogICAgIFdLUGFnZVNldFBhZ2VVSUNsaWVu dCh3a1BhZ2UsICZ3a1VJQ2xpZW50KTsK