87740 2012-05-29 06:34:40 -0700 [Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8 2012-05-30 15:59:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 79666 87521 1 ossy webkit-unassigned darin mitz ossy oldest_to_newest 635959 0 ossy 2012-05-29 06:34:40 -0700 After http://trac.webkit.org/changeset/118568, fast/forms/textarea-maxlength.html started to fail on Qt 4.8 platforms. (It passes on Qt 5, because Qt 5 build uses ICU) --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/forms/textarea-maxlength-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/forms/textarea-maxlength-actual.txt @@ -23,8 +23,8 @@ PASS textArea.value is "A\nB" PASS textArea.value is "a\n\n" PASS textArea.value is "\n\n\n" -PASS textArea.value is "AB" + fancyX -PASS textArea.value.length is 5 +FAIL textArea.value should be ABx̲̅. Was AB. +FAIL textArea.value.length should be 5. Was 2. PASS textArea.value is "ABC" PASS textArea.value is "AB" + u10000 PASS textArea.value.length is 4 635967 1 ossy 2012-05-29 06:48:16 -0700 I skipped it - http://trac.webkit.org/changeset/118766 Please unskip it with the proper fix. 636241 2 144588 mitz 2012-05-29 11:05:11 -0700 Created attachment 144588 Possible fix Sorry about breaking this! I don’t have access to this build configuration, but I think this patch will fix the regression. Can you try it? Thanks! 637575 3 ossy 2012-05-30 12:56:08 -0700 (In reply to comment #2) > Created an attachment (id=144588) [details] > Possible fix > > Sorry about breaking this! I don’t have access to this build configuration, but I think this patch will fix the regression. Can you try it? Thanks! Not problem. I tried your patch and it fixed fast/forms/textarea-maxlength.html test. Thanks. 637591 4 144901 mitz 2012-05-30 13:13:45 -0700 Created attachment 144901 Use the return value of setUpIterator in the NonSharedCharacterBreakIterator constructor 637777 5 mitz 2012-05-30 15:59:17 -0700 Fixed in <http://trac.webkit.org/r118990>. 144588 2012-05-29 11:05:11 -0700 2012-05-30 13:13:45 -0700 Possible fix 87740_r1.diff text/plain 875 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dEJyZWFrSXRlcmF0b3JR dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9UZXh0 QnJlYWtJdGVyYXRvclF0LmNwcAkocmV2aXNpb24gMTE4ODA2KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vdGV4dC9xdC9UZXh0QnJlYWtJdGVyYXRvclF0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzYsNyArNzYsMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIGNyZWF0 ZWRJdGVyYXRvciA9IG1faXRlcmF0b3IgJiYgd2Vha0NvbXBhcmVBbmRTd2FwKHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCoqPigmbm9uU2hhcmVkQ2hhcmFjdGVyQnJlYWtJdGVyYXRvciksIG1faXRlcmF0 b3IsIDApOwogICAgICAgICBpZiAoIWNyZWF0ZWRJdGVyYXRvcikKICAgICAgICAgICAgIG1faXRl cmF0b3IgPSBuZXcgVGV4dEJyZWFrSXRlcmF0b3IoKTsKLSAgICAgICAgc2V0VXBJdGVyYXRvcigq bV9pdGVyYXRvciwgUVRleHRCb3VuZGFyeUZpbmRlcjo6R3JhcGhlbWUsIGJ1ZmZlciwgbGVuZ3Ro KTsKKyAgICAgICAgaWYgKCFzZXRVcEl0ZXJhdG9yKCptX2l0ZXJhdG9yLCBRVGV4dEJvdW5kYXJ5 RmluZGVyOjpHcmFwaGVtZSwgYnVmZmVyLCBsZW5ndGgpKSB7CisgICAgICAgICAgICBkZWxldGUg bV9pdGVyYXRvcjsKKyAgICAgICAgICAgIG1faXRlcmF0b3IgPSAwOworICAgICAgICB9CiAgICAg fQogCiAgICAgTm9uU2hhcmVkQ2hhcmFjdGVyQnJlYWtJdGVyYXRvcjo6fk5vblNoYXJlZENoYXJh Y3RlckJyZWFrSXRlcmF0b3IoKQo= 144901 2012-05-30 13:13:45 -0700 2012-05-30 14:04:17 -0700 Use the return value of setUpIterator in the NonSharedCharacterBreakIterator constructor 87740_r1.diff text/plain 2884 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODk1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTMwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMTg1 NjgpOiBJdCBicm9rZSBmYXN0L2Zvcm1zL3RleHRhcmVhLW1heGxlbmd0aC5odG1sIG9uIFF0IDQu OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc3NDAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL3RleHQvcXQvVGV4dEJyZWFrSXRlcmF0b3JRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpO b25TaGFyZWRDaGFyYWN0ZXJCcmVha0l0ZXJhdG9yOjpOb25TaGFyZWRDaGFyYWN0ZXJCcmVha0l0 ZXJhdG9yKTogQ2hhbmdlZCB0byB1c2UKKyAgICAgICAgdGhlIHJldHVybiB2YWx1ZSBvZiBzZXRV cEl0ZXJhdG9yLgorCiAyMDEyLTA1LTI5ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5j b20+CiAKICAgICAgICAgVHJhbnNmb3JtZWQgZml4ZWQgcG9zaXRpb24gbGF5ZXJzIGhhdmUgYW4g aW5jb3JyZWN0IG92ZXJsYXAgbWFwIGVudHJ5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L3F0L1RleHRCcmVha0l0ZXJhdG9yUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dEJyZWFrSXRlcmF0b3JRdC5jcHAJKHJldmlzaW9u IDExODgwNikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dEJyZWFrSXRl cmF0b3JRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc2LDcgKzc2LDEwIEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgYm9vbCBjcmVhdGVkSXRlcmF0b3IgPSBtX2l0ZXJhdG9yICYmIHdl YWtDb21wYXJlQW5kU3dhcChyZWludGVycHJldF9jYXN0PHZvaWQqKj4oJm5vblNoYXJlZENoYXJh Y3RlckJyZWFrSXRlcmF0b3IpLCBtX2l0ZXJhdG9yLCAwKTsKICAgICAgICAgaWYgKCFjcmVhdGVk SXRlcmF0b3IpCiAgICAgICAgICAgICBtX2l0ZXJhdG9yID0gbmV3IFRleHRCcmVha0l0ZXJhdG9y KCk7Ci0gICAgICAgIHNldFVwSXRlcmF0b3IoKm1faXRlcmF0b3IsIFFUZXh0Qm91bmRhcnlGaW5k ZXI6OkdyYXBoZW1lLCBidWZmZXIsIGxlbmd0aCk7CisgICAgICAgIGlmICghc2V0VXBJdGVyYXRv cigqbV9pdGVyYXRvciwgUVRleHRCb3VuZGFyeUZpbmRlcjo6R3JhcGhlbWUsIGJ1ZmZlciwgbGVu Z3RoKSkgeworICAgICAgICAgICAgZGVsZXRlIG1faXRlcmF0b3I7CisgICAgICAgICAgICBtX2l0 ZXJhdG9yID0gMDsKKyAgICAgICAgfQogICAgIH0KIAogICAgIE5vblNoYXJlZENoYXJhY3RlckJy ZWFrSXRlcmF0b3I6On5Ob25TaGFyZWRDaGFyYWN0ZXJCcmVha0l0ZXJhdG9yKCkKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDExODk1OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTMwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CisKKyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMTg1NjgpOiBJdCBicm9rZSBmYXN0 L2Zvcm1zL3RleHRhcmVhLW1heGxlbmd0aC5odG1sIG9uIFF0IDQuOAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc3NDAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0LTQuOC9Ta2lwcGVk OiBSZW1vdmVkIGZhc3QvZm9ybXMvdGV4dGFyZWEtbWF4bGVuZ3RoLmh0bWwuCisKIDIwMTItMDUt MjkgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KIAogICAgICAgICBUcmFuc2Zv cm1lZCBmaXhlZCBwb3NpdGlvbiBsYXllcnMgaGF2ZSBhbiBpbmNvcnJlY3Qgb3ZlcmxhcCBtYXAg ZW50cnkKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3F0LTQuOC9Ta2lwcGVkCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0LTQuOC9Ta2lwcGVkCShyZXZpc2lvbiAxMTg4 MDYpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC00LjgvU2tpcHBlZAkod29ya2luZyBjb3B5 KQpAQCAtMTU0LDcgKzE1NCwzIEBAIGZhc3QvdGV4dC96ZXJvLXdpZHRoLWNoYXJhY3RlcnMuaHRt bAogCiAjIEZhaWwgd2l0aCBRdFhtbFBhdHRlcm5zICh1c2VkIGJ5IFF0IDQuOCBidWlkKSwgYnV0 IHBhc3Mgd2l0aCBsaWJ4c2x0ICh1c2VkIGJ5IFF0IDUgYnVpbGQpCiBmYXN0L3BhcnNlci9pbm5l cmh0bWwtd2l0aC1wcmVmaXhlZC1lbGVtZW50cy54aHRtbAotCi0jIFtRdF0gUkVHUkVTU0lPTihy MTE4NTY4KTogSXQgYnJva2UgZmFzdC9mb3Jtcy90ZXh0YXJlYS1tYXhsZW5ndGguaHRtbCBvbiBR dCA0LjgKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg3NzQwCi1m YXN0L2Zvcm1zL3RleHRhcmVhLW1heGxlbmd0aC5odG1sCg==