<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>87723</bug_id>
          
          <creation_ts>2012-05-29 03:48:30 -0700</creation_ts>
          <short_desc>CRASH() in Heap::markRoots</short_desc>
          <delta_ts>2012-05-29 10:41:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>86538</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Dongseong Hwang">dongseong.hwang</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>darin</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>635834</commentid>
    <comment_count>0</comment_count>
    <who name="Dongseong Hwang">dongseong.hwang</who>
    <bug_when>2012-05-29 03:48:30 -0700</bug_when>
    <thetext>This bug maybe arose between r116279 and r118267.

Heap::markRoots can call indirectly Heap::markRoots again.
It is why CRASH() can be fired in Heap::markRoots&apos;s following code.

    if (m_operationInProgress != NoOperation)
        CRASH();


I attached an example callstack.
JSC::Heap::markRoots() at Heap.cpp:428 0x7ffff5a2fe79	
JSC::Heap::collect() at Heap.cpp:683 0x7ffff5a307b5	
JSC::CopiedSpace::getFreshBlock() at CopiedSpace.cpp:240 0x7ffff5a25944	
JSC::CopiedSpace::addNewBlock() at CopiedSpaceInlineMethods.h:107 0x7ffff5a26859	
JSC::CopiedSpace::doneCopying() at CopiedSpace.cpp:226 0x7ffff5a257ed	
JSC::Heap::markRoots() at Heap.cpp:588 0x7ffff5a303ae	
JSC::Heap::collect() at Heap.cpp:683 0x7ffff5a307b5	
JSC::Heap::reportExtraMemoryCostSlowCase() at Heap.cpp:305 0x7ffff5a2f5f6	
JSC::Heap::reportExtraMemoryCost() at Heap.h:322 0x7ffff463ffb3	
WebCore::HTMLImageLoader::notifyFinished() at HTMLImageLoader.cpp:86 0x7ffff4afa6bd	


I tested &quot; http://www.dorothybrowser.com/test/webkitTest/imgdecode/bgimage-png/test.html &quot; using WebKitQt.
If you go into the site and push a back button and push a go button, you can encounter CRASH().

I don&apos;t know JSC&apos; GC, so I want for JSC experts to fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>636195</commentid>
    <comment_count>1</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2012-05-29 10:30:56 -0700</bug_when>
    <thetext>Is this fixed in ToT Mark?  We shouldn&apos;t be triggering GC during GC...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>636196</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2012-05-29 10:32:10 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Is this fixed in ToT Mark?  We shouldn&apos;t be triggering GC during GC...

I thought it was, but when I looked, bug 86538 is still waiting for a review...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>636213</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Hahnenberg">mhahnenberg</who>
    <bug_when>2012-05-29 10:41:19 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 86538 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>