87721 2012-05-29 03:27:59 -0700 [BlackBerry] OpenGL content is not rendered on simulator 2012-05-29 10:09:06 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson fspacek leo.yang mxie robin.webkit rwlbuis tonikitoo webkit.review.bot oldest_to_newest 635823 0 anilsson 2012-05-29 03:27:59 -0700 The simulator has decent OpenGL support these days, we just have to turn on ENABLE_GLES2 635825 1 144502 anilsson 2012-05-29 03:32:28 -0700 Created attachment 144502 Patch 635945 2 anilsson 2012-05-29 06:23:48 -0700 This stuff was reviewed internally by George Staikos (PR #150695) 636020 3 144502 webkit.review.bot 2012-05-29 07:57:41 -0700 Comment on attachment 144502 Patch Rejecting attachment 144502 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 8] _ssl.c:490: EOF occurred in violation of protocol> Full output: http://queues.webkit.org/results/12845536 636069 4 144502 anilsson 2012-05-29 08:48:27 -0700 Comment on attachment 144502 Patch try again, I think the commit-queue fluked out 636083 5 144502 webkit.review.bot 2012-05-29 09:02:10 -0700 Comment on attachment 144502 Patch Rejecting attachment 144502 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eorge Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm Hunk #1 FAILED at 930. Hunk #2 FAILED at 957. 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'George Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12840634 636142 6 anilsson 2012-05-29 09:50:21 -0700 (In reply to comment #5) > (From update of attachment 144502 [details]) > Rejecting attachment 144502 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > eorge Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Parsed 2 diffs from patch file(s). > patching file Tools/ChangeLog > Hunk #1 succeeded at 1 with fuzz 3. > patching file Tools/Scripts/webkitdirs.pm > Hunk #1 FAILED at 930. > Hunk #2 FAILED at 957. > 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'George Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output: http://queues.webkit.org/results/12840634 Gosh, I uploaded a patch based on master_35, not svn/master =( 636151 7 anilsson 2012-05-29 09:58:36 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 144502 [details] [details]) > > Rejecting attachment 144502 [details] [details] from commit-queue. > > > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > > > Last 500 characters of output: > > eorge Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > > > Parsed 2 diffs from patch file(s). > > patching file Tools/ChangeLog > > Hunk #1 succeeded at 1 with fuzz 3. > > patching file Tools/Scripts/webkitdirs.pm > > Hunk #1 FAILED at 930. > > Hunk #2 FAILED at 957. > > 2 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej > > > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'George Sta..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > > > Full output: http://queues.webkit.org/results/12840634 > > Gosh, I uploaded a patch based on master_35, not svn/master =( No, that wasn't it - apparently this patch is landed, but the CQ failed to mark the bug as fixed. 636153 8 anilsson 2012-05-29 09:59:01 -0700 It's landed 636155 9 anilsson 2012-05-29 10:00:32 -0700 Landed in http://trac.webkit.org/changeset/118777 636156 10 144502 anilsson 2012-05-29 10:01:08 -0700 Comment on attachment 144502 Patch Clearing flags like CQ usually does 636163 11 rwlbuis 2012-05-29 10:09:06 -0700 Hi Arvid, (In reply to comment #10) > (From update of attachment 144502 [details]) > Clearing flags like CQ usually does You can use webkit-patch mark-bug-fixed to close the bug from the command line, with a standardized message. 144502 2012-05-29 03:32:28 -0700 2012-05-29 10:01:07 -0700 Patch bug-87721-20120529123226.patch text/plain 1958 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4NzEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzg3ZmQyYWNiMWI2NTU5OTc2YTMxOTkzYjJkMjMzMmNi MjI0NzAwMi4uYzdhZjgyNzdiNjdhNjRkZGQxZDlhMTM1Mjc0Mzc0MWQ3MWI0MGE5YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA1LTI5ICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAg ICAgICAyMDEyLTA1LTI5ICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAg ICAgICBbQmxhY2tCZXJyeV0gT3BlbkdMIGNvbnRlbnQgaXMgbm90IHJlbmRlcmVkIG9uIHNpbXVs YXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODc3 MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhl ZCBieSBlbmFibGluZyBHTEVTMiBzdXBwb3J0IGluIHNpbXVsYXRvciBidWlsZHMuCisKKyAgICAg ICAgVG8gZXhwZXJpbWVudCB3aXRoIGJ1aWxkaW5nIHdpdGhvdXQgT3BlbkdMIHN1cHBvcnQsIHlv dSBjYW4gc2V0IHRoZQorICAgICAgICBESVNBQkxFX0dMRVMyIGVudmlyb25tZW50IHZhcmlhYmxl IHRvIGEgbm9uLWVtcHR5IHN0cmluZyBhbmQgcmVidWlsZC4KKworICAgICAgICBQUiAjMTUwNjk1 CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChibGFja2JlcnJ5 Q01ha2VBcmd1bWVudHMpOgorCiAyMDEyLTA1LTI4ICBKb25hdGhhbiBEb25nICA8am9uYXRoYW4u ZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIGh0dHAgYXV0 aGVudGljYXRlIGRpYWxvZyBwb3B1cCBvbmx5IG9uY2Ugbm8gbWF0dGVyIGF1dGhlbnRpY2F0aW9u IHBhc3Mgb3IgZmFpbApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDYxMDY3MDU3NGQzNzgwNzMyYTRiYzY2 ZmY5OGI3NDViNWJlYjAxMWIuLjJlYTEyYzc1N2NlZmQyMjdmNzhhOWMzMjc2ZmUxYmUzYWIzY2Nh ZGEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTkzMCw3ICs5MzAsNiBAQCBzdWIgYmxhY2tiZXJyeUNN YWtlQXJndW1lbnRzKCkKICAgICBpZiAoJGNwdSBlcSAiYTkiKSB7CiAgICAgICAgICRjcHUgPSAk YXJjaCAuICJ2N2xlIjsKICAgICAgICAgcHVzaCBAY21ha2VFeHRyYU9wdGlvbnMsICctRFRBUkdF VElOR19QTEFZQk9PSz0xJzsKLSAgICAgICAgcHVzaCBAY21ha2VFeHRyYU9wdGlvbnMsICctREVO QUJMRV9HTEVTMj0xJzsKICAgICB9CiAKICAgICBteSAkc3RhZ2VEaXIgPSAkRU5WeyJTVEFHRV9E SVIifTsKQEAgLTk1Nyw3ICs5NTYsNyBAQCBzdWIgYmxhY2tiZXJyeUNNYWtlQXJndW1lbnRzKCkK IAogICAgIHB1c2ggQGNtYWtlRXh0cmFPcHRpb25zLCAiLURDTUFLRV9TS0lQX1JQQVRIPSdPTici IGlmIGlzRGFyd2luKCk7CiAgICAgcHVzaCBAY21ha2VFeHRyYU9wdGlvbnMsICItREVOQUJMRV9E UlQ9MSIgaWYgJEVOVnsiRU5BQkxFX0RSVCJ9OwotICAgIHB1c2ggQGNtYWtlRXh0cmFPcHRpb25z LCAiLURFTkFCTEVfR0xFUzI9MSIgaWYgJEVOVnsiRU5BQkxFX0dMRVMyIn07CisgICAgcHVzaCBA Y21ha2VFeHRyYU9wdGlvbnMsICItREVOQUJMRV9HTEVTMj0xIiB1bmxlc3MgJEVOVnsiRElTQUJM RV9HTEVTMiJ9OwogCiAgICAgbXkgQGluY2x1ZGVTeXN0ZW1EaXJlY3RvcmllczsKICAgICBwdXNo IEBpbmNsdWRlU3lzdGVtRGlyZWN0b3JpZXMsIEZpbGU6OlNwZWMtPmNhdGRpcigkc3RhZ2VJbmMs ICJncnNraWEiLCAic2tpYSIpOwo=