87710 2012-05-29 01:46:33 -0700 Allow ports to make plugins focusable 2012-05-29 17:10:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 66687 1 abarth abarth ap epenner eric peter oldest_to_newest 635731 0 abarth 2012-05-29 01:46:33 -0700 Allow ports to make plugins focusable 635735 1 144478 abarth 2012-05-29 01:51:43 -0700 Created attachment 144478 Patch 635738 2 144478 abarth 2012-05-29 01:54:33 -0700 Comment on attachment 144478 Patch Clearing the review flag for a moment. I need to study the interaction between this patch and one other thing. 635739 3 peter 2012-05-29 01:54:49 -0700 +epenner This seems to be quite old code, Eric (Penner), could you comment on whether we want this upstreamed right now? 636329 4 ap 2012-05-29 12:29:19 -0700 This is surprising, because I can certainly focus Flash plug-ins to type in them in Safari on Mac and Windows. Keyboard also works in YouTube for controlling movies. 636551 5 abarth 2012-05-29 16:39:29 -0700 Yes, I believe this patch isn't correct. I'll post a patch to the chromium-android branch to remove it. 636573 6 epenner 2012-05-29 16:59:44 -0700 This was needed to support the case where events should only arrive when the plugin has focus, rather than all the time. In that case this is needed to insure the plugin gets focus when desired which is slightly different from when it would normally get focus. The code is indeed old, but I believe it's a valid use-case for plugins, when you don't always want them to receive events on a mobile device (but rather only when you tap on it first). 636589 7 abarth 2012-05-29 17:10:38 -0700 As far as I know, we're abandoning support for plugins on the chromium-android branch. That means instead of moving this patch upstream, we should remove it from downstream. If there's another reason to make this change, we can make the change again in the future when we have that need. 144478 2012-05-29 01:51:43 -0700 2012-05-29 01:54:33 -0700 Patch bug-87710-20120529015142.patch text/plain 4935 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODczNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTI5ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWxsb3cgcG9ydHMgdG8gbWFrZSBw bHVnaW5zIGZvY3VzYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODc3MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGxldHMgcG9ydHMgZm9yY2UgdGhlIEhUTUxQbHVnSW5FbGVtZW50 IHRvIGJlIGZvY3VzYWJsZSBieQorICAgICAgICBjYWxsaW5nIG92ZXJyaWRlU3VwcG9ydHNGb2N1 cyh0cnVlKS4gIFdoZW4gd2UgcnVuIFBlcHBlciBwbHVnaW5zIG9uCisgICAgICAgIE9TKEFORFJP SUQpLCB0aGV5IG5lZWQgdG8gYmUgZm9jdXNhYmxlIGluIG9yZGVyIGZvciB0b3VjaCBldmVudHMg dG8KKyAgICAgICAgd29yayBwcm9wZXJseS4gIEl0J3MgbGlrZWx5IHRoYXQgd2UnbGwgd2FudCB0 aGlzIGJlaGF2aW9yIG9uIG90aGVyCisgICAgICAgIG9wZXJhdGluZyBzeXN0ZW1zIGFzIHdlbGws IGJ1dCwgZm9yIHRoZSB0aW1lIGJlaW5nLCB0aGlzIHBhdGNoIGVuYWJsZXMKKyAgICAgICAgdGhp cyBiZWhhdmlvciBvbmx5IG9uIE9TKEFORFJPSUQpLiAgSWYvd2hlbiB3ZSBkZWNpZGUgd2Ugd2Fu dCB0aGlzCisgICAgICAgIGJlaGF2aW9yIG9uIG90aGVyIHBsYXRmb3Jtcywgd2UgY2FuIHJlbW92 ZSB0aGUgRU5BQkxFIG1hY3JvLgorCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MUGx1Z0luRWxlbWVudDo6SFRNTFBsdWdJbkVsZW1l bnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFBsdWdJbkVsZW1lbnQ6OnN1cHBvcnRzRm9jdXMp OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MUGx1Z0luRWxlbWVu dDo6b3ZlcnJpZGVTdXBwb3J0c0ZvY3VzKToKKyAgICAgICAgKiBodG1sL0hUTUxQbHVnSW5FbGVt ZW50Lmg6CisgICAgICAgIChIVE1MUGx1Z0luRWxlbWVudCk6CisKIDIwMTItMDUtMjkgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQZXJmb3JtYW5jZV0g T3B0aW1pemUgcXVlcnlTZWxlY3RvcigpIGFuZCBxdWVyeVNlbGVjdG9yQWxsKCkgYnkgcmVtb3Zp bmcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1lbnQuY3BwCShyZXZp c2lvbiAxMTg2NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmNw cAkod29ya2luZyBjb3B5KQpAQCAtNTMsNiArNTMsOCBAQCBIVE1MUGx1Z0luRWxlbWVudDo6SFRN TFBsdWdJbkVsZW1lbnQoY29uCiAgICAgLCBtX05QT2JqZWN0KDApCiAjZW5kaWYKICAgICAsIG1f aXNDYXB0dXJpbmdNb3VzZUV2ZW50cyhmYWxzZSkKKyAgICAsIG1fc3VwcG9ydHNGb2N1cyhmYWxz ZSkKKyAgICAsIG1fZGlkT3ZlcnJpZGVGb2N1cyhmYWxzZSkKIHsKIH0KIApAQCAtMjAyLDQgKzIw NCwxOCBAQCBOUE9iamVjdCogSFRNTFBsdWdJbkVsZW1lbnQ6OmdldE5QT2JqZWN0CiAKICNlbmRp ZiAvKiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkgKi8KIAorYm9vbCBIVE1MUGx1Z0luRWxl bWVudDo6c3VwcG9ydHNGb2N1cygpIGNvbnN0Cit7CisgICAgaWYgKG1fZGlkT3ZlcnJpZGVGb2N1 cykKKyAgICAgICAgcmV0dXJuIG1fc3VwcG9ydHNGb2N1czsKKworICAgIHJldHVybiBIVE1MRnJh bWVPd25lckVsZW1lbnQ6OnN1cHBvcnRzRm9jdXMoKTsKK30KKwordm9pZCBIVE1MUGx1Z0luRWxl bWVudDo6b3ZlcnJpZGVTdXBwb3J0c0ZvY3VzKGJvb2wgc3VwcG9ydHNGb2N1cykKK3sKKyAgICBt X3N1cHBvcnRzRm9jdXMgPSBzdXBwb3J0c0ZvY3VzOworICAgIG1fZGlkT3ZlcnJpZGVGb2N1cyA9 IHRydWU7Cit9CisKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1l bnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50 LmgJKHJldmlzaW9uIDExODY3MikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVs ZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsOSBAQCBwdWJsaWM6CiAKICAgICBi b29sIGNhbkNvbnRhaW5SYW5nZUVuZFBvaW50KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KIAor ICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0ZvY3VzKCkgY29uc3QgT1ZFUlJJREU7CisgICAgdm9p ZCBvdmVycmlkZVN1cHBvcnRzRm9jdXMoYm9vbCk7CisKIHByb3RlY3RlZDoKICAgICBIVE1MUGx1 Z0luRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1lLCBEb2N1bWVudCopOwogCkBA IC03OSw2ICs4Miw5IEBAIHByaXZhdGU6CiAgICAgTlBPYmplY3QqIG1fTlBPYmplY3Q7CiAjZW5k aWYKICAgICBib29sIG1faXNDYXB0dXJpbmdNb3VzZUV2ZW50czsKKworICAgIGJvb2wgbV9zdXBw b3J0c0ZvY3VzOworICAgIGJvb2wgbV9kaWRPdmVycmlkZUZvY3VzOwogfTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEx ODczNikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBBbGxvdyBwb3J0cyB0byBtYWtlIHBsdWdpbnMgZm9jdXNhYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NzcxMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIE9TKEFORFJP SUQpLCBwbHVnaW5zIGFyZSBmb2N1c2FibGUuCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgor ICAgICAgICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGx1Z2luQ29udGFpbmVySW1wbDo6V2ViUGx1Z2luQ29udGFpbmVySW1wbCk6CisKIDIw MTItMDUtMjggIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtXZWJTb2NrZXRdIFJlY2VpdmluZyByZXNlcnZlZCBjbG9zZSBjb2RlcywgMTAwNSwg MTAwNiwgYW5kIDEwMTUgbXVzdCBhcHBlYXIgYXMgY29kZT0xMDA2IGFuZCB3YXNDbGVhbj1mYWxz ZQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkocmV2aXNpb24gMTE4Njcy KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCSh3b3JraW5nIGNvcHkp CkBAIC0xNDcsNiArMTQ3LDcgQEAKICAgICAgICAgICAnRU5BQkxFX0ZPTlRfQk9PU1RJTkc9MScs CiAgICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTEnLAogICAgICAgICAgICdFTkFCTEVf UEFHRV9QT1BVUD0wJywKKyAgICAgICAgICAnRU5BQkxFX0ZPQ1VTQUJMRV9QTFVHSU5TPTEnLAog ICAgICAgICAgICdFTkFCTEVfV0VCX0FVRElPPTAnLAogICAgICAgICAgICdXVEZfVVNFX05BVElW RV9GVUxMU0NSRUVOX1ZJREVPPTEnLAogICAgICAgICBdLApAQCAtMTU2LDYgKzE1Nyw3IEBACiAg ICAgICAgICAgJ0VOQUJMRV9GT05UX0JPT1NUSU5HPTAnLAogICAgICAgICAgICdFTkFCTEVfTUVE SUFfQ0FQVFVSRT0wJywKICAgICAgICAgICAnRU5BQkxFX1BBR0VfUE9QVVA9MScsCisgICAgICAg ICAgJ0VOQUJMRV9GT0NVU0FCTEVfUExVR0lOUz0wJywKICAgICAgICAgICAnRU5BQkxFX1dFQl9B VURJTz0xJywKICAgICAgICAgXSwKICAgICAgIH1dLApJbmRleDogU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAJKHJldmlzaW9u IDExODY3MikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5l ckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzgsNiArNTc4LDkgQEAgV2ViUGx1Z2luQ29u dGFpbmVySW1wbDo6V2ViUGx1Z2luQ29udGFpbgogICAgICwgbV9pb1N1cmZhY2VJZCgwKQogI2Vu ZGlmCiB7CisjaWYgRU5BQkxFKEZPQ1VTQUJMRV9QTFVHSU5TKQorICAgIG1fZWxlbWVudC0+b3Zl cnJpZGVTdXBwb3J0c0ZvY3VzKHRydWUpOworI2VuZGlmCiB9CiAKIFdlYlBsdWdpbkNvbnRhaW5l ckltcGw6On5XZWJQbHVnaW5Db250YWluZXJJbXBsKCkK